From nobody Mon Feb 9 12:09:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1560511573; cv=none; d=zoho.com; s=zohoarc; b=BTYjF20TFX+CUN9qAjno/8YWS72dCmZXvmjz9bQzB4o98BaCenQ6GplS1WCVSHlGe+honDTmxjeKrpm1QGe/DCTO3y6mU0gHRYSUcep+z34vC8CtnqmhUkcoAaE568aqVJLNTleMk9Ni2wfIBhdBglJjjwHYt8tjbnYZMIRRxbc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1560511573; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=cZ9secuNHgAT8ov6P9yvu24mXr3zBb5vAErBSK3cQd0=; b=MhoPDryudy7uhxdRxkBGtxI69rXT544G5QEVTbIB0iyvJSD1VssQJRQlJCB+UBvoFV2PQNPhwwpBiI2ZsXHtxw6un69cMRUTIhUNZ/K2bpDZUu9RX4wEQ+dCTp/+HXlr6FPdzsbVTQ/sChQedVaXnrdQh//muHnJBCs3MWx8htY= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1560511573374390.49756237450447; Fri, 14 Jun 2019 04:26:13 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hbkKJ-0007SN-Jw; Fri, 14 Jun 2019 11:24:59 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hbkKI-0007Rs-1o for xen-devel@lists.xenproject.org; Fri, 14 Jun 2019 11:24:58 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 083ddd76-8e97-11e9-bcb6-c71690691944; Fri, 14 Jun 2019 11:24:54 +0000 (UTC) X-Inumbo-ID: 083ddd76-8e97-11e9-bcb6-c71690691944 Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: cIw7zh1P+Og1z/F7b764TOe+7i8Ycs8T3/dXt2wEgffCYNauiWg8ruWNyB8WGa9ktH08WbPC0V J7Bl3IBg8W5XRZ7PLQXGeiDd47n6tKEOJgDj4090fvg7sesqJnNg731ftfXr7k+uLyPsNRRdNA 0g0t0UtTwzntmjCgufhsvOqsx58emsS2PdBtyv8heQwVUIS0aqfOciCbA36nlVhRfgkcmXhJG9 Iki9eEFErKPwaB485piGY04YHfGj08W+vjWAOa/38rwSreUcgsPdvmqQOYnpKHJ0QDIHjQdB0Z pdM= X-SBRS: 2.7 X-MesageID: 1737468 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.63,373,1557201600"; d="scan'208";a="1737468" From: Anthony PERARD To: Date: Fri, 14 Jun 2019 12:24:36 +0100 Message-ID: <20190614112444.29980-8-anthony.perard@citrix.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190614112444.29980-1-anthony.perard@citrix.com> References: <20190614112444.29980-1-anthony.perard@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 07/15] libxl_dm: Fix initialisation of libxl__stub_dm_spawn_state X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony PERARD , Ian Jackson , Wei Liu Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" sdss->pvqemu wasn't initialiased and disposed of properly. Also, move the initialisation of sdss->xswait with the rest of the initialisation of sdss. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl_dm.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c index 348c3fddf5..5942e70c16 100644 --- a/tools/libxl/libxl_dm.c +++ b/tools/libxl/libxl_dm.c @@ -2105,8 +2105,11 @@ void libxl__spawn_stub_dm(libxl__egc *egc, libxl__st= ub_dm_spawn_state *sdss) libxl__domain_build_state *const d_state =3D sdss->dm.build_state; libxl__domain_build_state *const stubdom_state =3D &sdss->dm_state; =20 + /* Initialise private part of sdss */ libxl__domain_build_state_init(stubdom_state); dmss_init(&sdss->dm); + dmss_init(&sdss->pvqemu); + libxl__xswait_init(&sdss->xswait); =20 if (guest_config->b_info.device_model_version !=3D LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN_TRADITIONAL) { @@ -2391,8 +2394,6 @@ static void stubdom_pvqemu_cb(libxl__egc *egc, STATE_AO_GC(sdss->dm.spawn.ao); uint32_t dm_domid =3D sdss->pvqemu.guest_domid; =20 - libxl__xswait_init(&sdss->xswait); - if (rc) { LOGED(ERROR, sdss->dm.guest_domid, "error connecting nics devices"); @@ -2439,6 +2440,7 @@ static void stubdom_xswait_cb(libxl__egc *egc, libxl_= _xswait_state *xswait, libxl__domain_build_state_dispose(&sdss->dm_state); libxl__xswait_stop(gc, xswait); dmss_dispose(gc, &sdss->dm); + dmss_dispose(gc, &sdss->pvqemu); sdss->callback(egc, &sdss->dm, rc); } =20 --=20 Anthony PERARD _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel