From nobody Mon Feb 9 10:58:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1560511573; cv=none; d=zoho.com; s=zohoarc; b=ObqFKpNOKrcPPjv2LuaMNy2rlzhHJXiCQpWcJ/lmR6hmEZ/oGJhYdWKovnaDn/FucuZTZ3QzRMx6zhgTuYkpJxtr3k3JRW79unlv5psGLLi/Zeel1kaAMNuAuOhzwrSzIRb9BvZrG32Q+sGcll3Ggx4NwrRgy6C7LFvQEiLDU54= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1560511573; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=UP6ASRxiwNPPBKmyI4K6IBEHuU15e0rfg/zNmolc3to=; b=UWmBn4HWoQllc4MEJQnkUIyRu1ep5Opiafkj9a+cHjcpPMeglYIfSqhgjDVctXi+hqsQLnHITXPUEag+9tH5rqkk9rtSiqh8J0+wgNthmsQwTud6c+50TxiusHhtoDhXrBp6JTMul5S/9ZBiSU1FNb8mGUIPh4DgK9U4829UoJQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1560511573342371.5130772440883; Fri, 14 Jun 2019 04:26:13 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hbkKG-0007R9-8o; Fri, 14 Jun 2019 11:24:56 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hbkKE-0007Qu-Hc for xen-devel@lists.xenproject.org; Fri, 14 Jun 2019 11:24:54 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 07137794-8e97-11e9-9525-b3ca68e02144; Fri, 14 Jun 2019 11:24:52 +0000 (UTC) X-Inumbo-ID: 07137794-8e97-11e9-9525-b3ca68e02144 Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: XV6IkCd2Yu3yQY891cXZmwjY2QZ7ckJPuBvkdhG6xmtOo6cZ9fwf2ez6E+98XUnEf88pG2/kTM Qu47Tfj6jD2LU/c+HPGG8PGhYIByLlKIJgnA/POn6rZv/407u9LTbh6ZDUqlUjpMmGaquyMjT8 80Iyt23CB9lL6aK/V0rZA3fuEz6cPfLkCowttdcr+feJOvkQB4GxtHoJKQ1UlrNvcCFNGc3iZf rmxb1gfnttuqdvGhgnpiEIqddAQW3xHtAgiV8EMvERJsZ/siNacEwqnjuw4c7zn/6Fzg+EONMb G7Y= X-SBRS: 2.7 X-MesageID: 1737465 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.63,373,1557201600"; d="scan'208";a="1737465" From: Anthony PERARD To: Date: Fri, 14 Jun 2019 12:24:34 +0100 Message-ID: <20190614112444.29980-6-anthony.perard@citrix.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190614112444.29980-1-anthony.perard@citrix.com> References: <20190614112444.29980-1-anthony.perard@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 05/15] libxl_pci: `starting' is a bool X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony PERARD , Ian Jackson , Wei Liu Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" The argument `starting' is used as a boolean, change its type to reflex that throughout libxl_pci.c. No functional changes. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl_internal.h | 3 ++- tools/libxl/libxl_pci.c | 14 ++++++++------ 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h index 01411382fd..846227c3cd 100644 --- a/tools/libxl/libxl_internal.h +++ b/tools/libxl/libxl_internal.h @@ -1540,7 +1540,8 @@ _hidden int libxl__pci_topology_init(libxl__gc *gc, =20 /* from libxl_pci */ =20 -_hidden int libxl__device_pci_add(libxl__gc *gc, uint32_t domid, libxl_dev= ice_pci *pcidev, int starting); +_hidden int libxl__device_pci_add(libxl__gc *gc, uint32_t domid, + libxl_device_pci *pcidev, bool starting); _hidden int libxl__device_pci_destroy_all(libxl__gc *gc, uint32_t domid); _hidden bool libxl__is_igd_vga_passthru(libxl__gc *gc, const libxl_domain_config *d_confi= g); diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c index d2d37be75d..f204ac9fb7 100644 --- a/tools/libxl/libxl_pci.c +++ b/tools/libxl/libxl_pci.c @@ -116,7 +116,7 @@ static int libxl__create_pci_backend(libxl__gc *gc, uin= t32_t domid, static int libxl__device_pci_add_xenstore(libxl__gc *gc, uint32_t domid, const libxl_device_pci *pcidev, - int starting) + bool starting) { flexarray_t *back; char *num_devs, *be_path; @@ -983,7 +983,8 @@ static int qemu_pci_add_xenstore(libxl__gc *gc, uint32_= t domid, return rc; } =20 -static int do_pci_add(libxl__gc *gc, uint32_t domid, libxl_device_pci *pci= dev, int starting) +static int do_pci_add(libxl__gc *gc, uint32_t domid, + libxl_device_pci *pcidev, bool starting) { libxl_ctx *ctx =3D libxl__gc_owner(gc); libxl_domain_type type =3D libxl__domain_type(gc, domid); @@ -1164,7 +1165,7 @@ int libxl_device_pci_add(libxl_ctx *ctx, uint32_t dom= id, { AO_CREATE(ctx, domid, ao_how); int rc; - rc =3D libxl__device_pci_add(gc, domid, pcidev, 0); + rc =3D libxl__device_pci_add(gc, domid, pcidev, false); libxl__ao_complete(egc, ao, rc); return AO_INPROGRESS; } @@ -1186,7 +1187,8 @@ static int libxl_pcidev_assignable(libxl_ctx *ctx, li= bxl_device_pci *pcidev) return i !=3D num; } =20 -int libxl__device_pci_add(libxl__gc *gc, uint32_t domid, libxl_device_pci = *pcidev, int starting) +int libxl__device_pci_add(libxl__gc *gc, uint32_t domid, + libxl_device_pci *pcidev, bool starting) { libxl_ctx *ctx =3D libxl__gc_owner(gc); unsigned int orig_vdev, pfunc_mask; @@ -1241,7 +1243,7 @@ int libxl__device_pci_add(libxl__gc *gc, uint32_t dom= id, libxl_device_pci *pcide if (stubdomid !=3D 0) { libxl_device_pci pcidev_s =3D *pcidev; /* stubdomain is always running by now, even at create time */ - rc =3D do_pci_add(gc, stubdomid, &pcidev_s, 0); + rc =3D do_pci_add(gc, stubdomid, &pcidev_s, false); if ( rc ) goto out; } @@ -1294,7 +1296,7 @@ static void libxl__add_pcidevs(libxl__egc *egc, libxl= __ao *ao, uint32_t domid, int i, rc =3D 0; =20 for (i =3D 0; i < d_config->num_pcidevs; i++) { - rc =3D libxl__device_pci_add(gc, domid, &d_config->pcidevs[i], 1); + rc =3D libxl__device_pci_add(gc, domid, &d_config->pcidevs[i], tru= e); if (rc < 0) { LOGD(ERROR, domid, "libxl_device_pci_add failed: %d", rc); goto out; --=20 Anthony PERARD _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel