From nobody Mon Feb 9 14:33:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1560511573; cv=none; d=zoho.com; s=zohoarc; b=goJR9DuYQspWG0HNzOVzdnGJPglnHeBWKDzqr6lttZC6zNZZQ7CDpR6dOsnCOxg9qQ4+1eHWCz0rA9F7FV8RBYNG8SB9eOsfIsObsjf2tZhvVgSO102aKZhYubY1lC3VrHIrZ6DSpiIsKBBfBSa7EgLucf7iLGuUG7xAO1l98lQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1560511573; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=JXeMhUtFxxIpbLeaQ7kcieTB8k6oY2DchpIrMXiqKXo=; b=ieMWIP4m59CSNkIfq4ozI4uOX71Q4K2HOYBLaJJeX/1298J8+JVlg8GC8OcABZdnH+7K2D98gxxNpADBQIrCWf0IFLWuAQtUORcMVKeFYHzxcy6LveWUF2XHdwwm+ldfAPL+cCYsOltGpFqE00uj6HjUEo5myUzYSaTHHnfDMoM= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1560511573393160.8537054086853; Fri, 14 Jun 2019 04:26:13 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hbkKG-0007RN-Si; Fri, 14 Jun 2019 11:24:56 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hbkKE-0007R4-P0 for xen-devel@lists.xenproject.org; Fri, 14 Jun 2019 11:24:54 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 06efa044-8e97-11e9-bf5f-0f5740848fb4; Fri, 14 Jun 2019 11:24:52 +0000 (UTC) X-Inumbo-ID: 06efa044-8e97-11e9-bf5f-0f5740848fb4 Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: poLzMvH6Fod03BxScQ2jqc6QRto9O/UkuNyeY3nSy9U20CdFHW22Q6WNxhnMIlyoo3jy5GQlMO GOuFDN+TUQZ4enZHSt2UUC97zKTbVdyGi+MDz+3GOdnnaEsn6Ndd+6XBZ50RYTVTqKB85vCZ9W hRqIBAVAmaciBRiqD8TRrocgrJA+ZcJuf21MbYKDwKCckIj7pZzpk6BiBYfqmMSrtns+/KhrgT aFIzejhcUSfFAjUXXt1yQdSarwHoO+orB6CuoLWw8BA6BWUOVNo7lTSKu3DDf6tFeO8akRqBqF TCU= X-SBRS: 2.7 X-MesageID: 1737464 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.63,373,1557201600"; d="scan'208";a="1737464" From: Anthony PERARD To: Date: Fri, 14 Jun 2019 12:24:33 +0100 Message-ID: <20190614112444.29980-5-anthony.perard@citrix.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190614112444.29980-1-anthony.perard@citrix.com> References: <20190614112444.29980-1-anthony.perard@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 04/15] libxl_pci: Constify arg `pcidev' of libxl__device_pci_add_xenstore X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony PERARD , Ian Jackson , Wei Liu Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" libxl__device_pci_add_xenstore doesn't modify `pcidev', so it can be constified. Also, we don't need pcidev_saved anymore, so remove the saved copy. (device_add_domain_config is going to make it's own copy anyway.) To achieve this, constify pcidev in all functions that libxl__device_pci_add_xenstore calls. No functional changes. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl_pci.c | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c index 0e07f70f29..d2d37be75d 100644 --- a/tools/libxl/libxl_pci.c +++ b/tools/libxl/libxl_pci.c @@ -47,7 +47,10 @@ static void pcidev_struct_fill(libxl_device_pci *pcidev,= unsigned int domain, pcidev->vdevfn =3D vdevfn; } =20 -static void libxl_create_pci_backend_device(libxl__gc *gc, flexarray_t *ba= ck, int num, libxl_device_pci *pcidev) +static void libxl_create_pci_backend_device(libxl__gc *gc, + flexarray_t *back, + int num, + const libxl_device_pci *pcidev) { flexarray_append(back, GCSPRINTF("key-%d", num)); flexarray_append(back, GCSPRINTF(PCI_BDF, pcidev->domain, pcidev->bus,= pcidev->dev, pcidev->func)); @@ -64,7 +67,7 @@ static void libxl_create_pci_backend_device(libxl__gc *gc= , flexarray_t *back, in } =20 static void libxl__device_from_pcidev(libxl__gc *gc, uint32_t domid, - libxl_device_pci *pcidev, + const libxl_device_pci *pcidev, libxl__device *device) { device->backend_devid =3D 0; @@ -76,7 +79,8 @@ static void libxl__device_from_pcidev(libxl__gc *gc, uint= 32_t domid, } =20 static int libxl__create_pci_backend(libxl__gc *gc, uint32_t domid, - libxl_device_pci *pcidev, int num) + const libxl_device_pci *pcidev, + int num) { flexarray_t *front =3D NULL; flexarray_t *back =3D NULL; @@ -109,7 +113,10 @@ static int libxl__create_pci_backend(libxl__gc *gc, ui= nt32_t domid, NULL); } =20 -static int libxl__device_pci_add_xenstore(libxl__gc *gc, uint32_t domid, l= ibxl_device_pci *pcidev, int starting) +static int libxl__device_pci_add_xenstore(libxl__gc *gc, + uint32_t domid, + const libxl_device_pci *pcidev, + int starting) { flexarray_t *back; char *num_devs, *be_path; @@ -117,12 +124,9 @@ static int libxl__device_pci_add_xenstore(libxl__gc *g= c, uint32_t domid, libxl_d xs_transaction_t t =3D XBT_NULL; int rc; libxl_domain_config d_config; - libxl_device_pci pcidev_saved; libxl__domain_userdata_lock *lock =3D NULL; =20 libxl_domain_config_init(&d_config); - libxl_device_pci_init(&pcidev_saved); - libxl_device_pci_copy(CTX, &pcidev_saved, pcidev); =20 be_path =3D libxl__domain_device_backend_path(gc, 0, domid, 0, LIBXL__DEVICE_KIND_PCI); @@ -158,7 +162,7 @@ static int libxl__device_pci_add_xenstore(libxl__gc *gc= , uint32_t domid, libxl_d if (rc) goto out; =20 device_add_domain_config(gc, &d_config, &libxl__pcidev_devtype, - &pcidev_saved); + pcidev); =20 rc =3D libxl__dm_check_start(gc, &d_config, domid); if (rc) goto out; @@ -180,7 +184,6 @@ static int libxl__device_pci_add_xenstore(libxl__gc *gc= , uint32_t domid, libxl_d out: libxl__xs_transaction_abort(gc, &t); if (lock) libxl__unlock_domain_userdata(lock); - libxl_device_pci_dispose(&pcidev_saved); libxl_domain_config_dispose(&d_config); return rc; } --=20 Anthony PERARD _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel