From nobody Mon Feb 9 10:58:30 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1560511573; cv=none; d=zoho.com; s=zohoarc; b=c340NkHarqEPiVL5FrseJ0NpNqNuyjQnY0x+TNE3lpXXWDTZSAKTCiLwbjKrxJtp+Ov7Fj5YQ4irPnM+ufjPRypRm/dJtWYG7BPMn9zZWZ7Qvy3U3wxF0CEqllW6bvo01vy5a1+6RfiHWxEvEZIy2ABPBgTutTUrCzVDOik9dq4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1560511573; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=ohwGDrU+4Jq9JsRjr3NX9Rz9r+IKw+IqRzguYOC3Vkc=; b=ebNnHwc4RhZe6p15eTksJwUIKxhNkKqPN/nl7Rho5Qb/hh6GL9928w8kgTJyHYiH/+pfohNOAJpiGiLJ78kRU3djP9yCnMXlrJtNDrg9iWTPXawrgHMjm5Q/DYow3v8JbCBOgmLLpa6dQTzWfaQxo63ReADw3FnAVOa4D36SnKA= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1560511573587566.034651475541; Fri, 14 Jun 2019 04:26:13 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hbkKM-0007TI-DQ; Fri, 14 Jun 2019 11:25:02 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hbkKL-0007T9-E3 for xen-devel@lists.xenproject.org; Fri, 14 Jun 2019 11:25:01 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0a0760aa-8e97-11e9-9df2-6f477a47ccb4; Fri, 14 Jun 2019 11:24:57 +0000 (UTC) X-Inumbo-ID: 0a0760aa-8e97-11e9-9df2-6f477a47ccb4 Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: B4g2j01qBHPBe1inYvHEy9tGwzv02NI4UcK0IMnEdTK+2o0y3bQVGy41sDpf6tM9bWD6VuD0mY bOzn5YvzW+cHng3GQ/U6gDl+CjVTpuxknHSXHHQPYcVtAY6c4Ki8sZqC7zPIsF404dCD/iOmDU hb67dLmR9vnbTGL8m/pBcZyeOthl3wYpJRcmu6HhVYqSPiMhPTNt/QkfXrpGaYdbHQ7WFPq0qK ygKuwT99ji/PPNyUsqF2Gy9GGzImaz/my3hCcPLbeM9+fxDxuY9q2CXgS8ve51IZmtokibOSeX i4U= X-SBRS: 2.7 X-MesageID: 1737471 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.63,373,1557201600"; d="scan'208";a="1737471" From: Anthony PERARD To: Date: Fri, 14 Jun 2019 12:24:38 +0100 Message-ID: <20190614112444.29980-10-anthony.perard@citrix.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190614112444.29980-1-anthony.perard@citrix.com> References: <20190614112444.29980-1-anthony.perard@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 09/15] libxl_domain: Cleanup libxl__destroy_domid X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony PERARD , Ian Jackson , Wei Liu Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" - dom_path isn't used anymore in that function, remove it. - Use `r' to store return value of external calls. - Use `CTX', no need for a local `ctx'. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl_domain.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/tools/libxl/libxl_domain.c b/tools/libxl/libxl_domain.c index aee621b0a5..11a29b235b 100644 --- a/tools/libxl/libxl_domain.c +++ b/tools/libxl/libxl_domain.c @@ -1023,14 +1023,13 @@ static void domain_destroy_domid_cb(libxl__egc *egc, void libxl__destroy_domid(libxl__egc *egc, libxl__destroy_domid_state *dis) { STATE_AO_GC(dis->ao); - libxl_ctx *ctx =3D CTX; uint32_t domid =3D dis->domid; - char *dom_path; int rc, dm_present; + int r; =20 libxl__ev_child_init(&dis->destroyer); =20 - rc =3D libxl_domain_info(ctx, NULL, domid); + rc =3D libxl_domain_info(CTX, NULL, domid); switch(rc) { case 0: break; @@ -1058,17 +1057,12 @@ void libxl__destroy_domid(libxl__egc *egc, libxl__d= estroy_domid_state *dis) abort(); } =20 - dom_path =3D libxl__xs_get_dompath(gc, domid); - if (!dom_path) { - rc =3D ERROR_FAIL; - goto out; - } - if (libxl__device_pci_destroy_all(gc, domid) < 0) LOGD(ERROR, domid, "Pci shutdown failed"); - rc =3D xc_domain_pause(ctx->xch, domid); - if (rc < 0) { - LOGEVD(ERROR, rc, domid, "xc_domain_pause failed"); + r =3D xc_domain_pause(CTX->xch, domid); + if (r < 0) { + LOGEVD(ERROR, r, domid, "xc_domain_pause failed"); + rc =3D ERROR_FAIL; } =20 if (dm_present) { --=20 Anthony PERARD _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel