[Xen-devel] [PATCH] xen/public: arch-arm: Use xen_mk_ullong instead of suffixing value with ULL

Julien Grall posted 1 patch 14 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/xen tags/patchew/20190603160829.31912-1-julien.grall@arm.com
xen/include/public/arch-arm.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

[Xen-devel] [PATCH] xen/public: arch-arm: Use xen_mk_ullong instead of suffixing value with ULL

Posted by Julien Grall 14 weeks ago
There are a few places in include/public/arch-arm.h that are still
suffixing immediate with ULL instead of using xen_mk_ullong.

The latter allows a consumer to easily tweak the header if ULL is not
supported.

So switch the remaining users of ULL to xen_mk_ullong.

Signed-off-by: Julien Grall <julien.grall@arm.com>
---
 xen/include/public/arch-arm.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index eb424e8286..f550137089 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -407,12 +407,12 @@ typedef uint64_t xen_callback_t;
 #define GUEST_GICV3_GICR0_SIZE     xen_mk_ullong(0x01000000)
 
 /* ACPI tables physical address */
-#define GUEST_ACPI_BASE 0x20000000ULL
-#define GUEST_ACPI_SIZE 0x02000000ULL
+#define GUEST_ACPI_BASE xen_mk_ullong(0x20000000)
+#define GUEST_ACPI_SIZE xen_mk_ullong(0x02000000)
 
 /* PL011 mappings */
-#define GUEST_PL011_BASE    0x22000000ULL
-#define GUEST_PL011_SIZE    0x00001000ULL
+#define GUEST_PL011_BASE    xen_mk_ullong(0x22000000)
+#define GUEST_PL011_SIZE    xen_mk_ullong(0x00001000)
 
 /*
  * 16MB == 4096 pages reserved for guest to use as a region to map its
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] xen/public: arch-arm: Use xen_mk_ullong instead of suffixing value with ULL

Posted by Alexandru Stefan ISAILA 11 weeks ago
Looks good to me

> There are a few places in include/public/arch-arm.h that are still
> suffixing immediate with ULL instead of using xen_mk_ullong.
> 
> The latter allows a consumer to easily tweak the header if ULL is not
> supported.
> 
> So switch the remaining users of ULL to xen_mk_ullong.
> 
> Signed-off-by: Julien Grall <julien.grall@arm.com>

Reviewed-by: Alexandru Isaila <aisaila@bitdefender.com>

Cheers
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] xen/public: arch-arm: Use xen_mk_ullong instead of suffixing value with ULL

Posted by Stefano Stabellini 6 weeks ago
On Wed, 26 Jun 2019, Alexandru Stefan ISAILA wrote:
> Looks good to me
> 
> > There are a few places in include/public/arch-arm.h that are still
> > suffixing immediate with ULL instead of using xen_mk_ullong.
> > 
> > The latter allows a consumer to easily tweak the header if ULL is not
> > supported.
> > 
> > So switch the remaining users of ULL to xen_mk_ullong.
> > 
> > Signed-off-by: Julien Grall <julien.grall@arm.com>
> 
> Reviewed-by: Alexandru Isaila <aisaila@bitdefender.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] xen/public: arch-arm: Use xen_mk_ullong instead of suffixing value with ULL

Posted by Julien Grall 11 weeks ago
Hi,

Gentle ping.

Cheers,

On 03/06/2019 17:08, Julien Grall wrote:
> There are a few places in include/public/arch-arm.h that are still
> suffixing immediate with ULL instead of using xen_mk_ullong.
> 
> The latter allows a consumer to easily tweak the header if ULL is not
> supported.
> 
> So switch the remaining users of ULL to xen_mk_ullong.
> 
> Signed-off-by: Julien Grall <julien.grall@arm.com>
> ---
>   xen/include/public/arch-arm.h | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index eb424e8286..f550137089 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -407,12 +407,12 @@ typedef uint64_t xen_callback_t;
>   #define GUEST_GICV3_GICR0_SIZE     xen_mk_ullong(0x01000000)
>   
>   /* ACPI tables physical address */
> -#define GUEST_ACPI_BASE 0x20000000ULL
> -#define GUEST_ACPI_SIZE 0x02000000ULL
> +#define GUEST_ACPI_BASE xen_mk_ullong(0x20000000)
> +#define GUEST_ACPI_SIZE xen_mk_ullong(0x02000000)
>   
>   /* PL011 mappings */
> -#define GUEST_PL011_BASE    0x22000000ULL
> -#define GUEST_PL011_SIZE    0x00001000ULL
> +#define GUEST_PL011_BASE    xen_mk_ullong(0x22000000)
> +#define GUEST_PL011_SIZE    xen_mk_ullong(0x00001000)
>   
>   /*
>    * 16MB == 4096 pages reserved for guest to use as a region to map its
> 

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel