From nobody Mon Feb 9 16:55:45 2026 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1559039663; cv=none; d=zoho.com; s=zohoarc; b=FnS6+oGx7kc3XZpMpEGP2kIZ6OYjYs/ut5iPi7uDHjPciI/CTJ2xoeMDVG0Ej5YkDzbAB5x16yMgrPL0zSMQMCF1C9ePG0Kh/8TcuEmt85H4H6SlK7yMEfltSRHTa8WFduI26Rxq8Bi/AOrepWSB3InPbS+EeaYgQaH4gKNIW8A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559039663; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=uPpubcUG9hyQb5lnhKuIVhbYGf8WG+mDHKPilfcRFTo=; b=dEtk/TAc6F3aka9a0nI95742t2Q2/URXUa2LpmOtfNGaia2zoLqyZKxxyYGaroirdotG7ALrYK2g8FAZLB90CcP/HReAfSPTb8jL9ec+Q+2izUdycGbzpYg1dXlLSvxEL6WxrBxIorYg1JJm/kMQofcaB3aeiQ5EicqVk/Rz2LA= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1559039663322773.3326648989289; Tue, 28 May 2019 03:34:23 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hVZQO-0005Eq-Fm; Tue, 28 May 2019 10:33:44 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hVZQA-0004kI-2p for xen-devel@lists.xenproject.org; Tue, 28 May 2019 10:33:30 +0000 Received: from mx1.suse.de (unknown [195.135.220.15]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id 070b75fc-8134-11e9-8980-bc764e045a96; Tue, 28 May 2019 10:33:27 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 7B8A8B03A; Tue, 28 May 2019 10:33:26 +0000 (UTC) X-Inumbo-ID: 070b75fc-8134-11e9-8980-bc764e045a96 X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Juergen Gross To: xen-devel@lists.xenproject.org Date: Tue, 28 May 2019 12:32:51 +0200 Message-Id: <20190528103313.1343-39-jgross@suse.com> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20190528103313.1343-1-jgross@suse.com> References: <20190528103313.1343-1-jgross@suse.com> Subject: [Xen-devel] [PATCH 38/60] x86: make loading of GDT at context switch more modular X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Andrew Cooper , Wei Liu , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" In preparation for core scheduling carve out the GDT related functionality (writing GDT related PTEs, loading default of full GDT) into sub-functions. Signed-off-by: Juergen Gross Acked-by: Jan Beulich --- RFC V2: split off non-refactoring part V1: constify pointers, use initializers (Jan Beulich) --- xen/arch/x86/domain.c | 57 +++++++++++++++++++++++++++++++----------------= ---- 1 file changed, 35 insertions(+), 22 deletions(-) diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index d3ee699da6..adc06154ee 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -1626,6 +1626,37 @@ static inline bool need_full_gdt(const struct domain= *d) return is_pv_domain(d) && !is_idle_domain(d); } =20 +static inline void write_full_gdt_ptes(seg_desc_t *gdt, const struct vcpu = *v) +{ + unsigned long mfn =3D virt_to_mfn(gdt); + l1_pgentry_t *pl1e =3D pv_gdt_ptes(v); + unsigned int i; + + for ( i =3D 0; i < NR_RESERVED_GDT_PAGES; i++ ) + l1e_write(pl1e + FIRST_RESERVED_GDT_PAGE + i, + l1e_from_pfn(mfn + i, __PAGE_HYPERVISOR_RW)); +} + +static inline void load_full_gdt(const struct vcpu *v, unsigned int cpu) +{ + struct desc_ptr gdt_desc =3D { + .limit =3D LAST_RESERVED_GDT_BYTE, + .base =3D GDT_VIRT_START(v), + }; + + lgdt(&gdt_desc); +} + +static inline void load_default_gdt(const seg_desc_t *gdt, unsigned int cp= u) +{ + struct desc_ptr gdt_desc =3D { + .limit =3D LAST_RESERVED_GDT_BYTE, + .base =3D (unsigned long)(gdt - FIRST_RESERVED_GDT_ENTRY), + }; + + lgdt(&gdt_desc); +} + static void __context_switch(void) { struct cpu_user_regs *stack_regs =3D guest_cpu_user_regs(); @@ -1634,7 +1665,6 @@ static void __context_switch(void) struct vcpu *n =3D current; struct domain *pd =3D p->domain, *nd =3D n->domain; seg_desc_t *gdt; - struct desc_ptr gdt_desc; =20 ASSERT(p !=3D n); ASSERT(!vcpu_cpu_dirty(n)); @@ -1676,25 +1706,13 @@ static void __context_switch(void) =20 gdt =3D !is_pv_32bit_domain(nd) ? per_cpu(gdt_table, cpu) : per_cpu(compat_gdt_table, cpu); - if ( need_full_gdt(nd) ) - { - unsigned long mfn =3D virt_to_mfn(gdt); - l1_pgentry_t *pl1e =3D pv_gdt_ptes(n); - unsigned int i; =20 - for ( i =3D 0; i < NR_RESERVED_GDT_PAGES; i++ ) - l1e_write(pl1e + FIRST_RESERVED_GDT_PAGE + i, - l1e_from_pfn(mfn + i, __PAGE_HYPERVISOR_RW)); - } + if ( need_full_gdt(nd) ) + write_full_gdt_ptes(gdt, n); =20 if ( need_full_gdt(pd) && ((p->vcpu_id !=3D n->vcpu_id) || !need_full_gdt(nd)) ) - { - gdt_desc.limit =3D LAST_RESERVED_GDT_BYTE; - gdt_desc.base =3D (unsigned long)(gdt - FIRST_RESERVED_GDT_ENTRY); - - lgdt(&gdt_desc); - } + load_default_gdt(gdt, cpu); =20 write_ptbase(n); =20 @@ -1707,12 +1725,7 @@ static void __context_switch(void) =20 if ( need_full_gdt(nd) && ((p->vcpu_id !=3D n->vcpu_id) || !need_full_gdt(pd)) ) - { - gdt_desc.limit =3D LAST_RESERVED_GDT_BYTE; - gdt_desc.base =3D GDT_VIRT_START(n); - - lgdt(&gdt_desc); - } + load_full_gdt(n, cpu); =20 if ( pd !=3D nd ) cpumask_clear_cpu(cpu, pd->dirty_cpumask); --=20 2.16.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel