From nobody Sat Apr 27 19:20:07 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1558449040; cv=none; d=zoho.com; s=zohoarc; b=SR1DbczRSfNLbEFh6PI1k77pGWv8GaGCYsSGH6jK+g0qGXUoZgrX1yluk3FndaW7HMHiRkj+Asad+ShlsZOX8LFxzwg+mdyVKpzoanRlzrbov3rJ4kdiTIhNaZGIspyXQnbWn8JPFCJXJ9ijI8tdm/4JhTttD6zB7Lk3kCzNC10= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558449040; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=6+Egidmmbu1+V8yLiDnBLMgIzSGblUABeOgIEWC8RIY=; b=n7eFCiSkfPYcQA7FdQJkXhcZrDBvBeVzl3JMDc1DD8fcwYc1tr3wabekTHcTzDjnC1WEfqzVedNvl6HtOlPV5vXPL3KFDkdwaTOrQdjJJfTb1K54XR3kKqQDgD4w1wNPWGbAjQ38Dd9Y8A2kVGLfti5OIR5+TTyEJ8Skvxh0z9Y= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1558449040383367.89331460945084; Tue, 21 May 2019 07:30:40 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hT5lc-0008Vh-78; Tue, 21 May 2019 14:29:24 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hT5la-0008Vc-Ba for xen-devel@lists.xenproject.org; Tue, 21 May 2019 14:29:22 +0000 Received: from foss.arm.com (unknown [217.140.101.70]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTP id d21a6224-7bd4-11e9-8980-bc764e045a96; Tue, 21 May 2019 14:29:20 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CAA73374; Tue, 21 May 2019 07:29:19 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.196.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DD6213F5AF; Tue, 21 May 2019 07:29:18 -0700 (PDT) X-Inumbo-ID: d21a6224-7bd4-11e9-8980-bc764e045a96 From: Julien Grall To: xen-devel@lists.xenproject.org Date: Tue, 21 May 2019 15:29:13 +0100 Message-Id: <20190521142913.22394-1-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 Subject: [Xen-devel] [PATCH] xen/arm64: livepatch: Fix build after 03957f58db X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Julien Grall , sstabellini@kernel.org MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Commit 03957f58db "xen/const: Extend the existing macro BIT to take a suffix in parameter" didn't convert all the callers of the macro BIT. This will result to a build breakage when enabling Livepatch on arm64. Reported-by: Andrew Cooper Signed-off-by: Julien Grall Acked-by: Andrew Cooper Acked-by: Stefano Stabellini --- xen/arch/arm/arm64/livepatch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/arm64/livepatch.c b/xen/arch/arm/arm64/livepatch.c index 2247b925a0..5c75779284 100644 --- a/xen/arch/arm/arm64/livepatch.c +++ b/xen/arch/arm/arm64/livepatch.c @@ -208,7 +208,7 @@ static int reloc_insn_imm(enum aarch64_reloc_op op, voi= d *dest, u64 val, sval >>=3D lsb; =20 /* Extract the value bits and shift them to bit 0. */ - imm_mask =3D (BIT(lsb + len) - 1) >> lsb; + imm_mask =3D (BIT(lsb + len, UL) - 1) >> lsb; imm =3D sval & imm_mask; =20 /* Update the instruction's immediate field. */ --=20 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel