[Xen-devel] [PATCH 1/4] gitignore: ignore .vscode directory

Wei Liu posted 4 patches 1 year, 11 months ago

[Xen-devel] [PATCH 1/4] gitignore: ignore .vscode directory

Posted by Wei Liu 1 year, 11 months ago
The directory is created by Visual Studio Code editor to store its
local state.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index 26bc583f74..3822bb75ba 100644
--- a/.gitignore
+++ b/.gitignore
@@ -30,6 +30,7 @@ cscope.out
 cscope.po.out
 .config
 .vimrc
+.vscode
 
 dist
 stubdom/*.tar.gz
-- 
2.20.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 1/4] gitignore: ignore .vscode directory

Posted by Anthony PERARD 1 year, 11 months ago
On Mon, May 13, 2019 at 02:47:11PM +0100, Wei Liu wrote:
> The directory is created by Visual Studio Code editor to store its
> local state.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
>  .gitignore | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.gitignore b/.gitignore
> index 26bc583f74..3822bb75ba 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -30,6 +30,7 @@ cscope.out
>  cscope.po.out
>  .config
>  .vimrc
> +.vscode

Shouldn't this go in "~/.config/git/ignore" instead? Or whatever `git
config core.excludesFile` point to.

`git help ignore` for more detail.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 1/4] gitignore: ignore .vscode directory

Posted by Wei Liu 1 year, 11 months ago
On Mon, May 13, 2019 at 03:13:06PM +0100, Anthony PERARD wrote:
> On Mon, May 13, 2019 at 02:47:11PM +0100, Wei Liu wrote:
> > The directory is created by Visual Studio Code editor to store its
> > local state.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > ---
> >  .gitignore | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/.gitignore b/.gitignore
> > index 26bc583f74..3822bb75ba 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -30,6 +30,7 @@ cscope.out
> >  cscope.po.out
> >  .config
> >  .vimrc
> > +.vscode
> 
> Shouldn't this go in "~/.config/git/ignore" instead? Or whatever `git
> config core.excludesFile` point to.
> 
> `git help ignore` for more detail.

We already put a bunch of files for various tools in xen.git's
gitignore. I don't see why this can't be done for vscode.

Wei.

> 
> -- 
> Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel