From nobody Tue Feb 10 03:44:41 2026 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1555605204; cv=none; d=zoho.com; s=zohoarc; b=QUZUT2Iob5InoLt7TMr30sGxhiZWExNB8gSAS/2+r2VJQ9hTfFeyN37ldMO5P2e8CweRuciMhPvdpOROfDq2++F+XCH1kSLRvtaQ1gjbtMulF2KVTHzgruh4t/YLzwspj/TRd1PvWEiUa7jKefs+3W1010g0WNCN/nZp0na1ZJ8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1555605204; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=oi8UFTr92xJ9TsbkOCxfTmiP8lMP3AvAt9y5MlMct34=; b=G0mPD38m26MsmnEEefPKN+5LIsTTyxF/MUg7Q2jgPjiS44znMBGQ/5SDP64F3c/7rzK5opoW70ck5eXIiX1egLHSRxWWuSJKwo2xIvnSJkCt8y1p+1UrIdKFImrCXB0rCpqQxl4hIl0hINGkWpyFGG1jXEmtK12aY0S0qEU5wtk= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1555605204086885.1557153576906; Thu, 18 Apr 2019 09:33:24 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hH9xP-000287-FH; Thu, 18 Apr 2019 16:32:15 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hH9xN-00025i-O2 for xen-devel@lists.xenproject.org; Thu, 18 Apr 2019 16:32:13 +0000 Received: from SMTP03.CITRIX.COM (unknown [162.221.156.55]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id 83ee2663-61f7-11e9-92d7-bc764e045a96; Thu, 18 Apr 2019 16:32:11 +0000 (UTC) X-Inumbo-ID: 83ee2663-61f7-11e9-92d7-bc764e045a96 X-IronPort-AV: E=Sophos;i="5.60,366,1549929600"; d="scan'208";a="83913792" From: Ian Jackson To: Date: Thu, 18 Apr 2019 17:31:43 +0100 Message-ID: <20190418163158.11408-7-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190418163158.11408-1-ian.jackson@eu.citrix.com> References: <20190418163158.11408-1-ian.jackson@eu.citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [OSSTEST PATCH 06/21] starvation: Teach archaeologists about starved job state X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Ian Jackson Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" sg-report-flight is a bit awkward. It thinks mostly about step status, not job status. So, when justifying, if we don't find a step, and the job state is starved, we treat the step as starved. If there are only starved steps, then we don't have evidence that this is a regression, because the test wasn't run in the baseline. If there are other steps we look at those instead. Signed-off-by: Ian Jackson --- Osstest/Executive.pm | 4 ++-- sg-report-flight | 11 +++++++++++ 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm index b27b8d25..a9f9ac78 100644 --- a/Osstest/Executive.pm +++ b/Osstest/Executive.pm @@ -362,8 +362,8 @@ END Content =3D> (join " | ", @content), ColourAttr =3D> "bgcolor=3D\"$failcolour\"", }; - } elsif ($status eq 'blocked') { - return $single->("blocked", $purple), + } elsif ($status eq 'blocked' or $status eq 'starved') { + return $single->($status, $purple), } elsif ($status eq 'queued') { return $single->("($status)", $grey_dark), } elsif ($status eq 'preparing') { diff --git a/sg-report-flight b/sg-report-flight index 2677c479..6c481f6f 100755 --- a/sg-report-flight +++ b/sg-report-flight @@ -160,6 +160,10 @@ sub findaflight ($$$$$) { return undef; } =20 + my $jcheckq=3D db_prepare(<execute($tflight, $job, $testid); ($chkst) =3D $checkq->fetchrow_array(); + if (!defined $chkst) { + $jcheckq->execute($tflight, $job); + my ($jchkst) =3D $jcheckq->fetchrow_array(); + $chkst =3D $jchkst if $jchkst eq 'starved'; + } } $whynot=3D $sub->($tflight, $chkst) if !defined $whynot; if (!defined $whynot) { @@ -861,6 +870,8 @@ END my $tblocker =3D $st eq 'fail' ? 'regression' : $st; my $tpriority =3D $j->{job} =3D~ m/^build/ ? 600 : 100; $rtup=3D [ $tpriority, $tblocker, "REGR. vs.", $chkflight ]; + } elsif ($chkst eq 'starved') { # actually, the job was 'starved' + $rtup=3D [ 50, '', "starved in", $chkflight ]; } else { $rtup=3D [ 170, '', "$chkst in", $chkflight ]; } --=20 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel