From nobody Thu Apr 25 23:25:56 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1555362798; cv=none; d=zoho.com; s=zohoarc; b=nVm1ZguAybn19bMnWN65qcOW2QSXgTHN5bczYY5rlE7r+IOMFUntlJa4owdriDVRgy+24gInJyzT7XXIGbRrknUA38UzsJT/GNxJSSME5vI1nwVC3tjVt9LokFgaKMnCkkz721seH2+iYe74Hg4yDFKchnROCaHV5FK5YcGSn+Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1555362798; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=0RZ4dUcoLRWjkhj/goiV8G2Scq7cgWdE7vKFG0GbnPc=; b=ApDG1mmxQIJzCED0HmuJGd45XaBMFi11kM7iQXWbdkwVggmsg3UNVjgslKN0oQEPqLrP/YV44vgnPH5Ner5MZ9NWEUVBhqhNgq5mMjDoGXD9hkmHZA2aw5a2kMRntFnYvWt9WZAwAzfJPLJn5Ox1vtrfO4ZxUKMIy0wW6PPZRvw= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1555362798874544.4643666309273; Mon, 15 Apr 2019 14:13:18 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hG8tH-000483-Pp; Mon, 15 Apr 2019 21:11:47 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hG8tG-00047y-HO for xen-devel@lists.xenproject.org; Mon, 15 Apr 2019 21:11:46 +0000 Received: from gateway20.websitewelcome.com (unknown [192.185.67.41]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id 1273be5c-5fc3-11e9-92d7-bc764e045a96; Mon, 15 Apr 2019 21:11:44 +0000 (UTC) Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 5B0F6400D85D7 for ; Mon, 15 Apr 2019 16:11:44 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id G8tEhE8f92PzOG8tEhmH6G; Mon, 15 Apr 2019 16:11:44 -0500 Received: from [189.250.55.242] (port=53160 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.91) (envelope-from ) id 1hG8tD-001APC-Av; Mon, 15 Apr 2019 16:11:43 -0500 X-Inumbo-ID: 1273be5c-5fc3-11e9-92d7-bc764e045a96 X-Authority-Reason: nr=8 Date: Mon, 15 Apr 2019 16:11:41 -0500 From: "Gustavo A. R. Silva" To: Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "David S. Miller" Message-ID: <20190415211141.GA1732@embeddedor> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - lists.xenproject.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.55.242 X-Source-L: No X-Exim-ID: 1hG8tD-001APC-Av X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.250.55.242]:53160 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 5 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Subject: [Xen-devel] [PATCH net-next] xen-netfront: mark expected switch fall-through X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, "Gustavo A. R. Silva" , linux-kernel@vger.kernel.org, Kees Cook , netdev@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: drivers/net/xen-netfront.c: In function =E2=80=98netback_changed=E2=80=99: drivers/net/xen-netfront.c:2038:6: warning: this statement may fall through= [-Wimplicit-fallthrough=3D] if (dev->state =3D=3D XenbusStateClosed) ^ drivers/net/xen-netfront.c:2041:2: note: here case XenbusStateClosing: ^~~~ Warning level 3 was used: -Wimplicit-fallthrough=3D3 Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find. This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough. Signed-off-by: Gustavo A. R. Silva Reviewed-by: Juergen Gross --- drivers/net/xen-netfront.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index 80c30321de41..8d33970a2950 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -2037,7 +2037,7 @@ static void netback_changed(struct xenbus_device *dev, case XenbusStateClosed: if (dev->state =3D=3D XenbusStateClosed) break; - /* Missed the backend's CLOSING state -- fallthrough */ + /* Fall through - Missed the backend's CLOSING state. */ case XenbusStateClosing: xenbus_frontend_closed(dev); break; --=20 2.21.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel