From nobody Wed Apr 24 05:04:08 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1555345789; cv=none; d=zoho.com; s=zohoarc; b=Kj9TtCI/Fs8V2Zz7RcyastW0uA0KMQ8FiGRVh5xMN1m3UqKTAyont5AQh291tLkj+je3W8yRSPtPU9dZx0Ibyr+YTobg9t0buJBGWH7LsIook3m4kB+Sz13aBqHLC0yHaMR+W6V5KYuM6N6r3Xi80QITVrmVCgag11+LfAHYGSs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1555345789; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=j6Jt4XetI8kv9ramq4jtl0W0FRR6OCveOQcQmyuk1y4=; b=Gp1gOjl+sSr9t8xFSVrlJ4To1cmSpiPuMhkAq+6fNDoc3qJdwwj3zof4wtB1dT8CxwDmDC2NItI6iEGZV+YCVxDeFHzHoCMG9X9eYmMVxAmkC9Rhzm7KNLQmJavFn1EivTzsJYuQinjSL7WQIIIY8Gbock32gxUK0FYEO73WuII= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1555345789241457.0019629804243; Mon, 15 Apr 2019 09:29:49 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hG4Sz-0007Ug-8b; Mon, 15 Apr 2019 16:28:21 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hG4Sx-0007UQ-50 for xen-devel@lists.xenproject.org; Mon, 15 Apr 2019 16:28:19 +0000 Received: from SMTP03.CITRIX.COM (unknown [162.221.156.55]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id 79824356-5f9b-11e9-92d7-bc764e045a96; Mon, 15 Apr 2019 16:28:17 +0000 (UTC) X-Inumbo-ID: 79824356-5f9b-11e9-92d7-bc764e045a96 X-IronPort-AV: E=Sophos;i="5.60,354,1549929600"; d="scan'208";a="83602165" From: Ian Jackson To: Date: Mon, 15 Apr 2019 17:28:08 +0100 Message-ID: <20190415162809.23675-2-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190415162809.23675-1-ian.jackson@eu.citrix.com> References: <20190415162809.23675-1-ian.jackson@eu.citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 1/2] build system: make install-stubdom depend on install-tools again X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Wei Liu , Ian Jackson Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" In d290e325179ccee966cd679d0fed48be6f4cc1b7 "build system: don't let install-stubdom depend on install-tools" the dependency of install-stubdom on install-tools was removed. However, this was not correct. stubdom/Makefile contains this: $(XEN_ROOT)/tools/qemu-xen-traditional-dir: $(MAKE) DESTDIR=3D -C $(XEN_ROOT)/tools qemu-xen-traditional-dir-find As I have written before: With recursive make, it is necessary for the overall structure of the makefiles to sequence things so that each directory is entered exactly once, before its dependent directories are entered. (It is possible to violate this rule without creating races but it is tricky and inadvisable.) Since d290e325179c, it can happen that the command for the qemu-xen-traditional-dir-find rule is run twice simultaneously - once as a result of $(MAKE) -C tools install, and once as a result of $(MAKE) -C stubdom install. If you get unlucky, this causes lossage. (This just happened to me in an osstest flight.) In principle we could alternatively fix this by lifting the commands in the qemu-xen-traditional-dir-find target (and perhaps other things too) into the toplevel Makefile, as was done for mini-os. But that seems overkill given how bad the stubdom build system is, and the fact that we think at some point this qemu-trad will go away entirely. Adding the tools dependency back to the stubdom build is by and large good enough. (Someone who really wants to build stubdom without tools is welcome to do this separation if they really want to.) CC: Juergen Gross CC: Wei Liu Signed-off-by: Ian Jackson Acked-by: Wei Liu --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index d959cd5b47..829ac63741 100644 --- a/Makefile +++ b/Makefile @@ -127,7 +127,7 @@ install-tools: install-tools-public-headers $(MAKE) -C tools install =20 .PHONY: install-stubdom -install-stubdom: mini-os-dir install-tools-public-headers +install-stubdom: mini-os-dir install-tools $(MAKE) -C stubdom install ifeq (x86_64,$(XEN_TARGET_ARCH)) XEN_TARGET_ARCH=3Dx86_32 $(MAKE) -C stubdom install-grub --=20 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel From nobody Wed Apr 24 05:04:08 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1555345790; cv=none; d=zoho.com; s=zohoarc; b=lEerUAjZVq542uaor92Ca7oY9CSA7UOznoiTNVrQ1/6Hi6WB1Sz9UWMor3g2DJ0mYkZj+IoRdwJEgOB2/1nFypkyAuhSCszAYMUy738H4n0Sp2+6HigPjlsJQxOHUa47zxPfa03BQ4da4DRxdZeUkTBJiKZ1FPYoRp4aQk00gNg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1555345790; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=8htGe7pdLr02Wggf4ky0zg20W1cEtVBRq0YevEI/6R0=; b=oQdrsfzfIaNEqRcyMcYPqHbXCZJB9ULnYINpij09gLcMgSNAUh1ERe8Igjj0x6ECKd4YyctQzJVNIHzzAQxVsQH8T+vh284sWeg4Srkasj/J2Q3rlN/nDwU4SYkeoc3F5Erk8lH8fKwZ2sSHKVn830gkWegM9LZe0/nTH0O/7oQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1555345790251144.56040530405267; Mon, 15 Apr 2019 09:29:50 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hG4Sz-0007Ua-01; Mon, 15 Apr 2019 16:28:20 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hG4Sx-0007UR-4n for xen-devel@lists.xenproject.org; Mon, 15 Apr 2019 16:28:19 +0000 Received: from SMTP03.CITRIX.COM (unknown [162.221.156.55]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id 794e0d33-5f9b-11e9-92d7-bc764e045a96; Mon, 15 Apr 2019 16:28:17 +0000 (UTC) X-Inumbo-ID: 794e0d33-5f9b-11e9-92d7-bc764e045a96 X-IronPort-AV: E=Sophos;i="5.60,354,1549929600"; d="scan'208";a="83602166" From: Ian Jackson To: Date: Mon, 15 Apr 2019 17:28:09 +0100 Message-ID: <20190415162809.23675-3-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190415162809.23675-1-ian.jackson@eu.citrix.com> References: <20190415162809.23675-1-ian.jackson@eu.citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 2/2] DO NOT APPLY git-checkout.sh: add sleep to demonstrate race X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Ian Jackson Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" This allows easy reproduction of git-checkout races: each checkout waits until you kill its sleep. You can see the multiple identical checkout runes in ps etc. A good rune is: watch 'ps -fHtpts/60' (replacing pts/60 with the pty of your build job). Signed-off-by: Ian Jackson --- scripts/git-checkout.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/git-checkout.sh b/scripts/git-checkout.sh index 20ae31ff23..290026ad32 100755 --- a/scripts/git-checkout.sh +++ b/scripts/git-checkout.sh @@ -11,6 +11,8 @@ DIR=3D$3 =20 set -e =20 +sleep 1000 ||: + if test \! -d $DIR-remote; then rm -rf $DIR-remote $DIR-remote.tmp mkdir -p $DIR-remote.tmp; rmdir $DIR-remote.tmp --=20 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel