From nobody Sat Apr 20 11:12:52 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1555329225; cv=none; d=zoho.com; s=zohoarc; b=Eq7eAURcMI1zyrAKvdeVXusJqO1sT1byL/lH5ogOJ1FoZnmkNLLeHvnEihKOB8W0q/YCyB1TR6L5e0VEutuvSKAMg7HwQvWv/Z+NM5l1hLPQW+9HeoQQwnbtci8HXJZIzF2da4Nj8lJQVpddhJUc4Cli/KQ9CiIPfV027NbTFEQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1555329225; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=BbAm+frZZ9UC9KXY/vhL/GCRFPFNqpl6Bora1C0cK+o=; b=nJ8R4xgfi0uUdxFTXyhDzk+QkPtBpLC6kY71Nmk0gnuQYbXfhCmq8m94kC90AcLA/o9cuVI0CbAwASFeEsn+jytdLK3iRv7iGzSXP3IFJxaYB/Ji6N+2zWAS3qNhxo6Ypy/UnR5wwYziYso4vC0a6SY17v6dhDIRWtHBRx5+DHA= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1555329225036840.8644962348267; Mon, 15 Apr 2019 04:53:45 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hG09r-0000uH-Qx; Mon, 15 Apr 2019 11:52:19 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hG09q-0000uC-Vi for xen-devel@lists.xenproject.org; Mon, 15 Apr 2019 11:52:19 +0000 Received: from SMTP03.CITRIX.COM (unknown [162.221.156.55]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id eaa9dbc8-5f74-11e9-92d7-bc764e045a96; Mon, 15 Apr 2019 11:52:17 +0000 (UTC) X-Inumbo-ID: eaa9dbc8-5f74-11e9-92d7-bc764e045a96 X-IronPort-AV: E=Sophos;i="5.60,353,1549929600"; d="scan'208";a="83568941" From: Ian Jackson To: Date: Mon, 15 Apr 2019 12:51:58 +0100 Message-ID: <20190415115158.18478-1-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Subject: [Xen-devel] [OSSTEST PATCH] ts-host-install: Do not force MAC address of Xen vifs X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Julien Grall , Ian Jackson Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" For some broken hosts we explicitly force the mac address in software. (This is controlled by the ForceMacAddress host property.) We achieve this by writing a udev rule (which ends up both in the installer and in the initramfs) which calls `ip link set ... address'. However: in some cases we share the initramfs with guests. In particular, the `xen-tools' package likes to use the host initramfs. In stretch at least, this rule, empirically, applies in the guest too. The result is that with ForceMacAddress, the guest ends up with the same mac address as the host, breaking everything. Fix this by explicitly excluding Xen network interfaces. These all get a proper mac address from xenstore (ultimately, from osstest itself via the guest config, or in other configurations from libxl). I don't know why this apparently worked on jessie. Startup order changes are a possibility. CC: Julien Grall Signed-off-by: Ian Jackson --- ts-host-install | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ts-host-install b/ts-host-install index ea087a25..4213c3a2 100755 --- a/ts-host-install +++ b/ts-host-install @@ -212,7 +212,7 @@ sub setup_netboot_firstboot($) { file_simple_write_contents ($persistent_net_rules, $ho->{Flags}{'force-mac-address'} ? <{Ether}" +SUBSYSTEM=3D=3D"net", ACTION=3D=3D"add", DRIVERS=3D=3D"?*", SUBSYSTEMS!=3D= "xen", KERNEL=3D=3D"$wantphysif", RUN +=3D "$ipcmd link set $wantphysif add= ress $ho->{Ether}" END SUBSYSTEM=3D=3D"net", ACTION=3D=3D"add", DRIVERS=3D=3D"?*", ATTR{address}= =3D=3D"$ho->{Ether}", ATTR{dev_id}=3D=3D"0x0", ATTR{type}=3D=3D"1", KERNEL= =3D=3D"eth*", NAME=3D"$wantphysif" END --=20 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel