From nobody Sun May 19 00:42:59 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1611761519; cv=none; d=zohomail.com; s=zohoarc; b=XSrLkeXJYOrC09yQWRiD43H7S3T7xvT5Fiq9Rs0uVN8x4ue274TYmyjnOPDkrkuZwIvXADBJ+zM2KdhPWj9o8td7WTAce5fMr3coKwnWaKdo/My2mnHRhNdMxMJ+tt8oW8wCEknvPzIj0EUypWthjGlydR+wNKszy3JXh95Zr6c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611761519; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=+xMr8r59GC8l/0GawA88vKREQ5w6lVwfXZx8ItnU74Q=; b=aUiSLJYODjUz8NFfM3NhEOe4aDiJAmPnsIMx9GTYRihWwiS0bqiaCsFJXJjD/hAE9DeB98usL5XeuPNiGeorV2ZhVhHaMpQBxoRnI0T9jtblGrFX/+UDoLafwyq+Uh8Rt7453ZUi8qSynezdn45uOcjjaxzhuLvtOXkRhO64YJw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1611761519789292.9507128298503; Wed, 27 Jan 2021 07:31:59 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.76154.137284 (Exim 4.92) (envelope-from ) id 1l4mnJ-0001iy-BS; Wed, 27 Jan 2021 15:31:45 +0000 Received: by outflank-mailman (output) from mailman id 76154.137284; Wed, 27 Jan 2021 15:31:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l4mnJ-0001ir-7i; Wed, 27 Jan 2021 15:31:45 +0000 Received: by outflank-mailman (input) for mailman id 76154; Wed, 27 Jan 2021 15:31:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l4mnH-0001il-OL for xen-devel@lists.xenproject.org; Wed, 27 Jan 2021 15:31:43 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 559a7538-2135-45a0-a322-70911f12ea35; Wed, 27 Jan 2021 15:31:43 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2BF5BADE0; Wed, 27 Jan 2021 15:31:42 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 559a7538-2135-45a0-a322-70911f12ea35 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1611761502; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+xMr8r59GC8l/0GawA88vKREQ5w6lVwfXZx8ItnU74Q=; b=IGOSkn5vnbOa7M8tCdR77wM2BS0JyMIR11buvsmATUnpcrsX9zdsHkyGJ68sbM/Ngh0NOD aIausovsvGACHkSBpMkOuOAQc+8AOjD+q/wwtWuIZqmga/YXTeoXi3HCER/M0ClLqSpD8v 8MFlG65a0FRQVEkJJUlGJYKFLxAfQrM= To: "xen-devel@lists.xenproject.org" Cc: Ian Jackson , Wei Liu , Anthony Perard From: Jan Beulich Subject: [PATCH] libxlutil: avoid almost-undefined behavior Message-ID: <1d735cfa-d011-c8f5-ff39-81e0227e3a5d@suse.com> Date: Wed, 27 Jan 2021 16:31:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) Content-Type: text/plain; charset="utf-8" While only value computations of an object are disallowed in the presence of another unsequenced side effect, at least gcc 4.3 looks to extend this to taking the object's address. The resulting warning causes the build to fail, because of -Werror. While there also correct an adjacent comment. Fixes: bdc0799fe26a ("libxlu: introduce xlu_pci_parse_spec_string()") Signed-off-by: Jan Beulich Reviewed-by: Ian Jackson --- a/tools/libs/util/libxlu_pci.c +++ b/tools/libs/util/libxlu_pci.c @@ -155,9 +155,10 @@ int xlu_pci_parse_spec_string(XLU_Config if (!ret) { bdf_present =3D true; =20 - /* Check whether 'vslot' if present */ + /* Check whether 'vslot' is present */ if (*ptr =3D=3D '@') { - ret =3D parse_vslot(&pci->vdevfn, ++ptr, &ptr); + ++ptr; + ret =3D parse_vslot(&pci->vdevfn, ptr, &ptr); if (ret) return ret; }