From nobody Mon Feb 9 17:24:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1619017011; cv=none; d=zohomail.com; s=zohoarc; b=MDmPMVkYOG3OynJTy7qgVuhnmDrBtukl8Yg2VW/YQQkcr6HNyGbh2VS18AbHEBKbNSYSU1GRwO2dCT7VDg4QtU1pxNLJX5NW5sKqQlpzVkA9DisRoMcXgoEbyAkOizfkkqPAOGyoH+z5iVSxO2nMnwzjBL+ItgfDskhZwEYzBf8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619017011; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=0hiOnsYBKJJyY/OKqVdi3PZ5qXRAtnLxQ2fMzsttxVs=; b=LzrQi8g0tmL2km4T5zWTRHZ/gIVsFPQSE2yYd2ju8VaQRx5Duho4fnUVU5qbQ6KbZDbdleK1iIZbsTwLdr+T50i3GIob6cFnccum0mJ6TbHDrLnylaifxDZGSymwHLSheJVyZyyuhxBsOxitvjqJ4GbPx+CoSPbzbq4ug3X+dpI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1619017011182827.8913250900093; Wed, 21 Apr 2021 07:56:51 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.114788.218809 (Exim 4.92) (envelope-from ) id 1lZEHN-0007yc-BH; Wed, 21 Apr 2021 14:56:37 +0000 Received: by outflank-mailman (output) from mailman id 114788.218809; Wed, 21 Apr 2021 14:56:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lZEHN-0007yU-88; Wed, 21 Apr 2021 14:56:37 +0000 Received: by outflank-mailman (input) for mailman id 114788; Wed, 21 Apr 2021 14:56:35 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lZEHL-0007yG-92 for xen-devel@lists.xenproject.org; Wed, 21 Apr 2021 14:56:35 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id eaf0465f-6f39-4fa3-85b3-2b310311ebfc; Wed, 21 Apr 2021 14:56:34 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 995EBAD8A; Wed, 21 Apr 2021 14:56:33 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eaf0465f-6f39-4fa3-85b3-2b310311ebfc X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1619016993; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0hiOnsYBKJJyY/OKqVdi3PZ5qXRAtnLxQ2fMzsttxVs=; b=YkEJ7t+xIMGDyZM7Qp7QFZv3vodtNbLlNSZYSXvVpEYHO46U2S3Z6z4eDDf3OAjDnTbFV2 F6aQxPtgPTvLPKJ6d2rBJhCT2TrgEws68wp5UerVuPqURgfDgiG3IW6+PXdn1y/12MlBkZ KYSrxY/mV1tKcV0Bj22ueyqCJ8IN3vA= Subject: [PATCH v2 2/8] x86/HVM: avoid effectively open-coding xmalloc_array() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Paul Durrant References: <091b4b91-712f-3526-78d1-80d31faf8e41@suse.com> Message-ID: <1c3d573d-051f-3d18-cd63-6ccad5911786@suse.com> Date: Wed, 21 Apr 2021 16:56:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <091b4b91-712f-3526-78d1-80d31faf8e41@suse.com> Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) Content-Type: text/plain; charset="utf-8" There is a difference in generated code: xmalloc_bytes() forces SMP_CACHE_BYTES alignment. But if code really cared about such higher than default alignment, it should request so explicitly rather than using a type-unsafe interface. And if e.g. cache line sharing was a concern, the allocator itself should arrange to avoid such. Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/emulate.c +++ b/xen/arch/x86/hvm/emulate.c @@ -1924,7 +1924,7 @@ static int hvmemul_rep_movs( dgpa -=3D bytes - bytes_per_rep; =20 /* Allocate temporary buffer. Fall back to slow emulation if this fail= s. */ - buf =3D xmalloc_bytes(bytes); + buf =3D xmalloc_array(char, bytes); if ( buf =3D=3D NULL ) return X86EMUL_UNHANDLEABLE; =20 @@ -2037,7 +2037,7 @@ static int hvmemul_rep_stos( for ( ; ; ) { bytes =3D *reps * bytes_per_rep; - buf =3D xmalloc_bytes(bytes); + buf =3D xmalloc_array(char, bytes); if ( buf || *reps <=3D 1 ) break; *reps >>=3D 1;