From nobody Wed May 8 01:49:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1619793862; cv=none; d=zohomail.com; s=zohoarc; b=aDn/wjV8p/qktLw4/9LQSIG0dzFqWf/alPbp/b1L/nCor7I0GpzmcnGQjhQiPhbeFoLXtY0aL/3Op4Eoxxcr6JFML/2ESlxUJleClanLCLhtONsrIhzBC/uLMzB15bpV8nIDfr+K8CYseyCR6WgG+gjY2mV+nZf6w/PQoaf9eHc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619793862; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6oCDlYqqGUYNrVBiSX4LnnYH4/TGpQyc8Ua94Bo9cz4=; b=avXKMXmtwiCqsb5dbKrE9OdSMkgRZNMZFur8mQxws3a2OeXiExwwT/WhfdAkklrXJ2sMPueKDq85W20pc2qOt0El0HblWJ8Q7UqybsBTgrtwSiWDD9wVTkED6yQsamUxsphq+79foToXw6hQGX9Jg4Y1JuIENmjbxyoGsKzqmsY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1619793862859920.4224669413896; Fri, 30 Apr 2021 07:44:22 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.120573.228018 (Exim 4.92) (envelope-from ) id 1lcUN9-0002ZK-Ej; Fri, 30 Apr 2021 14:44:03 +0000 Received: by outflank-mailman (output) from mailman id 120573.228018; Fri, 30 Apr 2021 14:44:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lcUN9-0002ZD-BU; Fri, 30 Apr 2021 14:44:03 +0000 Received: by outflank-mailman (input) for mailman id 120573; Fri, 30 Apr 2021 14:44:02 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lcUN8-0002Z8-4E for xen-devel@lists.xenproject.org; Fri, 30 Apr 2021 14:44:02 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c6a8a42e-123d-443f-948a-289655a324d8; Fri, 30 Apr 2021 14:44:00 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1EC00B038; Fri, 30 Apr 2021 14:44:00 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c6a8a42e-123d-443f-948a-289655a324d8 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1619793840; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6oCDlYqqGUYNrVBiSX4LnnYH4/TGpQyc8Ua94Bo9cz4=; b=kh52rfQ1VbsqkBNHFH7MztwWog9cjV53kxOQg3f46X35nGXMQG7qgpiUB6nqUaQe1hv7/S Zcu36SmSsRzZra521hbcF9CLbPdkH9YmbQxWcW1o4/OCVfpbAk1IZ+l3EZvOPkhC73XG8+ ltKwjMSAesnXsZCduLOdRo7fNlaacio= Subject: [PATCH 1/3] firmware/shim: update linkfarm exclusions From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson References: <19695ffc-34d8-b682-b092-668f872d4e57@suse.com> Message-ID: Date: Fri, 30 Apr 2021 16:43:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <19695ffc-34d8-b682-b092-668f872d4e57@suse.com> Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) Content-Type: text/plain; charset="utf-8" Some intermediate files weren't considered at all at the time. Also after its introduction, various changes to the build environment have rendered the exclusion sets stale. For example, we now have some .*.cmd files in the build tree. Combine all respective patterns into a single .* one, seeing that we don't have any actual source files matching this pattern in the tree. Add other patterns as well as individual files. Also introduce LINK_EXCLUDE_PATHS to deal with entire directories full of generated headers as well as a few specific files the names of which are too generic to list under LINK_EXCLUDES. Signed-off-by: Jan Beulich Acked-by: Roger Pau Monn=C3=A9 --- a/tools/firmware/xen-dir/Makefile +++ b/tools/firmware/xen-dir/Makefile @@ -15,9 +15,19 @@ DEP_DIRS=3D$(foreach i, $(LINK_DIRS), $(XE DEP_FILES=3D$(foreach i, $(LINK_FILES), $(XEN_ROOT)/$(i)) =20 # Exclude some intermediate files and final build products -LINK_EXCLUDES :=3D '*.[isoa]' '.*.d' '.*.d2' '.config' -LINK_EXCLUDES +=3D '*.map' 'xen' 'xen.gz' 'xen.efi' 'xen-syms' -LINK_EXCLUDES +=3D '.*.tmp' +LINK_EXCLUDES :=3D '*.[isoa]' '*.bin' '*.chk' '*.lnk' '*.gz' '.*' +LINK_EXCLUDES +=3D lexer.lex.? parser.tab.? conf +LINK_EXCLUDES +=3D asm-offsets.h asm-macros.h compile.h '*-autogen.h' +LINK_EXCLUDES +=3D mkelf32 mkreloc symbols config_data.S xen.lds efi.lds +LINK_EXCLUDES +=3D '*.map' xen xen.gz xen.efi xen-syms check.efi + +# To exclude full subtrees or individual files of not sufficiently specific +# names, regular expressions are used: +LINK_EXCLUDE_PATHS :=3D xen/include/compat/.* +LINK_EXCLUDE_PATHS +=3D xen/include/config/.* +LINK_EXCLUDE_PATHS +=3D xen/include/generated/.* +LINK_EXCLUDE_PATHS +=3D xen/arch/x86/boot/reloc[.]S +LINK_EXCLUDE_PATHS +=3D xen/arch/x86/boot/cmdline[.]S =20 # This is all a giant mess and doesn't really work. # @@ -32,9 +42,10 @@ LINK_EXCLUDES +=3D '.*.tmp' # support easy development of the shim, but has a side effect of clobbering # the already-built shim. # -# $(LINK_EXCLUDES) should be set such that a parallel build of shim and xe= n/ -# doesn't cause a subsequent `make install` to decide to regenerate the -# linkfarm. This means that all final build artefacts must be excluded. +# $(LINK_EXCLUDES) and $(LINK_EXCLUDE_DIRS) should be set such that a para= llel +# build of shim and xen/ doesn't cause a subsequent `make install` to deci= de to +# to regenerate the linkfarm. This means that all intermediate and final = build +# artefacts must be excluded. linkfarm.stamp: $(DEP_DIRS) $(DEP_FILES) FORCE mkdir -p $(D) rm -f linkfarm.stamp.tmp @@ -46,7 +57,8 @@ linkfarm.stamp: $(DEP_DIRS) $(DEP_FILES) sed 's,^$(XEN_ROOT)/$(d)/,,g' | xargs mkdir -p .);) \ $(foreach d, $(LINK_DIRS), \ (cd $(XEN_ROOT); \ - find $(d) ! -type l -type f $(addprefix ! -name ,$(LINK_EXCLUDES))) \ + find $(d) ! -type l -type f $(addprefix ! -name ,$(LINK_EXCLUDES)) \ + | grep -v $(patsubst %,-e '^%$$',$(LINK_EXCLUDE_PATHS))) \ >> linkfarm.stamp.tmp ; ) \ $(foreach f, $(LINK_FILES), \ echo $(f) >> linkfarm.stamp.tmp ;) From nobody Wed May 8 01:49:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1619793876; cv=none; d=zohomail.com; s=zohoarc; b=FUpBsAPVjHAkQ3+y+bP60+3GevYY7tp2XkoGWH/Rb0aIciNfVLbSHhrCQfsJavZ/Ftr8UleL2Fop/VsvWYJC277yIDEkfXixdhVnZ8HJ/a2qBS7DEKjV/BaSSvTPYY286E+UajDoqxEj4X60EwUgbdCuuOCG+39aUsjWLvkmehs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619793876; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4WSaABwQNqG2JTm70xmiIAHfh+9L9Z20dtHsVXRIDIg=; b=VT20LLUxeOcI5pmd5Uek5xGsSEnk19cSAlYP5xG3tMFz1HH7IrIJH5BJHc+l39IJYhL8pUYZS1ZuAFvwbc5oakeV+ZPig9b0l7hfvaBwEefJbrli53Qn33F6AVd9iGr2d9WwPRVXrAgCaHVskYh1hGy8E61dF2Qi029dIwXKL/s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 161979387679516.323344996131823; Fri, 30 Apr 2021 07:44:36 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.120575.228030 (Exim 4.92) (envelope-from ) id 1lcUNV-0002fi-N5; Fri, 30 Apr 2021 14:44:25 +0000 Received: by outflank-mailman (output) from mailman id 120575.228030; Fri, 30 Apr 2021 14:44:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lcUNV-0002fb-Jz; Fri, 30 Apr 2021 14:44:25 +0000 Received: by outflank-mailman (input) for mailman id 120575; Fri, 30 Apr 2021 14:44:23 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lcUNT-0002fK-M6 for xen-devel@lists.xenproject.org; Fri, 30 Apr 2021 14:44:23 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 34d10e4c-b18a-48fb-a228-d36dbf4bd7cc; Fri, 30 Apr 2021 14:44:22 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1A7ADB038; Fri, 30 Apr 2021 14:44:22 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 34d10e4c-b18a-48fb-a228-d36dbf4bd7cc X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1619793862; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4WSaABwQNqG2JTm70xmiIAHfh+9L9Z20dtHsVXRIDIg=; b=TUXCJDj0WvBzBreDJt0SRxvGQx1jhnB+j2FvQP5UfpJVScQacYmgPOS0SvUqEuOcotyTXa 8s+WExlwnFub7VBuF2xrw3t+DurZ65IPkrGDHzLERCqESrsKoN6RAGe6roAEEixmZOewaa WNnKM0FP05uCJZc/poHeIHvOFAtbFzU= Subject: [PATCH 2/3] firmware/shim: drop XEN_CONFIG_EXPERT uses From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson References: <19695ffc-34d8-b682-b092-668f872d4e57@suse.com> Message-ID: <56bb5e87-fe35-75a8-fe18-ecc959b21799@suse.com> Date: Fri, 30 Apr 2021 16:44:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <19695ffc-34d8-b682-b092-668f872d4e57@suse.com> Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) Content-Type: text/plain; charset="utf-8" As of commit d155e4aef35c ("xen: Allow EXPERT mode to be selected from the menuconfig directly") EXPERT is a regular config option. Signed-off-by: Jan Beulich --- a/tools/firmware/xen-dir/Makefile +++ b/tools/firmware/xen-dir/Makefile @@ -74,10 +74,10 @@ $(D): linkfarm.stamp $(MAKE) -C $(D)/xen distclean =20 $(D)/xen/.config: $(D) - $(MAKE) -C $(@D) KBUILD_DEFCONFIG=3Dpvshim_defconfig XEN_CONFIG_EXPERT=3D= y defconfig + $(MAKE) -C $(@D) KBUILD_DEFCONFIG=3Dpvshim_defconfig defconfig =20 xen-shim: $(D)/xen/.config - $(MAKE) -C $( (p=quarantine dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1619793920655430.76254455922935; Fri, 30 Apr 2021 07:45:20 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.120581.228045 (Exim 4.92) (envelope-from ) id 1lcUOA-0002nm-2i; Fri, 30 Apr 2021 14:45:06 +0000 Received: by outflank-mailman (output) from mailman id 120581.228045; Fri, 30 Apr 2021 14:45:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lcUO9-0002nf-Vx; Fri, 30 Apr 2021 14:45:05 +0000 Received: by outflank-mailman (input) for mailman id 120581; Fri, 30 Apr 2021 14:45:05 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lcUO9-0002nX-6h for xen-devel@lists.xenproject.org; Fri, 30 Apr 2021 14:45:05 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 28b905ea-f032-476b-b7ca-c4d42db25261; Fri, 30 Apr 2021 14:45:04 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6C597B03A; Fri, 30 Apr 2021 14:45:03 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 28b905ea-f032-476b-b7ca-c4d42db25261 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1619793903; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5fOkOupL5RkW0UbAtmQcNHl08DT14j0dorRN/S9Rg88=; b=eftbUYNyaqUl+jgTZ8zJQr3xdDBe9ar7LkG8nz5He2nb+vYGoz32j1n3N+QkcoRz2KCPf7 Dm9teJWZJejjfuOirGEeI5OoYGsj0TZottA41D+avEIhgsJjrCkddK3gDqdPa5/PZjN6kG IouqeWGMAJ8ReryvC4aklTnkTLYmjrY= Subject: [PATCH 3/3] firmware/shim: UNSUPPORTED=n From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson , Stefano Stabellini , George Dunlap , Dario Faggioli References: <19695ffc-34d8-b682-b092-668f872d4e57@suse.com> Message-ID: Date: Fri, 30 Apr 2021 16:45:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <19695ffc-34d8-b682-b092-668f872d4e57@suse.com> Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) Content-Type: text/plain; charset="utf-8" We shouldn't default to include any unsupported code in the shim. Mark the setting as off, replacing the ARGO specification. This points out anomalies with the scheduler configuration: Unsupported schedulers better don't default to Y in release builds (like is already the case for ARINC653). Without these adjustments, the shim would suddenly build with RTDS as its default scheduler. Signed-off-by: Jan Beulich Acked-by: Roger Pau Monn=C3=A9 ---- I'm certainly open to consider alterations on the sched/Kconfig adjustments, but _something_ needs to be done there. In particular I'm puzzled to find the NULL scheduler marked unsupported. Clearly with the shim defaulting to it, it must be supported at least there. --- a/xen/arch/x86/configs/pvshim_defconfig +++ b/xen/arch/x86/configs/pvshim_defconfig @@ -15,7 +15,7 @@ CONFIG_SCHED_NULL=3Dy # CONFIG_KEXEC is not set # CONFIG_XENOPROF is not set # CONFIG_XSM is not set -# CONFIG_ARGO is not set +# CONFIG_UNSUPPORTED is not set # CONFIG_SCHED_CREDIT is not set # CONFIG_SCHED_CREDIT2 is not set # CONFIG_SCHED_RTDS is not set --- a/xen/common/sched/Kconfig +++ b/xen/common/sched/Kconfig @@ -16,7 +16,7 @@ config SCHED_CREDIT2 =20 config SCHED_RTDS bool "RTDS scheduler support (UNSUPPORTED)" if UNSUPPORTED - default y + default DEBUG ---help--- The RTDS scheduler is a soft and firm real-time scheduler for multicore, targeted for embedded, automotive, graphics and gaming @@ -31,7 +31,7 @@ config SCHED_ARINC653 =20 config SCHED_NULL bool "Null scheduler support (UNSUPPORTED)" if UNSUPPORTED - default y + default PV_SHIM || DEBUG ---help--- The null scheduler is a static, zero overhead scheduler, for when there always are less vCPUs than pCPUs, typically From nobody Wed May 8 01:49:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1622014693; cv=none; d=zohomail.com; s=zohoarc; b=aGgtHoOOMzolypQtz8IIm6kO3Hme4PUxr7GltFExgGO4tt+IQfGko5Vnu/2GRGghSo2Fce4EvUQEz8clzZe3noQ/xw/bEtWatdf83N5QCxuH6Wib7wwoy+4d2Qzvif3ZwcDdg7mruVC4wbtsuPdBIuVK/S6gNgK35eZsfRgoMZE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622014693; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=DAgndc2MvHoRJlh2yskU6N8P+M2J8gBju5BwD3ep2bQ=; b=OFWwSs8/fMMeErgwhRlJ9PUqX4IylOKFHVa+WCryidy6x41yNfDdPWnjc5yNA9uv/zODn21bP1f+GewhRaz1WQKaGpp0t6FfRSXyYWPWhejg8/n/P5F6iI1gBVxyQBD7uv3R/7tRSr+iX7oQCf1YwISoJbVrcelhlaBAWma3HV8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1622014693759225.80245023186922; Wed, 26 May 2021 00:38:13 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.132360.246913 (Exim 4.92) (envelope-from ) id 1llo6s-0007dQ-5t; Wed, 26 May 2021 07:37:46 +0000 Received: by outflank-mailman (output) from mailman id 132360.246913; Wed, 26 May 2021 07:37:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1llo6s-0007dJ-2s; Wed, 26 May 2021 07:37:46 +0000 Received: by outflank-mailman (input) for mailman id 132360; Wed, 26 May 2021 07:37:44 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1llo6q-0007dD-8R for xen-devel@lists.xenproject.org; Wed, 26 May 2021 07:37:44 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8181a2fc-b05d-49af-9a8e-04814d7b975d; Wed, 26 May 2021 07:37:43 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F14D9ADE2; Wed, 26 May 2021 07:37:41 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8181a2fc-b05d-49af-9a8e-04814d7b975d X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1622014662; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DAgndc2MvHoRJlh2yskU6N8P+M2J8gBju5BwD3ep2bQ=; b=T5e4pvE0nuOx6tpWrbmtSHLUcwGI1ScYp4O4NIn5RsYpGz3nrp9oHO4IjzOKZ9JKKPjnWz HipBuPlDA57ewEEW2Es5glNi4VZCjkc0m19M9mHnCgsqz8m7UPA4Ttw+8o8ltrPHWAzSGu ET8HakWNR6PUEpt7z9CimIVu8o4sGB8= From: Jan Beulich Subject: [PATCH v2] firmware/shim: UNSUPPORTED=n To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Dario Faggioli References: <19695ffc-34d8-b682-b092-668f872d4e57@suse.com> Message-ID: <72b98382-34ba-6e9d-c90e-c913dfe66258@suse.com> Date: Wed, 26 May 2021 09:37:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <19695ffc-34d8-b682-b092-668f872d4e57@suse.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) We shouldn't default to include any unsupported code in the shim. Mark the setting as off, replacing the ARGO specification. This points out anomalies with the scheduler configuration: Unsupported schedulers better don't default to Y in release builds (like is already the case for ARINC653). Without at least the SCHED_NULL adjustments, the shim would suddenly build with RTDS as its default scheduler. As a result, the SCHED_NULL setting can also be dropped from defconfig. Clearly with the shim defaulting to it, SCHED_NULL must be supported at least there. Signed-off-by: Jan Beulich Acked-by: Roger Pau Monn=C3=A9 Reviewed-by: Dario Faggioli --- v2: Also drop SCHED_NULL setting from defconfig. Make SCHED_NULL the default when PV_SHIM_EXCLUSIVE. --- I'm certainly open to consider alterations on the sched/Kconfig adjustments, but _something_ needs to be done there. In particular I was puzzled to find the NULL scheduler marked unsupported. Clearly with the shim defaulting to it, it must be supported at least there. In a PV_SHIM (but perhaps !PV_SHIM_EXCLUSIVE) build with the build-time default not being SCHED_NULL, when actually running as shim I can't seem to see how the null scheduler would get chosen as the default nevertheless. Shouldn't this happen (in the absence of a command line override)? --- a/SUPPORT.md +++ b/SUPPORT.md @@ -351,9 +351,10 @@ Currently only single-vcpu domains are s A very simple, very static scheduling policy that always schedules the same vCPU(s) on the same pCPU(s). It is designed for maximum determinism and minimum overhead -on embedded platforms. +on embedded platforms and the x86 PV shim. =20 Status: Experimental + Status, x86/shim: Supported =20 ### NUMA scheduler affinity =20 --- a/xen/arch/x86/configs/pvshim_defconfig +++ b/xen/arch/x86/configs/pvshim_defconfig @@ -6,7 +6,6 @@ CONFIG_PV_SHIM=3Dy CONFIG_PV_SHIM_EXCLUSIVE=3Dy CONFIG_NR_CPUS=3D32 CONFIG_EXPERT=3Dy -CONFIG_SCHED_NULL=3Dy # Disable features not used by the PV shim # CONFIG_XEN_SHSTK is not set # CONFIG_GRANT_TABLE is not set @@ -15,7 +14,7 @@ CONFIG_SCHED_NULL=3Dy # CONFIG_KEXEC is not set # CONFIG_XENOPROF is not set # CONFIG_XSM is not set -# CONFIG_ARGO is not set +# CONFIG_UNSUPPORTED is not set # CONFIG_SCHED_CREDIT is not set # CONFIG_SCHED_CREDIT2 is not set # CONFIG_SCHED_RTDS is not set --- a/xen/common/sched/Kconfig +++ b/xen/common/sched/Kconfig @@ -16,7 +16,7 @@ config SCHED_CREDIT2 =20 config SCHED_RTDS bool "RTDS scheduler support (UNSUPPORTED)" if UNSUPPORTED - default y + default DEBUG ---help--- The RTDS scheduler is a soft and firm real-time scheduler for multicore, targeted for embedded, automotive, graphics and gaming @@ -31,7 +31,7 @@ config SCHED_ARINC653 =20 config SCHED_NULL bool "Null scheduler support (UNSUPPORTED)" if UNSUPPORTED - default y + default PV_SHIM || DEBUG ---help--- The null scheduler is a static, zero overhead scheduler, for when there always are less vCPUs than pCPUs, typically @@ -39,6 +39,7 @@ config SCHED_NULL =20 choice prompt "Default Scheduler?" + default SCHED_NULL_DEFAULT if PV_SHIM_EXCLUSIVE default SCHED_CREDIT2_DEFAULT =20 config SCHED_CREDIT_DEFAULT