From nobody Mon Feb 9 12:09:24 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1618236490; cv=none; d=zohomail.com; s=zohoarc; b=B3jgnsSPbiKsuCGBVESyNT/34SYSfnhUTzDah3UOPH4yFl5B6fyAe2tOuvHGInK+mWkpOrm9kk3fjhUweAuStUzJKUoc6OrbDnz4nYRNfjKHY4E5QSGhaFtNjAoZZUjTvPRcq61qC9dr3ylAT6AOvIo3MfgcYoMTQVzcosLXYZ0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618236490; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3wdroPuGfKuZZGJHeiqndko2WBYxJIqNkRfSw3fJY0U=; b=LL/oLGm0KMEjGrb7mNBJcCgg7SLPnij2YRI6Gd5QrD5p3X20eXIBIOXk8Yi87k+QLYwbjWtRJOEZ6AsqeCIdi4kCUEoZJ0ObqXM7ANEI9uReHMD5g2AAyG9wzbgMXsHbLegRYG5iIiYrvubUKbtyo7cBxOthDFVryNofbtjFjVo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1618236490024221.78309664435415; Mon, 12 Apr 2021 07:08:10 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.109179.208368 (Exim 4.92) (envelope-from ) id 1lVxEH-0004qV-53; Mon, 12 Apr 2021 14:07:53 +0000 Received: by outflank-mailman (output) from mailman id 109179.208368; Mon, 12 Apr 2021 14:07:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lVxEH-0004qO-1y; Mon, 12 Apr 2021 14:07:53 +0000 Received: by outflank-mailman (input) for mailman id 109179; Mon, 12 Apr 2021 14:07:52 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lVxEG-0004qG-3W for xen-devel@lists.xenproject.org; Mon, 12 Apr 2021 14:07:52 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4545c696-18c8-4dca-85ae-b40de634959f; Mon, 12 Apr 2021 14:07:51 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AC32CAF95; Mon, 12 Apr 2021 14:07:50 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4545c696-18c8-4dca-85ae-b40de634959f X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1618236470; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3wdroPuGfKuZZGJHeiqndko2WBYxJIqNkRfSw3fJY0U=; b=uGiwk5AfKObcwe/w+SEj7r8Dy134Nk/Mg6Pe6QjbzK6xyF8Nm2ECE9yJcwJKiCkAWkWdel dLZKkpfqnFIQz+PVk0ZCylxM93jXm559EyYni4xj1AKHuj7VNbDXbZhpdBk3fESMVDHfl8 JzmARMwxoEkzyvro6EDt9idcrp71qe0= Subject: [PATCH v2 04/12] AMD/IOMMU: guest IOMMU support is for HVM only From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap References: <3cf73378-b9d6-0eca-12b6-0f628518bebf@suse.com> Message-ID: <187fa031-c237-2298-6b39-2c4a63b06c0f@suse.com> Date: Mon, 12 Apr 2021 16:07:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <3cf73378-b9d6-0eca-12b6-0f628518bebf@suse.com> Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) Content-Type: text/plain; charset="utf-8" Generally all of this is dead code anyway, but there's a caller of guest_iommu_add_ppr_log(), and the code itself calls p2m_change_type_one(), which is about to become HVM-only. Hence this code, short of deleting it altogether, needs to become properly HVM- only as well. Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monn=C3=A9 --- v2: New. --- a/xen/drivers/passthrough/amd/Makefile +++ b/xen/drivers/passthrough/amd/Makefile @@ -5,4 +5,4 @@ obj-y +=3D pci_amd_iommu.o obj-bin-y +=3D iommu_acpi.init.o obj-y +=3D iommu_intr.o obj-y +=3D iommu_cmd.o -obj-y +=3D iommu_guest.o +obj-$(CONFIG_HVM) +=3D iommu_guest.o --- a/xen/drivers/passthrough/amd/iommu.h +++ b/xen/drivers/passthrough/amd/iommu.h @@ -307,12 +307,16 @@ int __must_check amd_iommu_suspend(void) void amd_iommu_crash_shutdown(void); =20 /* guest iommu support */ +#ifdef CONFIG_HVM void amd_iommu_send_guest_cmd(struct amd_iommu *iommu, u32 cmd[]); void guest_iommu_add_ppr_log(struct domain *d, u32 entry[]); void guest_iommu_add_event_log(struct domain *d, u32 entry[]); int guest_iommu_init(struct domain* d); void guest_iommu_destroy(struct domain *d); int guest_iommu_set_base(struct domain *d, uint64_t base); +#else +static inline void guest_iommu_add_ppr_log(struct domain *d, uint32_t entr= y[]) {} +#endif =20 static inline u32 get_field_from_reg_u32(u32 reg_value, u32 mask, u32 shif= t) {