From nobody Mon Feb 9 19:10:46 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 16984137043391015.3961060749698; Fri, 27 Oct 2023 06:35:04 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.624388.972972 (Exim 4.92) (envelope-from ) id 1qwMyq-00020g-Pk; Fri, 27 Oct 2023 13:34:28 +0000 Received: by outflank-mailman (output) from mailman id 624388.972972; Fri, 27 Oct 2023 13:34:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qwMyq-0001wb-BE; Fri, 27 Oct 2023 13:34:28 +0000 Received: by outflank-mailman (input) for mailman id 624388; Fri, 27 Oct 2023 13:34:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qwMyo-0000bB-JI for xen-devel@lists.xenproject.org; Fri, 27 Oct 2023 13:34:26 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8b68a9e1-74cd-11ee-98d6-6d05b1d4d9a1; Fri, 27 Oct 2023 15:34:25 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 638DB4EE0C8D; Fri, 27 Oct 2023 15:34:24 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b68a9e1-74cd-11ee-98d6-6d05b1d4d9a1 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, jbeulich@suse.com, andrew.cooper3@citrix.com, roger.pau@citrix.com, Nicola Vetrini , George Dunlap , Julien Grall , Wei Liu Subject: [XEN PATCH][for-4.19 v4 8/8] xen/compat: use BUILD_BUG_ON in CHECK_SIZE macros Date: Fri, 27 Oct 2023 15:34:15 +0200 Message-Id: <16877f531dd79442a7fad6e8bacd17f445a0ad66.1698410970.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1698413705414100006 Content-Type: text/plain; charset="utf-8" BUILD_BUG_ON is the preferred way to induce a build error upon statically determined incorrect conditions. This also fixes a MISRA C:2012 Rule 10.1 violation in the previous formulation. Signed-off-by: Nicola Vetrini Acked-by: Jan Beulich --- Changes in v2: - replace the construct with a BUILD_BUG_ON. Changes in v3: - drop unused typedef. --- xen/include/xen/compat.h | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/xen/include/xen/compat.h b/xen/include/xen/compat.h index f2ce5bb3580a..41a5d61eef98 100644 --- a/xen/include/xen/compat.h +++ b/xen/include/xen/compat.h @@ -151,12 +151,18 @@ CHECK_NAME_(k, n, T)(k xen_ ## n *x, \ return x =3D=3D c; \ } =20 -#define CHECK_SIZE(name) \ - typedef int CHECK_NAME(name, S)[1 - (sizeof(xen_ ## name ## _t) !=3D \ - sizeof(compat_ ## name ## _t)) * = 2] +#define CHECK_SIZE(name) \ +static inline void __maybe_unused CHECK_SIZE_##name(void) \ +{ \ + BUILD_BUG_ON(sizeof(xen_ ## name ## _t) !=3D \ + sizeof(compat_ ## name ## _t)); \ +} #define CHECK_SIZE_(k, n) \ - typedef int CHECK_NAME_(k, n, S)[1 - (sizeof(k xen_ ## n) !=3D \ - sizeof(k compat_ ## n)) * 2] +static inline void __maybe_unused CHECK_SIZE_##k_##n(void) \ +{ \ + BUILD_BUG_ON(sizeof(k xen_ ## n) !=3D \ + sizeof(k compat_ ## n)); \ +} =20 #define CHECK_FIELD_COMMON(name, t, f) \ static inline int __maybe_unused name(xen_ ## t ## _t *x, compat_ ## t ## = _t *c) \ --=20 2.34.1