From nobody Wed May 1 14:39:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1575417415; cv=none; d=zohomail.com; s=zohoarc; b=XzklN5azZ4l9YwY2bYFohMbIf++joYlHSHCYUNMutZzQ2XegoXREiyGeaXPa2nnf79ZxbCR3F7/GpW9EmU/zD28fHpCMJWai7pIKbT0tShpXPL0OFtN7RB0w1RS81SXX9brH/dgx0fK05HdawIMdDz0zxPkehdnvD2ulZO+ROlc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575417415; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=9v+yER7ZjtR5h6H/HZAE05qRJYvVWLegTwlkAbMoRk4=; b=Ga9lb1bUDwkCYLZN5MVHSBCJKmRw0xz843iD4tTs/09i3M/9/IewQyFZrzK5IunZbD2zUAvrdJ3+C04b/qZjLSqCnGkA8fhTi/AW5ndhu9W0bXl6dYqF6MUiocXWy+pLEOhbE1CPjQ7JjWoJ67mdBR+QYiLX8wlh+sxzB9+dT7Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 157541741565559.759728466852266; Tue, 3 Dec 2019 15:56:55 -0800 (PST) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1icI1e-0006Gz-6L; Tue, 03 Dec 2019 23:56:14 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1icI1d-0006Gu-H6 for xen-devel@lists.xenproject.org; Tue, 03 Dec 2019 23:56:13 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7be1e434-1628-11ea-a0d2-bc764e2007e4; Tue, 03 Dec 2019 23:56:12 +0000 (UTC) X-Inumbo-ID: 7be1e434-1628-11ea-a0d2-bc764e2007e4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1575417372; h=from:to:cc:subject:date:message-id:mime-version; bh=TFD3VzeeXzI0ahwELebBgPMvYu71biEqCJE3NLat9dQ=; b=HRkimQEsW64FdWGHfzQtc08SsiYU/bsSyFoTZHPpaXOdymvr9Q86N5BE SZMHFYEitpMD/qbqDPrgO56r5loJJ35vbGVJ4FdPgoBY96dZnvvfL7qO7 Umc0uAOqWzFQqbwS7S+Is1gARbcz5PLMAAR5cr7szldIrdtfm9N9y7lgd U=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=igor.druzhinin@citrix.com; spf=Pass smtp.mailfrom=igor.druzhinin@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender authenticity information available from domain of igor.druzhinin@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="igor.druzhinin@citrix.com"; x-sender="igor.druzhinin@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa4.hc3370-68.iphmx.com: domain of igor.druzhinin@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="igor.druzhinin@citrix.com"; x-sender="igor.druzhinin@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="igor.druzhinin@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: g+3YzLlxnjg2O7v2zDKDUe2lwBpt9WRb7g9f/Kv1Nz+hSn7bRRCUp7SLb4243TZxBLz0WdkC9y 4zQN1emD4tqlVU5YXtleO4Dia9sUGM3sf1EXOUuHqJAF6nBRdt3T8W2JoHQgGg9kWvN6CyxV2t 35+tBIYb0ylpybc+SAHuZuY2QZ3yj0r+jw6AjlAjtNerwayRBMY99L+BcEjB7rmM2fO4GpUSZ1 TvvF4xIQogI/RJFm4MJenMKPRxaruixZV94iTM/euqh1dvPAtrck6bMGfeEVtCanZng70Wa2sr 5iU= X-SBRS: 2.7 X-MesageID: 9706778 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,275,1571716800"; d="scan'208";a="9706778" From: Igor Druzhinin To: Date: Tue, 3 Dec 2019 23:56:07 +0000 Message-ID: <1575417367-12822-1-git-send-email-igor.druzhinin@citrix.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Subject: [Xen-devel] [PATCH v2] x86/AMD: unbreak CPU hotplug on AMD systems without RstrFpErrPtrs X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: jgross@suse.com, Igor Druzhinin , wl@xen.org, andrew.cooper3@citrix.com, jbeulich@suse.com, roger.pau@citrix.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) If the feature is not present Xen will try to force X86_BUG_FPU_PTRS feature at CPU identification time. This is especially noticeable in PV-shim that usually hotplugs its vCPUs. We either need to restrict this action for boot CPU only or allow secondary CPUs to modify forced CPU capabilities at runtime. Choose the former since modifying forced capabilities out of boot path leaves the system in potentially inconsistent state. Signed-off-by: Igor Druzhinin Reviewed-by: Jan Beulich --- Changes in v2: - pick the former approach instead of the latter --- xen/arch/x86/cpu/amd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c index fec2830..8b5f0f2 100644 --- a/xen/arch/x86/cpu/amd.c +++ b/xen/arch/x86/cpu/amd.c @@ -583,7 +583,7 @@ static void init_amd(struct cpuinfo_x86 *c) * Older AMD CPUs don't save/load FOP/FIP/FDP unless an FPU exception * is pending. Xen works around this at (F)XRSTOR time. */ - if (!cpu_has(c, X86_FEATURE_RSTR_FP_ERR_PTRS)) + if (c =3D=3D &boot_cpu_data && !cpu_has(c, X86_FEATURE_RSTR_FP_ERR_PTRS)) setup_force_cpu_cap(X86_BUG_FPU_PTRS); =20 /* --=20 2.7.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel