From nobody Sat Apr 20 15:34:05 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1574788150; cv=none; d=zohomail.com; s=zohoarc; b=TSkb0GlAbx+Pai7epBsisVklauDu1Jj2vTEPCzbqoYz/Gm1d2wAMid3TwJ7B+GQGpXVhnoOqSILjHost0nPt0nWmsD5CQK99GtCd+XBnJqPAzUbcWRDqbvN+76F6ATjUs9m2b5BdV7TjyjJ1QUVugZSUvOtz96RaORDIhNRYnGs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1574788150; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=DcdEH65oYoQ4KuIF5H485+eEkXggsC7rrBQ1tqp2PdA=; b=L30i5vm2O3ADHYTFCnjX9pm43pdy5S9v8NYpzD70dnARFOHlcL16ojo5RkmL3wBO7F2C1fAsTUhKHWql7BEk22bEbMGfsDP74dXkYIuVcdyDN/sxL1VPLnFyPRw59yBpvL1ZPQAeuH2slm9jSMlMBZy92G66HU/VVUPw3YKnsQw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1574788150050779.1568153743192; Tue, 26 Nov 2019 09:09:10 -0800 (PST) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iZeK9-00013j-SZ; Tue, 26 Nov 2019 17:08:25 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iZeK8-00013e-Os for xen-devel@lists.xenproject.org; Tue, 26 Nov 2019 17:08:24 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5a850104-106f-11ea-a3a5-12813bfff9fa; Tue, 26 Nov 2019 17:08:23 +0000 (UTC) X-Inumbo-ID: 5a850104-106f-11ea-a3a5-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1574788104; h=from:to:cc:subject:date:message-id:mime-version; bh=kmubR2fmYJKIh04zW4i+clZ0PiCfZ0qo/+44Qw1S9AU=; b=MYXtsF7i0SyPTNcudPN06reKsEKOL2yIVhf/BYYDaZaNwFWGqgQx9tqK BBfLb14V/Q7XAABKnhkW/VvfUsazSFSg01FJYIkVmz5yntNNarKTT98wh ENfBf7J1AWBMI9mMhqVNoyuLIuWxskGc+kpmz0Ju/iYSMvgS5pV1PSqfU c=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=igor.druzhinin@citrix.com; spf=Pass smtp.mailfrom=igor.druzhinin@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of igor.druzhinin@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="igor.druzhinin@citrix.com"; x-sender="igor.druzhinin@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa3.hc3370-68.iphmx.com: domain of igor.druzhinin@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="igor.druzhinin@citrix.com"; x-sender="igor.druzhinin@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="igor.druzhinin@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: qJUO4F5ZHYHCsjsgY57h7CE9q+VsSBl5WhlrpPq1nuk8RHAsyLUQRIpT18pu2B40h35jkMetJq lHSzVlvQcIQJx33xhqRh2B/K2MLeyeDr0CnA5RkKJtA5rw4jxycpyLivdv7ImoLS9n6GuHjapm d55WI3z5tv3FVVhyq/YumevtgBPhNz6YQx46FSpI60aOwdvcaEBNC9IS/3+I5FHD3Q+L3pNPyW Mj4t36fYkBKz7zLEcKc0cWhDgps81RDzgVi/gHJEb/yKybWkM6ywLKGIR+0P4oyMff5ALeMftR xuU= X-SBRS: 2.7 X-MesageID: 8858396 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,246,1571716800"; d="scan'208";a="8858396" From: Igor Druzhinin To: Date: Tue, 26 Nov 2019 17:08:19 +0000 Message-ID: <1574788099-11821-1-git-send-email-igor.druzhinin@citrix.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Subject: [Xen-devel] [PATCH for-4.13 v2] AMD/IOMMU: honour IR setting while pre-filling DTEs X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: jgross@suse.com, andrew.cooper3@citrix.com, jbeulich@suse.com, Igor Druzhinin Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) IV bit shouldn't be set in DTE if interrupt remapping is not enabled. It's a regression in behavior of "iommu=3Dno-intremap" option which otherwise would keep interrupt requests untranslated for all of the devices in the system regardless of wether it's described as valid in IVRS or not. Signed-off-by: Igor Druzhinin Reviewed-by: Andrew Cooper --- xen/drivers/passthrough/amd/iommu_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/drivers/passthrough/amd/iommu_init.c b/xen/drivers/passthr= ough/amd/iommu_init.c index 16e84d4..2b81e38 100644 --- a/xen/drivers/passthrough/amd/iommu_init.c +++ b/xen/drivers/passthrough/amd/iommu_init.c @@ -1279,7 +1279,7 @@ static int __init amd_iommu_setup_device_table( for ( bdf =3D 0, size /=3D sizeof(*dt); bdf < size; ++bdf ) dt[bdf] =3D (struct amd_iommu_dte){ .v =3D true, - .iv =3D true, + .iv =3D iommu_intremap, }; } =20 --=20 2.7.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel