From nobody Fri May 3 21:38:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1563541761; cv=none; d=zoho.com; s=zohoarc; b=Dhl5Y0ytSQqgzcZj968sFB0ORCv5OqU9uelei0UfotgtmlAQvkd3apo+U96OqU305uuJmkATl5ko7J0OoZT5+/XkOmqCgbf2sX+mENgAMlT79ZfOFDNnaAzJB2s55tQkodGHX/xc1G1S8+snyLkMzoJ1M2aUngcFN/kGUpkcW1c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563541761; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=VfZhFKmhSdbhaEKHRRUVJ9syZM9w16fjufLYcIKdzb8=; b=U1pg2wiMwvOLjomyhwFRgyEVWfJ52h4sg/7PJ67b3o/hIfoCdP1OhQjNK30LrqRaNLTfAgCKZ5Z1t/5Qc9TcQYQE5XvwRJutN+QkOXg2TBlxO//9cXiU/T5a7LWtLFPlC9xVJ0ZFpcGGBx753X2z0RnM7m1MaP2z8cOURpCNw5g= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1563541760957542.9131486605442; Fri, 19 Jul 2019 06:09:20 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hoScW-0007tu-1H; Fri, 19 Jul 2019 13:08:20 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hoScU-0007tj-Tj for xen-devel@lists.xenproject.org; Fri, 19 Jul 2019 13:08:18 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 456bb9e8-aa26-11e9-97e8-afc52c91b028; Fri, 19 Jul 2019 13:08:16 +0000 (UTC) X-Inumbo-ID: 456bb9e8-aa26-11e9-97e8-afc52c91b028 Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=igor.druzhinin@citrix.com; spf=Pass smtp.mailfrom=igor.druzhinin@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of igor.druzhinin@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="igor.druzhinin@citrix.com"; x-sender="igor.druzhinin@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa3.hc3370-68.iphmx.com: domain of igor.druzhinin@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="igor.druzhinin@citrix.com"; x-sender="igor.druzhinin@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="igor.druzhinin@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: 0RQYjNoFlcvkczk0XGFi+hODCidiu/fYGSWqaDRdYFT1zrYgbzl1rQJzFrFUNVhgWbcyCPZp9N OpufiRm3Bwe8/qZPpVDYsV5v4WeAa8UtAhEuwxC4/4gbQNKpBYxbHaKRB9tnYpMmpkUK+PQnR5 GHmyH3XdvZcU2XDAZXMjD8QXI9O8zs+OXgLuOCCQStBBRdMkRgl2OP/bROAcyNPEu0O5jiowSM BguVY5khVvSCY3W9EUNYYscJ/e2cAH7XNYdsqiCBWtjdzxP+k/lbN0vlkKDfA4jTnqXLFI7QVu w60= X-SBRS: 2.7 X-MesageID: 3197137 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.64,282,1559534400"; d="scan'208";a="3197137" From: Igor Druzhinin To: Date: Fri, 19 Jul 2019 14:07:48 +0100 Message-ID: <1563541668-6012-1-git-send-email-igor.druzhinin@citrix.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Subject: [Xen-devel] [PATCH] x86/crash: fix kexec transition breakage X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: andrew.cooper3@citrix.com, Igor Druzhinin , wl@xen.org, jbeulich@suse.com, roger.pau@citrix.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Following 6ff560f7f ("x86/SMP: don't try to stop already stopped CPUs") an incorrect condition was placed into kexec transition path leaving crashing CPU always online breaking kdump kernel entering. Correct it by unifying the condition with smp_send_stop(). Signed-off-by: Igor Druzhinin Reviewed-by: Andrew Cooper --- xen/arch/x86/crash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/crash.c b/xen/arch/x86/crash.c index f9772dc..a9f3e18 100644 --- a/xen/arch/x86/crash.c +++ b/xen/arch/x86/crash.c @@ -169,7 +169,7 @@ static void nmi_shootdown_cpus(void) */ iommu_crash_shutdown(); =20 - if ( num_online_cpus() > 1 ) + if ( cpu_online(cpu) ) { __stop_this_cpu(); =20 --=20 2.7.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel