From nobody Mon Feb 9 10:29:28 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1561109873; cv=none; d=zoho.com; s=zohoarc; b=A4oce9YK3MMtFg8KPLOQLfueJE4hi/ghicRh4Ie1Lmoo2c9G2d8AYs2Ek4KU+i2jhK8UXKePPyUp0o1W55ZYrmI5sj0xmySchziypjrJ2sEwoSByN6aGIEa/cj6euR+VPTCjT/2Nbre++E9YWLo33/XJfG53Qc3NK+lTeTcmElQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561109873; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=MDBn0cfEesJ9mFAACtzkxAhGiWQJ/6e+uvnW6TwEFKE=; b=QFf2wSoqy4yprjdZgL4ZKdwl3Jues0iUl7wk1058HpJe5eEZ6hYE6qgihtsXA3nY0DrfCdyaFiDuRrpukYekOQo51+32YWl2Z7vAvNLyYdrumg4Byv4IVrT27L3RkT9yw+t9oxxCQ1vvSM1esmfffTw/eBnJ6NGC9aBVU5o1hVE= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1561109873082831.8340325921297; Fri, 21 Jun 2019 02:37:53 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1heFyR-0007aY-BH; Fri, 21 Jun 2019 09:36:47 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1heFyP-0007a9-QI for xen-devel@lists.xenproject.org; Fri, 21 Jun 2019 09:36:45 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id 152d0e33-9408-11e9-8980-bc764e045a96; Fri, 21 Jun 2019 09:36:44 +0000 (UTC) X-Inumbo-ID: 152d0e33-9408-11e9-8980-bc764e045a96 Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@citrix.com; spf=Pass smtp.mailfrom=Andrew.Cooper3@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of andrew.cooper3@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="andrew.cooper3@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa1.hc3370-68.iphmx.com: domain of Andrew.Cooper3@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="Andrew.Cooper3@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: pJBqWnN1+Zomj8YcpNMobkrhTT26oNYxj6+fwFmgCGNca26V+TRBk9BNwD0Xq1upyfT3pZwqct H3vNTM+CbqEwOThyqzFgaPr3OMnNSd7g6ihEd8KYfEE9cvCYfMu2joQD8Zy+sI5BW5X4LDwccd YZWrpreQ6NyWJp8GiZnR+eH/nymFelEKr8tAjaaj0LXwahK17ASE4jwSWpxnqRa0EciIo6aSVE HywicuF133pwCzD2RXbUo6ljFkb6Zq3fuXJwgr5iOigqQx6cUOGDUmnVXpRl9xQNCaarbPdnZ2 5ts= X-SBRS: 2.7 X-MesageID: 2060661 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.63,399,1557201600"; d="scan'208";a="2060661" From: Andrew Cooper To: Xen-devel Date: Fri, 21 Jun 2019 10:36:36 +0100 Message-ID: <1561109798-8744-4-git-send-email-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1561109798-8744-1-git-send-email-andrew.cooper3@citrix.com> References: <1561109798-8744-1-git-send-email-andrew.cooper3@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 3/5] arm/gnttab: Implement stub helpers as static inlines X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Julien Grall , Stefano Stabellini Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" It is inefficient to call into a different translation unit for a stub function, when a static inline will work fine. Replace an open-coded printk_once() while moving it. No functional change. Signed-off-by: Andrew Cooper Acked-by: Julien Grall --- CC: Stefano Stabellini CC: Julien Grall --- xen/arch/arm/mm.c | 16 ---------------- xen/include/asm-arm/grant_table.h | 17 +++++++++++++++-- 2 files changed, 15 insertions(+), 18 deletions(-) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 35dc1f7..44258ad 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -41,7 +41,6 @@ #include #include =20 -#include #include =20 /* Override macros from asm/page.h to make them work with mfn_t */ @@ -1532,21 +1531,6 @@ void put_page_type(struct page_info *page) return; } =20 -void gnttab_clear_flag(struct domain *d, unsigned long nr, uint16_t *addr) -{ - guest_clear_mask16(d, BIT(nr, UL), addr); -} - -void gnttab_mark_dirty(struct domain *d, mfn_t mfn) -{ - /* XXX: mark dirty */ - static int warning; - if (!warning) { - gdprintk(XENLOG_WARNING, "gnttab_mark_dirty not implemented yet\n"= ); - warning =3D 1; - } -} - int create_grant_host_mapping(unsigned long addr, mfn_t frame, unsigned int flags, unsigned int cache_flags) { diff --git a/xen/include/asm-arm/grant_table.h b/xen/include/asm-arm/grant_= table.h index 1ed0aef..b0d673b 100644 --- a/xen/include/asm-arm/grant_table.h +++ b/xen/include/asm-arm/grant_table.h @@ -6,6 +6,8 @@ #include #include =20 +#include + #define INITIAL_NR_GRANT_FRAMES 1U #define GNTTAB_MAX_VERSION 1 =20 @@ -14,13 +16,24 @@ struct grant_table_arch { gfn_t *status_gfn; }; =20 -void gnttab_clear_flag(struct domain *d, unsigned long nr, uint16_t *addr); +static inline void gnttab_clear_flag(struct domain *d, + unsigned long nr, uint16_t *addr) +{ + guest_clear_mask16(d, BIT(nr, UL), addr); +} + +static inline void gnttab_mark_dirty(struct domain *d, mfn_t mfn) +{ +#ifndef NDEBUG + printk_once(XENLOG_G_WARNING "gnttab_mark_dirty not implemented yet\n"= ); +#endif +} + int create_grant_host_mapping(unsigned long gpaddr, mfn_t mfn, unsigned int flags, unsigned int cache_flags= ); #define gnttab_host_mapping_get_page_type(ro, ld, rd) (0) int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn, unsigned long new_gpaddr, unsigned int flag= s); -void gnttab_mark_dirty(struct domain *d, mfn_t mfn); #define gnttab_release_host_mappings(domain) 1 =20 /* --=20 2.1.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel