From nobody Sun Apr 28 07:57:22 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1560975175; cv=none; d=zoho.com; s=zohoarc; b=NF8J6EhVH0O78HiSGszwlFiBACtYBIzxc64dNvAF4O1pznxmjg9UJlbP8yOKCfFONUXi1UPNSv9dw6c+5Clum1IDHaVrSbaFRC891EGv61MupnaPG0XTGL05XCC8q+n+gXl2KDZ+nLRsKQAiA2+V3kiYEOYaPCLfN5OLXVGLqdQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1560975175; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=Elz3+Ya7xNhlpOnoCjbqY2tRH2ZIbLhmgEgaahyTYmw=; b=RRzzNkvQaIvF/wSCGKF7fkHTC5rkloUhN4QcF/gXY9WAbr3dDHrk0+xUMfkBvVWyLyK9py0k8poqemHuGYL3+EAEovSwTJCVG896Scjq9NHvBuWCwok7QKaFHO4sg9sZ9JQ4Rvl0c4FwDUNGnmJiHNJoQ82WT/nAqDAVN1qlq4A= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1560975175398472.8053033342421; Wed, 19 Jun 2019 13:12:55 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hdgve-0002gk-PS; Wed, 19 Jun 2019 20:11:34 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hdgvd-0002gc-4Q for xen-devel@lists.xenproject.org; Wed, 19 Jun 2019 20:11:33 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id 6dd1544f-92ce-11e9-8980-bc764e045a96; Wed, 19 Jun 2019 20:11:31 +0000 (UTC) X-Inumbo-ID: 6dd1544f-92ce-11e9-8980-bc764e045a96 Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@citrix.com; spf=Pass smtp.mailfrom=Andrew.Cooper3@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of andrew.cooper3@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="andrew.cooper3@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa6.hc3370-68.iphmx.com: domain of Andrew.Cooper3@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="Andrew.Cooper3@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: r9Vb/f2EHFTEOjtGKa0cJUCrEMs8mv+4NY9u54plpui+z03nWUoEeLxZJ/S7tRpaiyEIgM0/9N Q2ucoG+/IIqe+SAsXXyjReXF7yCTF8VeBIIicvW3XPymhFQ1m1efsJX8kTICFntqa5kJc/+t+3 GKGOYGfp0MU36cZo2Ni2eKK1wNoiDYZgb9VWAIGWFfqQCY9r/OVKjfXN8oQTdHtRqN7RTWY8v3 8NsSPYqeaRYM2ctnoSFwP8K1t0HNI7xtq/Q2pLXJyLj02wShv+DpuU+C8AM0V41A9I5IGhwjgD r5I= X-SBRS: 2.7 X-MesageID: 1968177 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.63,394,1557201600"; d="scan'208";a="1968177" From: Andrew Cooper To: Xen-devel Date: Wed, 19 Jun 2019 21:11:24 +0100 Message-ID: <1560975087-25632-2-git-send-email-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1560975087-25632-1-git-send-email-andrew.cooper3@citrix.com> References: <1560975087-25632-1-git-send-email-andrew.cooper3@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 1/4] xen/link: Cope with .rodata.cst* sections X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Julien Grall , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" .rodata.cst* sections are used for mergable constant data, and the clang/ll= vm 8 toolchain has been observed to create .rodata.cst8 in a default Xen build. Unfortunately, this section (and its .init counterpart) aren't captured by Xen's linker globs, and end up as orphaned sections. Generalise the data globbing to pick up cst and future special sections. Reported-by: Roger Pau Monn=C3=A9 Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monn=C3=A9 CC: Stefano Stabellini CC: Julien Grall --- xen/arch/arm/xen.lds.S | 9 +++------ xen/arch/x86/xen.lds.S | 9 +++------ 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S index e664c44..31d74a8 100644 --- a/xen/arch/arm/xen.lds.S +++ b/xen/arch/arm/xen.lds.S @@ -96,8 +96,7 @@ SECTIONS __start_schedulers_array =3D .; *(.data.schedulers) __end_schedulers_array =3D .; - *(.data.rel) - *(.data.rel.*) + *(.data.*) CONSTRUCTORS } :text =20 @@ -154,8 +153,7 @@ SECTIONS . =3D ALIGN(PAGE_SIZE); .init.data : { *(.init.rodata) - *(.init.rodata.rel) - *(.init.rodata.str*) + *(.init.rodata.*) =20 . =3D ALIGN(POINTER_ALIGN); __setup_start =3D .; @@ -176,8 +174,7 @@ SECTIONS *(.altinstr_replacement) =20 *(.init.data) - *(.init.data.rel) - *(.init.data.rel.*) + *(.init.data.*) =20 . =3D ALIGN(8); __ctors_start =3D .; diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S index cb42dc8..ec37d38 100644 --- a/xen/arch/x86/xen.lds.S +++ b/xen/arch/x86/xen.lds.S @@ -206,8 +206,7 @@ SECTIONS #endif =20 *(.init.rodata) - *(.init.rodata.rel) - *(.init.rodata.str*) + *(.init.rodata.*) =20 . =3D ALIGN(POINTER_ALIGN); __setup_start =3D .; @@ -221,8 +220,7 @@ SECTIONS __initcall_end =3D .; =20 *(.init.data) - *(.init.data.rel) - *(.init.data.rel.*) + *(.init.data.*) . =3D ALIGN(4); __trampoline_rel_start =3D .; *(.trampoline_rel) @@ -272,8 +270,7 @@ SECTIONS DECL_SECTION(.data) { *(.data.page_aligned) *(.data) - *(.data.rel) - *(.data.rel.*) + *(.data.*) CONSTRUCTORS } :text =20 --=20 2.1.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel From nobody Sun Apr 28 07:57:22 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1560975177; cv=none; d=zoho.com; s=zohoarc; b=gXpLnX9JRM8pxwn0Ibwz3Jtg5bDDGzm0lTc7VHAx6b5m1MMrp23tU+RwlBEZOxzY1aQzlTsxGaDmKioLKbe5AZAujcSkpqSmo+9JwdtvkIvV7LPqjyGcsvdXUMjp+hbdsCK4D8Cm89d5QI8H6nsqHTEwPPNeKFHNtrU9082drnw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1560975177; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=99LBdPEWqF/PLD88pNne/+fE5KD54SVza1HOKtFyvNU=; b=eGlAWpqeSBeyvDLoh2bwhUCvIcWIXJJXKXhtMByXvMMUSjrlV/MW1Ur63Qm0Dl97B1ZyFA+uuW0i74XRVtoC5DEVlHqDTt5Zz1aDXD7sk8qGK0VbEozEZLczJl2HEPQwo0scI3QqGudoVyVF67zYfc9baAEaIqqk0RDPn6kE7+0= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1560975177662482.1562323412005; Wed, 19 Jun 2019 13:12:57 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hdgvm-0002ho-VC; Wed, 19 Jun 2019 20:11:42 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hdgvk-0002hW-Pu for xen-devel@lists.xenproject.org; Wed, 19 Jun 2019 20:11:40 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 71c4e380-92ce-11e9-b927-c797f0bb5d13; Wed, 19 Jun 2019 20:11:38 +0000 (UTC) X-Inumbo-ID: 71c4e380-92ce-11e9-b927-c797f0bb5d13 Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@citrix.com; spf=Pass smtp.mailfrom=Andrew.Cooper3@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of andrew.cooper3@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="andrew.cooper3@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa1.hc3370-68.iphmx.com: domain of Andrew.Cooper3@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="Andrew.Cooper3@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: NhalVcVCJzicGN5mcRtjgmhMgsv4RWwzijn2PgFDdcUt2rGmKuZyP7L1U+S7g0D8J6Wiq6ApFh u2Twom13SvBqYFg5QEdfDJaV9+PB0E86Xu84ViEriCABocQorWMDB6IpQ5mFafHdLe5PC2kCdE 9wtFZjSm48WrCrz5EpsDMam7eLS0JtzJeC/Ev6JcBcNiJDx8dTKuO3BlEKMbEWi82Eig4SymJO Us6kXzTiZkBCU0WKJqGyJqJf37cOMJ7FBNVVtDeBGz+CPGPWH+jo0vt3uX/K4xLgfQGe1+P26i oeU= X-SBRS: 2.7 X-MesageID: 1983437 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.63,394,1557201600"; d="scan'208";a="1983437" From: Andrew Cooper To: Xen-devel Date: Wed, 19 Jun 2019 21:11:25 +0100 Message-ID: <1560975087-25632-3-git-send-email-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1560975087-25632-1-git-send-email-andrew.cooper3@citrix.com> References: <1560975087-25632-1-git-send-email-andrew.cooper3@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 2/4] xen/link: Link .data.schedulers and CONSTRUCTERS in more appropriate locations X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Julien Grall , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Neither of these should live in .data * .data.schedulers is only ever read, so is moved into .rodata * CONSTRUCTORS is only ever read, and only at boot, so is moved to beside .init.rodata Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monn=C3=A9 --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monn=C3=A9 CC: Stefano Stabellini CC: Julien Grall --- xen/arch/arm/xen.lds.S | 11 ++++++----- xen/arch/x86/xen.lds.S | 11 ++++++----- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S index 31d74a8..2b44e5d 100644 --- a/xen/arch/arm/xen.lds.S +++ b/xen/arch/arm/xen.lds.S @@ -66,6 +66,11 @@ SECTIONS *(.data.param) __param_end =3D .; =20 + . =3D ALIGN(POINTER_ALIGN); + __start_schedulers_array =3D .; + *(.data.schedulers) + __end_schedulers_array =3D .; + __proc_info_start =3D .; *(.proc.info) __proc_info_end =3D .; @@ -92,12 +97,7 @@ SECTIONS . =3D ALIGN(PAGE_SIZE); *(.data.page_aligned) *(.data) - . =3D ALIGN(8); - __start_schedulers_array =3D .; - *(.data.schedulers) - __end_schedulers_array =3D .; *(.data.*) - CONSTRUCTORS } :text =20 . =3D ALIGN(SMP_CACHE_BYTES); @@ -154,6 +154,7 @@ SECTIONS .init.data : { *(.init.rodata) *(.init.rodata.*) + CONSTRUCTORS =20 . =3D ALIGN(POINTER_ALIGN); __setup_start =3D .; diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S index ec37d38..9fa6c99 100644 --- a/xen/arch/x86/xen.lds.S +++ b/xen/arch/x86/xen.lds.S @@ -140,6 +140,11 @@ SECTIONS *(.data.param) __param_end =3D .; =20 + . =3D ALIGN(POINTER_ALIGN); + __start_schedulers_array =3D .; + *(.data.schedulers) + __end_schedulers_array =3D .; + #if defined(CONFIG_HAS_VPCI) && defined(CONFIG_LATE_HWDOM) . =3D ALIGN(POINTER_ALIGN); __start_vpci_array =3D .; @@ -207,6 +212,7 @@ SECTIONS =20 *(.init.rodata) *(.init.rodata.*) + CONSTRUCTORS =20 . =3D ALIGN(POINTER_ALIGN); __setup_start =3D .; @@ -261,17 +267,12 @@ SECTIONS . =3D ALIGN(SMP_CACHE_BYTES); DECL_SECTION(.data.read_mostly) { *(.data.read_mostly) - . =3D ALIGN(8); - __start_schedulers_array =3D .; - *(.data.schedulers) - __end_schedulers_array =3D .; } :text =20 DECL_SECTION(.data) { *(.data.page_aligned) *(.data) *(.data.*) - CONSTRUCTORS } :text =20 DECL_SECTION(.bss) { --=20 2.1.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel From nobody Sun Apr 28 07:57:22 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1560975178; cv=none; d=zoho.com; s=zohoarc; b=nkOGmK2fxbsLxW6nOTgJHZGQJqQG0yIpSE5IHo7VPzP95n13cjPX8GRSpMcFXJpDIn4y4Bu4L3P+xANdb/VXdWRu9HWzSqT11x6mNyEenW0f/Dth6aUqXLDUNOaFVMJm6fj9QcZYxuzaRRb2QPw7KJU4DFHpRKd1IWJGYeyzbP8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1560975178; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=mSN3+CmHN3VHXtofH9iPHEk0HwysQNhOThAzclRienU=; b=MuckAUBTeroAGQT1UOeZ4TzLjWnzrrpTG76E83gwKkA+zm5Zv9beiFfan51sliQjg36V5G9x3DAFMnwuYMj9cMnk5xOVAmjOHPi9P21DLKkhoLMRPsevfDHeiKbFf9FmlQmqE3zVcnUnvcK/Lc7aG566hGDMj+9ATDGfKK5gtTI= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 156097517823562.23606671237917; Wed, 19 Jun 2019 13:12:58 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hdgvk-0002hT-Ko; Wed, 19 Jun 2019 20:11:40 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hdgvj-0002hL-Ke for xen-devel@lists.xenproject.org; Wed, 19 Jun 2019 20:11:39 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id 71caa132-92ce-11e9-8980-bc764e045a96; Wed, 19 Jun 2019 20:11:38 +0000 (UTC) X-Inumbo-ID: 71caa132-92ce-11e9-8980-bc764e045a96 Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@citrix.com; spf=Pass smtp.mailfrom=Andrew.Cooper3@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of andrew.cooper3@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="andrew.cooper3@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa6.hc3370-68.iphmx.com: domain of Andrew.Cooper3@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="Andrew.Cooper3@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: VXzA7aOTz80s8bo+Rql/Et+wTjDPiMWoFt+2Z7ic71YvYxDms1vmkqvDHoJLTXX3BJqnOshr4/ 5JkliV6D2mDehWUFhZbR7/QFhQdCUW6CY5p4mPYbWDkDnzwRZWamBno+Ic5SpI1BsRHz4sayoE onGTMBtRRRuMr8U3Hy7dQLFGag0mAOLbCBxRt3RLtv7qFHoHlofdDSPHwBjaYdRNC0LV90pncs x0ccGX1g3wZDeZTxlc3iCPOBKSioUe129WZN1I1W4f4fF1tHpS+Ix1mwXaN9tGrn0iYF8Wj6Hj /EE= X-SBRS: 2.7 X-MesageID: 1968182 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.63,394,1557201600"; d="scan'208";a="1968182" From: Andrew Cooper To: Xen-devel Date: Wed, 19 Jun 2019 21:11:26 +0100 Message-ID: <1560975087-25632-4-git-send-email-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1560975087-25632-1-git-send-email-andrew.cooper3@citrix.com> References: <1560975087-25632-1-git-send-email-andrew.cooper3@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 3/4] xen/link: Fold .data.read_mostly into .data X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Julien Grall , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" .data.read_mostly only needs separating from adjacent data by one cache line to be effective, and placing it adjacent to .data.page_aligned fulfills this requirement. For ARM, .ex_table appears to be a vestigial remnant. Nothing in the resulting build ever inspects or acts on the contents of the table. The ar= m32 build does however have some assembly routines which fill .ex_table. Drop all of ARM's .ex_table infrastructure, to reduce the size of the compi= led binary, and avoid giving the illusion of exception handling working. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monn=C3=A9 CC: Stefano Stabellini CC: Julien Grall Only compile tested on ARM. --- xen/arch/arm/arm32/lib/assembler.h | 19 ++----------------- xen/arch/arm/xen.lds.S | 16 +--------------- xen/arch/x86/xen.lds.S | 7 ++----- 3 files changed, 5 insertions(+), 37 deletions(-) diff --git a/xen/arch/arm/arm32/lib/assembler.h b/xen/arch/arm/arm32/lib/as= sembler.h index 6de2638..42eaabb 100644 --- a/xen/arch/arm/arm32/lib/assembler.h +++ b/xen/arch/arm/arm32/lib/assembler.h @@ -160,13 +160,6 @@ restore_irqs_notrace \oldcpsr .endm =20 -#define USER(x...) \ -9999: x; \ - .pushsection __ex_table,"a"; \ - .align 3; \ - .long 9999b,9001f; \ - .popsection - #ifdef CONFIG_SMP #define ALT_SMP(instr...) \ 9998: instr @@ -247,7 +240,7 @@ #ifdef CONFIG_THUMB2_KERNEL =20 .macro usraccoff, instr, reg, ptr, inc, off, cond, abort, t=3DT() -9999: + .if \inc =3D=3D 1 \instr\cond\()b\()\t\().w \reg, [\ptr, #\off] .elseif \inc =3D=3D 4 @@ -256,10 +249,6 @@ .error "Unsupported inc macro argument" .endif =20 - .pushsection __ex_table,"a" - .align 3 - .long 9999b, \abort - .popsection .endm =20 .macro usracc, instr, reg, ptr, inc, cond, rept, abort @@ -288,7 +277,7 @@ =20 .macro usracc, instr, reg, ptr, inc, cond, rept, abort, t=3DT() .rept \rept -9999: + .if \inc =3D=3D 1 \instr\cond\()b\()\t \reg, [\ptr], #\inc .elseif \inc =3D=3D 4 @@ -297,10 +286,6 @@ .error "Unsupported inc macro argument" .endif =20 - .pushsection __ex_table,"a" - .align 3 - .long 9999b, \abort - .popsection .endr .endm =20 diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S index 2b44e5d..3dc5117 100644 --- a/xen/arch/arm/xen.lds.S +++ b/xen/arch/arm/xen.lds.S @@ -94,27 +94,13 @@ SECTIONS _erodata =3D .; /* End of read-only data */ =20 .data : { /* Data */ + *(.data.read_mostly) . =3D ALIGN(PAGE_SIZE); *(.data.page_aligned) *(.data) *(.data.*) } :text =20 - . =3D ALIGN(SMP_CACHE_BYTES); - .data.read_mostly : { - /* Exception table */ - __start___ex_table =3D .; - *(.ex_table) - __stop___ex_table =3D .; - - /* Pre-exception table */ - __start___pre_ex_table =3D .; - *(.ex_table.pre) - __stop___pre_ex_table =3D .; - - *(.data.read_mostly) - } :text - . =3D ALIGN(8); .arch.info : { _splatform =3D .; diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S index 9fa6c99..ef11949 100644 --- a/xen/arch/x86/xen.lds.S +++ b/xen/arch/x86/xen.lds.S @@ -264,12 +264,9 @@ SECTIONS __2M_init_end =3D .; =20 __2M_rwdata_start =3D .; /* Start of 2M superpages, mapped RW. */ - . =3D ALIGN(SMP_CACHE_BYTES); - DECL_SECTION(.data.read_mostly) { - *(.data.read_mostly) - } :text - DECL_SECTION(.data) { + *(.data.read_mostly) + . =3D ALIGN(PAGE_SIZE); *(.data.page_aligned) *(.data) *(.data.*) --=20 2.1.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel From nobody Sun Apr 28 07:57:22 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1560975179; cv=none; d=zoho.com; s=zohoarc; b=GatfW3Gktup+3fZqCFEom9w5XeRgNvNaDIn9h20SXk4tcijvntMfIqIVTNZ4S+uhcLfpstjFZ894T2+4opUfAmbOJ76Q9jyqrVMgRtd4spbuvTLmz/SMhBSS7w9fBK4o4VH51TLXsGB9b4Ny6iTpKrV270/pmovUyhlR48rS5mc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1560975179; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=x6131YowKESLP8Y6PkIGhHmNBJh23kkCrDhCZ+C0ytM=; b=WU/81rZNAkqKXedDjd/jV34v0Ug5Rn7+svhSuSBTKwwYTfB9HGk0n0kTL3tQeJeQLMLXE2gJDSJs2PhRZokbMVs/D4SA/KqufIwEs0wBJJRuNtrR9QGWigT13Dp4JW+LBDi7bkN5zJgkWlRTW/jEZv+XdnPUf9v0ieSFW8WbdCg= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 156097517884291.46393238592543; Wed, 19 Jun 2019 13:12:58 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hdgvh-0002h6-BQ; Wed, 19 Jun 2019 20:11:37 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hdgvg-0002h1-Gi for xen-devel@lists.xenproject.org; Wed, 19 Jun 2019 20:11:36 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6f21a65e-92ce-11e9-b0f0-e3c021641c09; Wed, 19 Jun 2019 20:11:34 +0000 (UTC) X-Inumbo-ID: 6f21a65e-92ce-11e9-b0f0-e3c021641c09 Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@citrix.com; spf=Pass smtp.mailfrom=Andrew.Cooper3@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender authenticity information available from domain of andrew.cooper3@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="andrew.cooper3@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa4.hc3370-68.iphmx.com: domain of Andrew.Cooper3@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="Andrew.Cooper3@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: RXn7b7lHeTLSAtjGslDKFl9I66NiuxfzMZgfIm8pZIKToqAMc/gpFJX9GGaotfp5QmeqrYMtq6 MxTyQV8+96/+/VCkBqkp+Wca8wP0F/g+IOz1eXJ0j5DlMHq5pfY94F7DjUyfE3ksg+C5lIv6F3 tZz+MQe19UXuHgpCA0CdBbXVzjL+H9b8Y2giIABG6slZkQgStqE6GILW14WPmQgdWW+uXANiiT BsDvEXFMSwngsewjx3l5TjzjH+HMLH1DnMzrsNOx/wJWAymK1G15sOIlOtX8EANBEl8ED4gdZx NT8= X-SBRS: 2.7 X-MesageID: 1992902 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.63,394,1557201600"; d="scan'208";a="1992902" From: Andrew Cooper To: Xen-devel Date: Wed, 19 Jun 2019 21:11:27 +0100 Message-ID: <1560975087-25632-5-git-send-email-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1560975087-25632-1-git-send-email-andrew.cooper3@citrix.com> References: <1560975087-25632-1-git-send-email-andrew.cooper3@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 4/4] xen/link: Misc cleanup X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Julien Grall , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" * Drop .gnu.warning. Xen, not being a library, has no need for __attribute__((__warning__("str"))) and isn't liable to ever gain such annotations for link time warnings. * Adjust the indentation of the start of ARM's .rodata section. * Discard .discard on ARM. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Acked-by: Julien Grall Reviewed-by: Roger Pau Monn=C3=A9 --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monn=C3=A9 CC: Stefano Stabellini CC: Julien Grall --- xen/arch/arm/xen.lds.S | 7 ++++--- xen/arch/x86/xen.lds.S | 1 - 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S index 3dc5117..c5ef5d5 100644 --- a/xen/arch/arm/xen.lds.S +++ b/xen/arch/arm/xen.lds.S @@ -35,14 +35,13 @@ SECTIONS *(.text.cold) *(.text.unlikely) *(.fixup) - *(.gnu.warning) _etext =3D .; /* End of text section */ } :text =3D 0x9090 =20 . =3D ALIGN(PAGE_SIZE); .rodata : { - _srodata =3D .; /* Read-only data */ - /* Bug frames table */ + _srodata =3D .; /* Read-only data */ + /* Bug frames table */ __start_bug_frames =3D .; *(.bug_frames.0) __stop_bug_frames_0 =3D .; @@ -209,6 +208,8 @@ SECTIONS *(.exit.text) *(.exit.data) *(.exitcall.exit) + *(.discard) + *(.discard.*) *(.eh_frame) } =20 diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S index ef11949..8bc2be3 100644 --- a/xen/arch/x86/xen.lds.S +++ b/xen/arch/x86/xen.lds.S @@ -82,7 +82,6 @@ SECTIONS *(.text.unlikely) *(.fixup) *(.text.kexec) - *(.gnu.warning) _etext =3D .; /* End of text section */ } :text =3D 0x9090 =20 --=20 2.1.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel