[Xen-devel] [PATCH] automation: Add an 'all' target for container maintenance

Andrew Cooper posted 1 patch 10 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/xen tags/patchew/1560189148-25219-1-git-send-email-andrew.cooper3@citrix.com
automation/build/Makefile | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

[Xen-devel] [PATCH] automation: Add an 'all' target for container maintenance

Posted by Andrew Cooper 10 weeks ago
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Wei Liu <wl@xen.org>
CC: Doug Goldstein <cardoe@cardoe.com>
---
 automation/build/Makefile | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/automation/build/Makefile b/automation/build/Makefile
index 773b160..7c7612b 100644
--- a/automation/build/Makefile
+++ b/automation/build/Makefile
@@ -1,13 +1,12 @@
 
 # the base of where these containers will appear
 REGISTRY := registry.gitlab.com/xen-project/xen
+CONTAINERS = $(subst .dockerfile,,$(wildcard */*.dockerfile))
 
 help:
 	@echo "Builds containers for building Xen based on different distros"
 	@echo "To build one run 'make DISTRO/VERSION'. Available containers:"
-	@$(foreach file,$(sort $(subst .dockerfile,,$(wildcard */*.dockerfile))), \
-		echo ${file} ; \
-	)
+	@$(foreach file,$(sort $(CONTAINERS)),echo ${file};)
 	@echo "To push container builds, set the env var PUSH"
 
 %: %.dockerfile ## Builds containers
@@ -15,3 +14,6 @@ help:
 	@if [ ! -z $${PUSH+x} ]; then \
 		docker push $(REGISTRY)/$(@D):$(@F); \
 	fi
+
+.PHONY: all
+all: $(CONTAINERS)
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] automation: Add an 'all' target for container maintenance

Posted by Doug Goldstein 10 weeks ago
On Mon, Jun 10, 2019 at 06:52:28PM +0100, Andrew Cooper wrote:
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Wei Liu <wl@xen.org>
> CC: Doug Goldstein <cardoe@cardoe.com>

Acked-by: Doug Goldstein <cardoe@cardoe.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel