From nobody Tue May 7 06:53:29 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1558949442; cv=none; d=zoho.com; s=zohoarc; b=AZGJAnh9CxuGbWdRHiw1s9JZHptk7xVwex/DlYn3vBFTHLy/RsZYXQagBTb715OSYrjNXsOFKEy+WwdSS/vyeHuu0wDNMFZf3ZbPugD8zOYlqccYKoWOQc1y7KMJLyGn6uCUu6znzPTBHibScEe2GfLRD+J7hBONnV6Aoqx3Des= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558949442; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=N+d6vIjugUSrEZZjshU/9ZSASHMCTc/MiuyfW1+zZPo=; b=NAuZnLG6W60wAWaK4d4L406RBkGFdVony0MfndqTiY1aFr7kwtxeUv/Vs61jswe2HCyGD5PKZ4LoD1XIdy7QZRAGc06c+/67WzkXliFM5D/u+5ZdlXLNZOrmR3uHLdOdBy1Tpz5Ei4Jd/0Vfp6LFN6gDkawkoHO9uKzKR+w0dWc= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1558949442574346.2476294004422; Mon, 27 May 2019 02:30:42 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hVBwn-0002UL-63; Mon, 27 May 2019 09:29:37 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hVBwl-0002U9-5g for xen-devel@lists.xenproject.org; Mon, 27 May 2019 09:29:35 +0000 Received: from mail-lf1-x141.google.com (unknown [2a00:1450:4864:20::141]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id efd00ce9-8061-11e9-8980-bc764e045a96; Mon, 27 May 2019 09:29:34 +0000 (UTC) Received: by mail-lf1-x141.google.com with SMTP id u27so11551384lfg.10 for ; Mon, 27 May 2019 02:29:34 -0700 (PDT) Received: from aanisov-work.kyiv.epam.com (ll-22.209.223.85.sovam.net.ua. [85.223.209.22]) by smtp.gmail.com with ESMTPSA id c8sm2165601ljk.77.2019.05.27.02.29.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 27 May 2019 02:29:31 -0700 (PDT) X-Inumbo-ID: efd00ce9-8061-11e9-8980-bc764e045a96 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=P1gAu1mrglqggSbDLY3YWxRAcdHeoG5hxre+/93oNEE=; b=bOUQ+AcDyM0iH8U9DfM+wHAyPwM5FIgHI51Pfw/vnzLK/4YnTGSvt3MjWndfdNuV8J NwRjZP823EYDRqsQbBi4aanFL4XesVEb3I3A7IqkMvlMaLhIFljDUxifRMAUPx63wBCs zj2iDdjqsTwcxGWqP26h2nRUJoRQPzI/3NZl9UFRSVOM83OTWY3xKZOIj7iBKHEkyr1x 2fUucH0OJH7iMpFf+BrGAeeeePC9HI8EKCaHw769tCNyenZIFkUFjCUHk0KovPPgb7Ld nn7ipq7hMqpHhL09CMHeky5F8oHjUZ3csU0i30N/u4g+TgJB15bl1dlq2a8jJdUeAFPo jtcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=P1gAu1mrglqggSbDLY3YWxRAcdHeoG5hxre+/93oNEE=; b=qXvO2Y0hNz6jg5HHSbD6pKAooR5dDcc8wyl5C9mXR3Vs+DFChWn5bCNMqFabhqeSyM bpJ2rvy2stPokRclvN79fM8/o/Td/bGZvBTMhTUYrY3waNZ3F6ekzqZQPbcWyS+3y143 z1Eo3VhiQxYG+z4ZL46mV1az4hpgbA3qSpsTX3zsAz3xayqIrEyv5T5rHsr53A4e7gJp fQsjyuJ0xJXc16SsldSZRZWjYCOewREjUm1sMeQUTWRChS9zT2z77CLaNe6p70JoDvsd Tz95Gnern2/MWOBYigyhVIQX3VOAbuOObvVT32gF732yRe+E3NvDS7nhFPL36GrKM7/v arNA== X-Gm-Message-State: APjAAAV8IA57U4j2IDIDJSzMtIcmCbP1hGka735I6OT7DEhJXGbEIN4O YBpOpa8c+143uejPHC3ipbDGC6sgm20= X-Google-Smtp-Source: APXvYqzT4yBcjB6gWai6YdDXUoYlbvRzPzZ00Vb3UwNH+Endyt6UFI314rKcq17VJm+i8KObSUBuLQ== X-Received: by 2002:ac2:46ef:: with SMTP id q15mr1384574lfo.63.1558949372571; Mon, 27 May 2019 02:29:32 -0700 (PDT) From: Andrii Anisov To: xen-devel@lists.xenproject.org Date: Mon, 27 May 2019 12:29:30 +0300 Message-Id: <1558949370-14331-1-git-send-email-andrii.anisov@gmail.com> X-Mailer: git-send-email 2.7.4 Subject: [Xen-devel] [PATCH v2] gic: drop interrupts enabling on interrupts processing X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Julien Grall , Stefano Stabellini , Andrii Anisov MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Andrii Anisov This reduces the number of context switches in case we have coming guest interrupts from different sources at a high rate. What is likely for multimedia use-cases. Having irqs unlocked here makes us go through trap path again in case we have a new guest interrupt arrived (even with the same priority, after `desc->handler->end(desc)` in `do_IRQ()`), what is just a processor cycles wasting. We will catch them all in the `gic_interrupt() function loop anyway. And the guest irqs arrival prioritization is meaningless here, it is only effective at guest's level. Signed-off-by: Andrii Anisov --- Changes: in v2: Drop irq enabling for lpi processing as well. --- xen/arch/arm/gic.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c index 6cc7dec..113655a 100644 --- a/xen/arch/arm/gic.c +++ b/xen/arch/arm/gic.c @@ -386,17 +386,13 @@ void gic_interrupt(struct cpu_user_regs *regs, int is= _fiq) =20 if ( likely(irq >=3D 16 && irq < 1020) ) { - local_irq_enable(); isb(); do_IRQ(regs, irq, is_fiq); - local_irq_disable(); } else if ( is_lpi(irq) ) { - local_irq_enable(); isb(); gic_hw_ops->do_LPI(irq); - local_irq_disable(); } else if ( unlikely(irq < 16) ) { --=20 2.7.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel