From nobody Mon May 6 10:51:31 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1558704691; cv=none; d=zoho.com; s=zohoarc; b=AEc4lF+qZRV169rfCdi/eeoRfcnmxyb21VfpV2/Rqh6ElG9qZReEW2Bu9oiJ5FtuULJK43Gdkr0lqsLOzUothavGNXBoNEM2hebcGd/0gv4UXsnddUuSumxxL+p6mdvRIh9F1notz/135G2UlaSuBdGNC/Yv/yRB8S2W6uM4pRs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558704691; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=HcyXpAeF4vS08cUpBTsnb+hiiDf7rZP3A52rqSlNXDo=; b=D+R/OQbvGEAbl8WcYuhVPw6+3sGn5PsJOLU+Cy2zfP68bdhJYsxCfqAPMCr2R3efsgP4el3WLwu5TtJgRqtJgJMpw+gzNRW1pw1A/Cywh9ib/QHyroWDSoWiDcooBuU3dRsugIeKHnpxlvc8qbB0j/DVS1feCH+H60nWIpsEPq8= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1558704691010669.1920285490048; Fri, 24 May 2019 06:31:31 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hUAGk-0007dk-Nf; Fri, 24 May 2019 13:29:58 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hUAGj-0007df-Iw for xen-devel@lists.xenproject.org; Fri, 24 May 2019 13:29:57 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id 047f636a-7e28-11e9-8980-bc764e045a96; Fri, 24 May 2019 13:29:55 +0000 (UTC) X-Inumbo-ID: 047f636a-7e28-11e9-8980-bc764e045a96 Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@citrix.com; spf=Pass smtp.mailfrom=Andrew.Cooper3@citrix.com; spf=None smtp.helo=postmaster@MIAPEX02MSOL01.citrite.net Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of andrew.cooper3@citrix.com) identity=pra; client-ip=23.29.105.83; receiver=esa2.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="andrew.cooper3@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of Andrew.Cooper3@citrix.com designates 23.29.105.83 as permitted sender) identity=mailfrom; client-ip=23.29.105.83; receiver=esa2.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="Andrew.Cooper3@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:23.29.105.83 ip4:162.221.156.83 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@MIAPEX02MSOL01.citrite.net) identity=helo; client-ip=23.29.105.83; receiver=esa2.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="postmaster@MIAPEX02MSOL01.citrite.net"; x-conformance=sidf_compatible IronPort-SDR: abTgHiboO0LijqjzNUN0k/kcdz2estFlDdMSc9u8YRKFPN1DVB3BUo6fXFzamLSOLDnQIWv6OP JKZyC94WiStEIJd9+5ljt0/nASBr4KbVhc73rww6gLmM0rt301QGzeJCuxo7W53h+D7x094cv+ JbhjZe3qh/D/06ECtL7PabBjIoiWCP1PL+j1a8hcGGyCsFO0vc3h7m/JJe+bHUkMlAR2nkQfi1 SB5/Qd7c4fwrWlrI9wOcvSxZob22N2QvTVU/ntjP4IcNG6iKCUo0xnLhT3eQeLvqfOrGyCiNir HB8= X-SBRS: 2.7 X-MesageID: 881362 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 23.29.105.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.60,507,1549947600"; d="scan'208";a="881362" From: Andrew Cooper To: Xen-devel Date: Fri, 24 May 2019 14:29:46 +0100 Message-ID: <1558704586-829-1-git-send-email-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 Subject: [Xen-devel] [PATCH] tests/cpu-policy: Skip building on older versions of GCC X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Ian Jackson , Wei Liu , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" GCC 4.4 (as included in CentOS 6) is too old to handle designated initialis= ers in anonymous unions. As this is just a developer tool, skip the test in th= is case, rather than sacraficing the legibility/expresibility of the test case= s. This fixes the Gitlab CI tests. While adding this logic to cpu-polcy, adjust the equivelent logic from x86_emulator on which this was based. Printing: Test harness not built, use newer compiler than "gcc" isn't helpful for anyone unexpectedly encountering the error. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich Reviewed-by: Wei Liu --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monn=C3=A9 CC: Ian Jackson --- tools/tests/cpu-policy/Makefile | 14 +++++++++++++- tools/tests/x86_emulator/Makefile | 2 +- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/tools/tests/cpu-policy/Makefile b/tools/tests/cpu-policy/Makef= ile index eeed7f3..4b6caec 100644 --- a/tools/tests/cpu-policy/Makefile +++ b/tools/tests/cpu-policy/Makefile @@ -1,8 +1,20 @@ XEN_ROOT =3D $(CURDIR)/../../.. include $(XEN_ROOT)/tools/Rules.mk =20 +TARGET-y :=3D test-cpu-policy + +# For brevity, these tests make extensive use of designated initialisers, = but +# GCCs older than 4.6 can't cope. Ignore the test in this case. +ifneq ($(clang),y) +TARGET-$(call cc-ver,$(CC),lt,0x040600) :=3D +endif + +ifeq ($(TARGET-y),) +$(warning Test harness not built, use newer compiler than $(CC) $(shell $(= CC) -dumpversion)) +endif + .PHONY: all -all: test-cpu-policy +all: $(TARGET-y) =20 .PHONY: clean clean: diff --git a/tools/tests/x86_emulator/Makefile b/tools/tests/x86_emulator/M= akefile index 4f4c0f6..970ec3e 100644 --- a/tools/tests/x86_emulator/Makefile +++ b/tools/tests/x86_emulator/Makefile @@ -97,7 +97,7 @@ $(foreach flavor,$(SIMD) $(FMA),$(eval $(call simd-check-= cc,$(flavor)))) TARGET-$(shell echo 'asm("{evex} vzeroall");' | $(CC) -x c -c -o /dev/null= - || echo y) :=3D =20 ifeq ($(TARGET-y),) -$(warning Test harness not built, use newer compiler than "$(CC)") +$(warning Test harness not built, use newer compiler than $(CC) $(shell $(= CC) -dumpversion) and an "{evex}" capable assembler) endif =20 all: $(TARGET-y) --=20 2.1.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel