From nobody Sat May 30 11:15:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1778680871; cv=none; d=zohomail.com; s=zohoarc; b=S9CxVzNIFcc2eOPDnX237KNEnbvZIwIpC5zfA6kVwa4944Fh3+MYaXZVTbhI4GsL4SyA2Eu7Clt0RzsWFYNJbkjxhjwmHeueQFuFz+y/R6WHObbf9v3K3Yn15BGiXHVivWmZiMIK3Z/UjuKPtJB2rpaxaiYGJbcOK4zIRN1GHNI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778680871; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=G79nBLbusI+wOTeHofiLWxIFyMI86o2grvlpiB2XF6M=; b=I5h4fIyiILEC3synrsIOvNH/PB7QozwdnQ2dLt2saDkNWTJkjF0jpS9i200Zbcdh3nngneJgQUpBqVg3D9Db63TEVnn5Svu9Ecpx8X4qb54h9IMqoxLBmPPY/kkJWwEbEzT8JN7Ju+wHJIp9WOYVKzzMVfqNs23FIHqGtuPKEy0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1778680871612165.99240563701744; Wed, 13 May 2026 07:01:11 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1308036.1579580 (Exim 4.92) (envelope-from ) id 1wNA8k-00079i-Bu; Wed, 13 May 2026 14:00:46 +0000 Received: by outflank-mailman (output) from mailman id 1308036.1579580; Wed, 13 May 2026 14:00:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wNA8k-00079b-9H; Wed, 13 May 2026 14:00:46 +0000 Received: by outflank-mailman (input) for mailman id 1308036; Wed, 13 May 2026 14:00:45 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wNA8j-00079K-Io for xen-devel@lists.xenproject.org; Wed, 13 May 2026 14:00:45 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wNA8i-00357C-T6 for xen-devel@lists.xenproject.org; Wed, 13 May 2026 16:00:44 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a048406-bab6-0a2a0a5309dd-0a2a4501e290-6 for ; Wed, 13 May 2026 16:00:43 +0200 Received: from [209.85.128.47] (helo=mail-wm1-f47.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.56.1) (envelope-from ) id 6a04840b-c1f2-0a2a45010019-d155802fc065-3 for ; Wed, 13 May 2026 16:00:43 +0200 Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-488a9033b2cso61476385e9.2 for ; Wed, 13 May 2026 07:00:43 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fce38328esm44172595e9.13.2026.05.13.07.00.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 May 2026 07:00:42 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1778680843; x=1779285643; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=G79nBLbusI+wOTeHofiLWxIFyMI86o2grvlpiB2XF6M=; b=HL+QtMsCYJ9DdQAmdNhVSJ8IJUzYd6pJs9yTNSxoJMVpGn0pyya/PjY4PbDOHx8S6s TYYOXxc4Ie0EjqfmSoV9QXqJuxsUzC56d7RVpujkKvxmC3zBTvMxFje/nPMmckuMjCEq XgYwMAlxATR7+YS3NvhK6HHgzmWGGiHerTeqJ0JkhtJPaPpa/Opc2LzECIoNrVHF6tbm 2vmk0up88jZRb/RP7sJEB702EaMOybpB8qjjtri3Mb5iUAcHcMxUtJEYRwPtUkWa0/Km Uqs+AwW7zWZzyoRJz8maNRRs16bIIEilVh/SSQVov4fst1Xqi/XGFFBaFBZVNFtExlRh uTZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778680843; x=1779285643; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=G79nBLbusI+wOTeHofiLWxIFyMI86o2grvlpiB2XF6M=; b=NDwAD+IxFD9cOmgd6i4Jw8YfMmiV6eyy79qYcwRhPyNxys4Ja+RkevehzEJG4A8TKt J+2xT/2Cr6thymJmOx9yhHEKbipKicRA56GzOsVz1ptmsWStKtXC3rcD6UaNRsvuoZMy tRp24O/lOMIJihq9I9ZIP8lq/bYOv0fXn5iHsi5IsBFknWw/XlDvehZ0QMlXCT04I4Ur rDPlYnTxI7NR9TDWdwr0+EMRPS8yQ4iP3biVp/7ybZr2uTPxIR5vuTUqtsgQIuoVYaAE aC5d4wA0UFWwAYZxO6e3e2gDBb9IjzFSRxNgxXisl1t1s0HsGuTqsA1KEYOKq42m/ERy b3Zw== X-Gm-Message-State: AOJu0Yz+iah28r9G0O1GHi5gmGFYU2Q2hScLt6+4H3EEVlsEKFbtcl7j 9v/mRi2bAKD9RApcqP8JofUGWo0/htP7+ddsYl4mG1eRwAdObXIBaNS8SA9WGjXgsuz0jXGY4Z/ rB08= X-Gm-Gg: Acq92OGef3NeAC5aIQsZEhpIcOZqvSMpW1e5U3s3kIRd02jSS4VnTZ5oV5N6jTXzCAZ 2+nudHuzcrYILclRXvuKy8ppU4mtKBsnn1pDzwqIBHIdxWOHOto8w79ZidNEPi0O0Lz69Sn9irS CIGzjxdLTENxewuUF4pbvcQznpVUwhCd0UeKMu4pAfRzhcH9J07TIYlrNpUcsy5OfGhLyATnBvm CUAqLurskffTfZ1RRepadjuDh387iOpdqlOE1v6in9etYA7eWf0HmlQayfna5Q2t5u4J+i+X5W3 HYwsukCWHN7uizq4b9dn+v6aKkKy7pT05eihSEt2D9kN7hE2+6FbpMKIvEnYMKryWQcwBAUNThJ mavL20StmhFBJJxKL1frH6qSQhVXFgyFudFfcAGCz3RMlJgqbMFxxf1vjfehD60ukPsP6dYpZv9 gY1WUDAOlsYhYwAaCDofJaNs+VLz8JX92s9pKClwMzFfjRzzzwaeJA6O80AFZOATdqm9oObaL// DzClF5Vynu5eYs= X-Received: by 2002:a05:600c:4e43:b0:489:1fa5:997f with SMTP id 5b1f17b1804b1-48fc9a0ef11mr46192765e9.9.1778680842484; Wed, 13 May 2026 07:00:42 -0700 (PDT) Message-ID: <0af810a1-3392-472a-93c9-c98fcb81c43a@suse.com> Date: Wed, 13 May 2026 16:00:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 1/2] kexec: kexec_crash_save_info() vs Misra C:2012 rule 8.3 From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper References: <13ca5f9f-d985-41bf-9c30-afd657dade89@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <13ca5f9f-d985-41bf-9c30-afd657dade89@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-d62444/1778680843-AC851FF4-E60505C5/0/0 X-purgate-type: clean X-purgate-size: 644 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1778680873656158500 Content-Type: text/plain; charset="utf-8" ... ("All declarations of an object or function shall use the same names and type qualifiers"). The declaration doesn't use the typedef, so the definition shouldn't either. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper Reviewed-by: Stefano Stabellini --- Really, is the typedef of much use? I.e. can't we drop it altogether? --- a/xen/common/kexec.c +++ b/xen/common/kexec.c @@ -333,7 +333,7 @@ void kexec_crash_save_cpu(void) } =20 /* Set up the single Xen-specific-info crash note. */ -crash_xen_info_t *kexec_crash_save_info(void) +struct crash_xen_info *kexec_crash_save_info(void) { int cpu =3D smp_processor_id(); crash_xen_info_t info; From nobody Sat May 30 11:15:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1778680887; cv=none; d=zohomail.com; s=zohoarc; b=a02aq6s2EMxSikuSWS1CVK5j5OWuDowgRebMv2nGLD6J6m1LsmsNxTBWnBCuLpcbzTUqq7VIyv/cWTLpw6wJdDuwNoGC+g4gavPKiJ5OF/PWPjnm0BZgznbGs35Xxos8i4VgqeYBoCHIl4hLnOQrEHq7enoAAvtgdFpO88x4LgU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778680887; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=femi926UTfwC+WciGwdWOVpE8CZ0X7r6UWioon78b18=; b=aFaQNN9zm2TIWksM6C8Aj/+HDqUT1/P9WalmghejkMbSG00hpYCVPyeb9Wgoca+dLTxzbVMCRZQvfmYPmw81s6nQ6Pffej+PEzrsDcDc2suD6arquFTa/r3IJdO5+WsTkX6v0zCiDJkWdsqeWe4vCZYnt4CkWiyIuAQeK70Ot7I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1778680887421932.8615389386032; Wed, 13 May 2026 07:01:27 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1308042.1579590 (Exim 4.92) (envelope-from ) id 1wNA9A-0007ga-OS; Wed, 13 May 2026 14:01:12 +0000 Received: by outflank-mailman (output) from mailman id 1308042.1579590; Wed, 13 May 2026 14:01:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wNA9A-0007gA-Jl; Wed, 13 May 2026 14:01:12 +0000 Received: by outflank-mailman (input) for mailman id 1308042; Wed, 13 May 2026 14:01:11 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wNA99-0007dz-GR for xen-devel@lists.xenproject.org; Wed, 13 May 2026 14:01:11 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wNA98-00EQdJ-Rc for xen-devel@lists.xenproject.org; Wed, 13 May 2026 16:01:10 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a048416-2eae-0a2a0a5409dd-0a2a4503a792-40 for ; Wed, 13 May 2026 16:01:10 +0200 Received: from [209.85.221.54] (helo=mail-wr1-f54.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.56.1) (envelope-from ) id 6a048426-672d-0a2a45030019-d155dd36cc9b-3 for ; Wed, 13 May 2026 16:01:10 +0200 Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-44ce78ab5feso5843028f8f.0 for ; Wed, 13 May 2026 07:01:10 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45491e94c0fsm43198189f8f.32.2026.05.13.07.01.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 May 2026 07:01:09 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1778680870; x=1779285670; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=femi926UTfwC+WciGwdWOVpE8CZ0X7r6UWioon78b18=; b=YvQHJ5NZbx37SYN5wrokhD+e6WzoybxJURedj3Lj5uEVGMeREWhqDqR9OGwbpC7FAW 3BG5bmHOHTZVWLD6ZxIouOpzc7t1MR/uSeD0pmp3Tf0SEoj88pgmpAVW7Gv6/KI5NKOb grYEcRPdn3in7QynXTKaA90NohLkygKrQI38CXj04xp/x4GE/3liJv0OIe9+zBcF1tFl EHw71MqQDz6pG66fF7yJWEYMJ0ULbn7NpUqVymYiStWQJwPHY+mQU/pTJe2440Npa/jl FSga4QVodcSzLYCc6F1Zd/6+w83ldFC52FeP9MYgJ3OGnxUkOaEnptpylUsXvvS1OnJA e1eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778680870; x=1779285670; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=femi926UTfwC+WciGwdWOVpE8CZ0X7r6UWioon78b18=; b=Yp/Ifq9NHRefNJfSuo8YTh5+3ecfdYI7+XNMPrzj/niXXtxfdLlu38uO81QdIxqm3X fxDMjOo7O2LEYsuZx+ZmvGEw3d0ljvDs+fkb/9DieDaj6m1syCSrsB8+wdRxSz4C5gyW 5f2X6sGXlx9akT1TsYgY6EJ5dXBQSAy3ZWCswuzLyYLL7ggaAyBWlas8hw0TUtxzloYP qGMfTxjhb1x6mu2mtzjB2pXa01VqcEtr1uRQXzwYSWbX58IUXNr+ZmdW+rlccqYmtOy0 hGw5KLtIBjAfNzV+UIq2DkwWdPZWjVLgHPtzuyBk6LPPh46iqII9vtjYh95PAc+Oim+r Y77Q== X-Gm-Message-State: AOJu0Yz3xo66VcIQ8OcAeKagg4slDpViOEsLyQXerbop1BpgUMXjXk5l 0f6DE+PnFOwj/93rEspEnIrjwA+XXIEQ5ebROsICMEDMmsUpXnZCjIdx4UZUpeGwYuwve1Hd8Jy gxK4= X-Gm-Gg: Acq92OEZ0c//3eOazubRhFNJqlIvMtcO3dJTb9RGZs5WSicVB3l/LmKvl4V6b+f8opu ayewMCtz6BWg6O2oCQnoBeWYzT++hLmgzrJDJXAyc5fEfHj8hSJ87ZWt8tt16pEEYuYrJhkf8RG 732tirKPUA5ZWz/in8Y4afzQ1e/JPaYMkz73FXiKYx4Bkz3uK6ZLACnkpl8xN+9kJiejEhzcScm DCnrbHn/v7JlmwvSoEY+FekGfDp/NKb8k+qh/SxmnnpyUgK4dXmF3tL67AqgsCNBRyQBSbdOvfe JkdrEFhMop77mbq/U/i3H4T3bXzYz7UhTOBVh7YKMcOZtN+zJ8eVQcG9+vOcKftuIB7pDZysYxG aBtLI38lt+ieLdMUzYD0qvkBkmJKnCOuWFbYoScTWSvRhMPIZSkoTyWrEMm4paA72teMev97+H2 kuIkmxbS/v3a6nrymR1epvzSQkQQ2fCoj41gpNiR6541bCdEx7i/0oCtSWhYOHfbXPthyCpnICq e2Kno3LSEhBfEE= X-Received: by 2002:a5d:5d13:0:b0:43d:76d8:5794 with SMTP id ffacd0b85a97d-45c5ac51c66mr5460534f8f.36.1778680869772; Wed, 13 May 2026 07:01:09 -0700 (PDT) Message-ID: <3ca0351a-8be9-4b3b-989f-0ba004fada2f@suse.com> Date: Wed, 13 May 2026 16:01:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 2/2] crypto/rijndael: adjust for Misra C:2012 rule 8.3 From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <13ca5f9f-d985-41bf-9c30-afd657dade89@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <13ca5f9f-d985-41bf-9c30-afd657dade89@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-33051d/1778680870-39B7C938-8944C878/0/0 X-purgate-type: clean X-purgate-size: 1235 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1778680887826158500 Content-Type: text/plain; charset="utf-8" ... ("All declarations of an object or function shall use the same names and type qualifiers"). Bring declarations in line with the corresponding definitions, accepting the use of the being-phased-out u types. While we don't define NEED_RIJNDAEL_DECRYPT, cover rijndaelKeySetupDec() as well for completeness. Signed-off-by: Jan Beulich Reviewed-by: Nicola Vetrini --- a/xen/include/crypto/rijndael.h +++ b/xen/include/crypto/rijndael.h @@ -50,9 +50,8 @@ int rijndael_set_key_enc_only(rijndael_c void rijndael_decrypt(rijndael_ctx *ctx, const unsigned char *src, unsigne= d char *dst); void rijndael_encrypt(rijndael_ctx *ctx, const unsigned char *src, unsigne= d char *dst); =20 -int rijndaelKeySetupEnc(unsigned int rk[], const unsigned char cipherKey[]= , int keyBits); -int rijndaelKeySetupDec(unsigned int rk[], const unsigned char cipkerKey[]= , int keyBits); -void rijndaelEncrypt(const unsigned int rk[], int Nr, const unsigned char = pt[16], - unsigned char ct[16]); +int rijndaelKeySetupEnc(u32 rk[], const u8 cipherKey[], int keyBits); +int rijndaelKeySetupDec(u32 rk[], const u8 cipkerKey[], int keyBits); +void rijndaelEncrypt(const u32 rk[], int Nr, const u8 pt[16], u8 ct[16]); =20 #endif /* __RIJNDAEL_H */