From nobody Sun May 19 01:26:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1615473623; cv=none; d=zohomail.com; s=zohoarc; b=YRQ27gFJQbDOoQSkVEGpcvWG8f05a3bJmn67gPMloBfDrskJQ2I+vH+HJd3GKnt5UJmTi+MRHVoCoUvR8nRcxfoPMXbrwUYadnAIeRoTJo/mySWg9TQF3CZc5mcOlPTAS4cQUQh98X8MA9eCtYQxw9U0Ck9mFwBohAvVP784HUc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615473623; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=SpCLboR3rdGxQgHP4USmwjA3IAZd5oALlQEmZb2qbDQ=; b=k6AmbNI/9TtrU1EqD3XpbY+J3CPIJaVaIZaemKoPx7C/zTwYsdlRCExNwpHAhU6r8fFg+jv5cmOu/hl+I90lNLG2Qol7n67KdykGuHNsRbC/i/RPKiGRv9p/qDP8Us03VGZbswNkMq5QxOL7LNc+/6dnMtRsjDYizFP94LqKCQ0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1615473623205930.5190222854266; Thu, 11 Mar 2021 06:40:23 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.96640.183042 (Exim 4.92) (envelope-from ) id 1lKMTv-0007cx-OF; Thu, 11 Mar 2021 14:40:07 +0000 Received: by outflank-mailman (output) from mailman id 96640.183042; Thu, 11 Mar 2021 14:40:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMTv-0007cq-L5; Thu, 11 Mar 2021 14:40:07 +0000 Received: by outflank-mailman (input) for mailman id 96640; Thu, 11 Mar 2021 14:40:06 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMTu-0007cj-Q9 for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 14:40:06 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ac6cdb5c-38a0-4866-bacc-06f2e1926510; Thu, 11 Mar 2021 14:40:06 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3069CAC16; Thu, 11 Mar 2021 14:40:05 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac6cdb5c-38a0-4866-bacc-06f2e1926510 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615473605; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SpCLboR3rdGxQgHP4USmwjA3IAZd5oALlQEmZb2qbDQ=; b=uTjgsNBNMTB05iipx9Ld7t+JrAcOmC12AQYRAKUIjvhmDqNsP6AVmeY/0C/1w0OMtMnFCG l7eVUZBdVeSzGMenZMDNxXVpR7Oiwf9MPapbcWzvzt2CYf/MwUbQs5QMUHcsSWWAA5tUpn s03bkfma65oz9ehZVfSa8UC1d2o1JDI= Subject: [PATCH v2 1/2][4.15] tools/x86: don't rebuild cpuid-autogen.h every time From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Ian Jackson , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <1365013b-1e90-aeb2-3c80-7a5c6284c46a@suse.com> Message-ID: <1b8aee19-9194-153c-8dbb-0aec3412e255@suse.com> Date: Thu, 11 Mar 2021 15:40:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <1365013b-1e90-aeb2-3c80-7a5c6284c46a@suse.com> Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) Content-Type: text/plain; charset="utf-8" The first thing the "xen-dir" rule does is delete the entire xen/ subtree. Obviously this includes deleting xen/lib/x86/*autogen.h. As a result there's no original version for $(move-if-changed ...) to compare against, and hence the file and all its consumers would get rebuilt every time. Instead only find and delete all the symlinks. Fixes: eddf9559c977 ("libx86: generate cpuid-autogen.h in the libx86 includ= e dir") Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monn=C3=A9 --- v2: Different approach. --- Ian did suggest to pass -0r to xargs (and -print0 to find), but I couldn't convince myself that these are standard compliant options. We don't use any special characters in file names, so -print0 / -0 shouldn't be necessary at all. The stray rm invocation when there is no output from find can be taken care of by passing -f to it. --- a/tools/include/Makefile +++ b/tools/include/Makefile @@ -19,7 +19,7 @@ xen-foreign: $(MAKE) -C xen-foreign =20 xen-dir: - @rm -rf xen acpi + find xen/ acpi/ -type l 2>/dev/null | xargs rm -f -- mkdir -p xen/libelf acpi ln -s $(XEN_ROOT)/xen/include/public/COPYING xen/ ln -s $(XEN_ROOT)/xen/include/public/*.h xen/ From nobody Sun May 19 01:26:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1615473670; cv=none; d=zohomail.com; s=zohoarc; b=b3ME+B7ld5dmY3RzTWKStXRAXdaG+ss+js7q8xcMqBPQ5PWfSxn7DnrrjvhO3fFkZ4Jdz0wbB+zI1mXB+7wGw1EbtNQ9SK19v8upT/b00TJEQ0Qle0YtW09llj9lFi3W0H6GvK2UzgSbq1vusPu72dy91GlLX5wh0zCGXdlY6Zs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615473670; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+X69GrozWYaghxwvS9MPdag8I8/4ve4VeVt9yKkZhYs=; b=NJpYMjvum6FXWUM+v/zoOiePcD9gA3xxKcRqGoUO38DkbZnLL2S8VrTji9onL7OOjF5GugcU6v8Ff6VbVypyuK435IwMlZ/VE/4kuAn5toBBJHGIz1nnW6TRdW1Zm+l8/h8YBUyIDdmYgVViwzam1JyxtJy0y82KpDfq5vt9FOw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1615473670387783.9741662752845; Thu, 11 Mar 2021 06:41:10 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.96643.183054 (Exim 4.92) (envelope-from ) id 1lKMUj-0007kE-24; Thu, 11 Mar 2021 14:40:57 +0000 Received: by outflank-mailman (output) from mailman id 96643.183054; Thu, 11 Mar 2021 14:40:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMUi-0007k7-Ue; Thu, 11 Mar 2021 14:40:56 +0000 Received: by outflank-mailman (input) for mailman id 96643; Thu, 11 Mar 2021 14:40:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMUh-0007k0-N2 for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 14:40:55 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e43e1200-1ea9-4ec1-92f7-5ae55f97bcf4; Thu, 11 Mar 2021 14:40:54 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F3B7CAB8C; Thu, 11 Mar 2021 14:40:53 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e43e1200-1ea9-4ec1-92f7-5ae55f97bcf4 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615473654; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+X69GrozWYaghxwvS9MPdag8I8/4ve4VeVt9yKkZhYs=; b=Nz1PRdnUSOdE9jtsJU3xqs4L//HENNUebiCm6H4gdKgedYR6kE3npHieyVCq3gAR7Mu6g4 3GreSc/GDdXn0hvU2XdVee0k2gomGl/chDx3IRgOKPXpdX73Ik6OStBrLIu6s0RNvMZF7K uZvPmEwx/Dkr5Il0PSjbfYpAV8siOCE= Subject: [PATCH v2 2/2] tools/x86: move arch-specific include/xen/ population into arch-specific rule From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Ian Jackson , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <1365013b-1e90-aeb2-3c80-7a5c6284c46a@suse.com> Message-ID: Date: Thu, 11 Mar 2021 15:40:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <1365013b-1e90-aeb2-3c80-7a5c6284c46a@suse.com> Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) Content-Type: text/plain; charset="utf-8" There's no need for the common "xen-dir" rule to have an arch-specific part when there already is a arch-specific rule where this can be taken care of (arguably instead of all-y this might better be xendir-y anyway). Also change the pattern from *autogen.h to *-autogen.h. Signed-off-by: Jan Beulich --- v2: Insert dash in pattern. Re-base over changed earlier patch. --- I was tempted to move the "xen-dir" dependency from all-$(CONFIG_X86) to the general all-y, but perhaps that's less related and hence should really be a separate change (and there may also be arguments against that). --- a/tools/include/Makefile +++ b/tools/include/Makefile @@ -29,14 +29,12 @@ xen-dir: ln -s ../xen-foreign xen/foreign ln -s $(XEN_ROOT)/xen/include/acpi/platform acpi/ ln -s $(XEN_ROOT)/xen/include/acpi/ac*.h acpi/ -ifeq ($(CONFIG_X86),y) + +all-$(CONFIG_X86): xen-dir ln -s $(XEN_ROOT)/xen/include/asm-x86 xen/asm mkdir -p xen/lib/x86 - ln -s $(filter-out %autogen.h,$(wildcard $(XEN_ROOT)/xen/include/xen/lib/= x86/*.h)) xen/lib/x86/ + ln -s $(filter-out %-autogen.h,$(wildcard $(XEN_ROOT)/xen/include/xen/lib= /x86/*.h)) xen/lib/x86/ ln -s $(XEN_ROOT)/xen/include/xen/lib/x86/Makefile xen/lib/x86/ -endif - -all-$(CONFIG_X86): xen-dir $(MAKE) -C xen/lib/x86 all XEN_ROOT=3D$(XEN_ROOT) PYTHON=3D$(PYTHON) =20 # Not xen/xsm as that clashes with link to From nobody Sun May 19 01:26:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1615567846; cv=none; d=zohomail.com; s=zohoarc; b=YxPMI7pxRrk8pfKWZqcrsSAiKSLFWbCua7o/pMOGxva3ZzooQNg4UaZK+HLK95cm2xVQ5D8dMeoEJsY1Wx4wtqdG+hi4qLzIRf3TLYmgwbbeegPsw4Dv3rcppyLGYcFVNRpCTWAzi22q3+f2+tmvMZM5BtnQoec6bp1yIiL28u4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615567846; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=MmGPfV8DwHMB3Z9ZDZqRR5s22asV4IuA5dkHojkwLiI=; b=LyjX/0ENyg8irT2OKljQmDcndW0niIs6u6Uvfoak69n2Wqrnp2Hnma6nVH46IGKqnkBUV9F1NY7JfCObZtjK9+v63zqEFcOVVoGB9Fg9JBWzYVQHBv1JgcRJpcpaeFZ97tvjd+1fL+bnU/OytwICfO7r5jciT6sSGMrzUonICAM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1615567846097552.740039949903; Fri, 12 Mar 2021 08:50:46 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.97243.184652 (Exim 4.92) (envelope-from ) id 1lKkzL-0001Ai-V0; Fri, 12 Mar 2021 16:50:11 +0000 Received: by outflank-mailman (output) from mailman id 97243.184652; Fri, 12 Mar 2021 16:50:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKkzL-0001Ab-Rs; Fri, 12 Mar 2021 16:50:11 +0000 Received: by outflank-mailman (input) for mailman id 97243; Fri, 12 Mar 2021 16:50:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKkzK-0001AW-Aa for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 16:50:10 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cfdeb2b2-ce53-4633-b7a2-758ae8234b04; Fri, 12 Mar 2021 16:50:09 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5311EAF6C; Fri, 12 Mar 2021 16:50:08 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cfdeb2b2-ce53-4633-b7a2-758ae8234b04 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615567808; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MmGPfV8DwHMB3Z9ZDZqRR5s22asV4IuA5dkHojkwLiI=; b=ssjRyOHivjERsl5WB/JR1yXJAQ7r4nj/wbnRmqAhz4bZ+mgNqLF/oLhDvza9Kx0jLVokhq EFCwujMf6zFyotBXQfwh560Fl9kJQFQCm/mvqNYLiWYTj79WihrsL5GIA5DVjvVoOsbGWt DY83wqVWWOwMkDjBGPvG8V286FZBuCk= From: Jan Beulich Subject: [PATCH v3][4.15] tools/x86: don't rebuild cpuid-autogen.h every time To: "xen-devel@lists.xenproject.org" Cc: Ian Jackson , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <1365013b-1e90-aeb2-3c80-7a5c6284c46a@suse.com> Message-ID: <96ad6d6e-84f0-89dd-f7b1-1e1ddc2183fd@suse.com> Date: Fri, 12 Mar 2021 17:50:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <1365013b-1e90-aeb2-3c80-7a5c6284c46a@suse.com> Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) Content-Type: text/plain; charset="utf-8" The first thing the "xen-dir" rule does is delete the entire xen/ subtree. Obviously this includes deleting xen/lib/x86/*autogen.h. As a result there's no original version for $(move-if-changed ...) to compare against, and hence the file and all its consumers would get rebuilt every time. Instead only find and delete all the symlinks. Fixes: eddf9559c977 ("libx86: generate cpuid-autogen.h in the libx86 includ= e dir") Signed-off-by: Jan Beulich Reviewed-by: Ian Jackson --- v3: Don't use xargs. Don't hide errors. v2: Different approach. --- a/tools/include/Makefile +++ b/tools/include/Makefile @@ -19,8 +19,8 @@ xen-foreign: $(MAKE) -C xen-foreign =20 xen-dir: - @rm -rf xen acpi mkdir -p xen/libelf acpi + find xen/ acpi/ -type l -exec rm '{}' + ln -s $(XEN_ROOT)/xen/include/public/COPYING xen/ ln -s $(XEN_ROOT)/xen/include/public/*.h xen/ ln -s $(XEN_ROOT)/xen/include/public/*/ xen/