From nobody Mon Jan 26 09:19:01 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1768834067; cv=none; d=zohomail.com; s=zohoarc; b=f81NZ6PuBQB7x1FrCwDpyva3eNbwqIrjyBxxs6GKKaqU2UQcB1LrwI6bmc303FXt0w9o13p0VtH3jRKuhjz4koXmpne7yN9e1LYmmhtD2VBGgmzAnvnrQK+rbUImat4LfYGbMAogrvYycdhOrkg13XMKHej63yCVITjktgPZs0k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768834067; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2cfIXKgHYTFCKsrX1bFpAF8sQFG6ytaJSHI//BPGSL8=; b=Lv+DjTXHB2vGfsWxJJwveVk++IMAZWStLlGDqoa8ZvpINSvwIE5np9ujYT2t5AmAKzafBLhAWiTnsFAGhY9opxDLXFrtxgLCpmcjkz3r4Ctkbjb0POBHUb8t1yEcMmPwICOjfcEpkR/0r5T6nJoil24XATBAlFldIQ1QV9L8RhA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 176883406791343.87443185087193; Mon, 19 Jan 2026 06:47:47 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1208149.1520390 (Exim 4.92) (envelope-from ) id 1vhqXV-0001MP-0g; Mon, 19 Jan 2026 14:47:33 +0000 Received: by outflank-mailman (output) from mailman id 1208149.1520390; Mon, 19 Jan 2026 14:47:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vhqXU-0001MG-St; Mon, 19 Jan 2026 14:47:32 +0000 Received: by outflank-mailman (input) for mailman id 1208149; Mon, 19 Jan 2026 14:47:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vhqXT-0001Lt-21 for xen-devel@lists.xenproject.org; Mon, 19 Jan 2026 14:47:31 +0000 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [2a00:1450:4864:20::42d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c69c21aa-f545-11f0-9ccf-f158ae23cfc8; Mon, 19 Jan 2026 15:47:29 +0100 (CET) Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-42fbc305882so2451681f8f.0 for ; Mon, 19 Jan 2026 06:47:28 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43569921da2sm23567771f8f.1.2026.01.19.06.47.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jan 2026 06:47:27 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c69c21aa-f545-11f0-9ccf-f158ae23cfc8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1768834048; x=1769438848; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=2cfIXKgHYTFCKsrX1bFpAF8sQFG6ytaJSHI//BPGSL8=; b=SBQKG6gNmS7B0g+ci15OQ5lXx425LxvWxv5ZGep241pwPi5PUk1vxVqZqFujrVbyXD X11qFOugvvdvpOC6KZ5wSTC0Wut58JaHzW2X+ocUTnQxUjJ+Q2D/W6EejR+3+bQZmJXc 6+rnYq3/6knc2t1DGTquuP+jDW2pWdfIrg5s97qZ32K6plRWOVsja3GsQL1GJi0P8SjW 9GxfStn3l7zcRhwrM63NSIC6EpEC1Zo6sdaNCYf7NJkb+tvTt5yGEF931dfpxwoUOZl8 /5sqTHhSP0zHjdOG6sYblFhCiHGvd6rBhKpqzPCPI8RgCHkxxzsDqim8iRHK/D4xY7fZ tTEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768834048; x=1769438848; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2cfIXKgHYTFCKsrX1bFpAF8sQFG6ytaJSHI//BPGSL8=; b=xH/XC4QK6q1aMqqOGGoL19+T7McWqnVfsRox7ysQUmxdOw7Qo3+LwZm5V+un8Rcltp xdZTyWKRol4c7XGn7k6nGtgDAqQYReu0ceyxeShhGVxseGkmNfAbRae5qcFINdEsIk3m q9SUC1WZX/ih16I3raWmiZ8Cjsl0AWcOm39fDXzD/P2kKCa/PqwZ/bXJWRP4CSmBppwo c5eNTVVd+OUju535MpSIEc0D0JbpNlAMVOAA+71z8K2mQsalac/+/CJrs9SzPdopxOKf HqA3oiku0lHdd8KDPesrSWKVaOSIdmxAsg+8V4mQXSSSa0GQQyxgvRC9CrIviAuy/8Ge BJEg== X-Gm-Message-State: AOJu0Yxg1gWXPdzPZP15ky0bPHRoyWtaxJITpEz0iXVMW5F3AbYNZavX 9SjETbfdfGKpYR85AQLkS0uKliklyNN1ECqe2voUU0YvgQ0Mil/CKcsIgwOPkYsP/RDfYpzKQUi PG7g= X-Gm-Gg: AZuq6aK4TSxuhOVcI7Ybv2CzsuPldkxH1nGtyDEO5vUdwICYBtxCmACpXkmVFEdp/9M YlCL63A7tTPAJTS3EgZ7XgjNTI/aGgLAziqJtFTP/Fh4kv2jAP3QHW0XyfhnvrtoCh9lF9PInLl HwdpVfrsjH5GifpBVWSRorjElP2nakHrShPUh0NQMkaQDbwYBx6WnLxMniNZ/vScxtUY3oT89C+ l35mzFIfW97FnGOS4MNOgbOhykG9068asbEusmF1UkBkCab4R08FhWxzlM4yZerfzCFm3szgU7l rTlqm2AfH/C0ula7uLCkpl7/TIzEqcQr2Pv8JTGnvi8Mf0np9PEMPTCvS6t/fI2CMxt1D4lPyiL nIf53kkk2F5fVDlAGozJKBMerxTUq1PuHsCZ2UiRPBsHtfHcnrEVxx/pZDujkcLlUf7qCjVULdp xAsR4quXl9yA9YQsDDpPWk/hXRwekJFD4VpQFxB7rJGC33fTOOe1wU67ngKRmRfPHoU2XGOaaXT Dg= X-Received: by 2002:a05:6000:2c13:b0:430:f742:fbc8 with SMTP id ffacd0b85a97d-43569972d7bmr13723591f8f.6.1768834047591; Mon, 19 Jan 2026 06:47:27 -0800 (PST) Message-ID: <133c1cb0-bdb6-4c9a-bea8-c50f42ce58d7@suse.com> Date: Mon, 19 Jan 2026 15:47:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 3/4] PCI: don't look for ext-caps when there's no extended cfg space From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stewart Hildebrand References: <58091dc1-7bda-4536-8200-2d0a5679d4d1@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <58091dc1-7bda-4536-8200-2d0a5679d4d1@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1768834071213154100 Content-Type: text/plain; charset="utf-8" Avoid interpreting as extended capabilities what may be about anything. In doing so, vPCI then also won't mis-interpret data from beyond base config space anymore. Fixes: 3b35911d709e ("Enable pci mmcfg and ATS for x86_64") Fixes: a845b50c12f3 ("vpci/header: Emulate extended capability list for dom= 0") Signed-off-by: Jan Beulich --- Because of the multiple prereq changes, despite the Fixes: tags I'm not quite sure whether to backport this. (I'm leaning towards "no".) --- a/xen/drivers/pci/pci.c +++ b/xen/drivers/pci/pci.c @@ -113,6 +113,12 @@ unsigned int pci_find_next_ext_capabilit int ttl =3D 480; /* 3840 bytes, minimum 8 bytes per capability */ unsigned int pos =3D max(start, PCI_CFG_SPACE_SIZE + 0U); =20 + if ( !pdev->ext_cfg ) + { + ASSERT(!start); + return 0; + } + header =3D pci_conf_read32(pdev->sbdf, pos); =20 /*