From nobody Mon Apr 13 02:10:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1772631579; cv=none; d=zohomail.com; s=zohoarc; b=XNWJu6uqWmkTDN5c2TG+xV6pciaQE3ODFjf7As1KYGYHAA2ziCSMsVt1Y4dtbKE6IrlwpzTmThv0yspJcdIU2MwbXxXetS0bFAeZpfQD9FDmdBbKLlJy6DS0cRbDbXZViBsko32vzgmDXLAk7KlKKWeQnTEXcuBLflMTWo9Ab+U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772631579; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=X8CtSVUJuB+yYJVb/WeTxprdobFeg8yLEY1rCMe57LE=; b=g1wEA8ZzyL/fontxEQ+oNE7h1En5khcUc50KEvzgPReImAAYpqtoP28lxWtuq/W3F2NJvxF95WpMCp/Sgt+rfdXqb/KCzNR3kQ+fWEXC+y5kzAOXPuV4oU6s+pafmwNhwyCCk9AsFgv8sPkXcMjPsK+cR9wXGPHKVS25vNcBl1s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1772631579537737.9558023642945; Wed, 4 Mar 2026 05:39:39 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1245371.1544706 (Exim 4.92) (envelope-from ) id 1vxmRP-0005vi-2D; Wed, 04 Mar 2026 13:39:07 +0000 Received: by outflank-mailman (output) from mailman id 1245371.1544706; Wed, 04 Mar 2026 13:39:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vxmRO-0005vb-Uo; Wed, 04 Mar 2026 13:39:06 +0000 Received: by outflank-mailman (input) for mailman id 1245371; Wed, 04 Mar 2026 13:39:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vxmRO-0005vT-6r for xen-devel@lists.xenproject.org; Wed, 04 Mar 2026 13:39:06 +0000 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [2a00:1450:4864:20::32f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 82981ee1-17cf-11f1-b164-2bf370ae4941; Wed, 04 Mar 2026 14:39:04 +0100 (CET) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-48374014a77so83354745e9.3 for ; Wed, 04 Mar 2026 05:39:04 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48518807293sm50031755e9.11.2026.03.04.05.39.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Mar 2026 05:39:03 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 82981ee1-17cf-11f1-b164-2bf370ae4941 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1772631544; x=1773236344; darn=lists.xenproject.org; h=content-transfer-encoding:autocrypt:subject:from:cc:to :content-language:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=X8CtSVUJuB+yYJVb/WeTxprdobFeg8yLEY1rCMe57LE=; b=L3t+bEsRf2k7Cm9FOtMr+P7q8Jmt4Q97e/m+I5P6Tb7wCaOvZffh6C0bjawMe+YUJl cGSb2c6hlU4Za7BEZUwdDjWqBbzOdzQIOU4Szu7mtsSD+5SW7R+3BZ4+7ltALEm0AiH7 NxJuu0naz1qfA+XTkXBp8KpIxxjvZ/uaeSCTNDz4fJZ0UvHXCSnMiXNZlgZYIPQN4kYD TvrHmV/PuEUauVdculw8/xN3ktGJ4ezL5Z5mbpbz4T2+sxKHsy3fF24K3Twi9MM8wKQX LuFQi9/E7/t++cz4dBD2vljtvCB6T8q53gqCqdUoYEshO0ML9R86KwSfAz66tjGVGWzH YWKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772631544; x=1773236344; h=content-transfer-encoding:autocrypt:subject:from:cc:to :content-language:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=X8CtSVUJuB+yYJVb/WeTxprdobFeg8yLEY1rCMe57LE=; b=D2PB9pVAKhO5qVt7/oM8LJEHxwN23q3bddqCSCjRcAm5Zu+oWJMQcgwBydvLsvbaol 1JgcVoGUC7I7y90uAHYY+U0LVgWox02o1xEVbmauWlGH9WOT+EsURxCvcT4rntPA6/X5 48pcVkovc6yZqWAp7v9CLEIYfvpWJ4HiD5setLZnlCS/yxuAXylz40We2yIDGS9mPEsi IeIHiSb2ZLrvYIJG1Izz1uIEvpLm0HWWmo8Z/6IDevxX7lBC0oehVkuqBGcR1+90QudE zTG/m+HoF0vnHiA0IJ9JjDmWGYXgfATMSQ4uJr2X2g662NC/t8+AKSOcHr2zJ11ctWyh p4Tw== X-Gm-Message-State: AOJu0YzqwavaZSCwbOe3wOXohI0P2emPN/vHHFbMzdJ5mPK6teqTwK4C Za9T7xUA4GHEfm9MySqZfxFZsPdrtiCCbd/k5lKCN6h/Fp8Lzt3PtOQpvcMuhpPtdgWlv3BAqSn FKus= X-Gm-Gg: ATEYQzweliDychRUsTdH2tJEsCw80hel6T2Pk146Damin6qGWS0XA7WoOEap6Ysfhnz vkvmbddST1eygJWPNxq8TwTbjNVEPbEugwF3zPBQ9SitL9RmJX9FRU86IRypPHfDF3n/JPgev0w qPbXYOL4tOeGCuHIuoDkuq0/gDyZuxWt25fyrtNo3aSVYX+r4JYntaeFZtSryMJMpXQi46C5r9Z R36ztb60+qMiaF+8PdXJralyKp2OfAhQd2JmvwyFewWGxTnlOPQxOqwtkGRdhc0knfXJzONwQ01 tEcD1EATvx1dvfVoOxU6sD8VNGvfG8AYGDYoMoaDOpPNy9XySFSlWQbbuJkk4km9jQbT0vCKOHI 3LJsj/hsargqdgEGvY82n93OormL//B91t/3kjgEvCc++IrqsvzcMk9wE0Qd1g4SA/emgWuxCOi A1dcha6eVBCTUk5kVM5O7qkkh09fgy6s4VXtLTs+iSxzJU4NJC07YUm8Plo5TipPTTnI9W161Xi 2Nb25swVdrCH7M= X-Received: by 2002:a05:600c:4e8b:b0:480:1d0b:2d32 with SMTP id 5b1f17b1804b1-48519847bb7mr35003105e9.12.1772631543674; Wed, 04 Mar 2026 05:39:03 -0800 (PST) Message-ID: <12fbad10-78ad-4679-a1db-3995e34da094@suse.com> Date: Wed, 4 Mar 2026 14:39:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Marek Marczykowski From: Jan Beulich Subject: [PATCH] x86/S3: restore MCE (APs) and add MTRR (BSP) init Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1772631580485158500 MCE init for APs was broken when CPU feature re-checking was added. MTRR (re)init for the BSP looks to never have been there on the resume path. Fixes: bb502a8ca592 ("x86: check feature flags after resume") Reported-by: Marek Marczykowski-G=C3=B3recki Signed-off-by: Jan Beulich --- Sadly we need to go by CPU number (zero vs non-zero) here. See the call site of recheck_cpu_features() in enter_state(). --- a/xen/arch/x86/cpu/common.c +++ b/xen/arch/x86/cpu/common.c @@ -642,16 +642,21 @@ void identify_cpu(struct cpuinfo_x86 *c) smp_processor_id()); } =20 - if (system_state =3D=3D SYS_STATE_resume) - return; + if (system_state =3D=3D SYS_STATE_resume) { + unsigned int cpu =3D smp_processor_id(); =20 + if (cpu) + mcheck_init(&cpu_data[cpu], false); + else /* Yes, the BSP needs to use the AP function here. */ + mtrr_ap_init(); + } /* * On SMP, boot_cpu_data holds the common feature set between * all CPUs; so make sure that we indicate which features are * common between the CPUs. The first time this routine gets * executed, c =3D=3D &boot_cpu_data. */ - if ( c !=3D &boot_cpu_data ) { + else if (c !=3D &boot_cpu_data) { /* AND the already accumulated flags with these */ for ( i =3D 0 ; i < NCAPINTS ; i++ ) boot_cpu_data.x86_capability[i] &=3D c->x86_capability[i];