From nobody Thu Sep 3 07:03:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1788330619; cv=none; d=zohomail.com; s=zohoarc; b=DGhVsaLO7t/1rPyZEp+TH7rc9xJDfQ2kaugGeeq0CA1qNt93MlV/R8Kq4VbPEmdDf78jjyelMUPY0SZQDY1KE5WRopaQ10P2oF4e/vTos/beTVdXpfce2+AhLxVlyTJEF2+6OPsQWkEO3PbB74uvgRMRHItjepvTH5OJqLue/d4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788330619; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ZQgf6lhFc6DJzEwMjaZidYZkmvOwmEo5c6f5ck/LBtM=; b=PCJfep2U81QmDFOVM0LKtz9BnLzrdAM4UYnb1H6xK7MriZu79RcS0nLpMtXVS26z6hOp9H5mZ7QyptTjlzChduoruOPGECfsxjrei6Yi6hjzqDp159TmKDipLN60Izo8cxGu7P1P14xnxhbSaEy0vqzhrSzE4fvEAY9NnMSrZcU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1788330619430375.65411353670436; Tue, 1 Sep 2026 23:30:19 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1405035.1638576 (Exim 4.92) (envelope-from ) id 1x1eU3-0002S0-64; Wed, 02 Sep 2026 06:30:07 +0000 Received: by outflank-mailman (output) from mailman id 1405035.1638576; Wed, 02 Sep 2026 06:30:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x1eU3-0002Rt-3Y; Wed, 02 Sep 2026 06:30:07 +0000 Received: by outflank-mailman (input) for mailman id 1405035; Wed, 02 Sep 2026 06:30:05 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x1eU1-0002DO-Ae for xen-devel@lists.xenproject.org; Wed, 02 Sep 2026 06:30:05 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x1eU0-00ANlB-NC for xen-devel@lists.xenproject.org; Wed, 02 Sep 2026 08:30:04 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a97c269-8faa-0a2a0a5109dd-0a2a4505b328-18 for ; Wed, 02 Sep 2026 08:30:04 +0200 Received: from [209.85.221.48] (helo=mail-wr1-f48.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a97c26c-4cb1-0a2a45050019-d155dd30ad58-3 for ; Wed, 02 Sep 2026 08:30:04 +0200 Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-48433fad54aso418555f8f.1 for ; Tue, 01 Sep 2026 23:30:04 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48448eeabbfsm3927968f8f.31.2026.09.01.23.30.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Sep 2026 23:30:03 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1788330604; x=1788935404; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=ZQgf6lhFc6DJzEwMjaZidYZkmvOwmEo5c6f5ck/LBtM=; b=HjFAPo0V5Cqc2z++ovb14Ozo+YwE0ebrDYC9x2AgeOSLB5y/dD8K0apw0VtpcRJJZl LOdw30iHopivlHFJflgojAVX9nUIgvtvyhrwR7kIT/HhIKK1joJMcWUP6XgILb+O0YCY XFSxUxz08cGjp9pTn+fas9KliZYvw2WUMrdsuD86yWNxhnCUyGhBjQL6MNTcYy1tECOf wzJDST0EmiXhkB3DX1BmssgxrSsgLkUSauW6GX/ROM7zOUzCC3vuw5YYmXjClxYMxNbB 3iatNPgPlbnn5/N+IMabVDIP/T9VvxWCC5beeMiCmx/pcKKJ6zU8EUqssNXjNvqptEQr lx+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788330604; x=1788935404; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=ZQgf6lhFc6DJzEwMjaZidYZkmvOwmEo5c6f5ck/LBtM=; b=p8X3RDUujGPH3IBKT72c4hF/9m4L/srJDNbC/Bq9u3qPo55Sb00bOUhxqC2GzO48qU HywKLM4wGaSkDxVYRlo5mvN703csBDPfs62c5jLVl24jNYHtNRTLhGXjApSyhVzzXqeR UVGGcXv78HIOwrXvTZS0ttnBr+REW8T/y31JLiPjyiRJ1wLz9XcMiyPrXaAKIu1QIKjt 03Pj9Hr7268yeaiGsNdqtCXkoxoV0N+2zjxLycL/Fb9C/J02sqlT1JjnWCu3Fx1FZig2 d/yYl+w+Gw9hYY/cmrNhSGjCd1X/+gdHMSzY8b68hnbEXRZrrxRwNDagjbA42OPuztrp qwTQ== X-Gm-Message-State: AFuF++nPvj1JOTF9IaTl2RrJJF5yA46ys2TQSKohGUtVP54+idil2bC8 aPo99u2bWVpF4K7wRt6W0LPw0gFrHKAKD1bqzH8pZF1R1vL8zezMtYkRiPiuAEFD9wELE3Q0cw9 dXbfYEg== X-Gm-Gg: AYBFou2pcEvVowXuNf7GeE4Ci86EeeJo7kKxbBGLHBxzsA29sUaM9IVcQolcpU5z1xD 5CCd3SCOTbx0403sS0hWCVxU6ZrK/Afhg2r/l9/sbOgE6jQUKVdwq9cKYYKTd/Nz5YgrOoXWSpS ldjS8Gfk3WZA6YcJbYLg9lRQX9rsljOPFv8pJpm4o8Uar8HSbIhx40FIjSQVIbO1ylry2oCsg6N QaWNHt+ALHiDfN1KhU4jrn16440udz1GXUf4RzSjos0namzBpFAHLGVKYKcUyPP65I5SNeuehm9 l+B5wW9c8cBe6CINr8ZDOu3MsGLookZZB+bpEjSdP/FVxzG4NYOBpncnDr0gC8AD7APkFwG7wI4 71dKaikpCwMk3oD9rGxkRh5byexdfiZxxirxXihthSx2AvF6gvMzFol1U7w8xYUfS8iUNhP3XRH SUMJMW4VrvbS+qlbdyiTqqoelu1CsZeovnYBdGl96bHkMBKGo8uP2J0JWCfOdce4Au9gOx0jNvB TbYeET1KKk0Lz8Rnj4TajceDubF1g/Q9EoAs8vBxa5jwhHrE8x5 X-Received: by 2002:a05:6000:2481:b0:484:3310:710b with SMTP id ffacd0b85a97d-484913bf064mr3621318f8f.23.1788330603979; Tue, 01 Sep 2026 23:30:03 -0700 (PDT) Message-ID: <12d3f4cc-e3c3-4f2a-a791-724271473fb9@suse.com> Date: Wed, 2 Sep 2026 08:30:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 01/14] lib: obey to Misra rule 11.8 where possible From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <0ff5676d-2ad3-49e3-a94b-90e7c3edb55f@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <0ff5676d-2ad3-49e3-a94b-90e7c3edb55f@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-c201ff/1788330604-F7ABF2A1-2BB4FCD4/0/0 X-purgate-type: clean X-purgate-size: 2637 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1788330622453154100 Content-Type: text/plain; charset="utf-8" Casting away const-ness (or volatile-ness) is never a good idea, but some library functions (e.g. strchr()) require doing so. Where not required, remove / replace respective casts. While there convert touched functions to Xen style. No functional change intended. Signed-off-by: Jan Beulich --- a/xen/lib/memcpy.c +++ b/xen/lib/memcpy.c @@ -15,12 +15,13 @@ */ void *(memcpy)(void *dest, const void *src, size_t n) { - char *tmp =3D (char *) dest, *s =3D (char *) src; + char *tmp =3D dest; + const char *s =3D src; =20 - while (n--) - *tmp++ =3D *s++; + while ( n-- ) + *tmp++ =3D *s++; =20 - return dest; + return dest; } =20 /* --- a/xen/lib/memmove.c +++ b/xen/lib/memmove.c @@ -14,21 +14,25 @@ */ void *(memmove)(void *dest, const void *src, size_t n) { - char *tmp, *s; + char *tmp; + const char *s; =20 - if (dest <=3D src) { - tmp =3D (char *) dest; - s =3D (char *) src; - while (n--) - *tmp++ =3D *s++; - } else { - tmp =3D (char *) dest + n; - s =3D (char *) src + n; - while (n--) - *--tmp =3D *--s; - } + if ( dest <=3D src ) + { + tmp =3D dest; + s =3D src; + while ( n-- ) + *tmp++ =3D *s++; + } + else + { + tmp =3D dest + n; + s =3D src + n; + while ( n-- ) + *--tmp =3D *--s; + } =20 - return dest; + return dest; } =20 /* --- a/xen/lib/strcmp.c +++ b/xen/lib/strcmp.c @@ -11,16 +11,15 @@ */ int (strcmp)(const char *cs, const char *ct) { - unsigned char *csu =3D (unsigned char *)cs; - unsigned char *ctu =3D (unsigned char *)ct; - int res; + const unsigned char *csu =3D (const void *)cs; + const unsigned char *ctu =3D (const void *)ct; + int res; =20 - while (1) { - if ((res =3D *csu - *ctu++) !=3D 0 || !*csu++) - break; - } + for ( ; ; ) + if ( (res =3D *csu - *ctu++) !=3D 0 || !*csu++ ) + break; =20 - return res; + return res; } =20 /* --- a/xen/lib/strncmp.c +++ b/xen/lib/strncmp.c @@ -12,17 +12,18 @@ */ int (strncmp)(const char *cs, const char *ct, size_t count) { - unsigned char *csu =3D (unsigned char *)cs; - unsigned char *ctu =3D (unsigned char *)ct; - int res =3D 0; + const unsigned char *csu =3D (const void *)cs; + const unsigned char *ctu =3D (const void *)ct; + int res =3D 0; =20 - while (count) { - if ((res =3D *csu - *ctu++) !=3D 0 || !*csu++) - break; - count--; - } + while ( count ) + { + if ( (res =3D *csu - *ctu++) !=3D 0 || !*csu++ ) + break; + count--; + } =20 - return res; + return res; } =20 /* From nobody Thu Sep 3 07:03:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1788330679; cv=none; d=zohomail.com; s=zohoarc; b=QgSXJlziNQnZ7lQUO3+2n6Q4hlPztEDWLkZ47cH5m1s6/4Lk5RHzlMVOBHaQDokoUjbwAyaYE/vUa5sRkSSvFNpY6896Ml0ceCXEHQQakJ6EoCRgJBOmzMijjVjG31+tr737birk0lnsNYQZZyDxLZ+MuPA5Sv9canAIHyP+vSU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788330679; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=qf1WHuiH8vY+yMHFbjVMhDzcKdeDFrIIHvK/5ttVZtM=; b=Wajwi/RAAoQsKN5IdKvWxHW80MARDDlIr+EiFOkadsKLXdxqvPQaaqmPPR101O9UZ5ODJi5lnptErOITqnkRb2VGEwt/vinr2VuevOYxZvnwFoul7ywAuWn/LdOyJZRaf7ngHKSvTLAgt+lMzqhlMGY4agThU+lT48sDIum4uHc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1788330679353901.8693283863745; Tue, 1 Sep 2026 23:31:19 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1405043.1638586 (Exim 4.92) (envelope-from ) id 1x1eUo-0002w0-HC; Wed, 02 Sep 2026 06:30:54 +0000 Received: by outflank-mailman (output) from mailman id 1405043.1638586; Wed, 02 Sep 2026 06:30:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x1eUo-0002vt-E2; Wed, 02 Sep 2026 06:30:54 +0000 Received: by outflank-mailman (input) for mailman id 1405043; Wed, 02 Sep 2026 06:30:52 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x1eUm-0002vj-Bf for xen-devel@lists.xenproject.org; Wed, 02 Sep 2026 06:30:52 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x1eUl-00Ggy9-Fb for xen-devel@lists.xenproject.org; Wed, 02 Sep 2026 08:30:51 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a97c290-2eae-0a2a0a5409dd-0a2a450699c6-30 for ; Wed, 02 Sep 2026 08:30:51 +0200 Received: from [209.85.128.43] (helo=mail-wm1-f43.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a97c29a-195a-0a2a45060019-d155802be072-3 for ; Wed, 02 Sep 2026 08:30:50 +0200 Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-49b8e527d63so7088265e9.2 for ; Tue, 01 Sep 2026 23:30:50 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ce3c86a0asm52736995e9.9.2026.09.01.23.30.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Sep 2026 23:30:50 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1788330650; x=1788935450; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=qf1WHuiH8vY+yMHFbjVMhDzcKdeDFrIIHvK/5ttVZtM=; b=GgpnU+GOAc7XNBjE1/l3VujYHF/KfyE3DMnjUe5/M3LM2bsj3ap6JA+0cyP/JzThpE ChTXaoU+Ao68lxE7we7YkR6XkncXutHyQR3LDPXwNMMtAkMVzZ9MQd1BVBbqMhymCIEs lfNu1hUhb2widIkj5kvnCLg4d936fGKX4kw5X47alUaq3vZLx/+3ap1c9bAg7Xymxpbd 6alEEc+jKDa44fVyb7XIKwIKEMkY5Kao4HoKtXqqtJt6QBDPkFNOAqEBeljXKFeWGyDN 7hYdtEZHxfaK4fdO8Rtqp7oc9/FWMHjnbsSDpVYW7pQq7pEUzvZCr0729Xqc2/TkZkrC p0yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788330650; x=1788935450; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=qf1WHuiH8vY+yMHFbjVMhDzcKdeDFrIIHvK/5ttVZtM=; b=fGBjn1DnLplY7I+WbaH0NWeiNSs6NbMVNmshWdOW4YhrurekFsmp9Rx+xSo5VqDHE5 LAKaR7Tft1UUpBlKX+MPjwWpEsWxWBYZaxckVR+pU+hWwrm4pIE1JqF+Ht6/3QRuSvA1 RUjI60nkT8bmd3k2tthNuaqdI3hvUpdgAwSdGgS0uC4the7h1BvD5SHqPcFl8MpQ+L4A o/Y13+Q352gEvM85O+C/v1Smxc3yjMux91nzaX98Fn4W0PiTgGPtiZMQZdFtXhl7gaBV 6qRnqiZmPOFggGhS1lHFSVAImDh3YVrc5/rAOUWNFUzk32CDHdolSUwLVASxz7esBlbh giCA== X-Gm-Message-State: AFuF++mG8/3p7N8p2j3b5Mn4ng8ErBn3faVKwygXR3CSl6FTKXX5+tcg Lnk2vH0rXZDdl0R6efSfXDNiVA9DBwDPXC39eBrRvkJXXWAcDzd3z0M3Yv7TqurDh2wGWlrIcQH iVLdJqQ== X-Gm-Gg: AR+sD10L3d+rnDnI2+OdGGKTr6kv6PriyN9R7+15eB8shiLBPH13wChJYtQ3g85fHy9 ObJcCNlB+NnY3xyL5U0iTqTb/TA1if968HdLRyv+Zw5J9MesiIAhEX2fcGrDLpP+rQKaPDGMj8B w6RqiN0MDH/6e67tm4aQXmcmFT9Q2Kw3bhsO/x52wH5XXKIc5gu+ZsFqe/oIf7qiyIg5TnE9EEs r2zhS5FvFdujfGoe5SL59wAfQy3UcmCTpnnZRFMIt5PQPSNXJBt1mPyakuWilMc/EfKeH3G2wbB suetf6hK3ndwJc7gdUUQIhgV8rt2NgMRHogaF2efm5RQaxTgfn+b7c2GMmcFDydAytiynQO6i5M 1YVx0/hhszF3j4raByv4ptP806OHx9TNkYEMO4VCv8lUCDkj2WHkUu1FQnj9YgGcuVX9dOYfF5v 3ZcGRFcvss2hQ9vr9tggdZyNbFJo+NOsOAd3k0wB1RTVj9rcDHSV9AIsCq9EQEqXqIH/dN19+pX 5JNTXTQbR4SD/Pv51W3vd3MVkTKRbA7w7q1z3mJn6WJT+k9YpJY X-Received: by 2002:a05:600c:3494:b0:49b:9202:6f80 with SMTP id 5b1f17b1804b1-49ce57ee273mr44721865e9.6.1788330650419; Tue, 01 Sep 2026 23:30:50 -0700 (PDT) Message-ID: <75bd486e-054d-45f4-93b7-800b0ddb21f1@suse.com> Date: Wed, 2 Sep 2026 08:30:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 02/14] x86/bitops: don't cast away volatile-ness From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Oleksii Kurochko References: <0ff5676d-2ad3-49e3-a94b-90e7c3edb55f@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <0ff5676d-2ad3-49e3-a94b-90e7c3edb55f@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-16d1c6/1788330650-F5E0E77B-1CCCFC9C/0/0 X-purgate-type: clean X-purgate-size: 1626 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1788330680861154100 Content-Type: text/plain; charset="utf-8" Doing so, besides being a bad idea in general, violates Misra rule 11.8. Use the helper macro we have available anyway. No functional change intended. Fixes: f1879b2c2584 ("xen: introduce generic non-atomic test_*bit()") Signed-off-by: Jan Beulich --- a/xen/arch/x86/include/asm/bitops.h +++ b/xen/arch/x86/include/asm/bitops.h @@ -188,7 +188,7 @@ static inline int arch__test_and_set_bit asm volatile ( "btsl %[nr], %[addr]\n\t" ASM_FLAG_OUT(, "sbbl %[old], %[old]\n\t") : [old] ASM_FLAG_OUT("=3D@ccc", "=3Dr") (oldbit), - [addr] "+m" (*(int *)addr) : [nr] "Ir" (nr) : "memory= " ); + [addr] "+m" (ADDR) : [nr] "Ir" (nr) : "memory" ); =20 return oldbit; } @@ -234,7 +234,7 @@ static inline int arch__test_and_clear_b asm volatile ( "btrl %[nr], %[addr]\n\t" ASM_FLAG_OUT(, "sbbl %[old], %[old]\n\t") : [old] ASM_FLAG_OUT("=3D@ccc", "=3Dr") (oldbit), - [addr] "+m" (*(int *)addr) : [nr] "Ir" (nr) : "memory= " ); + [addr] "+m" (ADDR) : [nr] "Ir" (nr) : "memory" ); =20 return oldbit; } @@ -248,7 +248,7 @@ static inline int arch__test_and_change_ asm volatile ( "btcl %[nr], %[addr]\n\t" ASM_FLAG_OUT(, "sbbl %[old], %[old]\n\t") : [old] ASM_FLAG_OUT("=3D@ccc", "=3Dr") (oldbit), - [addr] "+m" (*(int *)addr) : [nr] "Ir" (nr) : "memory= " ); + [addr] "+m" (ADDR) : [nr] "Ir" (nr) : "memory" ); =20 return oldbit; } From nobody Thu Sep 3 07:03:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1788330704; cv=none; d=zohomail.com; s=zohoarc; b=Z70zY1kv4cO0ERMJDHWWlSGgqW2cyGNxUIWKrG2rDhabS3yX8kSYUgdJfyeGOKfm9HMxvhSd+z7n7Lh0WGwIpk1qeC7bHKkXDOMB2HeEDwYFgD+TWs+wWmwNcxBuea5in/wNShE+HnJruT6CrxmJLway8/VZHbrtGk3zGevitEs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788330704; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=AW5Js8HSLcZBr8DQXofVW/feqCltoKGq3ct/AKTu4nA=; b=V37ZAXeUawB3aa+MmYuLtD8OmCuS3SoyIvodnVXd5uCDxfx37hETCraAAWAmsFcoDNmDWPCqvl6VIRtsfuf+4euZzAZeih43sYm0CRWdTjLQgwrkBep5Smh746EILfxYyWh+m45SOLU2Q0IVhyR3S9ba2ONglQst5wrgaogztvU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1788330704303836.5506077792312; Tue, 1 Sep 2026 23:31:44 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1405049.1638595 (Exim 4.92) (envelope-from ) id 1x1eVJ-0003NV-OF; Wed, 02 Sep 2026 06:31:25 +0000 Received: by outflank-mailman (output) from mailman id 1405049.1638595; Wed, 02 Sep 2026 06:31:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x1eVJ-0003NK-L4; Wed, 02 Sep 2026 06:31:25 +0000 Received: by outflank-mailman (input) for mailman id 1405049; Wed, 02 Sep 2026 06:31:24 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x1eVI-0003NA-Pj for xen-devel@lists.xenproject.org; Wed, 02 Sep 2026 06:31:24 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x1eVI-001cWT-6N for xen-devel@lists.xenproject.org; Wed, 02 Sep 2026 08:31:24 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a97c2bb-bab6-0a2a0a5309dd-0a2a4509c0ec-4 for ; Wed, 02 Sep 2026 08:31:24 +0200 Received: from [209.85.128.47] (helo=mail-wm1-f47.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a97c2bb-be1a-0a2a45090019-d155802fe8b3-3 for ; Wed, 02 Sep 2026 08:31:24 +0200 Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-49b8be0409fso4122485e9.2 for ; Tue, 01 Sep 2026 23:31:24 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ce58da3acsm62073415e9.0.2026.09.01.23.31.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Sep 2026 23:31:23 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1788330683; x=1788935483; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=AW5Js8HSLcZBr8DQXofVW/feqCltoKGq3ct/AKTu4nA=; b=OYwFPJtVTnD39CnaVinmfV0sE+tMZJgnBJrilCrdL/5a13vN7TQhgLY/+Rfl3dg+7e sIAK7Zclgw2buPEOAoGydo9B4BbIE2es8QAQBAyYHbXcskdX6FkyZxi+MPmNP5PoBQ9+ xZYiDGW/jsrigsfl/ZRmCxcflaiBXPvZwCOMEiFXNZ9yvqLdKiSeqz+5kuSW+qnaBcTG TfjCEs5w9/UM7VUjn/b8KsdxZV63FWewlFxBT15cbZOlzF9ctz3fOHXJsualqeUfmzBH +od510/RrccBGnGT167EMX+/NVp/X/B31atnoSGc9hGZfia4yOxy7RdQwEXnKNKmMf0D 9ZbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788330683; x=1788935483; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=AW5Js8HSLcZBr8DQXofVW/feqCltoKGq3ct/AKTu4nA=; b=Wv5f2hvCyCFz9Xxb+dZNxTsqxtwCpz7KfQ+rgI/0r2VDps7V5+fiq43BOmOI7IkFjf mnnTCgVTWBybgHWABMmh959Hbz2AaPfhGdl5wjOYl9122LQIvNHQwDny9vEo/ANnOeAt quRhoPxNP6NnsxP3USuv8F0xVgwZx5bPhgdUXTrQOP9Sc815y43C1uP1NGEoF3xvlvoS JNx5XEhQ5KLYTge0oeC8As+vsQcxCO6E6arHfKzhWMxxVU6aXUn+cJq0pC9ObxK8nD3a 8ajdopanIbFAHHlaEG/NDXCdVCRirLUXDN1wA7v15/vnQXpU/TnkbGcea21orUCxuND/ ELkg== X-Gm-Message-State: AFuF++lWrT3+Gucw5UOlUy9BjYBNfTRzVAab6jskvKeWQZ7o9mOhO3Vk wWCe/rXKoTFzY8bM4JfUDqfvixGrso83Gf/uCDgnFq4a0rZNxy8LeEOqQHYTQRnvNYinDTCJvNK 605qwxg== X-Gm-Gg: AR+sD11Wj7e49vLeBj5qQ4Z3Xonog0n11/p9HMZ/PknUjPEU3wyIX5dl+4YwckUpGmH zW7+UFsCQo1zbTVMZXYJPPxiJcuI2VOdQo+bXLznfDzLjkQMxErvk3j+qxJ8tf3aQttUEKR32Pi H5RWO4y/NRlVaIe2VUZWgCwYF+r+bTA8qkSyWPhSVfNC4F5gQQzNpQBRg+tqMjqd5ypxkrmZKI4 U1Fr47vIT4OBPc7xO48KQszNV9xGxPEVYXBjNTUaVKQNWAOJSK/5JFIxhMCEXZE6a1oKLjl7pCB BQgEwoYWvaUFWau63g0prEiVuwCCP2Pl9aLcBos9sFPdzl+uN1C/G7qzRvQ5KEV0WUPyJ4kdgXQ EheEK6yuw88OuAzFOCAf9JBLef3efGHBxYpb4QT5UXTGNGal6zjcS/I0HaU7uNQ2/zJWTffePrU I17sOxOC9+xEZOX3gySIuWPEUQ67+9uLwVirE/YBdL8NeuKtIL/A3WRhJkCnKW2aD3m/pD14TfZ mdciCfbsgOY0rj9yRyvsOi65Hi5NtapR7alL0blrcbmd7aNV4YB X-Received: by 2002:a05:600c:4f0b:b0:493:bd2a:93be with SMTP id 5b1f17b1804b1-49ce581316dmr34390275e9.6.1788330683437; Tue, 01 Sep 2026 23:31:23 -0700 (PDT) Message-ID: <8ae3cc08-2011-4689-8530-f3b962ed4d72@suse.com> Date: Wed, 2 Sep 2026 08:31:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 03/14] x86: have cmpxchg16b() obey to Misra rule 11.8 From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <0ff5676d-2ad3-49e3-a94b-90e7c3edb55f@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <0ff5676d-2ad3-49e3-a94b-90e7c3edb55f@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-bad1c0/1788330684-BFAD0034-4119CBBB/0/0 X-purgate-type: clean X-purgate-size: 762 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1788330707291154100 Content-Type: text/plain; charset="utf-8" Casting away const-ness (or volatile-ness) is never a good idea, and there's no need to in cmpxchg16b(). No functional change intended. Fixes: e0116acbbd0b ("x86: add cmpxchg16b support") Signed-off-by: Jan Beulich --- a/xen/arch/x86/include/asm/x86_64/system.h +++ b/xen/arch/x86/include/asm/x86_64/system.h @@ -56,7 +56,7 @@ static always_inline __uint128_t cmpxchg ASSERT(!((unsigned long)_p & 0xf)); \ BUILD_BUG_ON(sizeof(*(o)) !=3D sizeof(__uint128_t)); \ BUILD_BUG_ON(sizeof(*(n)) !=3D sizeof(__uint128_t)); \ - __cmpxchg16b(_p, (void *)(o), (void *)(n)); \ + __cmpxchg16b(_p, (const void *)(o), (const void *)(n));\ }) =20 #endif /* __X86_64_SYSTEM_H__ */ From nobody Thu Sep 3 07:03:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1788330732; cv=none; d=zohomail.com; s=zohoarc; b=F71AHFc1STXCUwJ4Q96F+uOjA9r7x4dkwkiaeGsWBEF/76p787JI2flD4l+qRWyQkSrdhL2u4+syvawedhc5MyhaBo7+H9S2AKKBoY6iXEzoevHJhkEOumlzL/sF63TByWsl01Va7GoduMOoJW8w2/IEa7BqfvoQ6O8TrVvzuLk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788330732; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=SLQw4AZiW0xGo4eY+c2v6v3KWBjjDDtH8z6OZdHRa/4=; b=MMlUN3cgOs0+kOL4VUw5J3Gpw+sCQYWQTf279h61fGZD9Bdr8m3euzS75hcLMmTu/B3SNxGavrHYR47amX9Rn+r3UUOVp3jb8W88jgXBXG1/WNqUAv+tyUbZtLFE6uAcNscDhKkTWXEoLnfAGxyeDFBeUJrhaM5gQlyNMegw1YI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1788330732850107.21666807886527; Tue, 1 Sep 2026 23:32:12 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1405054.1638603 (Exim 4.92) (envelope-from ) id 1x1eVg-0003oo-VG; Wed, 02 Sep 2026 06:31:48 +0000 Received: by outflank-mailman (output) from mailman id 1405054.1638603; Wed, 02 Sep 2026 06:31:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x1eVg-0003oh-SS; Wed, 02 Sep 2026 06:31:48 +0000 Received: by outflank-mailman (input) for mailman id 1405054; Wed, 02 Sep 2026 06:31:47 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x1eVf-0003n2-GD for xen-devel@lists.xenproject.org; Wed, 02 Sep 2026 06:31:47 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x1eVe-00AIYQ-TA for xen-devel@lists.xenproject.org; Wed, 02 Sep 2026 08:31:46 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a97c2d2-8faa-0a2a0a5109dd-0a2a45069f90-0 for ; Wed, 02 Sep 2026 08:31:46 +0200 Received: from [209.85.128.49] (helo=mail-wm1-f49.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a97c2d2-195a-0a2a45060019-d1558031b446-3 for ; Wed, 02 Sep 2026 08:31:46 +0200 Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-49b9320423cso6190745e9.0 for ; Tue, 01 Sep 2026 23:31:46 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48448e72df2sm4531177f8f.1.2026.09.01.23.31.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Sep 2026 23:31:46 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1788330706; x=1788935506; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=SLQw4AZiW0xGo4eY+c2v6v3KWBjjDDtH8z6OZdHRa/4=; b=NPWsEPp9kIoikqvRgHzf3qgd3+AZd43HATQTrprd1mDHUGxxT/MBezdc5+YwNx+pmn FllsT9O+CYCOYjfpVvPBKf8RdjIw8BsOiKevObyNMbPxt3hpXCONF4m1/nh5N/QbOByt dLyZ8AcDoaeS3tcAELmIRqAgxgk8PtcPz6GSe8hIcDIZ0ZFlgaLsq6SAopteKxFirezK CeuJZC/fPDxJ9rO7oNu7po2OgrXjj5V7WSkBq1YdOUZ9xyt4OmqPhBa8zN01uo5Gq5Tf 0fiXe7pBFKavR535aNBvie+sgK27SM7IaLqZ7e4jAdWeSho2+nu07K/JJktESH6HPzof D5lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788330706; x=1788935506; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=SLQw4AZiW0xGo4eY+c2v6v3KWBjjDDtH8z6OZdHRa/4=; b=Prt+3R/8Bs9oCBLWqMuWTXw5f3O5uEf6eT1hxD/GhAmJFsFee7w3+H/zAexaSQKWvl HvEEV1lyRmtpDZXfJcMepfI5ZHSxVeBYDFb8a+z9sYRxL9nnSIH1nOKVWrid5ql+6arG m/0W3jKyNR2ctGuYj967aJVAWPuWjfKrrYNq3T4axI64wz37nB7EpygE/E7/o9uA9PTf hoPlwNoqbIjvNyJgOvy4eZUpBDnj0vrOpHWSal4i+yiCRH8eSLfluW2yR//Dr07P7ZDA UwasxMV0stYyGoElj26/pI6otqkM0mrL0gz/PCuS9RHgu8BRMZSfnTTXD36QiEKAqYHi l3Zw== X-Gm-Message-State: AFuF++m6MGuBZWVOYtlMx8A0Nr+paHDI7FfHz2X5DZYEzIHx/1BUm6nv qs0db29/wOQmZnf3HdbyxXP6Dkqp3+VPWzLqU3NBW5EGsnG/eqjPmlv5YtRcAPybQwGzxB8oCaO /YFxLFg== X-Gm-Gg: AR+sD11uMm07MquNZ3Zb5dPPfUFaQSVor9mDwmuMEoiCbunLglvDnoxycLZ7G7r2xFC euklJYYuEbDTalSI05L8Do/W6uos6U48R4OBs3K1VmkpB+FfWtRectmyCUIE6hmqhwes4ZMl/fV 8sgTE70owWzT3we2H3Uc5vI/9YCney5izk/A58l41gBUU0Mtd71qnPCUZb8052PaRnRCogfgnQS PjIizIWdp0AC9CaoSKzU6qTABwaWh4gcQlmi6mOihvxKKNTWkt9IBm0VB5SwUSQ6XM9qYmHMErj +81Vzm0/YiDsCSD84nIzGPT7IJCkypPC+uTn3rP345EDv8YOjka40XjYWqeIrpmkuH8zWIdtgt3 MurfC5Q5qbcAT4AG2jIs9Flg7MVoxwd0gtPsZ305ZJTPgO+/CI/dCCWiuwM4ci5eZGtTML/d87v EFuB0LpST939jTH/7XO9Owww20n6a2b1HDm4QlKvZSkmbqnJzGU9izHQ7eYMsEwsRR9ejk7Ge3c VUVLPvffTpCvzfEGcePY4pKIBw1r7JfZ9ls8JJfuLTEuG/qXido X-Received: by 2002:a05:600c:8b05:b0:498:943:ccc0 with SMTP id 5b1f17b1804b1-49ce5817bfemr48720775e9.6.1788330706300; Tue, 01 Sep 2026 23:31:46 -0700 (PDT) Message-ID: Date: Wed, 2 Sep 2026 08:31:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 04/14] x86/boot: don't cast away const-ness From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <0ff5676d-2ad3-49e3-a94b-90e7c3edb55f@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <0ff5676d-2ad3-49e3-a94b-90e7c3edb55f@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-16d1c6/1788330706-F540B77B-DCC2F386/0/0 X-purgate-type: clean X-purgate-size: 636 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1788330733937154100 Content-Type: text/plain; charset="utf-8" While the general C library strchr() has to do so, the early boot cmdline parsing has no such requirement. No functional change. Signed-off-by: Jan Beulich --- a/xen/arch/x86/boot/cmdline.c +++ b/xen/arch/x86/boot/cmdline.c @@ -77,12 +77,12 @@ static int strncmp(const char *cs, const return 0; } =20 -static char *strchr(const char *s, int c) +static const char *strchr(const char *s, int c) { for ( ; *s !=3D (char)c; ++s ) if ( *s =3D=3D '\0' ) return NULL; - return (char *)s; + return s; } =20 static size_t strspn(const char *s, const char *accept) From nobody Thu Sep 3 07:03:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1788330745; cv=none; d=zohomail.com; s=zohoarc; b=TEh6gDkCpeAhtZFu17WSiYD2CpLQHGayj4cveTZd9yAjPY7doOn25ilAwBgJkbfvg4XrP8qubbn+wtg+YtNACIkz07JO6GECDqmuVk1wbcNo7Ty0zZQmXbvgdtEycQ1tVAPlL/QpuX4oP0Aj74He7legN8b7b5JC0+qBzQTkT/8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788330745; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=FvD5+PYIvbWZ0qVpbaejKHF0dEio4ri6He7uleHAJAs=; b=dlm2xAX0Y56SFBgo6swgWNrdkK39O5+IXTQXa4rmEXUIf5Yo0DljCBPwmY5tLLJW9MOHJd6SZIV0Wll6bb3WFjWJJciwGXn5JRcz5JXS2KOPnTY8WoX3dDH7/biWKwstD5ppP3tPKdJPAnF7YV7LcKckwxxJQ/JBzNpzXFb9H4M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1788330745564787.3383257721667; Tue, 1 Sep 2026 23:32:25 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1405061.1638614 (Exim 4.92) (envelope-from ) id 1x1eW5-0004H3-7a; Wed, 02 Sep 2026 06:32:13 +0000 Received: by outflank-mailman (output) from mailman id 1405061.1638614; Wed, 02 Sep 2026 06:32:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x1eW5-0004Gw-3j; Wed, 02 Sep 2026 06:32:13 +0000 Received: by outflank-mailman (input) for mailman id 1405061; Wed, 02 Sep 2026 06:32:12 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x1eW4-0004FT-4K for xen-devel@lists.xenproject.org; Wed, 02 Sep 2026 06:32:12 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x1eW3-00AInw-HT for xen-devel@lists.xenproject.org; Wed, 02 Sep 2026 08:32:11 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a97c2e0-e002-0a2a0a5209dd-0a2a4502cee8-32 for ; Wed, 02 Sep 2026 08:32:11 +0200 Received: from [209.85.221.48] (helo=mail-wr1-f48.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a97c2eb-6ca4-0a2a45020019-d155dd30a9d2-3 for ; Wed, 02 Sep 2026 08:32:11 +0200 Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-48442ea8f59so1150042f8f.1 for ; Tue, 01 Sep 2026 23:32:11 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ce465161esm42964185e9.7.2026.09.01.23.32.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Sep 2026 23:32:10 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1788330731; x=1788935531; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=FvD5+PYIvbWZ0qVpbaejKHF0dEio4ri6He7uleHAJAs=; b=cOrB3LDLIQKfNA1Si+o8g1wKNIur0lQGT4z6h5+wnI+g+a3+8IHyI9nylKTWK0IDlI 6ITfuEY+CiJ9muMtXlcgskcDuX1jviMgJS23H0oTBoHm7uvYn/BNN6IrTpduDQbxZZaN m1A95AstT4jdrhzyj+QBawJouVG61j2NGGl8uDhImoEM29ue0Xa/QdfPABb1P/2AO1Bu 24wYB34wmYwAhZW1F7y7PlvMif7Nai/noU6Ce4VOxUlXChYac9sV9+9E4mJxSc/tm07k ClDvLsjuo+FYs7Du2vVqy5NzC0Pdoi3SG0KmGYuwTMhSGwW0IbYu4VxUJtAq/nsnzPQb g4tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788330731; x=1788935531; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=FvD5+PYIvbWZ0qVpbaejKHF0dEio4ri6He7uleHAJAs=; b=nl5wj9lWcygNCK6ES3J2nIKX5niozLVEZ7zrh/lcgwMefA3N5pR5F3eMjUJBkMDFz6 Bhjo1i70FW52/O5Ur0x+pVC5lNqvh4bBQQaLGAAA7M2vBJPc9LA1oRZXh73ijlngQQra mHMWMT9ReeDdhOgLHoSh7bo2n1B+Ra5u+dwkVjaeG+90V33B9d+Odc7HQVhda2N7Mzko Dm6aYVrAzBo77gJI/7vjFTI+PA6DDkP+LR3HlErU1ML9GfxxbInSUGQ+Gn4gMPbUvA7q ae6PSawodMF60c92DjQ5iG6sT2nuArGJDljjpJxzlBt28MQZynaRqxopvoOFR6rmtjMr yrNQ== X-Gm-Message-State: AFuF++kjZtjYVR5H0agv834UEpWfumanViYYIxzQGfVuhxIP7nZE4+Rn rWLMPpAefzi1bDmZoSReck648sUeiXJiG5+11X3Kff6RPhGfaKqjDp1WTSz33H0HHUKDkB+O+QG mtN5WOg== X-Gm-Gg: AR+sD120NmgWi/3/TL2bK26qrcdLTkuzd+WDZh44BH6UTih2xYWiOJo55Oz7VQsufgq 7Qi2lC3pqSeZg5ZnCh+0P/AHjTflzUvFmVH1Ll56L6HYZsUTmVDS8qkA8IPU4J6sPS1dwmcZbnY f5VXj9KoWxWB+8nhyGogZRi5KfvtMOyftiS5NX9HoqU9phjR5XrycRSUuovrhRuyWYyC7l7ONQO xbutGSwq6e4AI2HT5ytVuu2hx+UdWuQh8aaxXWIrSE0qKbrfS+iZPS9gVK4vc5L6FcscIUBXOB5 NB6KetYDpR6l7TGvSniY0NMEQnahPsHOOKlbwhZzn/7C90bwV3d1rMC65xGaQJttHOY+U507oqQ tFJKmf+8IVvT7ODHm/wG9Ghhzg/2z5Zmpv2a9r+x+4DAb3KRgSh2Tf1cm0+5OajqY3PWWpjMlbB aMA155n9ekSI8E41VO7unKs8g6uyhkpi2Yk8pvJI38oSvO2qMQQAl6W3STSRGW9bwOApLrCjy0h NKUWy/etWwWOc4psZD2RmJx/DJDCXubrrtL1PhwtFrSkGgof6UW0Ecm7OebZ+g= X-Received: by 2002:a05:600c:1553:b0:493:f783:c46a with SMTP id 5b1f17b1804b1-49ce7c27099mr9377965e9.6.1788330731001; Tue, 01 Sep 2026 23:32:11 -0700 (PDT) Message-ID: Date: Wed, 2 Sep 2026 08:32:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 05/14] x86/altcall: hide casting away of const From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <0ff5676d-2ad3-49e3-a94b-90e7c3edb55f@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <0ff5676d-2ad3-49e3-a94b-90e7c3edb55f@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-720697/1788330731-F30B02AC-19CA4EFC/0/0 X-purgate-type: clean X-purgate-size: 665 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1788330747687158500 Content-Type: text/plain; charset="utf-8" ALT_CALL_PTR() really means to get rid of const (when necessary, i.e. when used from apply_alt_calls()): We want to patch the original call site, after all, and memory-wise that's unrelated to the struct alt_call * that we start from. No functional change intended. Signed-off-by: Jan Beulich --- a/xen/arch/x86/include/asm/alternative-call.h +++ b/xen/arch/x86/include/asm/alternative-call.h @@ -9,7 +9,7 @@ struct alt_call { int32_t offset; }; -#define ALT_CALL_PTR(a) ((void *)&(a)->offset + (a)->offset) +#define ALT_CALL_PTR(a) ((void *)((long)&(a)->offset + (a)->offset)) #define ALT_CALL_LEN(a) (6) =20 /* From nobody Thu Sep 3 07:03:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1788330781; cv=none; d=zohomail.com; s=zohoarc; b=ctcbi8S5vMZezm3DDpT5zr+G+mkd8vQ0dVEguRae5pi9wKgCKcETe9jsrWt0jBVXiyaNFAQ1RUQG9h4whhWglsuOsNv+79ipQhHF69mRp0a97bQiQklp5UNPT1ysTH0VihKQGWepHucFVHHSdDe05GBh5u8igp8WV9OO6rjqV8Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788330781; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=IXAvx/vGULUwovSlnrWpyko7JV6p7KauR+GTHkHN/Os=; b=OdwDgruBRkKyAvuPR0IfNUovs1JzDx16mvcdm5HzxNUGLv6A1OAgd2OZ4U0vG37C3IIe2D3V8PmkadEV0f+UdSShZziUq3YwjMVs90x+kNLDRWomWpicw6peCXXmjK4VHF2XA3pB44Zpgl3KBXJEUrP9VL1E2ne9zyX+Rb1YMBU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1788330781845779.9248016963629; Tue, 1 Sep 2026 23:33:01 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1405069.1638621 (Exim 4.92) (envelope-from ) id 1x1eWZ-0004qr-Gk; Wed, 02 Sep 2026 06:32:43 +0000 Received: by outflank-mailman (output) from mailman id 1405069.1638621; Wed, 02 Sep 2026 06:32:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x1eWZ-0004qk-Dt; Wed, 02 Sep 2026 06:32:43 +0000 Received: by outflank-mailman (input) for mailman id 1405069; Wed, 02 Sep 2026 06:32:41 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x1eWX-0004qP-QZ for xen-devel@lists.xenproject.org; Wed, 02 Sep 2026 06:32:41 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x1eWX-002tla-7C for xen-devel@lists.xenproject.org; Wed, 02 Sep 2026 08:32:41 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a97c306-8faa-0a2a0a5109dd-0a2a4506a4e0-6 for ; Wed, 02 Sep 2026 08:32:41 +0200 Received: from [209.85.128.53] (helo=mail-wm1-f53.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a97c309-195a-0a2a45060019-d1558035c902-3 for ; Wed, 02 Sep 2026 08:32:41 +0200 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-49ccfbe062eso5068835e9.3 for ; Tue, 01 Sep 2026 23:32:41 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cdce10153sm133662375e9.4.2026.09.01.23.32.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Sep 2026 23:32:40 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1788330761; x=1788935561; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=IXAvx/vGULUwovSlnrWpyko7JV6p7KauR+GTHkHN/Os=; b=AeQ0noWdemhT3u5hnP8uNsQmTRQNA0jvndZJUqa95uWoE0IKNkdkMkbrl8jap227Ec 4eNaHGlrwuvSgGcuNZjvV5o4koLAtf9nJwKJGtJTcrsAcNs2a7aZAQ8pFsfkefOJCngq 9+UudeC9Rx7mTzLaY03qofA/Rk5j7mkByiw6cDVpVZnfXV8zeD6BfeeMtH3EpKZZOexD gA5wG/Ye7ElhTyQlbyt4YQyCXetqCduf3uQF29zeNlY1c4fFnXR2/Vm87f+GeucQa3v9 RFhMaPA62di6CdzWxkdFC8JWmIusfEdjSj1l0Vzgzk7V0h7iJrP07dzJFNqEBRD2bJO9 SXVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788330761; x=1788935561; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=IXAvx/vGULUwovSlnrWpyko7JV6p7KauR+GTHkHN/Os=; b=RVOM43Zg6jDF/UJgBCHXlRaCzFj7iny7BNmKmtWE1lho8s0xr3/UFy7NE+TimXHAU7 oHieXZ75P97+Q0u6VWhp8QKJIx4KhiIemYjBcDpz5MQruslLtQXJhBmzQfmXteur/urv B6+xcx14nWJ7LlPtjQJ/Cj9OoMOTid9eK9la0f3opzIiubdDvBycpMSLrrcKpacGUxNm LUgzwLp2vOLdX2RvRTfT7NBCZhYWJXC40cKszj7UyQnEs7HzLnQwpFAL9Ip3LyWIKMMl LmxtkRdOVti48QF6RgUAfUSpD23eGka6Q3ths7BefESzbtSZFPF0VZMtbFxhT5+Xcgbg q2zg== X-Gm-Message-State: AFuF++n/vBOSSTYeQRDUNATcWBmj0R+tOS1YmVtFhCPMejHqALGot+Yg sqbRXvT2EckiWdMgKSPOXYTc7cezOq4ONWVyzQYJ2PAOfTgD0Y3oI7d1DAx6SEDZyi0/v3RhLok MIsSBew== X-Gm-Gg: AR+sD13+n9qD1HRRS2zIEvrdnDWKn2lhJMkNRjJhiK/QNHhdlrFNTwdthGfGVW0jiJM 70dSXbmrJKSlqCgaACAOqzLbZxBRj8bnCNYf8oNuAGMrsNUfz2AgfVLj3x8mNTYZKcRTg0Nn7qL A0wg85wO2Dk2V2kM24RuN0vfKYRslULru8NBo4H94XJM/Xa4zO616kESLK+eIplDykyS5Z9HWRU 01iQucBY6/nLQadfmgOt/JY7gYS3LEdVphp+Ze1gKPluqDInWNBlJIYz0JAoa7qFt01e0ccABaT pSVuu0hNqyKhjWtYBcU7/WqNC4IW0S6nbMUDSpHWczYip5vbuFbcsMoqW6ASNErDPWzoHlVjBT3 iip5kR5qGh5FeHWl8vXtwxoJWO/TJXZT8Z4jfL2lhnQMq9vZ+gLMt3dy86EOYcJS1GszlG6YgqW 0ApX8QPPJA2pw7k8nqD3HEYZJNEZFOzpKrXXxAqPqMjIYj5uhEBfXQkG3dpUGZy3xn4+MAoUzdo VhbF0J+HqHNp31JY7w2psMpVhh5EzC8vBXJY+lpOkIr5HURiipG X-Received: by 2002:a05:600c:3496:b0:493:f5bf:4dc6 with SMTP id 5b1f17b1804b1-49ce57fb12cmr43745825e9.7.1788330760666; Tue, 01 Sep 2026 23:32:40 -0700 (PDT) Message-ID: <6b3a3849-304f-423b-a3c3-a614d83858c0@suse.com> Date: Wed, 2 Sep 2026 08:32:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 06/14] Arm/alternative: hide casting away of const From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Michal Orzel References: <0ff5676d-2ad3-49e3-a94b-90e7c3edb55f@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <0ff5676d-2ad3-49e3-a94b-90e7c3edb55f@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-16d1c6/1788330761-F4A0477B-1DF2EDA4/0/0 X-purgate-type: clean X-purgate-size: 608 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1788330782529154100 Content-Type: text/plain; charset="utf-8" We want to patch the original call site, which memory-wise is unrelated to the struct alt_instr * that we start from. No functional change intended. Signed-off-by: Jan Beulich Reviewed-by: Michal Orzel --- a/xen/arch/arm/alternative.c +++ b/xen/arch/arm/alternative.c @@ -134,7 +134,7 @@ static int __apply_alternatives(const st BUG_ON(alt->repl_len !=3D alt->orig_len); =20 origptr =3D ALT_ORIG_PTR(alt); - updptr =3D (void *)origptr + update_offset; + updptr =3D (void *)(long)origptr + update_offset; =20 nr_inst =3D alt->orig_len / ARCH_PATCH_INSN_SIZE; From nobody Thu Sep 3 07:03:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1788331268; cv=none; d=zohomail.com; s=zohoarc; b=AWJ6tNtpQAybcYCaivLPU8twzarOxVADe2pPxyilYvmyotyfC2o0DpdgJ6fFghR54HOJ8Mn7z2UHuzjPOAL99V8Z0qxqblbvVLkiUIgVzaxrKsmJBWCDgKQuvohFXoh5YDLpJx8FKPDMxtC1/HoHgqh26dc93zrb5HMsAFf92+w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788331268; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=rdPRqA6wEiNszUQj/y51xazgnGzZmRfdZpGOrsJoxyM=; b=KRmlZXKjSrGHVRRNB4+KnRTfYMPxG57xHOFVcCxSnnpvI1Ym2j5K5seQ+Itwrt/Tl9fVLJ+amEpPe5Ut7vvUBvEYnFqEccIKsfRpZDTWb2xyRBPZKa+4FJ/9ImaJDTbGwElNBtf/L7+/FRIs8j3J/3EmB6jnYHj0UerTN28v/j0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1788331268382654.4898601007867; Tue, 1 Sep 2026 23:41:08 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1405156.1638695 (Exim 4.92) (envelope-from ) id 1x1eeI-0002F9-SJ; Wed, 02 Sep 2026 06:40:42 +0000 Received: by outflank-mailman (output) from mailman id 1405156.1638695; Wed, 02 Sep 2026 06:40:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x1eeI-0002F2-Om; Wed, 02 Sep 2026 06:40:42 +0000 Received: by outflank-mailman (input) for mailman id 1405156; Wed, 02 Sep 2026 06:40:41 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x1eeH-0002Ew-SR for xen-devel@lists.xenproject.org; Wed, 02 Sep 2026 06:40:41 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x1eeG-00APjd-OX for xen-devel@lists.xenproject.org; Wed, 02 Sep 2026 08:40:40 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a97c4e8-e002-0a2a0a5209dd-0a2a45059dae-0 for ; Wed, 02 Sep 2026 08:40:40 +0200 Received: from [209.85.218.44] (helo=mail-ej1-f44.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a97c4e8-4cb1-0a2a45050019-d155da2cd407-3 for ; Wed, 02 Sep 2026 08:40:40 +0200 Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-c250f28f1cdso105502066b.0 for ; Tue, 01 Sep 2026 23:40:40 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48448e7315bsm4318538f8f.7.2026.09.01.23.33.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Sep 2026 23:33:06 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1788331240; x=1788936040; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=rdPRqA6wEiNszUQj/y51xazgnGzZmRfdZpGOrsJoxyM=; b=IPHWVm38xdol88QY5kHj2pwAn7Py2mTyXgqbii0nE31g5TCtONTbu0KQMiIpb/1gc4 EQtAH0QPvhEIot81+8mKIY0AiyqApKYYlOZ1mmc0UvRhho1/QEVJqjpZ8+wlDviXXCLQ uP0fn50RevlwgEzB56Km1ltZSV9On8t8FTl6nkk6iPccHp6ab5U+P6ETZwO3ZdrgT8Kt 8LreeScD8I6oe4Kw0+Jw+w5v3J92eYhbpXdOQKskqFSKJ0XSNGQfodC4FMfw/a2Km8eZ q7GYGdWV1cA2cR9FDYAz7qC4rpCnfeFQ0zi5Dpyq7Gt5Af6AFDztFiBjlhP0UJm7oNqb /Rmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788331240; x=1788936040; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=rdPRqA6wEiNszUQj/y51xazgnGzZmRfdZpGOrsJoxyM=; b=iz0iVx8wqiw9nbZhrJqifyV3/R4vu8tb3p6AiFQsUv/X5swYq35IRnC7tHNgXFrVUT 4XrRHti+88vX3H7dFTndEji0LEvHkEZyW9UM04If39IVImaEHDG8WMxNQvOZ9u+7tfFG 8eQWVbLUwehGZjun/x9TVRm+uvgxkpqDpyfpOuLVPfoIP2B6i2jb9JSV3vsQv6wX/b5W 0i2ytB9zZfZtpHJijAb0PG3gj+ILQATd7dMhQpwSxk0+HQ2uxcOgPIlyJKc08BExPkAr VtdTr/ljZxoUY4INZxgP5UzeAgcD+yJvqFcBvku2zaf1Jy06sn7y3fg7R4mTwFT36AwQ UA8g== X-Gm-Message-State: AFuF++n1OuD0W+CNYwYRcxUjftDy8r7W1eDrlZK+7VnBxzztdhC9D6n3 09yGeApYY+caRdbkVHVIZnj04/XkvVvnSCFAx2l0+PLBLaGqjYtQbGJPcRPtOVtwBS563Pckzjt XboYxqQ== X-Gm-Gg: AR+sD12lx4/BKKtLhE6Z73kwaqyNYuMOCQ+TVhghd/svfWlZpDEHmrsIwa5C+jZMc1h 0O7CABKa9149T/fUWO5VrhrfhVRZA6nHVT5haVzLC4xPBFmFtiKlW1fhNGWyDXkRBzAWJja+12h p5fe0dnd/1agXSqEzusNjES0p+jND/EnOnGD6c+Ynuqy9KGfOh0lI/COeWUEh3zEVMgzsp5fdRZ W2bEMpRoiuDEXGsseFBixB86vQUz+nKSWXrd7Dx8o/xW/YTW7Ev9j1C76NpeI5181QZFi9UTTTl 8Aw9dRqx33nPHen5uF94EX/nrAGi3nIiHTsGae0+jyRcK8H1QOzEqOya+afVcCNTv0XraMYwCcP Ru+fQfF35c+08eoORIh+K7W1pbrjaML6wcg/2FeohVHyfNTJVMUb2Dr2nCACbnLdAdH5HyYIKh5 aWtvQaUQLSoSyLCjCwUanHl1lHToWBwjcIX2kBpbxpD6TNAeMsSxLYDyZDkICNHFO8S/5kqAw44 bemllB4JqWtg4rbX2rTvP9172T7/UA8SfREeERPtDPYtxHr4NIr X-Received: by 2002:a05:6000:4901:b0:484:479f:4152 with SMTP id ffacd0b85a97d-484914bf9a2mr4793600f8f.23.1788330786845; Tue, 01 Sep 2026 23:33:06 -0700 (PDT) Message-ID: <9479d311-2449-441a-9855-66926dd8e0cd@suse.com> Date: Wed, 2 Sep 2026 08:33:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 07/14] Arm64/GICv3: have gicv3_its_find_quirk() not cast away const-ness From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Michal Orzel References: <0ff5676d-2ad3-49e3-a94b-90e7c3edb55f@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <0ff5676d-2ad3-49e3-a94b-90e7c3edb55f@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-c201ff/1788331240-732B32A1-185D5347/0/0 X-purgate-type: clean X-purgate-size: 773 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1788331269869158500 Content-Type: text/plain; charset="utf-8" Doing so violates Misra rule 11.8, while being entirely unnecessary here: All callers already store the return value in pointer-to-const variables. No functional change. Signed-off-by: Jan Beulich Reviewed-by: Michal Orzel --- a/xen/arch/arm/gic-v3-its.c +++ b/xen/arch/arm/gic-v3-its.c @@ -84,14 +84,14 @@ static const struct its_quirk its_quirks } }; =20 -static struct its_quirk* gicv3_its_find_quirk(uint32_t iidr) +static const struct its_quirk *gicv3_its_find_quirk(uint32_t iidr) { const struct its_quirk *quirks =3D its_quirks; =20 for ( ; quirks->desc; quirks++ ) { if ( quirks->iidr =3D=3D (quirks->mask & iidr) ) - return (struct its_quirk *)quirks; + return quirks; } =20 return NULL; From nobody Thu Sep 3 07:03:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1788330821; cv=none; d=zohomail.com; s=zohoarc; b=C52QysKNV0My0OGpHIIvG76q5yIJKdsGvK1uvSEtrXyZet2b3sEfhG+qHSISJv1zvu2V7T2dy7GPhTBs2AZzuuluSMcOdXtF4C8cLbMCatXy45Yl/2DNvfiyGNCAb+CwWmO9vpd7hVuZVa8e1PSwWkfXLMhjuenPq4K08IbsBR8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788330821; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=WsE0cG49Spb40SlFjalUjfTBIhzgLgv1Lpzf0EskD3A=; b=bXZJ1ZcsOYQv9kwWRMPcUmfhR2j8nA3Fv1VbEKL6h9z90K6/qgZbdwa8I4GA19w8dj6awN4Bh+KNRMqPLyGdzyWIEd/06ltCPAf0obJiqJVCa/e8XHpkmDlZl+r0cEwzUL4zE6Y+S/jVQi3wk6kwxFRdw02lcn4IDnOvPIUNl8o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1788330821428896.7212285149695; Tue, 1 Sep 2026 23:33:41 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1405080.1638630 (Exim 4.92) (envelope-from ) id 1x1eXK-0005Ok-OQ; Wed, 02 Sep 2026 06:33:30 +0000 Received: by outflank-mailman (output) from mailman id 1405080.1638630; Wed, 02 Sep 2026 06:33:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x1eXK-0005Od-LY; Wed, 02 Sep 2026 06:33:30 +0000 Received: by outflank-mailman (input) for mailman id 1405080; Wed, 02 Sep 2026 06:33:29 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x1eXJ-0005OJ-8t for xen-devel@lists.xenproject.org; Wed, 02 Sep 2026 06:33:29 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x1eXI-00Dz70-Lt for xen-devel@lists.xenproject.org; Wed, 02 Sep 2026 08:33:28 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a97c32f-8faa-0a2a0a5109dd-0a2a4505b27c-40 for ; Wed, 02 Sep 2026 08:33:28 +0200 Received: from [209.85.221.44] (helo=mail-wr1-f44.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a97c338-4cb1-0a2a45050019-d155dd2cc938-3 for ; Wed, 02 Sep 2026 08:33:28 +0200 Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-48441fa5c37so458406f8f.3 for ; Tue, 01 Sep 2026 23:33:28 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48448ed3840sm4273883f8f.17.2026.09.01.23.33.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Sep 2026 23:33:27 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1788330808; x=1788935608; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=WsE0cG49Spb40SlFjalUjfTBIhzgLgv1Lpzf0EskD3A=; b=bncEFbrULAX+rhh1SgplJfQJL5Yi14V2s+AbU/sPS9KCcn7fRzoiDiUxgPSRAPtbEq IcHO+CL0OGYxn4QlDU5VySq0Fh6j8pVfxpc5CYV0Ao2tlIrAlSbNOag9grN6zeqC6YQy NPLGX1v/0owfqLAOJ6b2fezyre1BRnBHTwF0F+IbPIhJ4Tublx0eyMJZEEhnxV19QoVi bt90QvcJaIHFWf6/NQmtvmiD/6Q5yEXYUjaHA9TexufiymBSNq3Nxk+wX8iHqpDbwg79 If8sU2nNFNJ9gFZUuDog4Nh9yH5B/zEvHTGwOAL4UI8uTvGmzCTZAlMzjoxajA88bm1d K4NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788330808; x=1788935608; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=WsE0cG49Spb40SlFjalUjfTBIhzgLgv1Lpzf0EskD3A=; b=rn1E15sG//lABz87voUoQecytkhIdocNQNOhejH/fQ5aVt9RbMdsNHpCR+MKIpGz5r e+wOjCFYhSakW8Qo5NKUINbKxywFG3MzI6qgUsMvzt/FBrtfTfAyTlYj6JIJK9kjp8+6 /iSvwQ8tIZhR3S3KxVAIzFvsc+K7L6byp4mHSsHmWJYUrXMNNhplL23oCEkkn7bG1jdM 3gy3EWdf1rkpZAeu5zUKNEevjaFYpcbh2XCaIJkHCq3zfNXrVGCI3z4umaCAoWIJ3n8q HRMXXDm2PKs9nhiuXwSj3FgvuQLC7MfpFFl5uYlzf12P3C+3Lojh/GGKXnMdKp2QOyYA 4MaA== X-Gm-Message-State: AFuF++l+gCaB+Uy8fEfeZ7qgvdL5TI8AkjRV1/rYS3jDtlwiXSHbdUum 4f7vtA1IMjzrDLql9RgfLoddyP00dc7tP8MvlMRw3jBuVECZ334J9hHWGVrL9XZwbo/DWI71x3u SKSN+OQ== X-Gm-Gg: AYBFou08LwOXqLuCaUjrJRWnUSu3++L1L7Iz/AGSLR6UrlFsVFe8j3iYyj2GH9oYz08 9wwpTUmwSzMzxMaUB02pMIrOIKiew/XEwBTShPW/AqeJdei68L81LrBFP3sAz5RKBDZ2+16h52o YWV3MZq4pE+73aDT+L7L6Y9wLMrLEBwlk+eNxyrKJRnuRUuSU2VjHjwBUSuHlgJw95gUpd353+/ B8XnUDHsJ02aHsw+uh9Uw+L1BbF5L67/XhB2vNUQli+XA1ZjvccWEouMOO0+YI+xb6hHSNzgSkZ KKGl3aV0IJyzO1sLmGjgBjY0NSMyb3XyR04t4vYjMI80SprD76qunA7CKLg0AVnvcWPZnYvcvHn 9UM7nYGe+nYULrro6aIBWQvAdll+PRH2lvo+nzH3ip2bz67+3PsqucWIgbgvBkpmuBrVGQJpP3W MoZxDLSxEr/xp4amgGgJbRoA0RokegXKqeU5eYNJgKQlU8xcMiI/3m3fktbz5GU+4zRawwmDKnB bSfzs8RLf0GpuuJuoFNGp/19LCRJbXmJ1Mc2jrTrzs+Rh9H/hmSFHIYFwX/pB0= X-Received: by 2002:adf:e18c:0:b0:484:41f5:5b0a with SMTP id ffacd0b85a97d-484914c1a64mr4079727f8f.28.1788330808052; Tue, 01 Sep 2026 23:33:28 -0700 (PDT) Message-ID: Date: Wed, 2 Sep 2026 08:33:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 08/14] Arm/guestcopy: deviate copy_guest() uses just like their x86 counterparts From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Michal Orzel References: <0ff5676d-2ad3-49e3-a94b-90e7c3edb55f@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <0ff5676d-2ad3-49e3-a94b-90e7c3edb55f@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-c201ff/1788330808-F56AD2A1-71FE91D4/0/0 X-purgate-type: clean X-purgate-size: 2262 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1788330823767158500 Content-Type: text/plain; charset="utf-8" Like x86/HVM's __hvm_copy(), Arm's copy_guest() is used for both to-guest and from-guest copying. Naturally in the latter case the hypervisor buffer needs writing to, hence the function parameter cannot be pointer-to-const. No functional change intended. Signed-off-by: Jan Beulich --- Of course for both the pre-existing x86 deviation and the new Arm one it might be more robust if the deviation was also limited to the respective source file. Can this be expressed together with the needed regex? --- a/automation/eclair_analysis/ECLAIR/deviations.ecl +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl @@ -433,6 +433,12 @@ Fixing this violation would require to i -config=3DMC3A2.R11.8,reports+=3D{safe,"any_area(any_loc(any_exp(macro(^co= ntainer_of$))))"} -doc_end =20 +-doc_begin=3D"Function copy_guest() in xen/arch/arm/guestcopy.c is a doubl= e-use +function, where the parameter needs to not be const because it can be set = for +write or not" +-config=3DMC3A2.R11.8,reports+=3D{safe,"any_area(any_loc(text(^.*copy_gues= t.*COPY_to_guest doesn't modify.*$)))"} +-doc_end + -doc_begin=3D"Function __hvm_copy in xen/arch/x86/hvm/hvm.c is a double-use function, where the parameter needs to not be const because it can be set = for write or not" --- a/xen/arch/arm/guestcopy.c +++ b/xen/arch/arm/guestcopy.c @@ -109,14 +109,16 @@ static unsigned long copy_guest(void *bu =20 unsigned long raw_copy_to_guest(void *to, const void *from, unsigned int l= en) { - return copy_guest((void *)from, (vaddr_t)to, len, - GVA_INFO(current), COPY_to_guest | COPY_linear); + return copy_guest((void *)from, /* COPY_to_guest doesn't modify */ + (vaddr_t)to, len, GVA_INFO(current), + COPY_to_guest | COPY_linear); } =20 unsigned long raw_copy_to_guest_flush_dcache(void *to, const void *from, unsigned int len) { - return copy_guest((void *)from, (vaddr_t)to, len, GVA_INFO(current), + return copy_guest((void *)from, /* COPY_to_guest doesn't modify */ + (vaddr_t)to, len, GVA_INFO(current), COPY_to_guest | COPY_flush_dcache | COPY_linear); } From nobody Thu Sep 3 07:03:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1788330869; cv=none; d=zohomail.com; s=zohoarc; b=VH31mk5At6ttbLdAnhlTEKSTf70vcKHly68oKSZbt6XYjRfCCp2KzKuNNEY8GV4x3QRnC6rtnSOdU3w/ZsfhUc6NqbBXngGv7sGuijOHbPwVUQeQk3Ico4T+uwaLXaoHiwzvZ0/4Up21piJt7zFzrJu41cNGSvn8O+/nffCRSho= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788330869; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=24jTXd7IeCDXlRGfWEqjcNP/1rsnFx4k/2yK1e1bOdo=; b=ObwUgkVcK5ihRqPmI/FSA2c7aMFhlLiEaB7vbuDg/lF5iuNuV0qvwiJiEXxVBUunp5UxmOsHfy88NbV6LySHhlUCwmFu46hPnX5ikf6xxBwPT9qNlPICA7yPzFoMZGshJ8t/4efehEHtGJf9JaBua1Q8YtI8tGWbTWd/CE0H+NQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1788330869911439.8404065402001; Tue, 1 Sep 2026 23:34:29 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1405086.1638639 (Exim 4.92) (envelope-from ) id 1x1eY1-0005sI-0Q; Wed, 02 Sep 2026 06:34:13 +0000 Received: by outflank-mailman (output) from mailman id 1405086.1638639; Wed, 02 Sep 2026 06:34:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x1eY0-0005sB-U9; Wed, 02 Sep 2026 06:34:12 +0000 Received: by outflank-mailman (input) for mailman id 1405086; Wed, 02 Sep 2026 06:34:11 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x1eXz-0005s1-Lp for xen-devel@lists.xenproject.org; Wed, 02 Sep 2026 06:34:11 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x1eXy-005yX5-Uv for xen-devel@lists.xenproject.org; Wed, 02 Sep 2026 08:34:10 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a97c35d-2eae-0a2a0a5409dd-0a2a45038600-26 for ; Wed, 02 Sep 2026 08:34:10 +0200 Received: from [209.85.128.49] (helo=mail-wm1-f49.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a97c362-fae8-0a2a45030019-d1558031d141-3 for ; Wed, 02 Sep 2026 08:34:10 +0200 Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4995b0343c1so6587415e9.3 for ; Tue, 01 Sep 2026 23:34:10 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48448e72df2sm4547374f8f.1.2026.09.01.23.34.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Sep 2026 23:34:10 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1788330850; x=1788935650; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=24jTXd7IeCDXlRGfWEqjcNP/1rsnFx4k/2yK1e1bOdo=; b=XiNITGlNNMzwI9V4myjEXTeVytpYgVBGDf8wNIEA3MP9Q6G9oqV/xN0czzAQzw1279 5zKhXPOkygQpEEnLbiH9s6iPRsNW6g5e8doaMZwdkeTnAlXNhW4dgPcYQuIAI86/APEP BwFQ5lMgg4dCdTyk5r9MPTeCPFmTbz5N9c5zDdB+UsyFolJBf1OOoCMHZgLI/0lNN8XA ULyj7FuFmf90OSWCimahWPuqNlQ0u0hCwoSWta5EHv065+2//SWv3jU905fIkfKOQk+S +tmbBeA7LCYeQN6sUi/tMrvr0gd4MkW7CHeSR7ht3AdQh8ibtJy9ku2pFefvoaRImXTY /v2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788330850; x=1788935650; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=24jTXd7IeCDXlRGfWEqjcNP/1rsnFx4k/2yK1e1bOdo=; b=jdbVrp3kotS7d0z+pGnkxxeFOsVdXI6SSEHJEtAZZ9kblRb9uYPf+BSlnBg6LXhd1f +3dMu5LnJcPIS+gKssvymT0sJ5/W1R2V47rZzgid+cvahYurL3L6+OSSIaR6+YFFIzlh 2z+ICqb3lEVVNN72v2xWIehfCuLL4Qi0AhA5emgoJ5cxxeiA4qcCix4AHXZMdO0zD0XN 8vgrTSdkftTLao9DWYr6kwez0ZTq1BicyM//tC0oXZj3e9xwnZ9Sz6znG8knceuYad1A 3svvFjFGMLcY2jva7jCX77qRkm+OSekLzUFxsJRBdcgOLzrqpbLyKFj06unarhDyFF7D 0dCQ== X-Gm-Message-State: AFuF++lU/U/dj417AUSAZsBcE3yzpwkAsPnlBlkPTTOSCaTLhWmaA+fD TXsXisCyf7N2bejLEFkLK8m1/vDQjgPA54wFBfrdpC/N9vY3J98bIyyonMcHAUEr8xiHmF1xEoY 2sA+RNw== X-Gm-Gg: AR+sD11RjT578q7FKMNbEt3FgJN4zY/S3QMZ6yWwHBub8IrD4AdGY67rO3rXMZM2f3m 97Opq7J41gG8gxbb1/gODbbGD96q4xnSOt11TjEOuNPrDQa77T4r3eFivjufCz7vKEWoca/LfAp x+NqXUE/9vVjAdDzLDkvcxgAlXcnJJmn8W30+G4te9Q8nj4w+EuQ1WkxLnsIPizeQR20FrzlhDw uIuyGNFyON9aqHmDEGBntCKElQA+aDPjj+8pGMR3C6mcKvrLrLtDFR4ph4LaZdvOu2Pl/Cira0A 9/ZMX6501VSxoQQhtAsTkQXHQgvGQCudPypXje2i//r3f5sSSlUnzqG0xBzC7giMdnbVSHeLca5 KbQT78n7BAoS//LzSoXHLKTULjiMYcTJgHOZhwuQZ5e4uS6CJ3z5vzRINDHfHtFa2tX6fXopXLv XJpWClYpehd+HfBN0DmnCcpfoPwNQAElSnCcxoQsDs32O8y/nMkP67bjSuY6BPVV+x5aHxpuyPI 0PscEqAu+an7Xjfe7N8/EPZqDCjNEwZIV9dou/MsioIjmBqVQBQlerQUUiEpcU= X-Received: by 2002:a05:600c:1da1:b0:499:9eb8:a1d7 with SMTP id 5b1f17b1804b1-49ce5842935mr48448965e9.9.1788330850372; Tue, 01 Sep 2026 23:34:10 -0700 (PDT) Message-ID: Date: Wed, 2 Sep 2026 08:34:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 09/14] ACPI: address a Misra rule 11.8 violation in Arm code From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Bertrand Marquis References: <0ff5676d-2ad3-49e3-a94b-90e7c3edb55f@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <0ff5676d-2ad3-49e3-a94b-90e7c3edb55f@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-33051d/1788330850-756834E9-659EB4D3/0/0 X-purgate-type: clean X-purgate-size: 1741 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1788330871982158500 Content-Type: text/plain; charset="utf-8" Outside of drivers/acpi/tables/ (which is excluded from Eclair reporting for dubious reasons), arch/arm/acpi/domain_build.c is the only user of ACPI_COMPARE_NAME(). Make the macro const correct, at the expense of introducing a "const" variant of ACPI_CAST_PTR(), and at the expense of altering an imported file. No functional change intended. Signed-off-by: Jan Beulich --- a/xen/include/acpi/acmacros.h +++ b/xen/include/acpi/acmacros.h @@ -103,6 +103,7 @@ * Pointer manipulation */ #define ACPI_CAST_PTR(t, p) ((t *) (acpi_uintptr_t) (p)) +#define ACPI_CAST_CPTR(t, p) ((const t *) (const acpi_uintptr_t= ) (p)) #define ACPI_CAST_INDIRECT_PTR(t, p) ((t **) (acpi_uintptr_t) (p)) #define ACPI_ADD_PTR(t,a,b) ACPI_CAST_PTR (t, (ACPI_CAST_PTR (= u8,(a)) + (acpi_native_uint)(b))) #define ACPI_PTR_DIFF(a,b) (acpi_native_uint) (ACPI_CAST_PTR = (u8,(a)) - ACPI_CAST_PTR (u8,(b))) @@ -116,9 +117,12 @@ #define ACPI_PTR_TO_PHYSADDR(i) ACPI_TO_INTEGER(i) =20 #ifndef ACPI_MISALIGNMENT_NOT_SUPPORTED -#define ACPI_COMPARE_NAME(a,b) (*ACPI_CAST_PTR (u32,(a)) =3D=3D *= ACPI_CAST_PTR (u32,(b))) +#define ACPI_COMPARE_NAME(a, b) (*ACPI_CAST_CPTR (u32, a) =3D=3D \ + *ACPI_CAST_CPTR (u32, b)) #else -#define ACPI_COMPARE_NAME(a,b) (!ACPI_STRNCMP (ACPI_CAST_PTR (cha= r,(a)), ACPI_CAST_PTR (char,(b)), ACPI_NAME_SIZE)) +#define ACPI_COMPARE_NAME(a, b) (!ACPI_STRNCMP (ACPI_CAST_CPTR (ch= ar, a), \ + ACPI_CAST_CPTR (ch= ar, b), \ + ACPI_NAME_SIZE)) #endif =20 /* From nobody Thu Sep 3 07:03:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1788330907; cv=none; d=zohomail.com; s=zohoarc; b=RK+zZL6CzznmgzOoIsJ7Z/M9TNPhfN8a6KVu+n1TNgOiQX4aCEsUwIawmoJsFylCMNImMpQ/siYPlGZakTdL1CXyc5m0F3qOD7tNUHvi6LDh3OzRjWcz3477gCw6lQGNF56lrBvyX+WM+hwfAC2sxadCXnfc3qNTuEdqYaSCHuw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788330907; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=4M7ZO90BkV+o7MOoEhTcnL8On+MmsrDJefwVfmLqVG0=; b=mFOJlJpYILyAU/8KIrBe0qHS2PC89+AxplnFgn7zGctIbkompNmc+3pfH1Rat8ZVKJrla6o/M9uxhnZBOxNsZXbToAM0/M4U6XzVfZY5htO7XfBVUNe/NGApLuvZFYy+0SKPIeQefHsYGDlUwDwfKNGgTRlHXp/81GCgInIf/EU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1788330907409949.5135090140008; Tue, 1 Sep 2026 23:35:07 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1405098.1638649 (Exim 4.92) (envelope-from ) id 1x1eYg-0006P6-9n; Wed, 02 Sep 2026 06:34:54 +0000 Received: by outflank-mailman (output) from mailman id 1405098.1638649; Wed, 02 Sep 2026 06:34:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x1eYg-0006Ox-6G; Wed, 02 Sep 2026 06:34:54 +0000 Received: by outflank-mailman (input) for mailman id 1405098; Wed, 02 Sep 2026 06:34:53 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x1eYf-0006OY-4V for xen-devel@lists.xenproject.org; Wed, 02 Sep 2026 06:34:53 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x1eYe-00AOt2-HT for xen-devel@lists.xenproject.org; Wed, 02 Sep 2026 08:34:52 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a97c386-8faa-0a2a0a5109dd-0a2a450388c4-10 for ; Wed, 02 Sep 2026 08:34:52 +0200 Received: from [209.85.221.49] (helo=mail-wr1-f49.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a97c387-fae8-0a2a45030019-d155dd31b190-3 for ; Wed, 02 Sep 2026 08:34:47 +0200 Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-484374f54d0so421653f8f.3 for ; Tue, 01 Sep 2026 23:34:47 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48448ee9cf7sm4347259f8f.25.2026.09.01.23.34.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Sep 2026 23:34:46 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1788330887; x=1788935687; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=4M7ZO90BkV+o7MOoEhTcnL8On+MmsrDJefwVfmLqVG0=; b=Jcf5lt7I0pywFWTZTdwXoYzOtjUMNO9JOtue6Uj/wfwVzGAIkD7qWEIC2P5qQ9hnuf 2Lb1r7Nv6bFpORP2wvH98pPE3PH2XDmylv81O+XEPF0nAqr/hmle/cR0va2MoPQH7JCX KAYQeIY+0po4vl8nZifN9/I7u3sM29B1dpz1cR67s0BJc/JfztNEnc/qrhXiorg+A8+T Y/RheTPASV6rBrm3sJtm3ttm0dFhaew2csfo+mXfIdpz8JWM3n7dGgB2hUxW6/Jvt1JR saymcwhrwk65rSn/eM570tMy8ouVl7eKNOec94DnJaM7a/L8SLGEBw3NLtUHy6dI77RP Ve3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788330887; x=1788935687; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=4M7ZO90BkV+o7MOoEhTcnL8On+MmsrDJefwVfmLqVG0=; b=tFWoaZoGw3CeJuULwFTwOv/LQVd0UNfKX1eeZZto+tJKH3x73ktx572NtxPjc35OE/ rpMQkbwpwQR0Y8GibCpH106XQ+2fZQlyrgmwbtVoLznOiYIePvjWLQO42v2MlJDDSjec DX44BwS78Xx7vq+pVHfl6M2G6dfKZO2xagDR2/bsYq7fPVIpdctFgsfo/OtkZVV4DgDd 9iRyJELDjEa/niv/fTJvak/TY20BqKrRuHxnM412vQLPyW6BittRKX8JWpuUKM3fKKsy g/h5ZNOwuaxZ8MLKFhbDE5eOtxIo1HT+uC6ruhrTlSL+NVisARw13VXMZau7zkeu3lXW bDzw== X-Gm-Message-State: AFuF++mEz4EQbHLo6MvvincoxnypCkhZFhaN2rnf4e241jPoizEmxe8K orRyykujefr34bdcuOgJQFJ5+M+CoDlx3CMOKsbcRzvzq9IsFzoFyFgKNW+iuq1WRLEnzULykNj TPGjvpQ== X-Gm-Gg: AYBFou2+jw0gbkybzaxmqdRJgR2mn60vKvEjknK62n6VHlnUrbzbOqOVVAVcZmt9hAh dQ6ttkh+RAW9/A/uqGEEMYhSSoUotRqDgzg3XyqbByuIW2DhTUmg//JEpAd8cviCcrAp6oa0rHU t4nZP8kBh4eBDP+p9dzNymTZR/kQCZIaEXah4x15rM0Hb7lhHTQYsHhQA5b+59eCVTwS17JSuAj 2ZEz5wTaLBpdQgSIaXHM+Jqxr9ankZ4TDfdCg0cEM4mg89OGOs+xakYbgD/+rzaH/2Lmd7Lm1ui q0dXTyztdXEO0OKWT9w8a6n0LSfHi/I2s55kyPXgrko57RDQnAICU5qBLtrIz1qlwXwU9un6RDq 6P+yi4HaetMQ0zDo+43UuW/QBxYaiJl0HBYX3yOmHKdU0FXnPWndVYNQyvMyfhPDH1AvoX7wKnS AxOLrYHlh1gpvIFbmsAV2GiLIsW8TeNQQ1yn2PJ10GUP2N5jCWvnScNbeedkvaGPaVdIQUw3nlD dId1bdpCOU0tGh6QoN5WYGWdtPkz/F0wYZXUUHKr7ErmqfxeFSL X-Received: by 2002:a5d:588f:0:b0:482:fbb5:8a74 with SMTP id ffacd0b85a97d-48488f032b6mr3872532f8f.11.1788330887011; Tue, 01 Sep 2026 23:34:47 -0700 (PDT) Message-ID: <8fe86787-7590-44f1-be4f-461b61d7669b@suse.com> Date: Wed, 2 Sep 2026 08:34:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 10/14] ELF/notes: use pointer-to-const by default in ELFNOTE_...() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <0ff5676d-2ad3-49e3-a94b-90e7c3edb55f@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <0ff5676d-2ad3-49e3-a94b-90e7c3edb55f@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-33051d/1788330887-758824E9-FA6350E7/0/0 X-purgate-type: clean X-purgate-size: 1311 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1788330910741154100 Content-Type: text/plain; charset="utf-8" Not doing so results in a number of Misra rule 11.8 (casting away of const-ness) violations. We need to allow kexec to use pointer to non- const though, so provide a means to override the default. For ELFNOTE_NEXT() we can do better and simply re-apply the type of the incoming pointer. Signed-off-by: Jan Beulich --- a/xen/common/kexec.c +++ b/xen/common/kexec.c @@ -6,6 +6,9 @@ * - Magnus Damm */ =20 +/* We're producing ELF notes here. */ +#define ELFNOTE_CONST + #include #include #include --- a/xen/include/xen/elf.h +++ b/xen/include/xen/elf.h @@ -29,9 +29,14 @@ =20 #include =20 +#ifndef ELFNOTE_CONST +#define ELFNOTE_CONST const +#endif + #define ELFNOTE_ALIGN(_n_) (((_n_)+3)&~3) -#define ELFNOTE_NAME(_n_) ((char*)(_n_) + sizeof(*(_n_))) +#define ELFNOTE_NAME(_n_) ((ELFNOTE_CONST char *)(_n_) + sizeof(*(_n_))) #define ELFNOTE_DESC(_n_) (ELFNOTE_NAME(_n_) + ELFNOTE_ALIGN((_n_)->namesz= )) -#define ELFNOTE_NEXT(_n_) ((Elf_Note *)(ELFNOTE_DESC(_n_) + ELFNOTE_ALIGN(= (_n_)->descsz))) +#define ELFNOTE_NEXT(_n_) ((typeof(_n_))(ELFNOTE_DESC(_n_) + \ + ELFNOTE_ALIGN((_n_)->descsz))) =20 #endif /* __XEN_ELF_H__ */ From nobody Thu Sep 3 07:03:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1788330934; cv=none; d=zohomail.com; s=zohoarc; b=e33qFKpgNwplsTlwbtC4tNbHNYdjJ6KKEIudzhQw8Y4uzWxKXJTnRoKgYDFO30z3o71KsDp8NQZKQuDhHMO5aRgkMO/Q9pjxEm9m8LihvUPdK5GACw99hPB8TM7S4t6oCr9/QbUWHQFONOqskfZCeEooKsy5KnG5TJWAhFGDEWM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788330934; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=boxk4p0eJVFYzZBGyHEQSWRcZFC+UVjv0HIaDcDz8xY=; b=gx3giDwwwE8BfpwWbMdmTfPbPFmo8VOn5p+13xUZ40FiRGU/ysKIp5ykXLY901E9cXfhi8JUiuv056Bdvv9etMUmmdezl5HsOKDgsKOr0jIAtpWmVF6VH08rOK8E2z/57xuKJABz2O5GbviJnv/8QGerbdmytwTikHmyCjw7dzY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1788330934978745.1705136412234; Tue, 1 Sep 2026 23:35:34 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1405103.1638658 (Exim 4.92) (envelope-from ) id 1x1eZ0-0006s9-KL; Wed, 02 Sep 2026 06:35:14 +0000 Received: by outflank-mailman (output) from mailman id 1405103.1638658; Wed, 02 Sep 2026 06:35:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x1eZ0-0006s2-He; Wed, 02 Sep 2026 06:35:14 +0000 Received: by outflank-mailman (input) for mailman id 1405103; Wed, 02 Sep 2026 06:35:13 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x1eYz-0006nC-7i for xen-devel@lists.xenproject.org; Wed, 02 Sep 2026 06:35:13 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x1eYy-00AOxg-Ka for xen-devel@lists.xenproject.org; Wed, 02 Sep 2026 08:35:12 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a97c36c-8faa-0a2a0a5109dd-0a2a4502edac-34 for ; Wed, 02 Sep 2026 08:35:12 +0200 Received: from [209.85.221.41] (helo=mail-wr1-f41.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a97c3a0-6ca4-0a2a45020019-d155dd29f1d0-3 for ; Wed, 02 Sep 2026 08:35:12 +0200 Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-482dd6ee390so675660f8f.3 for ; Tue, 01 Sep 2026 23:35:12 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48448ed30c0sm4313104f8f.24.2026.09.01.23.35.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Sep 2026 23:35:11 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1788330912; x=1788935712; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=boxk4p0eJVFYzZBGyHEQSWRcZFC+UVjv0HIaDcDz8xY=; b=CRqqb0fb89JAfPVPLS1KrLrdJRkATtJxDzN6/J0uhmkRy7qwWXFgwSw1ic5gumqSzZ IXrszCF3LbUZn3G+bTj7vO3sXKCJdTvo2zE4OCzN2psdQjSGk9HqSOLJQ6HqMhYhisW0 P+xjGMsQEB1FW9+C8oe4D+9RCELQBpvMd6n5h5wPPW7RVCEX7KtRhGIYgOerq6x3BtKb TZjbGcnyg37fMAJUimAWd7KqvLLOYNYpP7HWI3L78A9jyPSDTYdCk+8kJyfOlapSv+RO xIMAfZgKbqiLRTEo4Ufmty2u3ETjQhfykUbCitxXxLV9Pddiipr5+ton73wxq3C1x/lg 9lBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788330912; x=1788935712; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=boxk4p0eJVFYzZBGyHEQSWRcZFC+UVjv0HIaDcDz8xY=; b=BTk7AEed7Cs1SS7rwQ7evqm630t3Pc0hgFEiEFBcgWVOf/9LrWyP1+nfRv+F4eW91h xBFj4k/IE3Rujc5pvAoDYuTxI5aEU3eVP47pF91g9on6IVJ4F1rHEJp3b/oe5Z5y1nBc O6md+Jx+Z3JtbRwbO+W5Nkgo5WVVYPv699kFc1uAlmw3VLPW3AvAJ1QthZSLtroCWD39 7j4iCfg8iQAcwkaPW/sRInsQaSEYVc8j68ixwg9ELh+lZDnF7uje4t0Eb11amBz6zzwT vc6JIGtiZITYONqEz777X+h82XqqG+k5H17ua1PoPIcFCry2XsPES8uws+slSpW+pVED RTGQ== X-Gm-Message-State: AFuF++kwBXPlitypD1oFyJfxtNPVgQjw0QvxcA4zQiAgXwlpWXWWA5r9 xUQnYbL2s2+UTaRpfRQlBspqhgXCDVfb4UXsffHlkOt5nv7oWn75cS4AZ0onuEKRXlG79S/ceTl SIdHvBA== X-Gm-Gg: AYBFou2dIIKLVU1Ldyqbg83MDfm/kNowTPpkRbIShtsJZU6RkwC+ldtyZFporLKS6Sn 7PnDmjb7SO1p29Y7yn10T3NVJF4uMRy+DMrXe4SQ/BDEgoVW70G/ECRM30dTiQVZOqK0Ik/0Pis fwP3GafMhstfLZeHhwCzVD30aQrEUgEUNXaY5b00QV1KnU9mTBPhcB8OLupSFZW+KlovXy30wwY 7ec3RA6UyqlNaYsv8rwcLCwP2daGAEH7KdLXsHEbWQlDHI9yEnGk/Gj04yY2iTZ7zwbuYQOHXVe OGMx1bqUtUkz5KUYsWRPR0ez3/PPY8NLOV2y9cEn/aCTGSk+Ve/VCTfoj+BfODFiNHjEqIXxxvA 39LDnyy23ITLV/FJd2BHcZHGYXw0TI5gFNMUjGy12YxUgHGgOZAZTaVBEpprXs8QGfrJC8ZLU45 KylCXZ/woRe5Iglqpb7hjvdjFg+csCDdhaNlaYJxyvyDT5brUjhmjgOl38pZzJcxU+JHNNlF4y3 U0aRKnJFithRSoZK37trxR0T5gHSkqJew2XuyImvw22dSQzURZw X-Received: by 2002:a05:6000:40cc:b0:484:4880:449d with SMTP id ffacd0b85a97d-48488dee57bmr3688988f8f.3.1788330911990; Tue, 01 Sep 2026 23:35:11 -0700 (PDT) Message-ID: <1faace7c-2425-4691-b23b-3ffe033e5bc2@suse.com> Date: Wed, 2 Sep 2026 08:35:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 11/14] crypto/vmac: don't cast away const-ness in aes_key_setup() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <0ff5676d-2ad3-49e3-a94b-90e7c3edb55f@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <0ff5676d-2ad3-49e3-a94b-90e7c3edb55f@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-720697/1788330912-315CD2AC-90AEB312/0/0 X-purgate-type: clean X-purgate-size: 755 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1788330936753154100 Content-Type: text/plain; charset="utf-8" vmac_set_key() passes in a pointer-to-const, which has const-ness removed despite rijndaelKeySetupEnc() properly taking pointer-to-const. No functional change. Signed-off-by: Jan Beulich --- I was wondering whether I shouldn't adjust the adjacent aes_encryption() right away as well. --- a/xen/include/crypto/vmac.h +++ b/xen/include/crypto/vmac.h @@ -69,7 +69,7 @@ typedef u32 aes_int_key[4*(VMAC_KEY_LEN/ (u8 *)(in), (u8 *)(out)) #define aes_key_setup(user_key,int_key) \ rijndaelKeySetupEnc((u32 *)(int_key), \ - (u8 *)(user_key), \ + (const u8 *)(user_key), \ VMAC_KEY_LEN) #endif From nobody Thu Sep 3 07:03:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1788330963; cv=none; d=zohomail.com; s=zohoarc; b=CLYSZo9oy2YPMpFFBym/HCkWcvqH6/lq7NMgp6s4Oq3GLB1XvXcb18SjQ87FZU4+WdU6YHvaUnuZl1tHFoj9kZqdpt7K1aR/QHWge+9AIFzNpxuvBCnxQcvtku/YPU2ls4gzMrG07SWycDXIgCH1WKMxzN+oA4vSINZSGtr1SNk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788330963; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/ukptOfy7Urb2YHUd+l0+4nj0VI7QTd6I8HIWXBvIOE=; b=W5oNCUMAQNbhElinJben7Q1cB6C0+aX4OB4rWuHjMhdl1R7+RaLhXHSM4Sp91D4G3z7QrU0auZdSv4RIRBaNv3cH4ItmN1ISJOpqz9NdLy4/aCBVNdjjGoGjaF1iBK+7Iy79F409bXzA4Rc39PWp5OLjLGLCIj4m0Jbxsu1vuLI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1788330963454414.0797792935625; Tue, 1 Sep 2026 23:36:03 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1405117.1638667 (Exim 4.92) (envelope-from ) id 1x1eZb-0007S5-SI; Wed, 02 Sep 2026 06:35:51 +0000 Received: by outflank-mailman (output) from mailman id 1405117.1638667; Wed, 02 Sep 2026 06:35:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x1eZb-0007Rx-Oa; Wed, 02 Sep 2026 06:35:51 +0000 Received: by outflank-mailman (input) for mailman id 1405117; Wed, 02 Sep 2026 06:35:50 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x1eZa-0007RO-45 for xen-devel@lists.xenproject.org; Wed, 02 Sep 2026 06:35:50 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x1eZZ-005yng-H0 for xen-devel@lists.xenproject.org; Wed, 02 Sep 2026 08:35:49 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a97c3bb-8faa-0a2a0a5109dd-0a2a4501ba20-36 for ; Wed, 02 Sep 2026 08:35:49 +0200 Received: from [209.85.128.48] (helo=mail-wm1-f48.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a97c3c5-5984-0a2a45010019-d1558030e195-3 for ; Wed, 02 Sep 2026 08:35:49 +0200 Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-49cd9add88aso3818395e9.3 for ; Tue, 01 Sep 2026 23:35:49 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cdce3e0desm133583925e9.11.2026.09.01.23.35.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Sep 2026 23:35:48 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1788330949; x=1788935749; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=/ukptOfy7Urb2YHUd+l0+4nj0VI7QTd6I8HIWXBvIOE=; b=PPNFvwdz/X+dzzqQfrrr9SNTXTgOS0CznNcV71XIbPRwdf43B2q0rKJhRwogxv7NrV n9dzFk+OcXIJiotTXyFj331bSd38YUW9h1Rp586p+g6CTZM9bX9/SiUzptbIZMk45bXV KA23hAcDRoOP/y/Mz3u4I5LX5q+SvfhlPI0c257f16d++j5azGQqpHFRHi8So3DiH/ra 2kgmWWR7kLi03MODqOYeOaNVrOyuDnmmbo15qx86ggUDwRbwd/SfCNYdNW3RQKSXC6tp bReKZPJYYBTGmi8c9w7iQnMK+24R6pQykWHIXxiPFyPDXcdYyv6tUo49wvAtrQRKEuCz w53Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788330949; x=1788935749; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=/ukptOfy7Urb2YHUd+l0+4nj0VI7QTd6I8HIWXBvIOE=; b=efCrVp2VHt4QFVnRgzEPSnpplLRAKuwcGLnpl2gpev8kf4P35NQ0/wwPWulx1+Ah9z W14DPRs5oHHVI+c9M5rroNcSazLc9KfGsNCWaU415tD/QYxWQ+S9MCNEA2i+OKAn8eco utsGEO6Y9msiR3pJSxYFLje6wCyF0vMEvhWHQJZVpuY149+1rWFfnKLmZm+6uMdEFwfv YtJSoxsTb28LIfbQFlYyfIAd7BTlDkkPkPnUc3a3rdJW7FX0aGVxWOInpw2qo96VevgJ eBhfgF7SnP1gQQcWIy7jF6kzwDR8evV42OgD7L3Zn77z2uoP8GE/c9MXBD2bYNG+TyDI aRog== X-Gm-Message-State: AFuF++mgZ5T1ugWoDQxBktP3zTUdm7ryahiv6n+Ndht0C78+pqeTVlP7 RTsAABux8SES/PFa/FDJiyrYXVHV998WHgM+TYvF0Ur5o2l7TsKTxW53N7DfuxGZj63ScYMR3aI 7nz0z9A== X-Gm-Gg: AR+sD13nykA1D3hmgzJaAGpVJlDy1H1DS0v+JodFvdvjp6JiXL8PiGCNPEpav5LYS2+ QSEIefYOgalaU2dvLpHEV9um75Gt8YJEESnSd3tqklvUtdU9brSexVTcUPQuQ+vt2KCngSeH3CY pzYQM6mzubdWo3ePNwfEWDTm2yMUqb1r1wZRyJgMjwOtM4Wip5OJ+t4VWAxG8C/QLni/V9+Notp rRcRSDpAVc8wu3/Zp9wDRJwgce36nqrmhndjEMkkTRLUGlT8080Ch/KzYA6xl49urOwESB+Evii QmTZgKK8bsJpeTj1uNpJ9PTdpuUqC8eqcWv8hMHfyG2Ca3MfMX7bsj0mIF+T1926z6v/Rf/NeR/ d6iXCGdvk5v4HMPg1AtRRDoSNJBpPukghOuRUEepxJltB412zOn3IUZdwFUQjOC8SoZZ13utayX 1wZ+wX5P3HczxEeVa56TSDxJ91rqymlIcboJAYZKOnugACWcFSfKOWKDUVA6hDMVFug1ULPINwM eIHBUl5wFirRonM4xWhc7KDTW7fKeZM9iW0h0AsV8gRs3RkDIU7 X-Received: by 2002:a05:600c:37ca:b0:49c:cf18:494e with SMTP id 5b1f17b1804b1-49ce5819a2fmr46114605e9.12.1788330948918; Tue, 01 Sep 2026 23:35:48 -0700 (PDT) Message-ID: <1f55b457-c8cc-4ef9-ba5a-96e52b95fbbe@suse.com> Date: Wed, 2 Sep 2026 08:35:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 12/14] gnttab: don't cast away constness From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <0ff5676d-2ad3-49e3-a94b-90e7c3edb55f@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <0ff5676d-2ad3-49e3-a94b-90e7c3edb55f@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-d62444/1788330949-BF262757-518BC6AA/0/0 X-purgate-type: clean X-purgate-size: 1751 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1788330964436158500 Content-Type: text/plain; charset="utf-8" While _set_status_v2() indeed doesn't alter the grant_entry_header_t it is handed a pointer to, _set_status_v1() does. Drop the const from the parameter of the latter (and then necessarily also from _set_status()'s), while adding const to the local variable of the former. No functional change. Signed-off-by: Jan Beulich --- Really I think it would be best if we did away with the raw_shah local variables (which looks reasonably simple for at least _set_status_v2()). I'm unconvinced that we really need to use ACCESS_ONCE() here. Torn reads aren't a problem; what we require is that we look at a stable local copy, and that can be achieved by putting barrier() after the reads. --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -740,7 +740,7 @@ static unsigned int nr_grant_entries(str return 0; } =20 -static int _set_status_v1(const grant_entry_header_t *shah, +static int _set_status_v1(grant_entry_header_t *shah, struct domain *rd, struct active_grant_entry *act, int readonly, @@ -832,7 +832,7 @@ static int _set_status_v2(const grant_en domid_t ldomid) { int rc =3D GNTST_okay; - uint32_t *raw_shah =3D (uint32_t *)shah; + const uint32_t *raw_shah =3D (const uint32_t *)shah; union grant_combo scombo; uint16_t mask =3D GTF_type_mask; =20 @@ -909,7 +909,7 @@ done: } =20 =20 -static int _set_status(const grant_entry_header_t *shah, +static int _set_status(grant_entry_header_t *shah, grant_status_t *status, struct domain *rd, unsigned int rgt_version, From nobody Thu Sep 3 07:03:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1788331010; cv=none; d=zohomail.com; s=zohoarc; b=HqpLMfTZRiKjHhj0vYHDBp000zBR0ny6kvqeMdhkJMuxiHlhUywSFV0POfflrmqKt2CdadhMgWORi3geNmr/4IE4akgN2zo9XA5+92EZoenDp1x4cjFFZ/aymOA96h9RVaaiPbdYnoTaN5+uOvxqrm+g61bvedH0oDmKjPtvm1k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788331010; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=McMHeBsvsP9+2Amzdovql9JHeO48zwLTMwqVky0FzsI=; b=O57Kkmtxnupr6gEOliat+bE4D9EIoSAMiENJ3ha2ndZKt9dpSxqwuR2eYKJPBLtcbN3y3U++PLIP+cH47ddwLUR3hc1ZqmAhtf/0Wm4qcSrOGrQR2elU1pjQ5F4EPKUX+kn5ejjaSk7wEkDAyN7LiZFkdNJedtVaYCAtwoHrrCY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1788331010602327.02455628421785; Tue, 1 Sep 2026 23:36:50 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1405130.1638675 (Exim 4.92) (envelope-from ) id 1x1eaF-0007y4-2d; Wed, 02 Sep 2026 06:36:31 +0000 Received: by outflank-mailman (output) from mailman id 1405130.1638675; Wed, 02 Sep 2026 06:36:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x1eaE-0007xv-WD; Wed, 02 Sep 2026 06:36:31 +0000 Received: by outflank-mailman (input) for mailman id 1405130; Wed, 02 Sep 2026 06:36:29 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x1eaD-0007xg-F4 for xen-devel@lists.xenproject.org; Wed, 02 Sep 2026 06:36:29 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x1eaC-008Nhm-Rr for xen-devel@lists.xenproject.org; Wed, 02 Sep 2026 08:36:28 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a97c3e0-2eae-0a2a0a5409dd-0a2a4509bb86-36 for ; Wed, 02 Sep 2026 08:36:28 +0200 Received: from [209.85.128.45] (helo=mail-wm1-f45.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a97c3ec-be1a-0a2a45090019-d155802dd4f7-3 for ; Wed, 02 Sep 2026 08:36:28 +0200 Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-49954b88fffso4638525e9.0 for ; Tue, 01 Sep 2026 23:36:28 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cdce3e04csm117687405e9.10.2026.09.01.23.36.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Sep 2026 23:36:28 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1788330988; x=1788935788; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=McMHeBsvsP9+2Amzdovql9JHeO48zwLTMwqVky0FzsI=; b=UkuWBuVqIQqs4CK124QTWwtr+dxsefWKsXHCypBS0UgY+EXE26/KqcMOnUOO3X+DzY fz7rV5puIxoc4tFTYhBnh5FCKrdfcx44ZeyqJlul1EzeMrjWs845X7APxyamIj/Fe4Fm JQsElOFPTVm/Z0cxMCXRjziuLUfWQW+b+8gUopCf9qwP3stKw9dSmm6BhCGR5M6vfM44 mUuUOzvAhlzubbQ2Sd5fFmuFhldKLJ0zsjxPrynlQBzEjVvkryrjZXqBQGel6QgEHmdv FIdSgXDm6jRPC84umUVdtUSST11SvOBp0jol0MhUc4pdCdI+rGZGMieoVvHfSmURSbd6 tl/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788330988; x=1788935788; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=McMHeBsvsP9+2Amzdovql9JHeO48zwLTMwqVky0FzsI=; b=rIj7ZhdFQDkHvbaaNkA+LfmjdxHQSARMSueOg8bNJCgtSa2/uIbnDfywDad2BEo2TC Hj0m7loZvqJnW/n1NlTiQzF45FX/fBBuf9QE9aR5NQfsmWQn2j76Ge7loaQettIiM7qZ +Y6rvA82Bdl/KIOZt0r68D48Vdm5nTkyt3E42l8ZD19plR7EW0XaNfIFNvY1yIRHZMNO LXuUydESbrd2PCD1OhBi1soDSmZMVgZp2P6NzapC/TGaxLsM3F/DG+FdS3eDIDGbftK6 AVpnmeEDu6vmvnq9h9TTZMH5yyux95N0Fk1dgizdTg5jR6zNvP5r7689rwc7YgTmYZCF 2sEQ== X-Gm-Message-State: AFuF++kc99N17mWiWL3kOHesDfvsmcoGegydn3Ignl7npZ3Da8E3Pva1 0dCA+gxSF94IqJ18H8F3QBSJwDczMKzeET2oZJc40oDHsNA+tCO0yblO6BRSRRCDaOABr0D6LY7 vL6dIZQ== X-Gm-Gg: AR+sD10Glo5vBdi9dxnoRSXD5GNwvnFFtuI0W0Qnsgg4ZoflF6dnJln2X3v1J/9NYj3 JD+bP02n64jTUEHEOHGe3fgvDXrw4/MYn+44yQG5SAVUmqY17FhpTIpVTTMbaqwYLS8Gmuxu72T ARe4SKZSlmvNHSwqz5iB2k9Yq8ypA712uscUSfzKBdIUAAIGDtvVVZ7tIXR48y9EA4AQux133wr QHt+5zk8Nun0injZWt+izFvoBvZFicZSnyylR6n31W3cDTmSF5syb5UhpeeCMQy/3iouBJ2ti55 6/SxbVUSH4lxYGQS+ec9Td2BjYqXl0qFWngIejjt+83H5T43NxQ3pnXZ5tB7HuVeSwnIxw6PD/D mC7PIFwsw1T4b3biUahEMfiJVYNhp6/pfHmFRquOLdRt1gkSRxIkTBzIfKzFUPQx51IhwjKNGtf vHDj9nDTdif52raN+haMZGyXnyQw2zhihQlKBdvcvRs/fKQA3RUpWXiLuhVYM8TYgDUdywgSXwj O72UimGUxPznr2vXz0EPobnKXYsN85YiS82p7X1AFr+A1UhG5TT X-Received: by 2002:a05:600c:a086:b0:499:4892:d022 with SMTP id 5b1f17b1804b1-49ce580c170mr48931045e9.8.1788330988342; Tue, 01 Sep 2026 23:36:28 -0700 (PDT) Message-ID: Date: Wed, 2 Sep 2026 08:36:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 13/14] passthrough/PCI: rework (s,b,d,f) init of struct pci_dev From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <0ff5676d-2ad3-49e3-a94b-90e7c3edb55f@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <0ff5676d-2ad3-49e3-a94b-90e7c3edb55f@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-bad1c0/1788330988-3B0DD034-6F56138B/0/0 X-purgate-type: clean X-purgate-size: 2097 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1788331012656158500 Content-Type: text/plain; charset="utf-8" Right now we're casting away const-ness, to initialize the individual elements despite the field(s) being declared const. Eclair validly recognizes this as a Misra rule 11.8 violation. Hide this by switching to the use of memcpy(), deriving the destination address from the (mutable) struct pci_dev * which we hold in hands. No functional change intended. Signed-off-by: Jan Beulich --- Subsequently we may want to further leverage the sbdf local variable we now have in the function. Yet of course the primary question is: Is this an okay game to play in the first place? --- a/xen/drivers/passthrough/pci.c +++ b/xen/drivers/passthrough/pci.c @@ -318,6 +318,7 @@ static void apply_quirks(struct pci_dev static struct pci_dev *alloc_pdev(struct pci_seg *pseg, u8 bus, u8 devfn) { struct pci_dev *pdev; + pci_sbdf_t sbdf =3D { .seg =3D pseg->nr, .bus =3D bus, .devfn =3D devf= n }; unsigned int pos; int rc; =20 @@ -329,9 +330,15 @@ static struct pci_dev *alloc_pdev(struct if ( !pdev ) return NULL; =20 - *(u16*) &pdev->seg =3D pseg->nr; - *((u8*) &pdev->bus) =3D bus; - *((u8*) &pdev->devfn) =3D devfn; + /* + * pdev->sbdf is deliberately const, i.e. it can't be written by struc= ture + * or field assignment. Writing by memcpy() works, as long as it's not + * &pdev->sbdf which is passed. Since memcpy() isn't type-safe, have = an + * explicit type check first. + */ + (void)(&pdev->sbdf !=3D &sbdf); + memcpy((void *)pdev + offsetof(struct pci_dev, sbdf), &sbdf, sizeof(sb= df)); + pdev->domain =3D NULL; =20 INIT_LIST_HEAD(&pdev->vf_list); @@ -390,7 +397,6 @@ static struct pci_dev *alloc_pdev(struct phantom_devs[i].slot =3D=3D PCI_SLOT(devfn) && phantom_devs[i].stride > PCI_FUNC(devfn) ) { - pci_sbdf_t sbdf =3D pdev->sbdf; unsigned int stride =3D phantom_devs[i].stride; =20 while ( (sbdf.fn +=3D stride) > PCI_FUNC(devfn) ) From nobody Thu Sep 3 07:03:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1788331062; cv=none; d=zohomail.com; s=zohoarc; b=gcTSM2/B8Cxg1A3KrVGdjrVB2eu2YT2zhi5XxVAttqIrCxxhCv/1L2as8zypC95b9HBvsge97GZK0DoVEfcrHpg7y2H7xnwRN0dBkIg8Rj19lyN2hfx1IvdK7W/4m/e4yXlLjIpbOw3riDnJCvI3YVVzm7yV7NcDQJALgrGGLmo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788331062; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=VJtH51LzC3g8OlgK6LACaAIC7g20s+b/0wgQw5fmfdM=; b=bvaVRbqCsIkjtjcaM/yvLMkbi1ArUBqTMuf5Y/OFb0VI0VQHm5ySnZnr3SPZn99clPxVs5X0ds5xBUry3LfINBQNNPXxFGrbL6t5s+YJlwvMnMjmP8d6UIukoFDMXy1vZud5kTPYTfKMakAu4e/9bY7SKG5DeofL6ynCr//9ghw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1788331062226702.402696721307; Tue, 1 Sep 2026 23:37:42 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1405141.1638685 (Exim 4.92) (envelope-from ) id 1x1ebC-0008WT-Az; Wed, 02 Sep 2026 06:37:30 +0000 Received: by outflank-mailman (output) from mailman id 1405141.1638685; Wed, 02 Sep 2026 06:37:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x1ebC-0008WM-8C; Wed, 02 Sep 2026 06:37:30 +0000 Received: by outflank-mailman (input) for mailman id 1405141; Wed, 02 Sep 2026 06:37:29 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x1ebB-0008WC-1P for xen-devel@lists.xenproject.org; Wed, 02 Sep 2026 06:37:29 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x1ebA-001del-Dv for xen-devel@lists.xenproject.org; Wed, 02 Sep 2026 08:37:28 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a97c41d-e002-0a2a0a5209dd-0a2a45079154-44 for ; Wed, 02 Sep 2026 08:37:28 +0200 Received: from [209.85.128.48] (helo=mail-wm1-f48.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a97c428-b4ea-0a2a45070019-d1558030ec26-3 for ; Wed, 02 Sep 2026 08:37:28 +0200 Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-49b0d8bc2aaso5879815e9.0 for ; Tue, 01 Sep 2026 23:37:28 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ce7ac52c3sm11548705e9.4.2026.09.01.23.37.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Sep 2026 23:37:27 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1788331048; x=1788935848; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=VJtH51LzC3g8OlgK6LACaAIC7g20s+b/0wgQw5fmfdM=; b=f9I4i8IwZEKpAeg0nD7bfpLSye5SIzJ5aqlZwl8P2lpvfmWdc62M3F05IacotG7guS IT40Xxb7KNlRaSmgREiOpuKu/Y3GHiNp0UhjtERumdkJK6236AGNap1HDDsEhjFPqO5j YL29M2qO7vsQnPB/w5LJfV71p5H5ZX+zHyOOcd6J/5QJdc5pKRtJ01lIwroh+4eGUUmn P/+wZilUbzZjoEhfxFiKSgr5XuN8jVN86tmDIQqjWU1jTWgK7XNjo2P45y2DOZnzRTMY B409MD8PN+aqN5xr8i8/B1LYPBC0vO7iUe+rhiwTERTpb7iofjAyNF3RjCSyx41/hkp5 qj3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788331048; x=1788935848; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=VJtH51LzC3g8OlgK6LACaAIC7g20s+b/0wgQw5fmfdM=; b=TXvcNQWP+8jnVKltc98yC9p2qKMMz03vL7BmWA6PpPAcgHxsrWtKrUnklwzs0leSYe 26HXxd6NopDuXdBekJHLzVpB/0IomdsRclq3jdN48AuaRwOSLulpFIwghYWr2N+1srVw GEa1AVHi4dZmWeJLnb5cDbr5bDrP9Dq0na/PItwg0lj0dtTvzjtu8zYcgVRSZ0chKVm2 tjJI0K18p5/DxBqCQPbhdscaZF/r617A2zgJixaW4j/PyC+8A22Q3m0M3qrXMQT0+uwz m0EdZZw5c9NsRR9ThddlBBOkA09CVBT71SAcPjbDBrNCI+I9tAKzGaAa1MvNUnYcAlBo K5dg== X-Gm-Message-State: AFuF++mNsx3lIAGZEEa1tAqT/1vO2HoH2aZ9CyLqABmPD0lBYGYwXkr8 7B2PBYCqaTE/SDR8yxUoao7qyL5jOn+PWZDL4YWME5mddqBdlFH8HAu6B+ykQ9821rHI6LlvjuF P6ZfmJQ== X-Gm-Gg: AR+sD13g393kKgidTpD0ncQdA8GxYcHlTSb9rIKm3GcpDbgm/EOi6ky7yITHCO1/ijq t0+e0pj5cA6HXaJkI8hLGUnvRU7DxLF5eOTAxMdfc9WWJQHAim8STOo55vlvIJy2lSvYK5kquNQ /I0XZ9mvz/wmXBb6MFRalXHGh5oX/3YWL80Z3I4tVS41GTIvwrR8QBhZOtovxB9kZu9MJMaqRza S1Txwakoiouyvk4HZt+TDBqtgzdrj116Oc6TEOBE9wpsJMV1q2EcD69u52v+Np4iIgQGWBdmZEV VVXIQqyQLOXg2Y/yZlIdpfeu12lZcDzeY08gauKUD4OfBr+9J1iZeHeB9nlcmcrC3V+HecVhVYZ /HlStscsz2zYIjrWnqx/FdfjM9+j/Xsq0VMVeGlVcIQ3cPn3tu0Pkb9AIY/QmqnFX1dh/rTUPRu qIDVbefK6RwUj3AzgkbPupD16khWT11WImt4z6lE+ptq7njd34Da7xNrRFD2zPzSDX5yIAJLVsd qpASAJVq/SmwURKXh+C4Fy40g1VhbgbN8JnbL/dpTQpXNPN1OOF X-Received: by 2002:a05:600c:45c4:b0:499:79b9:e220 with SMTP id 5b1f17b1804b1-49ce5816186mr38862465e9.10.1788331047806; Tue, 01 Sep 2026 23:37:27 -0700 (PDT) Message-ID: Date: Wed, 2 Sep 2026 08:37:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 14/14] xhci-dbc: don't cast away const-ness in xhci_find_dbc() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Nicola Vetrini , Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Marek Marczykowski References: <0ff5676d-2ad3-49e3-a94b-90e7c3edb55f@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <0ff5676d-2ad3-49e3-a94b-90e7c3edb55f@suse.com> Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-ef75cf/1788331048-35EC6AE4-BFE21905/0/0 X-purgate-type: clean X-purgate-size: 992 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1788331063020158500 Content-Type: text/plain; charset="utf-8" Doing so (at the return statement), besides being a bad idea anyway, is a violation of Misra rule 11.8. Make "xcap" have an initializer while adjusting the code anyway. No functional change intended. Signed-off-by: Jan Beulich Reviewed-by: Marek Marczykowski-G=C3=B3recki --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -384,16 +384,15 @@ static bool __init dbc_init_xhc(struct d */ static struct dbc_reg __iomem *xhci_find_dbc(struct dbc *dbc) { - const uint32_t __iomem *xcap; uint32_t xcap_val; uint32_t next; uint32_t id =3D 0; - const void __iomem *mmio =3D dbc->xhc_mmio; + void __iomem *mmio =3D dbc->xhc_mmio; const uint32_t __iomem *hccp1 =3D mmio + 0x10; + uint32_t __iomem *xcap =3D mmio; const uint32_t DBC_ID =3D 0xA; int ttl =3D 48; =20 - xcap =3D mmio; /* * This is initially an offset to the first capability. All the offsets * (both in HCCP1 and then next capability pointer) are dword-based.