From nobody Thu Oct 30 22:42:12 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1760601544; cv=none; d=zohomail.com; s=zohoarc; b=MNlAFx/4g74JvZV2lM9lL740/fQ1NGbKRkLgoegvTaiGx0cxPhbMo35uWk9vG109OfuvPT+jwCtC5Mcrh10SI5cqGhczTOaEFtochONc7cNlREQGuVih90x45TVcc07euFudrfp8AjaUVJl07VFMv3E6PgmzH3U8ZmsdVPHq710= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760601544; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tDSXv59rmnY3eFBJLiKKPItBMr1pT4qTxAqiGpWveBs=; b=QLxVg0bmPYknu1rJOQ7Vvv2k8EcKh6/58MBW/33hdNrAoUhjzaFhgMeF/G8pReihzOOrmYSO/hEttRQme+7TRwdtX5KlD4pzNt0N0MfTWTl4/4YPut+41OiwPb1la76dD4xNfZf4fgMz7DT1RZf3TQTbVGdYzCa1BqRdQaY0K4k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1760601544023826.6288249836302; Thu, 16 Oct 2025 00:59:04 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1144296.1477742 (Exim 4.92) (envelope-from ) id 1v9Isw-0008Lx-2N; Thu, 16 Oct 2025 07:58:54 +0000 Received: by outflank-mailman (output) from mailman id 1144296.1477742; Thu, 16 Oct 2025 07:58:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v9Isv-0008Lk-Vu; Thu, 16 Oct 2025 07:58:53 +0000 Received: by outflank-mailman (input) for mailman id 1144296; Thu, 16 Oct 2025 07:58:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1v9Isu-0007Us-Rt for xen-devel@lists.xenproject.org; Thu, 16 Oct 2025 07:58:52 +0000 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [2a00:1450:4864:20::42e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f3fb4046-aa65-11f0-980a-7dc792cee155; Thu, 16 Oct 2025 09:58:51 +0200 (CEST) Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-426fd699c21so157050f8f.2 for ; Thu, 16 Oct 2025 00:58:51 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-426ce5e0e70sm32738788f8f.40.2025.10.16.00.58.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Oct 2025 00:58:50 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f3fb4046-aa65-11f0-980a-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1760601530; x=1761206330; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=tDSXv59rmnY3eFBJLiKKPItBMr1pT4qTxAqiGpWveBs=; b=R4md+T6VMyZBgaS2w7Omfau5G1l7svoBZEjTAMlX4tLXBl72zxyzmB7HbphmZ51nRA OVf2IeOQigRSzfh4A+kdFrCACYlc5hJEluxtwvB7ub23AWsgYtPfzSwwAhOSdYnvEh8O AqCr9O8WwKS8+Zg6BAAwNA3n6YiFvBbkDHV9IXtnhaqJihbb1YiBpGWrcee9sjnaFKa7 K/vUpSbvgkb7tOX9AOV8UnzL3xkeouXmPyah6Hx79xmZcnobSFskgh9hmL1kwQ5t/GRN QkBSikrAMhKHf9+OjUVBm3uhV0cje+tRiAlnf0bDsi1JWTfnDtEjllzKCRm38NzeamMi dt8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760601530; x=1761206330; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tDSXv59rmnY3eFBJLiKKPItBMr1pT4qTxAqiGpWveBs=; b=PYzfVrpC80JaUj3CeRRqEUtQhuBm7+nqS7XyusQuUEtIsEZR9CgoG8CkuB6gnRitUn 8wHG5t0yGRl9p8tlNV1iyPshRjXyX0K2Nf2SuCHAFbNv4fiA+UcgScnL3iYn+v6dCqvL GsybzWWm0HRIACSINUv0DD21W/977jZN4mVAX0j2j/iOmg4Nr9wjO9ZsEQsb9nFqYvaj 4n2nl83wJXqlDTVLjc0vzpWraNYhKcmcxw2bt3w7BIY8s8ncDKcAFuv2Dp3J/s+Fe+z1 XHhIkD9PwuwF79hxAyBSEszqrDn8CzXRgpEGyybaeWfjCtW1RL+mmThemDKDfF3K8L2h Sm2w== X-Gm-Message-State: AOJu0YyzTedj9keVS30jsxaJjLao6581OOQ706nGjE2mVnABj4gOCZw5 Yo7YXzrz9PSCmz3a/l89nLwUW2+vQMhe7Yz1WPhjRx3DTugoOsFPNJ8VGJp8KmGcsg+qMHQpYma Y08U= X-Gm-Gg: ASbGnctUh8Hvv1RU6EtektL6LKCm6x93NeIbApo9LN14lszdX7twl0qeJXvCL+sO6o1 0DEd8dq+BRleLo4xUaEFryCo2Z33+s2dop6YS/lIpOyaVcT9xWFHyEgS2Jn6l6o94ziXDPNHgWK NAwStJmLF0Gogiq/SQrzx6VZDZn2vaJ0BOhdf2E4jKsKCo+2I6Hg39ELZTFvZKUn0sRlJSBH07k 1+624p+fDNT3wqbUUqdAa23KhLPPXKtMp81kJCMWidSWwnKD2D3Dp1B/Qz7huBriw/wfWZ5GtuS dPaZWMVqSrmWW9agxuQy6MgjxI7xS1kpUt3nE7c8H9tv+1HBfFOEszfZkDGUJlF96ltTrAo1lwD AY4BdNdZ07BNxziMUt3/rzil1+oWcYd2iiDXD2NO8F8KbAoFFQ0CWFiQTCEieWv3ulpjulgyFsG GPe+Pg9qFhrwVjwLWIjgglytKjC9AlhYYb5gAKVrRdWoo5VDhkWzBvho/n3Vrt X-Google-Smtp-Source: AGHT+IGcRBu76B6Wg223k3baLc6M+EgVt6AtOXLOFBFTSXc/7pYD9COKGaG7j/HYvw4hsdhXspGm3Q== X-Received: by 2002:a05:6000:1887:b0:3eb:8395:e2e0 with SMTP id ffacd0b85a97d-4266e8de16amr19822072f8f.51.1760601530592; Thu, 16 Oct 2025 00:58:50 -0700 (PDT) Message-ID: <0f9f55eb-ebf5-4f4e-a989-132a2066ad14@suse.com> Date: Thu, 16 Oct 2025 09:58:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 2/3] x86/vLAPIC: drop VLAPIC_VERSION From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Andrew Cooper , Grygorii Strashko References: <37ba42d2-c89a-4c19-a1d8-b4a9c32f677a@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <37ba42d2-c89a-4c19-a1d8-b4a9c32f677a@suse.com> Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1760601549635158500 Content-Type: text/plain; charset="utf-8" In preparation of making the value somewhat dynamic drop the constant. Replace its use in guest_wrmsr_x2apic() by actually fetching the LVR value. Signed-off-by: Jan Beulich --- v2: Use MASK_INSR() right here. --- a/xen/arch/x86/hvm/vlapic.c +++ b/xen/arch/x86/hvm/vlapic.c @@ -31,7 +31,6 @@ #include #include =20 -#define VLAPIC_VERSION 0x00050014 #define LVT_BIAS(reg) (((reg) - APIC_LVTT) >> 4) =20 #define LVTS \ @@ -1015,7 +1014,7 @@ int guest_wrmsr_x2apic(struct vcpu *v, u case APIC_SPIV: if ( val & ~(APIC_VECTOR_MASK | APIC_SPIV_APIC_ENABLED | APIC_SPIV_FOCUS_DISABLED | - (VLAPIC_VERSION & APIC_LVR_DIRECTED_EOI + (vlapic_get_reg(vlapic, APIC_LVR) & APIC_LVR_DIRECTED= _EOI ? APIC_SPIV_DIRECTED_EOI : 0)) ) return X86EMUL_EXCEPTION; break; @@ -1439,7 +1438,9 @@ static void vlapic_do_init(struct vlapic if ( !has_vlapic(vlapic_vcpu(vlapic)->domain) ) return; =20 - vlapic_set_reg(vlapic, APIC_LVR, VLAPIC_VERSION); + vlapic_set_reg(vlapic, APIC_LVR, + MASK_INSR(0x14, APIC_LVR_VERSION_MASK) | + MASK_INSR(ARRAY_SIZE(lvt_reg) - 1, APIC_LVR_MAXLVT_MASK= )); =20 for ( i =3D 0; i < 8; i++ ) { --- a/xen/arch/x86/include/asm/apicdef.h +++ b/xen/arch/x86/include/asm/apicdef.h @@ -15,7 +15,10 @@ #define GET_xAPIC_ID(x) (((x)>>24)&0xFFu) #define SET_xAPIC_ID(x) (((x)<<24)) #define APIC_LVR 0x30 -#define APIC_LVR_MASK 0xFF00FF +#define APIC_LVR_VERSION_MASK 0xff +#define APIC_LVR_MAXLVT_MASK 0xff0000 +#define APIC_LVR_MASK (APIC_LVR_VERSION_MASK | \ + APIC_LVR_MAXLVT_MASK) #define APIC_LVR_DIRECTED_EOI (1 << 24) #define GET_APIC_VERSION(x) ((x)&0xFF) #define GET_APIC_MAXLVT(x) (((x)>>16)&0xFF)