From nobody Thu Apr 2 06:11:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1774870521; cv=none; d=zohomail.com; s=zohoarc; b=hXmokOYoR4jItc6r8HqXTGK/eCupWG8ZZ3r50KHLsDdQ+DyjkRBPzlnWNyJ2Vntfk8u454M/wZU9mNdUszeNqYcShf1MJMsqFetXmvNN5qeMDlkBnKa5DPZhjHeuLKaq2Na2BbBJhAScrSONRo4wf30ECrSxywYksZndDKyw0Vs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774870521; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=CXRCZYhfiOXMyDaM8umPhi6xsmZXvlmdqNRfyyJ8Sho=; b=lI5zWmCwfBRfR1L+ZpTCfFWEAYC5jIGUPgsuavD6ZpQlttL8kq8BAgmYPFFs+ZNyk03ve6a/AsvtJ+3pIdtQ+4IPjkx4I6OZs0/kab8EeXxLqr0aN9sgEe+sT2sloMqvZ1wE9N6WRaCDp8L+fDw9LlEwzJUX4v0b80VCH3cauBU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 17748705219221015.313133053678; Mon, 30 Mar 2026 04:35:21 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1267434.1556923 (Exim 4.92) (envelope-from ) id 1w7AtX-00052l-7d; Mon, 30 Mar 2026 11:34:59 +0000 Received: by outflank-mailman (output) from mailman id 1267434.1556923; Mon, 30 Mar 2026 11:34:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1w7AtX-00052e-4k; Mon, 30 Mar 2026 11:34:59 +0000 Received: by outflank-mailman (input) for mailman id 1267434; Mon, 30 Mar 2026 11:34:57 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1w7AtV-00052Y-NZ for xen-devel@lists.xenproject.org; Mon, 30 Mar 2026 11:34:57 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1w7AtV-00GKjD-3S for xen-devel@lists.xenproject.org; Mon, 30 Mar 2026 13:34:57 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 69ca5fcf-e002-0a2a0a5209dd-0a2a450689e8-38 for ; Mon, 30 Mar 2026 13:34:56 +0200 Received: from [209.85.128.53] (helo=mail-wm1-f53.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.55.2) (envelope-from ) id 69ca5fe0-3034-0a2a45060019-d1558035ac48-3 for ; Mon, 30 Mar 2026 13:34:56 +0200 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-486fb439299so39840755e9.0 for ; Mon, 30 Mar 2026 04:34:56 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48722c9506dsm263601925e9.7.2026.03.30.04.34.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2026 04:34:55 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Autocrypt:Subject:From:Cc:To:Content-Language:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1774870496; x=1775475296; darn=lists.xenproject.org; h=content-transfer-encoding:autocrypt:subject:from:cc:to :content-language:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=CXRCZYhfiOXMyDaM8umPhi6xsmZXvlmdqNRfyyJ8Sho=; b=bjmRlY2TzjmYlTZjLRv7B9h/SiO/xcSrUVJZoPIv/u8RjhRqXGtOsnHyMIQVGMenjZ kjbGwRM9Sk2NXN1bOQRhQ3WswXsNbzF79RlOzcnZY98buwnpW3OExbi8M6d0lIj3kXeh XCqDxtORql1VPTIeBxIy4ReXsebcWtP+ZBcmH81FGM8OxrCQMDk9SxozwRi2qZ8oHR1W ljg3Vg+mcR/efIHgersVgctKqNybnlHJj5VqQZ82+2fPZhzdiG2i8Sp789cMvelBrCwT Sj+c+Vutlu7pgwXlXNff4l2TMqz7SOsGB0hnolrRoiwlVdTdY/a+IK3iuZ0LJgUxAyBZ qP9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774870496; x=1775475296; h=content-transfer-encoding:autocrypt:subject:from:cc:to :content-language:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CXRCZYhfiOXMyDaM8umPhi6xsmZXvlmdqNRfyyJ8Sho=; b=ZfdZt1F4q60oXA4ooeztCWhlAeH3Kb24gUkIUxpvJF8iNUi+MqXWF1sllfnV7X2RSS tGS+4W/AIzEiKCKb7atte9Nk4IhkZWnY70ZUIwQeckOaasJfvaYs4Xk/hfOAGYVcdk/U nU8kpSkFWBGmUJg32KkZXZWOHNnp2W3DXK7O1pa78jatpJQoZDliw70sSb43B1mLo36l BR2cmTJ8OigCDjsbRLnSgljLJfl1f6EoCtPD3SA1fEkxmxlJHxmiqtixfqzQhkVd2nik ZyxZgbv6NLCb/cSKIZZ+ffBDuDv7B4Uoq5ztNTQaAxeYg7aCViDf767aSVtEhLdX8H5H sqLw== X-Gm-Message-State: AOJu0YzBHB0e1ZDp9aB2lTSck/e/sHkIkwAOz5corHr8ox07K30yVMrZ rCrEp1fwmISILVGXDGDyiFbc0ptlaKRU0nrOHW3gFf32c5riJTm4nRo++IHgXPoRAHp8iQR70bB v+tmn/A== X-Gm-Gg: ATEYQzwuUhCawkpLyrtssmjf+If55m36McAzU3W8+1m99YlIB7jPA6XyD6YIty9Ij6W K89YfJYvmLoCw0rBAlaC/GUWG5MLcJFoG/CDxL00+zMLgHUHC7CgPYLvlAhbEgOkG6RLt1k0Tr3 OU8HHTy9pSnf8HIRJc7pNTVMKve0s0R5UhGjvnmsgnXZDU9Crt3FkKWtITWsAaMmlGSMDIeDJhY Evh8V7gMIBnfJcvBDYwpLLkywp9wuGz92fNxqRFnBvvGLSu4hpFTSW99yt6ZhM1Ifm9AM7tpRtH UtVadPCKQdaEw1l1k4T0fJARSzvmEAOUbQbf09zBOB8aW17y8a95ynl3aERIMhQCmINu0XNEK0t gmhg73DjKfyowxUYdGxD4LHvD9cODHWqusgKT4DhD6MTLgwzG5mG6ONrcuZP9X9yuw1rMkSPZ9x L7jLbqMlY8rNRSkrC/B/N6+tcm+M2SdbG1ie+7QjbSC/sYRfDGEXE8oH/2SGpRjaXkyM9f84OV5 1fM8KYAEtGYXWqvJJ653/F9IQ== X-Received: by 2002:a05:600c:4743:b0:485:3d3e:1675 with SMTP id 5b1f17b1804b1-48727f0e5c7mr185765645e9.8.1774870496365; Mon, 30 Mar 2026 04:34:56 -0700 (PDT) Message-ID: <0ba80bf0-e786-4e17-936c-0b769194d369@suse.com> Date: Mon, 30 Mar 2026 13:34:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= From: Jan Beulich Subject: [PATCH] common: move safe_copy_string_from_guest() to lib/ Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-16d1c6/1774870496-785811C2-5C26E525/0/0 X-purgate-type: clean X-purgate-size: 1720 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1774870523896154100 Content-Type: text/plain; charset="utf-8" This function is unreachable on x86 when XSM_FLASK=3Dn, and it is another good candidate to put in an archive. Signed-off-by: Jan Beulich Reviewed-by: Michal Orzel --- I question its behavior: If the guest supplied string isn't nul- terminated, imo the input shouldn't be treated as valid, i.e. no nul should be silently appended. This would then also eliminate the order-1 allocations which will result here if exactly PAGE_SIZE input is provided by a guest (all callers passing PAGE_SIZE for max_size). --- xen/common/Makefile | 1 - xen/lib/Makefile | 1 + xen/{common/guestcopy.c =3D> lib/guest-strcpy.c} | 0 3 files changed, 1 insertion(+), 1 deletion(-) rename xen/{common/guestcopy.c =3D> lib/guest-strcpy.c} (100%) diff --git a/xen/common/Makefile b/xen/common/Makefile index dac8b711cdd3..6018e256147f 100644 --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -16,7 +16,6 @@ obj-y +=3D event_2l.o obj-y +=3D event_channel.o obj-$(CONFIG_EVTCHN_FIFO) +=3D event_fifo.o obj-$(CONFIG_GRANT_TABLE) +=3D grant_table.o -obj-y +=3D guestcopy.o obj-y +=3D gzip/ obj-$(CONFIG_HYPFS) +=3D hypfs.o obj-$(CONFIG_IOREQ_SERVER) +=3D ioreq.o diff --git a/xen/lib/Makefile b/xen/lib/Makefile index dcef1610b2a3..933f6d96fbb8 100644 --- a/xen/lib/Makefile +++ b/xen/lib/Makefile @@ -6,6 +6,7 @@ lib-y +=3D find-next-bit.o lib-y +=3D generic-ffsl.o lib-y +=3D generic-flsl.o lib-y +=3D generic-hweightl.o +lib-y +=3D guest-strcpy.o lib-y +=3D list-sort.o lib-y +=3D memchr.o lib-y +=3D memchr_inv.o diff --git a/xen/common/guestcopy.c b/xen/lib/guest-strcpy.c similarity index 100% rename from xen/common/guestcopy.c rename to xen/lib/guest-strcpy.c