From nobody Fri Oct 31 11:35:14 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1751399698; cv=none; d=zohomail.com; s=zohoarc; b=kYjDVL5bJFvQacMm22PPcr0qe/btUvVf8szjqIPoSTiFJhkgpn/uUpSbH2m+VkzvV3sViKmORp87HbRnlv4dNQyG76XvZAwHgTiCqhOwQJFVKQl9PATIxCbyOwBDromwRgggeos98ePQSKVnyKZjDMh+KM37BqO92ETg2iepkzQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751399698; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=hCdCFUU01yaVxgQDnPyQnDx1XPvODNjjRXJBKjo5xuA=; b=nsw+Uez5jDxqB4us5yipkoTLk7Rhd9RKwEWLa/EMPcNvn8QwyQy9I/F7n1k+KGtyQgUqBH7thAmNGA9rc2/Gc5hMlLUZExkSitgA25Zs2BEfCm70Ftq6l+NhIerOa6x6LOg57dXXbaac6HRnB5mGjUE6DrIp6i+dWI9FzMWAG5I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1751399698839887.4645014339212; Tue, 1 Jul 2025 12:54:58 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1029944.1403662 (Exim 4.92) (envelope-from ) id 1uWh3z-0000SP-7y; Tue, 01 Jul 2025 19:54:43 +0000 Received: by outflank-mailman (output) from mailman id 1029944.1403662; Tue, 01 Jul 2025 19:54:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uWh3z-0000SI-3y; Tue, 01 Jul 2025 19:54:43 +0000 Received: by outflank-mailman (input) for mailman id 1029944; Tue, 01 Jul 2025 19:54:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uWh3x-0000D0-TE for xen-devel@lists.xenproject.org; Tue, 01 Jul 2025 19:54:41 +0000 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [2a00:1450:4864:20::42e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3958c4d4-56b5-11f0-b894-0df219b8e170; Tue, 01 Jul 2025 21:54:40 +0200 (CEST) Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-3a4eed70f24so821012f8f.0 for ; Tue, 01 Jul 2025 12:54:40 -0700 (PDT) Received: from lab.home (dynamic-2a00-1028-83a4-4bca-c0bb-96ff-feed-9d50.ipv6.o2.cz. [2a00:1028:83a4:4bca:c0bb:96ff:feed:9d50]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a88c7e9d1csm14291644f8f.13.2025.07.01.12.54.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jul 2025 12:54:38 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3958c4d4-56b5-11f0-b894-0df219b8e170 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751399679; x=1752004479; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hCdCFUU01yaVxgQDnPyQnDx1XPvODNjjRXJBKjo5xuA=; b=Txw33WL1Il2ssqtj0mX/lGxwnnThK6h2dCal0vg0B7C7gFjocxTH9JhdsBsqb4hB0O P+Ib7fGAVAy/AddmYmZesPQu4dgKl7Ejo+AMwwlfPMLKkcHnTDZJiF8W+ZRrgM010awC XtSuFC79ZGcbGYHK8cTty1/jjCGkAZVcsIkdyp43LGAlsgPAmpN+PQHfpvSBwxpi+FPM jO4qRHrDo+amVEWp4reO1OzlPq8f+mVHTZ6gwlz28GpZqrv7uvngkv456T+W2JvyydQg fXhceC5S8/r9+x0uZnnsENip36IgxRTYyJw1aCj0wavjD/XGcD9idzcHpPosQuk/egLe GHEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751399679; x=1752004479; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hCdCFUU01yaVxgQDnPyQnDx1XPvODNjjRXJBKjo5xuA=; b=BQZiANnWSp6y1Psfd9Ih7QlNqbscJPmEBuCFU0C7tNwZDc4MoSdtmFJfY3cphHcHyv MMn1QXyxLa2LuAhzTUWoMTv13SN42+rFYOwHlnuhKZS4+2g2uvZH05LUq7xcwwHXFBAZ EdEM1Rsx0tLmOrTeRJ2B3KToHWNS7Btj8OFcERAcbYstEJ7TbZarggvzhmgdSJ2K2Fnb h8/v4L5+gvI4854JisCTZ5jDzdc8JmWsvFwKlBtQnQbuqU5SdoImt4OhIud17Iqq+/kj Dj7SCdLnmA3QW2iUXpJqsWpKFvspCfr+5rssh5grSc/U6AUlaFRoxn7n0a3HZLGe5MW7 jc3g== X-Gm-Message-State: AOJu0YxBS6tqu0dxftnRnxeSBBvmJlIruuZJQQK5drn5GNyHmh06XlBx SLFuyAa5N2YpR8OH91uHghvPezXyAAtQnHiT7orBzkgyxsdQfcsaNcqz2wmXCg== X-Gm-Gg: ASbGnctmch2h4Scv0yhevUMteEh5X60PhfbIJuXPnTky1XBeRIFmqJflVG4iN4+onSf Qk/aHsVHYF1Nm48TRG4pNYAKPpFnFFF5TmQQ6pM8xiclcD1RdeUXtgmlsd202r/bNiqX0QrM2DY BJbc0EQldXCEmSFn92mGWaRLU0yKOezl8ldNLz92xx+USguMUthTJ1MhDlYU+J8GC62c46UiPuz sUwv/N5HjFACWJ+4qY+CFHtLeeArOe9MJvYtPYxJMraJTrWay4rUjNUoTAcjIv3aTlOEY6fa8PC Hxj2Nu69v5XyvJAoODIpk3LSfvX1xxbp5EL8WcmmN0khsu4TyDVaJZM6XO/v6YJoTCiqJVmKsLU siruhxLl14yE+WL0CRXcZ/ciuFDFX7xm9sYoZGjgu3WomAUglHPbNRozTZ67+wwlFHfvLGgBI X-Google-Smtp-Source: AGHT+IGqy9WvmFoV4PCqeXPzzqJMJQX/mH9EUd2EwPVh3v1Bx49gZZ64DKvi6qWmziv3UlU1jzFqTw== X-Received: by 2002:a05:6000:2082:b0:3a5:3369:391c with SMTP id ffacd0b85a97d-3af23ad0719mr1593821f8f.1.1751399678973; Tue, 01 Jul 2025 12:54:38 -0700 (PDT) From: "=?UTF-8?q?Petr=20Bene=C5=A1?=" X-Google-Original-From: =?UTF-8?q?Petr=20Bene=C5=A1?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Petr=20Bene=C5=A1?= , Nick Rosbrook , George Dunlap , Anthony PERARD , Juergen Gross Subject: [PATCH v7 2/7] tools/xl: Add altp2m_count parameter Date: Tue, 1 Jul 2025 19:54:24 +0000 Message-Id: <090b27895506d78055d1bab9c2b3617e85f389c6.1751397919.git.w1benny@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1751399700611116600 From: Petr Bene=C5=A1 Introduce a new altp2m_count parameter to control the maximum number of alt= p2m views a domain can use. By default, if altp2m_count is unspecified and altp= 2m is enabled, the value is set to 10, reflecting the legacy behavior. This change is preparatory; it establishes the groundwork for the feature b= ut does not activate it. Signed-off-by: Petr Bene=C5=A1 Reviewed-by: Anthony PERARD Acked-by: Nick Rosbrook --- tools/golang/xenlight/helpers.gen.go | 2 ++ tools/golang/xenlight/types.gen.go | 1 + tools/include/libxl.h | 7 +++++++ tools/libs/light/libxl_create.c | 9 +++++++++ tools/libs/light/libxl_internal.h | 1 + tools/libs/light/libxl_types.idl | 1 + tools/xl/xl_parse.c | 9 +++++++++ 7 files changed, 30 insertions(+) diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/h= elpers.gen.go index 191be87297..515a6ef10a 100644 --- a/tools/golang/xenlight/helpers.gen.go +++ b/tools/golang/xenlight/helpers.gen.go @@ -1167,6 +1167,7 @@ if err :=3D x.ArchX86.MsrRelaxed.fromC(&xc.arch_x86.m= sr_relaxed);err !=3D nil { return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err) } x.Altp2M =3D Altp2MMode(xc.altp2m) +x.Altp2MCount =3D uint32(xc.altp2m_count) x.VmtraceBufKb =3D int(xc.vmtrace_buf_kb) if err :=3D x.Vpmu.fromC(&xc.vpmu);err !=3D nil { return fmt.Errorf("converting field Vpmu: %v", err) @@ -1695,6 +1696,7 @@ if err :=3D x.ArchX86.MsrRelaxed.toC(&xc.arch_x86.msr= _relaxed); err !=3D nil { return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err) } xc.altp2m =3D C.libxl_altp2m_mode(x.Altp2M) +xc.altp2m_count =3D C.uint32_t(x.Altp2MCount) xc.vmtrace_buf_kb =3D C.int(x.VmtraceBufKb) if err :=3D x.Vpmu.toC(&xc.vpmu); err !=3D nil { return fmt.Errorf("converting field Vpmu: %v", err) diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/typ= es.gen.go index 656933c6c9..1a4f076bd2 100644 --- a/tools/golang/xenlight/types.gen.go +++ b/tools/golang/xenlight/types.gen.go @@ -604,6 +604,7 @@ ArchX86 struct { MsrRelaxed Defbool } Altp2M Altp2MMode +Altp2MCount uint32 VmtraceBufKb int Vpmu Defbool TrapUnmappedAccesses Defbool diff --git a/tools/include/libxl.h b/tools/include/libxl.h index a8704e0268..d6b6e5d2dd 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -1257,6 +1257,13 @@ typedef struct libxl__ctx libxl_ctx; */ #define LIBXL_HAVE_ALTP2M 1 =20 +/* + * LIBXL_HAVE_ALTP2M_COUNT + * If this is defined, then libxl supports setting the maximum number of + * alternate p2m tables. + */ +#define LIBXL_HAVE_ALTP2M_COUNT 1 + /* * LIBXL_HAVE_REMUS * If this is defined, then libxl supports remus. diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_creat= e.c index 8a85fba1cf..acf7fd9837 100644 --- a/tools/libs/light/libxl_create.c +++ b/tools/libs/light/libxl_create.c @@ -421,6 +421,15 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc, return -ERROR_INVAL; } =20 + if (b_info->altp2m_count =3D=3D LIBXL_ALTP2M_COUNT_DEFAULT) { + if ((libxl_defbool_val(b_info->u.hvm.altp2m) || + b_info->altp2m !=3D LIBXL_ALTP2M_MODE_DISABLED)) + /* Reflect the default legacy count */ + b_info->altp2m_count =3D 10; + else + b_info->altp2m_count =3D 0; + } + /* Assume that providing a bootloader user implies enabling restrict. = */ libxl_defbool_setdefault(&b_info->bootloader_restrict, !!b_info->bootloader_user); diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_int= ernal.h index 75bb0b94cf..2a5b233caa 100644 --- a/tools/libs/light/libxl_internal.h +++ b/tools/libs/light/libxl_internal.h @@ -111,6 +111,7 @@ #define LIBXL_MIN_DOM0_MEM (128*1024) #define LIBXL_INVALID_GFN (~(uint64_t)0) #define LIBXL_VGA_HOLE_SIZE 0x20 +#define LIBXL_ALTP2M_COUNT_DEFAULT (~(uint32_t)0) /* use 0 as the domid of the toolstack domain for now */ #define LIBXL_TOOLSTACK_DOMID 0 #define QEMU_SIGNATURE "DeviceModelRecord0002" diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_type= s.idl index a3a79d12b2..fe251649f3 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -731,6 +731,7 @@ libxl_domain_build_info =3D Struct("domain_build_info",[ # Alternate p2m is not bound to any architecture or guest type, as it = is # supported by x86 HVM and ARM support is planned. ("altp2m", libxl_altp2m_mode), + ("altp2m_count", uint32, {'init_val': 'LIBXL_ALTP2M_COUNT_DEFAULT'}), =20 # Size of preallocated vmtrace trace buffers (in KBYTES). # Use zero value to disable this feature. diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index 7e11c62ba0..28cdbf07c2 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -2099,6 +2099,15 @@ void parse_config_data(const char *config_source, } } =20 + if (!xlu_cfg_get_long(config, "altp2m_count", &l, 1)) { + if (l !=3D (uint16_t)l) { + fprintf(stderr, "ERROR: invalid value %ld for \"altp2m_count\"= \n", l); + exit (1); + } + + b_info->altp2m_count =3D l; + } + if (!xlu_cfg_get_long(config, "vmtrace_buf_kb", &l, 1) && l) { b_info->vmtrace_buf_kb =3D l; } --=20 2.34.1