From nobody Tue Nov 11 08:31:25 2025 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1569426648; cv=none; d=zoho.com; s=zohoarc; b=EEXOV2J9GQbFDCIEmh09Q7huFJ6KoG8rSLDnX3/4V84uEwyFcjxdbsax9x1lIh+W6RRdhFntyI8j0XTf/4Hp4JZEyVKG1YU4hWm4SjJ+NNiGN3vZLWpOx7KVbFbo0S5Pv58X8PHQuiPSQbu2xZyjGqB72z+J9jI2XeeWnyBUYXs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1569426648; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=mnZT/yXDQ9w9rZxpUEApADPHtPkTA7y7wZ2/DO72Lhw=; b=fxMTZjkMWoic4iLbOuWAKHse0LNL8RyroxQuH9S2QoagSvUZ4sCU5QMWarawXiRl1rPdolIAABgOBJCVO4EWiIXoT+6PiWwR1H+cfuF0vo1D1nhyoA8fpZUS5fmXH2wFXCHgkswB6r7Ib2UqKjGRlBliLn68FKTG6AWjVy1l7tg= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1569426648075117.60603148535006; Wed, 25 Sep 2019 08:50:48 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iD9Xp-0000mg-Oc; Wed, 25 Sep 2019 15:49:33 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iD9Xo-0000mI-TW for xen-devel@lists.xenproject.org; Wed, 25 Sep 2019 15:49:32 +0000 Received: from mga12.intel.com (unknown [192.55.52.136]) by localhost (Halon) with ESMTPS id 0f5c2020-dfac-11e9-9637-12813bfff9fa; Wed, 25 Sep 2019 15:49:30 +0000 (UTC) Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2019 08:49:28 -0700 Received: from tlengyel-mobl2.amr.corp.intel.com (HELO localhost.localdomain) ([10.252.129.153]) by orsmga006.jf.intel.com with ESMTP; 25 Sep 2019 08:49:27 -0700 X-Inumbo-ID: 0f5c2020-dfac-11e9-9637-12813bfff9fa X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,548,1559545200"; d="scan'208";a="193812624" From: Tamas K Lengyel To: xen-devel@lists.xenproject.org Date: Wed, 25 Sep 2019 08:48:39 -0700 Message-Id: <07b30029c26f90d292d05d2e28944d9034f27fa7.1569425745.git.tamas.lengyel@intel.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Subject: [Xen-devel] [RFC PATCH for-next 01/18] x86: make hvm_{get/set}_param accessible X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Tamas K Lengyel , Wei Liu , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Currently the hvm parameters are only accessible via the HVMOP hypercalls. = By exposing hvm_{get/set}_param it will be possible for VM forking to copy the parameters directly into the clone domain. Signed-off-by: Tamas K Lengyel --- xen/arch/x86/hvm/hvm.c | 169 ++++++++++++++++++++-------------- xen/include/asm-x86/hvm/hvm.h | 4 + 2 files changed, 106 insertions(+), 67 deletions(-) diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index fdb1e17f59..667c830db5 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -4054,16 +4054,17 @@ static int hvmop_set_evtchn_upcall_vector( } =20 static int hvm_allow_set_param(struct domain *d, - const struct xen_hvm_param *a) + uint32_t index, + uint64_t new_value) { - uint64_t value =3D d->arch.hvm.params[a->index]; + uint64_t value =3D d->arch.hvm.params[index]; int rc; =20 rc =3D xsm_hvm_param(XSM_TARGET, d, HVMOP_set_param); if ( rc ) return rc; =20 - switch ( a->index ) + switch ( index ) { /* The following parameters can be set by the guest. */ case HVM_PARAM_CALLBACK_IRQ: @@ -4096,7 +4097,7 @@ static int hvm_allow_set_param(struct domain *d, if ( rc ) return rc; =20 - switch ( a->index ) + switch ( index ) { /* The following parameters should only be changed once. */ case HVM_PARAM_VIRIDIAN: @@ -4106,7 +4107,7 @@ static int hvm_allow_set_param(struct domain *d, case HVM_PARAM_NR_IOREQ_SERVER_PAGES: case HVM_PARAM_ALTP2M: case HVM_PARAM_MCA_CAP: - if ( value !=3D 0 && a->value !=3D value ) + if ( value !=3D 0 && new_value !=3D value ) rc =3D -EEXIST; break; default: @@ -4116,13 +4117,11 @@ static int hvm_allow_set_param(struct domain *d, return rc; } =20 -static int hvmop_set_param( +int hvmop_set_param( XEN_GUEST_HANDLE_PARAM(xen_hvm_param_t) arg) { - struct domain *curr_d =3D current->domain; struct xen_hvm_param a; struct domain *d; - struct vcpu *v; int rc; =20 if ( copy_from_guest(&a, arg, 1) ) @@ -4142,23 +4141,42 @@ static int hvmop_set_param( if ( !is_hvm_domain(d) ) goto out; =20 - rc =3D hvm_allow_set_param(d, &a); + rc =3D hvm_set_param(d, a.index, a.value); + + out: + rcu_unlock_domain(d); + return rc; +} + +int hvm_set_param( + struct domain *d, + uint32_t index, + uint64_t value) +{ + struct domain *curr_d =3D current->domain; + int rc; + struct vcpu *v; + + if ( index >=3D HVM_NR_PARAMS ) + return -EINVAL; + + rc =3D hvm_allow_set_param(d, index, value); if ( rc ) goto out; =20 - switch ( a.index ) + switch ( index ) { case HVM_PARAM_CALLBACK_IRQ: - hvm_set_callback_via(d, a.value); + hvm_set_callback_via(d, value); hvm_latch_shinfo_size(d); break; case HVM_PARAM_TIMER_MODE: - if ( a.value > HVMPTM_one_missed_tick_pending ) + if ( value > HVMPTM_one_missed_tick_pending ) rc =3D -EINVAL; break; case HVM_PARAM_VIRIDIAN: - if ( (a.value & ~HVMPV_feature_mask) || - !(a.value & HVMPV_base_freq) ) + if ( (value & ~HVMPV_feature_mask) || + !(value & HVMPV_base_freq) ) rc =3D -EINVAL; break; case HVM_PARAM_IDENT_PT: @@ -4168,7 +4186,7 @@ static int hvmop_set_param( */ if ( !paging_mode_hap(d) || !cpu_has_vmx ) { - d->arch.hvm.params[a.index] =3D a.value; + d->arch.hvm.params[index] =3D value; break; } =20 @@ -4183,7 +4201,7 @@ static int hvmop_set_param( =20 rc =3D 0; domain_pause(d); - d->arch.hvm.params[a.index] =3D a.value; + d->arch.hvm.params[index] =3D value; for_each_vcpu ( d, v ) paging_update_cr3(v, false); domain_unpause(d); @@ -4192,23 +4210,23 @@ static int hvmop_set_param( break; case HVM_PARAM_DM_DOMAIN: /* The only value this should ever be set to is DOMID_SELF */ - if ( a.value !=3D DOMID_SELF ) + if ( value !=3D DOMID_SELF ) rc =3D -EINVAL; =20 - a.value =3D curr_d->domain_id; + value =3D curr_d->domain_id; break; case HVM_PARAM_ACPI_S_STATE: rc =3D 0; - if ( a.value =3D=3D 3 ) + if ( value =3D=3D 3 ) hvm_s3_suspend(d); - else if ( a.value =3D=3D 0 ) + else if ( value =3D=3D 0 ) hvm_s3_resume(d); else rc =3D -EINVAL; =20 break; case HVM_PARAM_ACPI_IOPORTS_LOCATION: - rc =3D pmtimer_change_ioport(d, a.value); + rc =3D pmtimer_change_ioport(d, value); break; case HVM_PARAM_MEMORY_EVENT_CR0: case HVM_PARAM_MEMORY_EVENT_CR3: @@ -4223,24 +4241,24 @@ static int hvmop_set_param( rc =3D xsm_hvm_param_nested(XSM_PRIV, d); if ( rc ) break; - if ( a.value > 1 ) + if ( value > 1 ) rc =3D -EINVAL; /* * Remove the check below once we have * shadow-on-shadow. */ - if ( !paging_mode_hap(d) && a.value ) + if ( !paging_mode_hap(d) && value ) rc =3D -EINVAL; - if ( a.value && + if ( value && d->arch.hvm.params[HVM_PARAM_ALTP2M] ) rc =3D -EINVAL; /* Set up NHVM state for any vcpus that are already up. */ - if ( a.value && + if ( value && !d->arch.hvm.params[HVM_PARAM_NESTEDHVM] ) for_each_vcpu(d, v) if ( rc =3D=3D 0 ) rc =3D nestedhvm_vcpu_initialise(v); - if ( !a.value || rc ) + if ( !value || rc ) for_each_vcpu(d, v) nestedhvm_vcpu_destroy(v); break; @@ -4248,30 +4266,30 @@ static int hvmop_set_param( rc =3D xsm_hvm_param_altp2mhvm(XSM_PRIV, d); if ( rc ) break; - if ( a.value > XEN_ALTP2M_limited ) + if ( value > XEN_ALTP2M_limited ) rc =3D -EINVAL; - if ( a.value && + if ( value && d->arch.hvm.params[HVM_PARAM_NESTEDHVM] ) rc =3D -EINVAL; break; case HVM_PARAM_TRIPLE_FAULT_REASON: - if ( a.value > SHUTDOWN_MAX ) + if ( value > SHUTDOWN_MAX ) rc =3D -EINVAL; break; case HVM_PARAM_IOREQ_SERVER_PFN: - d->arch.hvm.ioreq_gfn.base =3D a.value; + d->arch.hvm.ioreq_gfn.base =3D value; break; case HVM_PARAM_NR_IOREQ_SERVER_PAGES: { unsigned int i; =20 - if ( a.value =3D=3D 0 || - a.value > sizeof(d->arch.hvm.ioreq_gfn.mask) * 8 ) + if ( value =3D=3D 0 || + value > sizeof(d->arch.hvm.ioreq_gfn.mask) * 8 ) { rc =3D -EINVAL; break; } - for ( i =3D 0; i < a.value; i++ ) + for ( i =3D 0; i < value; i++ ) set_bit(i, &d->arch.hvm.ioreq_gfn.mask); =20 break; @@ -4283,35 +4301,35 @@ static int hvmop_set_param( sizeof(d->arch.hvm.ioreq_gfn.legacy_mask) * 8); BUILD_BUG_ON(HVM_PARAM_BUFIOREQ_PFN > sizeof(d->arch.hvm.ioreq_gfn.legacy_mask) * 8); - if ( a.value ) - set_bit(a.index, &d->arch.hvm.ioreq_gfn.legacy_mask); + if ( value ) + set_bit(index, &d->arch.hvm.ioreq_gfn.legacy_mask); break; =20 case HVM_PARAM_X87_FIP_WIDTH: - if ( a.value !=3D 0 && a.value !=3D 4 && a.value !=3D 8 ) + if ( value !=3D 0 && value !=3D 4 && value !=3D 8 ) { rc =3D -EINVAL; break; } - d->arch.x87_fip_width =3D a.value; + d->arch.x87_fip_width =3D value; break; =20 case HVM_PARAM_VM86_TSS: /* Hardware would silently truncate high bits. */ - if ( a.value !=3D (uint32_t)a.value ) + if ( value !=3D (uint32_t)value ) { if ( d =3D=3D curr_d ) domain_crash(d); rc =3D -EINVAL; } /* Old hvmloader binaries hardcode the size to 128 bytes. */ - if ( a.value ) - a.value |=3D (128ULL << 32) | VM86_TSS_UPDATED; - a.index =3D HVM_PARAM_VM86_TSS_SIZED; + if ( value ) + value |=3D (128ULL << 32) | VM86_TSS_UPDATED; + index =3D HVM_PARAM_VM86_TSS_SIZED; break; =20 case HVM_PARAM_VM86_TSS_SIZED: - if ( (a.value >> 32) < sizeof(struct tss32) ) + if ( (value >> 32) < sizeof(struct tss32) ) { if ( d =3D=3D curr_d ) domain_crash(d); @@ -4322,34 +4340,33 @@ static int hvmop_set_param( * 256 bits interrupt redirection bitmap + 64k bits I/O bitmap * plus one padding byte). */ - if ( (a.value >> 32) > sizeof(struct tss32) + + if ( (value >> 32) > sizeof(struct tss32) + (0x100 / 8) + (0x10000 / 8) + 1 ) - a.value =3D (uint32_t)a.value | + value =3D (uint32_t)value | ((sizeof(struct tss32) + (0x100 / 8) + (0x10000 / 8) + 1) << 32); - a.value |=3D VM86_TSS_UPDATED; + value |=3D VM86_TSS_UPDATED; break; =20 case HVM_PARAM_MCA_CAP: - rc =3D vmce_enable_mca_cap(d, a.value); + rc =3D vmce_enable_mca_cap(d, value); break; } =20 if ( rc !=3D 0 ) goto out; =20 - d->arch.hvm.params[a.index] =3D a.value; + d->arch.hvm.params[index] =3D value; =20 HVM_DBG_LOG(DBG_LEVEL_HCALL, "set param %u =3D %"PRIx64, - a.index, a.value); + index, value); =20 out: - rcu_unlock_domain(d); return rc; } =20 static int hvm_allow_get_param(struct domain *d, - const struct xen_hvm_param *a) + uint32_t index) { int rc; =20 @@ -4357,7 +4374,7 @@ static int hvm_allow_get_param(struct domain *d, if ( rc ) return rc; =20 - switch ( a->index ) + switch ( index ) { /* The following parameters can be read by the guest. */ case HVM_PARAM_CALLBACK_IRQ: @@ -4411,42 +4428,60 @@ static int hvmop_get_param( if ( !is_hvm_domain(d) ) goto out; =20 - rc =3D hvm_allow_get_param(d, &a); + rc =3D hvm_get_param(d, a.index, &a.value); if ( rc ) goto out; =20 - switch ( a.index ) + rc =3D __copy_to_guest(arg, &a, 1) ? -EFAULT : 0; + + HVM_DBG_LOG(DBG_LEVEL_HCALL, "get param %u =3D %"PRIx64, + a.index, a.value); + + out: + rcu_unlock_domain(d); + return rc; +} + +int hvm_get_param( + struct domain *d, + uint32_t index, + uint64_t *value) +{ + int rc; + + if ( index >=3D HVM_NR_PARAMS || !value ) + return -EINVAL; + + rc =3D hvm_allow_get_param(d, index); + if ( rc ) + return rc; + + switch ( index ) { case HVM_PARAM_ACPI_S_STATE: - a.value =3D d->arch.hvm.is_s3_suspended ? 3 : 0; + *value =3D d->arch.hvm.is_s3_suspended ? 3 : 0; break; =20 case HVM_PARAM_VM86_TSS: - a.value =3D (uint32_t)d->arch.hvm.params[HVM_PARAM_VM86_TSS_SIZED]; + *value =3D (uint32_t)d->arch.hvm.params[HVM_PARAM_VM86_TSS_SIZED]; break; =20 case HVM_PARAM_VM86_TSS_SIZED: - a.value =3D d->arch.hvm.params[HVM_PARAM_VM86_TSS_SIZED] & - ~VM86_TSS_UPDATED; + *value =3D d->arch.hvm.params[HVM_PARAM_VM86_TSS_SIZED] & + ~VM86_TSS_UPDATED; break; =20 case HVM_PARAM_X87_FIP_WIDTH: - a.value =3D d->arch.x87_fip_width; + *value =3D d->arch.x87_fip_width; break; default: - a.value =3D d->arch.hvm.params[a.index]; + *value =3D d->arch.hvm.params[index]; break; } =20 - rc =3D __copy_to_guest(arg, &a, 1) ? -EFAULT : 0; - - HVM_DBG_LOG(DBG_LEVEL_HCALL, "get param %u =3D %"PRIx64, - a.index, a.value); + return 0; +}; =20 - out: - rcu_unlock_domain(d); - return rc; -} =20 /* * altp2m operations are envisioned as being used in several different diff --git a/xen/include/asm-x86/hvm/hvm.h b/xen/include/asm-x86/hvm/hvm.h index 4e72d0732e..7f000fa6b1 100644 --- a/xen/include/asm-x86/hvm/hvm.h +++ b/xen/include/asm-x86/hvm/hvm.h @@ -336,6 +336,10 @@ unsigned long hvm_cr4_guest_valid_bits(const struct do= main *d, bool restore); bool hvm_flush_vcpu_tlb(bool (*flush_vcpu)(void *ctxt, struct vcpu *v), void *ctxt); =20 +/* Caller must hold domain locks */ +int hvm_get_param(struct domain *d, uint32_t index, uint64_t *value); +int hvm_set_param(struct domain *d, uint32_t index, uint64_t value); + #ifdef CONFIG_HVM =20 #define hvm_get_guest_tsc(v) hvm_get_guest_tsc_fixed(v, 0) --=20 2.20.1 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel