From nobody Fri Apr 26 00:21:57 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) smtp.mailfrom=seabios-bounces@seabios.org ARC-Seal: i=1; a=rsa-sha256; t=1584377089; cv=none; d=zohomail.com; s=zohoarc; b=Nk/xsKi+rbuwnShuoTmdubTMIsnlxBtNg74YP83odafoEodSm4Eq+yphB4nHTDImeTEEXahfCrwWJrSYEGwjygFpGokHaMgzrCJP9aUT+entyFehXcBtu6Ii82c0hl9wCtTqg3xv+zlCmB3flqQX+2HCcFwZYHi8+kKM+szXiVA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584377089; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Subject:To; bh=sxfRdbeNiNQajLKwPX8da+KXXiuqVZBOWkXecU5Fx+Q=; b=Mw0WPvtWsvO68p6abxhPY3KvFPhAnZ6WNzgAA3+FViuLZfWSSKQm8U9WCGhAIwkIHwwDbtFyKe2HiFkVSIN3lNDWr/3gOmDQUkivlj/nVtg79I8GutYjU3hg9o6Z4tEr0vsEpfMrnHH4yJ6wynUQszUwGbswhSHiXieDu24dWdA= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=none (zohomail.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) smtp.mailfrom=seabios-bounces@seabios.org Return-Path: Received: from coreboot.org (coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 1584377088984700.9268855355302; Mon, 16 Mar 2020 09:44:48 -0700 (PDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id 35A2DB01AA1; Mon, 16 Mar 2020 16:44:45 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTP id 061D2B01A4D for ; Mon, 16 Mar 2020 16:44:27 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id 87685206460A2; Mon, 16 Mar 2020 17:44:27 +0100 (CET) To: seabios@seabios.org From: Paul Menzel Message-ID: Date: Mon, 16 Mar 2020 17:44:27 +0100 MIME-Version: 1.0 Content-Language: en-US Message-ID-Hash: UUZXJ44Z3EYH6TT7OCFFCRZFSOFKHHJC X-Message-ID-Hash: UUZXJ44Z3EYH6TT7OCFFCRZFSOFKHHJC X-MailFrom: pmenzel@molgen.mpg.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Raul E Rangel X-Mailman-Version: 3.3.1 Precedence: list Subject: [SeaBIOS] [RFC] [PATCH] fw/coreboot: Don't scan all of memory List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: +++ X-Spam-Level: *** Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org Content-Type: text/plain; charset="utf-8"; format="flowed" From: Raul E Rangel Date: Tue, 14 Jan 2020 14:19:00 -0700 There seems to be a mismatch between the ACPI table coreboot writes, and what SeaBIOS is scanning: SeaBIOS: Scanning: 0x00000000 : 0x00001000 Scanning: 0xade50000 : 0xb0000000 Coreboot: IMD ROOT 0. affff000 00001000 IMD SMALL 1. afffe000 00001000 FSP MEMORY 2. aeffe000 01000000 CONSOLE 3. aefde000 00020000 TIME STAMP 4. aefdd000 00000910 TSEG 5. adfdd000 01000000 RAMSTAGE 6. adede000 000ff000 REFCODE 7. ade8e000 00050000 ACPI GNVS 8. ade8d000 00001000 COREBOOT 9. ade85000 00008000 ACPI 10. ade61000 00024000 TPM2 TCGLOG11. ade51000 00010000 SMBIOS 12. ade50000 00000800 BUG=3Dnone TEST=3DDali is able to boot Change-Id: I1db339f08d0754b836f84fe87cbf1139f27270e1 Signed-off-by: Raul E Rangel Reviewed-on:=20 https://chromium-review.googlesource.com/c/chromiumos/third_party/seabios/+= /2001559 Reviewed-by: Martin Roth Commit-Queue: Martin Roth Tested-by: Martin Roth --- The real bug should be fixed here. src/fw/coreboot.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/fw/coreboot.c b/src/fw/coreboot.c index 7c0954b..b95c680 100644 --- a/src/fw/coreboot.c +++ b/src/fw/coreboot.c @@ -243,10 +243,19 @@ void coreboot_debug_putc(char c) static void scan_tables(u32 start, u32 size) { + if (size > 0x100000) { + dprintf(5, "Size is too large: %d\n", size); + size =3D 0x100000; + } void *p =3D (void*)ALIGN(start, 16); void *end =3D (void*)start + size; - for (; pmap[i]; + + dprintf(3, "Looking at type: %x\n", m->type); if (m->type =3D=3D CB_MEM_TABLE) scan_tables(m->start, m->size); } + dprintf(3, "Done relocating coreboot bios tables\n"); find_acpi_features(); } --=20 2.25.1 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org