From nobody Wed Mar 12 15:31:20 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from coreboot.org (78.46.105.101 [78.46.105.101]) by mx.zohomail.com with SMTPS id 1738840501373563.1807147690608; Thu, 6 Feb 2025 03:15:01 -0800 (PST) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id 5BC0B22320; Thu, 6 Feb 2025 11:14:57 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTP id 8141420FA5 for ; Thu, 6 Feb 2025 11:14:40 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-408-AZKI8JgbOl2clT4klVjo1w-1; Thu, 06 Feb 2025 06:14:36 -0500 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DCFFA1800268; Thu, 6 Feb 2025 11:14:34 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 872551956051; Thu, 6 Feb 2025 11:14:34 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) id 0BC3A1800396; Thu, 06 Feb 2025 12:14:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738840479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GM1V6X5gsPpCpkRoEh4R15xlKcaR727mwTk2dhH5iBE=; b=WMCDyHQYButmtEo+A99CdWADk1U7IVubUK2myBgSilhDNqUzmTshodeW+7EpjQ3LTGLO1m 9B5aK1X40DeJLe4uTmeIHzldwpvFPdYMZGD7er5OCrU8tL+7+D3xOSX72dNxAbPag3LD3N mO0pS1ehTd6yOos8ih3WC4R1QCxV/i0= X-MC-Unique: AZKI8JgbOl2clT4klVjo1w-1 X-Mimecast-MFC-AGG-ID: AZKI8JgbOl2clT4klVjo1w Date: Thu, 6 Feb 2025 12:14:31 +0100 From: Gerd Hoffmann To: Christopher Lentocha Message-ID: References: <5s2btmuacrcfcjg4cuzgyalwwlgv4m6u5tplv4qbwnk6vpsnqa@nzvltw27etvp> <05775c3c-7ff7-150c-f3ce-c059626c5b1a@gmail.com> MIME-Version: 1.0 In-Reply-To: <05775c3c-7ff7-150c-f3ce-c059626c5b1a@gmail.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: jncgDMTvIHTqBqALzGM303q85UC_WfbJ_UFRwzlVb8Q_1738840475 X-Mimecast-Originator: redhat.com Content-Disposition: inline Message-ID-Hash: A6TXB6L4KXF3LE2C6IZUKGH5WF4CJSJI X-Message-ID-Hash: A6TXB6L4KXF3LE2C6IZUKGH5WF4CJSJI X-MailFrom: kraxel@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: seabios@seabios.org X-Mailman-Version: 3.3.6b1 Precedence: list Subject: [SeaBIOS] Re: [PATCH] Fix AHCI Disk Detection when using EDK2 CSM List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-Spamd-Bar: --- X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1738840502981019000 Content-Type: text/plain; charset="utf-8" On Wed, Feb 05, 2025 at 10:53:04AM -0500, Christopher Lentocha wrote: > Is it already pushed? Nope, apparently something went wrong ... > I think I need to add a `if (CONFIG_CSM) {` to it >=20 > because I think it wasn't working with the regual bios.bin without CSM Does a controller reset (see below) work in both cases? take care, Gerd commit 79d50d3c156dfd15ed710d0e2313d113251aeb2e Author: Gerd Hoffmann Date: Thu Feb 6 12:10:21 2025 +0100 ahci: add controller reset diff --git a/src/hw/ahci.c b/src/hw/ahci.c index 4f0f640a1c64..2285d33d4ae2 100644 --- a/src/hw/ahci.c +++ b/src/hw/ahci.c @@ -637,7 +637,7 @@ static void ahci_controller_setup(struct pci_device *pci) { struct ahci_port_s *port; - u32 val, pnr, max; + u32 pnr, max; =20 if (create_bounce_buf() < 0) return; @@ -660,8 +660,8 @@ ahci_controller_setup(struct pci_device *pci) =20 pci_enable_busmaster(pci); =20 - val =3D ahci_ctrl_readl(ctrl, HOST_CTL); - ahci_ctrl_writel(ctrl, HOST_CTL, val | HOST_CTL_AHCI_EN); + ahci_ctrl_writel(ctrl, HOST_CTL, HOST_CTL_RESET); + ahci_ctrl_writel(ctrl, HOST_CTL, HOST_CTL_AHCI_EN); =20 ctrl->caps =3D ahci_ctrl_readl(ctrl, HOST_CAP); ctrl->ports =3D ahci_ctrl_readl(ctrl, HOST_PORTS_IMPL); _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org