[SeaBIOS] [PATCH] Clarify license headers for dsdt and ssdt tables.

Robert Spier via SeaBIOS posted 1 patch 5 months, 1 week ago
src/fw/acpi-dsdt-cpu-hotplug.dsl | 19 +++++++++++++++++++
src/fw/acpi-dsdt-dbug.dsl        | 19 +++++++++++++++++++
src/fw/acpi-dsdt-hpet.dsl        | 19 +++++++++++++++++++
src/fw/acpi-dsdt-isa.dsl         | 19 +++++++++++++++++++
src/fw/acpi-dsdt-pci-crs.dsl     | 19 +++++++++++++++++++
src/fw/ssdt-misc.dsl             | 19 +++++++++++++++++++
src/fw/ssdt-pcihp.dsl            | 19 +++++++++++++++++++
src/fw/ssdt-proc.dsl             | 19 +++++++++++++++++++
8 files changed, 152 insertions(+)
[SeaBIOS] [PATCH] Clarify license headers for dsdt and ssdt tables.
Posted by Robert Spier via SeaBIOS 5 months, 1 week ago
From 7c84cde99ec50d80f4a1b327fcb80d25f617e636 Mon Sep 17 00:00:00 2001
From: Robert Spier <rspier@google.com>
Date: Tue, 9 Jul 2024 10:32:56 -0700
Subject: [PATCH] Add LGPLv2 header back to files derived from acpi-dsdt.dsl
 which came from Bochs/QEMU.

The original code was licensed under LGPLv2 *without* an "or later"
affordance.
---
 src/fw/acpi-dsdt-cpu-hotplug.dsl | 19 +++++++++++++++++++
 src/fw/acpi-dsdt-dbug.dsl        | 19 +++++++++++++++++++
 src/fw/acpi-dsdt-hpet.dsl        | 19 +++++++++++++++++++
 src/fw/acpi-dsdt-isa.dsl         | 19 +++++++++++++++++++
 src/fw/acpi-dsdt-pci-crs.dsl     | 19 +++++++++++++++++++
 src/fw/ssdt-misc.dsl             | 19 +++++++++++++++++++
 src/fw/ssdt-pcihp.dsl            | 19 +++++++++++++++++++
 src/fw/ssdt-proc.dsl             | 19 +++++++++++++++++++
 8 files changed, 152 insertions(+)

diff --git a/src/fw/acpi-dsdt-cpu-hotplug.dsl
b/src/fw/acpi-dsdt-cpu-hotplug.dsl
index 0f3e83b1..cc94c228 100644
--- a/src/fw/acpi-dsdt-cpu-hotplug.dsl
+++ b/src/fw/acpi-dsdt-cpu-hotplug.dsl
@@ -1,3 +1,22 @@
+/*
+ * Bochs/QEMU ACPI DSDT ASL definition
+ *
+ * Copyright (c) 2006 Fabrice Bellard
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License version 2 as published by the Free Software Foundation.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
 USA
+ */
+
 /****************************************************************
  * CPU hotplug
  ****************************************************************/
diff --git a/src/fw/acpi-dsdt-dbug.dsl b/src/fw/acpi-dsdt-dbug.dsl
index 276321f6..2d6d2b82 100644
--- a/src/fw/acpi-dsdt-dbug.dsl
+++ b/src/fw/acpi-dsdt-dbug.dsl
@@ -1,3 +1,22 @@
+/*
+ * Bochs/QEMU ACPI DSDT ASL definition
+ *
+ * Copyright (c) 2006 Fabrice Bellard
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License version 2 as published by the Free Software Foundation.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
 USA
+ */
+
 /****************************************************************
  * Debugging
  ****************************************************************/
diff --git a/src/fw/acpi-dsdt-hpet.dsl b/src/fw/acpi-dsdt-hpet.dsl
index f33e5279..a1edac7e 100644
--- a/src/fw/acpi-dsdt-hpet.dsl
+++ b/src/fw/acpi-dsdt-hpet.dsl
@@ -1,3 +1,22 @@
+/*
+ * Bochs/QEMU ACPI DSDT ASL definition
+ *
+ * Copyright (c) 2006 Fabrice Bellard
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License version 2 as published by the Free Software Foundation.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
 USA
+ */
+
 /****************************************************************
  * HPET
  ****************************************************************/
diff --git a/src/fw/acpi-dsdt-isa.dsl b/src/fw/acpi-dsdt-isa.dsl
index 23761dbb..72e5ac42 100644
--- a/src/fw/acpi-dsdt-isa.dsl
+++ b/src/fw/acpi-dsdt-isa.dsl
@@ -1,3 +1,22 @@
+/*
+ * Bochs/QEMU ACPI DSDT ASL definition
+ *
+ * Copyright (c) 2006 Fabrice Bellard
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License version 2 as published by the Free Software Foundation.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
 USA
+ */
+
 /* Common legacy ISA style devices. */
 Scope(\_SB.PCI0.ISA) {

diff --git a/src/fw/acpi-dsdt-pci-crs.dsl b/src/fw/acpi-dsdt-pci-crs.dsl
index d4218914..e87c6e19 100644
--- a/src/fw/acpi-dsdt-pci-crs.dsl
+++ b/src/fw/acpi-dsdt-pci-crs.dsl
@@ -1,3 +1,22 @@
+/*
+ * Bochs/QEMU ACPI DSDT ASL definition
+ *
+ * Copyright (c) 2006 Fabrice Bellard
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License version 2 as published by the Free Software Foundation.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
 USA
+ */
+
 /* PCI CRS (current resources) definition. */
 Scope(\_SB.PCI0) {

diff --git a/src/fw/ssdt-misc.dsl b/src/fw/ssdt-misc.dsl
index d1d2c9e3..1d62e187 100644
--- a/src/fw/ssdt-misc.dsl
+++ b/src/fw/ssdt-misc.dsl
@@ -1,3 +1,22 @@
+/*
+ * Bochs/QEMU ACPI DSDT ASL definition
+ *
+ * Copyright (c) 2006 Fabrice Bellard
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License version 2 as published by the Free Software Foundation.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
 USA
+ */
+
 ACPI_EXTRACT_ALL_CODE ssdp_misc_aml

 DefinitionBlock ("ssdt-misc.aml", "SSDT", 0x01, "BXPC", "BXSSDTSU", 0x1)
diff --git a/src/fw/ssdt-pcihp.dsl b/src/fw/ssdt-pcihp.dsl
index 518a5ebf..11a36966 100644
--- a/src/fw/ssdt-pcihp.dsl
+++ b/src/fw/ssdt-pcihp.dsl
@@ -1,3 +1,22 @@
+/*
+ * Bochs/QEMU ACPI DSDT ASL definition
+ *
+ * Copyright (c) 2006 Fabrice Bellard
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License version 2 as published by the Free Software Foundation.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
 USA
+ */
+
 ACPI_EXTRACT_ALL_CODE ssdp_pcihp_aml

 DefinitionBlock ("ssdt-pcihp.aml", "SSDT", 0x01, "BXPC", "BXSSDTPC", 0x1)
diff --git a/src/fw/ssdt-proc.dsl b/src/fw/ssdt-proc.dsl
index 407d61ea..00690e66 100644
--- a/src/fw/ssdt-proc.dsl
+++ b/src/fw/ssdt-proc.dsl
@@ -1,3 +1,22 @@
+/*
+ * Bochs/QEMU ACPI DSDT ASL definition
+ *
+ * Copyright (c) 2006 Fabrice Bellard
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License version 2 as published by the Free Software Foundation.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
 USA
+ */
+
 /* This file is the basis for the ssdt table generated in src/acpi.c.
  * It defines the contents of the per-cpu Processor() object.  At
  * runtime, a dynamically generated SSDT will contain one copy of this
-- 
2.45.2.803.g4e1b14247a-goog
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org
[SeaBIOS] Re: [PATCH] Clarify license headers for dsdt and ssdt tables.
Posted by Gerd Hoffmann 3 weeks, 5 days ago
On Wed, Jul 10, 2024 at 11:50:53AM -0700, Robert Spier via SeaBIOS wrote:
> From 7c84cde99ec50d80f4a1b327fcb80d25f617e636 Mon Sep 17 00:00:00 2001
> From: Robert Spier <rspier@google.com>
> Date: Tue, 9 Jul 2024 10:32:56 -0700
> Subject: [PATCH] Add LGPLv2 header back to files derived from acpi-dsdt.dsl
>  which came from Bochs/QEMU.
> 
> The original code was licensed under LGPLv2 *without* an "or later"
> affordance.

Short history lesson:

In 2013, in version 1.7, qemu introduced the feature that the acpi
tables for the virtual machine can be fetched from qemu via fw_cfg
interface.  seabios supports that via CONFIG_FW_ROMFILE_LOAD.

We kept the compiled-in acpi tables back then, for backward
compatibility with qemu versions 1.6 & older.

Fast forward 10 years.  Meanwhile qemu has removed backward
compatibility support for qemu versions that old (the oldest machine
type still supported by the upcoming qemu 9.2 release is for qemu 2.4).

I think it is save to simply remove these files now (and the
acpi_setup() function which uses them).  So I'd suggest to do that
instead of adding any fixes.

take care,
  Gerd

_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org