From nobody Thu Apr 25 06:43:39 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) smtp.mailfrom=seabios-bounces@seabios.org; arc=fail (BodyHash is different from the expected one); dmarc=pass(p=reject dis=none) header.from=seabios.org Return-Path: Received: from coreboot.org (coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 1643016078455932.444555461733; Mon, 24 Jan 2022 01:21:18 -0800 (PST) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id 7015B16E3E8C; Mon, 24 Jan 2022 09:21:13 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTP id 7B09716E3D30 for ; Mon, 24 Jan 2022 09:20:57 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) (mail-db3eur04lp2056.outbound.protection.outlook.com [104.47.12.56]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-19-kM4GHQkqOJeJIrDzG-YKiQ-1; Mon, 24 Jan 2022 10:20:55 +0100 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by DB6PR0401MB2248.eurprd04.prod.outlook.com (2603:10a6:4:48::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.17; Mon, 24 Jan 2022 09:20:54 +0000 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4909.017; Mon, 24 Jan 2022 09:20:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seabios.org; s=dkim; t=1643016074; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:list-id:list-owner:list-unsubscribe:list-subscribe:list-post; bh=SrrXDVNkvfH1025WvJ/5Yij8TwB2SLkLy6tl81DhuOM=; b=HVqHtEujcC1pW7DwZSikl/jcAj0khTshjyhl89Z7EGqeucmzMLQjtm+DAfT4emi4xd5zlf g6a2Wzv6ntPL65yDhnDO4M4M6Kw0hsAZbZtKUNmTErhzXNlTku5Ysyt0X79WhVP1rBXoVa 3yUV6OOiBrSw7JdgLKyZ2ONDNTgcTXY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1643016057; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kphgIjfqrGfGdJHSpFmB6jBo7D/HoyBMaOpZ16+O2SA=; b=c+jEfRbSjS6Fx+EjOvUgsK4YNbBHbHJcz02IfoXLc8M0TGIT0757oxLJM4RH5CC+Kb2bqV /Tr0dLsZLW5A8KS1WR1DYkNx877jQCWONYU0IUXj8YPXc34Yvmfv/NpBYAdre6w+39DMlF hf/V/hzTJQmP7cVkWaVz3kpoE6q1p9w= X-MC-Unique: kM4GHQkqOJeJIrDzG-YKiQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H2Mzu83nvHyQlX8dQbkLr0fbZNA4V1a1LrkBSm7byr3B36rNx3qX6dE9FT+ehkrM/Jko9fVuzGBLGfUiQXnydGBCTgLZdIObxmSugVxmfF8BHRhCBt/WOdjS/htUGzcMjx6Vg16/GAMvXAxF2FTirceJoBwqGJ29be5XdH+aM9NoMpYRWfpwJx53jsrol9O7WB8kjpZd7Gh6y9gEch34yqvwqfzmBmFu+kLTJIe3LhLALXy6h95sXvWF0cMDeLOdgLVeTxJSQgUIcj7+J8dqcRs4581WbZeLyobV70dez3HvegGJRQcsTQF/kcqGkeqXd0XJjq+LsXKwq9dEZcN9qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kphgIjfqrGfGdJHSpFmB6jBo7D/HoyBMaOpZ16+O2SA=; b=RTWXBQlZz2VzLXuj5ubXYI9cNkOkjfoAckaWa1T+QVm5Zg6CzhIcxUBW870UScjAosIpc/G9jXce/UXf0P+bAGnxVw6dCsQy04Uv9o9Z/Fdys2A1/1ZS5jOiikBQsVfVTEHPf7AHHt5jQDTtFlfYvfG0UZC/+qwSJTLRyidzOI/Ik/bZkTBDVksB4ZGcsa5sploYphjC4M+cLf/P1m4OrLdvOMH2AMKq9KTIJwA+Agst3mt5PC8VJwOlXS0tJ5pk8e6jblGZa1EpgiPok2h9VRZwq29GObIt1nL2y2Z7lJ/ozQNaySx5TMeTjuov6Ke8IVMWpY6YRd/KMe5ey5HpfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Message-ID: <9ba6267e-8a27-72e3-a499-ed67a600bb7f@suse.com> Date: Mon, 24 Jan 2022 10:20:53 +0100 Content-Language: en-US To: "seabios@seabios.org" X-ClientProxiedBy: AS9PR06CA0182.eurprd06.prod.outlook.com (2603:10a6:20b:45d::16) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 663fd0d9-aa21-4157-be35-08d9df1ad25c X-MS-TrafficTypeDiagnostic: DB6PR0401MB2248:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M/LQzD3TPmXo7yMqTRZjyf5x43AgMhzoVcG6281yDa3g5bzPpUq5wKP+tniqNnAQAU0Zgz+gD+C//O4T6iF7w7W3S3nwnbFr9Ox7z9DWU2TZIM0fgn5yZ66bkp/U5hK6CWvC5KfTvUut0X4TmHI/nTy9cFlRXNJc2XrCheoMHD682+qVeOhnJwI3Idmnk4EXZ2vLiLQdqQDBoiTEcXXAadSdPURZzAhT+uMotJXKPq0g4VYE+hK6Cmh9yg3CfO+/+4VsDQ2N9ik4PFqmxciwWe6U1/ajm//mPZ2k5duovD/UvfSnUNecRZ8Zgn9G8AsZ6sdL+j6HNfvnI/SDaUKvkoV9PAbtQZmmEjrSYAWzHMqZ2zerzBuJO6SHKdKW/DfP/mes3Fd+uWhavwvx2O/Twt3N32I00wdd9eUbZvOA/T+3n2ZQOU8blnvqAU0ch+6lUaE2w0ejIX4uc8LHNpfwnzlDuc8+g6c6cakfT95NkweFwUmh0pOulwgJoXqfiZy3yNAszluja4q7Lg4uW5ESxjwcpPKPXVck5XItHV/feptRmGAeBC921B7ddiQIgeOYLHT0l+alHQZcmgH0xkRbSy0IxKt0MKfiWhj9B3G4IRzqG+KMrOqziL7wQr6lP+genYWXcsVDxvONzNAfcdveM1TakR1Eb+ot7GYernyTmiefDUp5+7FSwoODux5swpbmgxmIkULoVwAopkXTUK6q5Lhnc1fH7/D0eYgrBFswwm0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6916009)(6512007)(4744005)(5660300002)(316002)(86362001)(31696002)(66946007)(8936002)(31686004)(66476007)(6486002)(186003)(508600001)(66556008)(2906002)(26005)(38100700002)(36756003)(8676002)(6506007)(2616005)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Sm5uUkhzbVdZUFJDVXlNOFVIWWt0dmN1b3NrdWticEt0ZlRtWkdFTk5vcW0y?= =?utf-8?B?T1J3djhrMndhZG1TUkhLNzB6UTBNT1FZRkV5UVFnanN3Q3hkZzltQ3FlUVZp?= =?utf-8?B?aHN0R0UvdHZZaEFoVUh6SDZiTXBZZ2VSRnNHRTUyRmJxQjA3N2s5QzcwMXVO?= =?utf-8?B?UzNwR0pqK3hEQjRIV0pPcXR6UWZpdFEwaUxKaThZMWFBVHdab0srWWduR0Js?= =?utf-8?B?eEZORHZyTVlFZ1VqdmJBN3JoS0czbE5jOWlPUDFyQWtmTzZkWGY4bGZteXJ4?= =?utf-8?B?ME9CMnVzNlZibEJhQUNIOUJhaWxyZUxON3J6cCtnL2R4WVU2NUs4aVFNdWJN?= =?utf-8?B?eHYxNzFjY2FCRUxMdmFzaWNsN3F5bWFLclNyY3RBcWJNYXB1ZzVsSmZMUnY4?= =?utf-8?B?ZTFXZGJMR0lucGxXckFmYktRSHp5dmh3WUNqS0N3VmY2ZDF2emRjUDQrT0lr?= =?utf-8?B?dkdBZ01qVDFlQXE1M0p3cStlMnVXbkppRFV6SkVUN2JjQ0QwdXRCN3V2RnJY?= =?utf-8?B?eWJyS0NuTDBKVXRLZkszYUlIdUdBZTB3NEk4eFlxMWY4aHlRVjVyT1cwVklT?= =?utf-8?B?ejcvUGo0V3d2UnhkTmhhbnoxZ3o2eVpWUVp5b25GalJlMW5KdDRoeUtuT2lx?= =?utf-8?B?Z0RQNFpZV3NjVDUzWWNUZ1NtOEc3Z0p2dkhwV1IxQng5T2kvWUNpeElSL2FP?= =?utf-8?B?cFpYMWdyU2kzK2UxUkJkOFVsWmU2V0NLcUdPbW9XL1pXSVEyeSs1eENRdFY2?= =?utf-8?B?TWpSZTZNNm94V2x1RzVieUtMT1BYV21uZUVEalY2YitJbXdvZWF2d1pOTVly?= =?utf-8?B?cnYwVERlZnZMMVc4WnNqMkQwSjBwb0Rac2k2RUIxdmlVbDJaTEI4TnIvWXFs?= =?utf-8?B?YzFtOU9WeFJ1QWVtM2tuOWE0RDdwWXI1OVlQRXZibE9GSU9GVW9rcmphYlZi?= =?utf-8?B?T3VmOGw3dW0wK3hYakF1VjAxbXVVTDRxS3lhdk1VVlFEdkkwMzNNckRPTDA3?= =?utf-8?B?T3BjdzFFMC9LUTBORFJVVnRMNk1qT3JaVmZTbTIvcVc2SDFvQkdQaHVUNElq?= =?utf-8?B?ODVDa2pLU0NkN2hiak5OWXhsL1pGSkZYU0duMDU2aHU5d1A2NmhWVHdob2ts?= =?utf-8?B?K2ovTTdocHQwV0lXQ1RSV1RqSHBEdmZ6dnc1bGNCNktWU1c0VHd0NXprbDI1?= =?utf-8?B?MElkdHUxd2NyVm9UbFpQSTVndWJKMWxTRVkyTVRZNzNndGRyTDZZUmVycm5l?= =?utf-8?B?WDJZd284OHl0MzFDOHQ5QnZGZEdUbHIrT3l6NVhDTVczYkRmSWoxaUNvTlI2?= =?utf-8?B?NThJamJXbkd1djlrRzMrRzVVenRzUWszMjY5UENNSDdXRUdyYUFEbFlKS3Nl?= =?utf-8?B?V1J4TjlDU0hqV3F5YlF4aUNZai9FRndMd2VEdmNOd2lhb3BLQkp1N3ppSzV2?= =?utf-8?B?RHk4S2xNNHNNZ3c5RCtGTjVGVXhucXV0akZsVFEvdzBlWnhIbmdUNGpPTkRk?= =?utf-8?B?MjZmZU45ZlZyTXpHbVptdndOUFV6TE1aemhmd2oydExKMkJrTUp0Y09ZV3A4?= =?utf-8?B?YUhzV3ppTmUvdlk4NCtOM1hMTkJ2TUxGdmlmMVNaVnM4V2VsWWdjSCtvQVRE?= =?utf-8?B?RXc3d1pjbDhFTFZYb3NoMUJic0RyYXp0WS9LVzRNSk1iZ0RxalczOFpRZ3Q1?= =?utf-8?B?cGJhb2V5RG8yamE3ZmEvZ3pNcVN5Q0xRYWhQVkVRQkFqYytUclVzMVRyR0s2?= =?utf-8?B?MFB1ZVphR0FNNlhkL01oOTJSbEprWDRpbFNWRjhGSGdkWTkvSHZWRHlPVzc2?= =?utf-8?B?bEpvdHdKUUI5UkkrVlFOcUxOTmZmdkxhVDZPV2lWTWJFSE1QSVhnT3l6ZVdK?= =?utf-8?B?QmRDRkNpNDlOcHM3em9SU2RRQVF5aGdjZ3JrWXhmWFZaRHdWSUJEdUxFaTVH?= =?utf-8?B?VnBZMmt0dWlZUjdBWVZCZC9hbTl0dTN6bFNuR01QeXhNZ1ltbzhubGVMU0Rt?= =?utf-8?B?dzM0YnYyYmc3czhJQnVtZGNVaEhBUkNuQWdBdkUwb2dBZU8wd3JlSjkvY2xN?= =?utf-8?B?M3lBZENzVkJvdDFWZ2FaeEdPanM1Q0NsS3NCV1kzZXZFTHd5cGgwZ0xVOVpO?= =?utf-8?B?allCZXdLN3hXcGpyZHBQdlVzMWxPaFF5VUI3d05CbDRHb2dIZWdNVE9WT0pH?= =?utf-8?Q?A88m2jaKXc1W/XIalG4RnbU=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 663fd0d9-aa21-4157-be35-08d9df1ad25c X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2022 09:20:54.3061 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8hMU1PuS4WJl7IH5Ok5S5QPMEN0GAQtjS4hwrL2uoDy4cQMbEgbhWIXmcy6KYEf/BWUIgNqvzEEsvYxTT5d6YA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2248 Message-ID-Hash: FYSUI3BC7PRUG76ISZTRFEE637CSYBHF X-Message-ID-Hash: FYSUI3BC7PRUG76ISZTRFEE637CSYBHF X-MailFrom: jbeulich@suse.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.5rc1 Precedence: list Subject: [SeaBIOS] [PATCH] nvme: avoid use-after-free in nvme_controller_enable() List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Jan Beulich via SeaBIOS Reply-To: Jan Beulich Content-Transfer-Encoding: quoted-printable Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-Spamd-Bar: - X-ZohoMail-DKIM: pass (identity @seabios.org) X-ZM-MESSAGEID: 1643016080590100001 Content-Type: text/plain; charset="utf-8" Commit b68f313c9139 ("nvme: Record maximum allowed request size") introduced a use of "identify" past it being passed to free(). Latch the value of interest into a local variable. Reported-by: Coverity (ID 1497613) Signed-off-by: Jan Beulich --- It was a Xen Project Coverity run which reported this after our updating to 1.15.0. --- a/src/hw/nvme.c +++ b/src/hw/nvme.c @@ -620,6 +620,7 @@ identify->nn, (identify->nn =3D=3D 1) ? "" : "s"); =20 ctrl->ns_count =3D identify->nn; + u8 mdts =3D identify->mdts; free(identify); =20 if ((ctrl->ns_count =3D=3D 0) || nvme_create_io_queues(ctrl)) { @@ -631,7 +632,7 @@ /* Populate namespace IDs */ int ns_idx; for (ns_idx =3D 0; ns_idx < ctrl->ns_count; ns_idx++) { - nvme_probe_ns(ctrl, ns_idx, identify->mdts); + nvme_probe_ns(ctrl, ns_idx, mdts); } =20 dprintf(3, "NVMe initialization complete!\n"); _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org