From nobody Sat Aug 15 10:42:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail(p=none dis=none) header.from=jablonski.xyz Return-Path: Received: from coreboot.org (mail.coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 1785260899025701.0822165956972; Tue, 28 Jul 2026 10:48:19 -0700 (PDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id DEEE854E4A2; Tue, 28 Jul 2026 17:48:12 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) (fout-a3-smtp.messagingengine.com [103.168.172.146]) by coreboot.org (Postfix) with ESMTP id EDC6754E496 for ; Tue, 28 Jul 2026 17:43:11 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by mailfout.phl.internal (Postfix) with ESMTP id 13CD9EC03E3; Tue, 28 Jul 2026 13:43:11 -0400 (EDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by phl-compute-06.internal (MEProxy); Tue, 28 Jul 2026 13:43:11 -0400 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) 28 Jul 2026 13:43:10 -0400 (EDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by chomposaur (OpenSMTPD) with ESMTPA id 3d2fa496; Tue, 28 Jul 2026 17:43:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jablonski.xyz; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1785260591; x= 1785346991; bh=sRb0jhPUrxyLiX69o0NBqM2YrSNXPqPkmOMz0EFl0XQ=; b=H gS4973DGkWvGpM0pCI47TpASOXr5CYyBaOT8eSl3aqT6dzbeL0SfE43+yYevCazb Zvzl6abe3R9D9whhB1Ca4QO/rVug8ktPBqgytWuLTqBQrIgquE663EBC5JXz7jcW ubaox0gdwLZZVZ3UBF+EET3mMjLDeVcQqxmd0CVnGEOdi2cihYVMt5rtKBamFeuL MbEcoWiAxICUOZTRYjHfPve69QmYH4yR5E1XVjOiRqZkYkGv07WAY3CBTHIgALjj Kclf3QUIIe4Bt8/PbdK+X6GvzIbDAeM+ZkgkTJthiO/9tvbB8XnIifjPs4YVj/Vi 02d9wVjcSIiXe+bXx4/KA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1785260591; x=1785346991; bh=s Rb0jhPUrxyLiX69o0NBqM2YrSNXPqPkmOMz0EFl0XQ=; b=M8rHSP3GykzOYNYZ7 q5gQizc/vbbWzEcMcmr9VQUTiTKzncBOzIi7v1qxl40Q722+G0Rv8h7lQ174G+P5 XqSqlQjKVn7iqxkio1s+Z6HJacc+W/WnBAFwkktOwqHMEYqqQcTMxwJmOcdPL5nA pJMcuKD/a9IRZG0DOaMMqzAjNmKvpoWXAvJha2aOJRx6Re/IzecIn7bBtI+2FgF4 Sau65axwZoZbTau3F5c0GNwqLEwATMyr4gVSyoFs8urGaPnUiU0VyiUJzLiv5b1I mP63Z/+Fyhan5O5qenWFqu2spnLFDZc7Xycu2HOtd6IDX++su1/GhJxqg2BrAeUJ XLGVw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGkhIO2r9whBLMidWSZA1ehG3656x4BkevwGjODGymBAIT57DXlfP1ZwdnQADjnlB pKEaQxCCMzxbDaxRfgmrn/u3f+Lau4db8fZl10kiGr02Uf8iAdPT9C/C2fE1b0CcGwFEoe qrR3d3/5gdLgB29ynX5oaeBFS6e7wqH1cQJiRWlawaj0799ttZ2+aa6z1Jw/uXPZO/SX/U QECbBSo0OvMjhiqFow72XQrwFDQCz5cdwCcvWSSqj/lR8SOifBMIoWbeBamc199cTe+C5n vGUVZGcezdXkayruhl48es6fGiZRnNVEMtbE3XWpMcSInIunS4Dh7DJPHTIia1z/JOCepU pkvpo8dgGbRG0BIEEjewiZ9QlyIzfboQqINLC0LEQJlpCWHuTQKwYC8Y68HVpu/lB96Q+t rsWh88K+m7qRiSVDNf3EvSk/Hd+1ccAuYHkxC7C6W8fsFL1vFvrH86j3FXtHUbAQzE1+MP aXG9IXKUm6ZuJGj52lsNANnFXdTgZEYeBuCnRyZJQUa86SHJaMZc1xz7czCMrVWxuZRffk muq6EvRTDCYFL7nxxrAZFRkBhodOAU5QQiBQ3bGnfOfE2DYuEDSfSBT4Y5fGO0SJMAin+y 8esv2OniPVVfb5i9eih8AkFmOkCOCaRsFWe0UlU0b+FnPduc6t81wYOuWyTw X-ME-Proxy: Feedback-ID: ib26944c1:Fastmail From: Chad Jablonski To: seabios@seabios.org Date: Tue, 28 Jul 2026 13:42:41 -0400 Message-ID: <20260728174243.1644268-2-chad@jablonski.xyz> In-Reply-To: <20260728174243.1644268-1-chad@jablonski.xyz> References: <20260728174243.1644268-1-chad@jablonski.xyz> MIME-Version: 1.0 X-Spam-Level: *** Message-ID-Hash: 7BHEN3EOEXHAHUU4HPPNQA5GTODAWHQR X-Message-ID-Hash: 7BHEN3EOEXHAHUU4HPPNQA5GTODAWHQR X-MailFrom: chad@jablonski.xyz X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header Cc: Gerd Hoffmann , Paul Menzel , Chad Jablonski X-Mailman-Version: 3.3.11b1 Precedence: list Subject: [SeaBIOS] [PATCH v3 1/3] atiext: Implement ATI tables in atiext.c List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-Spamd-Bar: --- X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZM-MESSAGEID: 1785260900414158500 Content-Type: text/plain; charset="utf-8" From: Kevin O'Connor Move the definitions in ati-tables.S to atiext.c . Signed-off-by: Kevin O'Connor Signed-off-by: Chad Jablonski Acked-by: Gerd Hoffmann --- vgasrc/ati-tables.S | 43 -------------------------------- vgasrc/atiext.c | 61 +++++++++++++++++++++++++++++++++++++++++++++ vgasrc/vgaentry.S | 6 ++++- 3 files changed, 66 insertions(+), 44 deletions(-) delete mode 100644 vgasrc/ati-tables.S diff --git a/vgasrc/ati-tables.S b/vgasrc/ati-tables.S deleted file mode 100644 index cdbde2fa..00000000 --- a/vgasrc/ati-tables.S +++ /dev/null @@ -1,43 +0,0 @@ -// -// Fake ati bios tables. -// -// aty128fb and radeonfb try to gather informations from these tables, -// so add some stuff here to make the drivers happy. Specifically -// radeonfb needs the pll information, otherwise it'll crash with a -// division by zero ... -// - .org 0x48 - .word _ati_main - - // main info - .org 0x50 -_ati_main: - .org 0x50 + 0x30 - .word _ati_pll - .org 0x50 + 0x50 - .word _ati_connector - - // pll info - .org 0x100 -_ati_pll: - .word 0 // ??? (not used by radeonfb) - .word 0 - .word 0 - .word 0 - .word 23000 // sclk - .word 23000 // mclk - .word 0 - .word 2700 // ref_clk - .word 4 // ref_div - .long 12000 // ppll_min - .long 35000 // ppll_max - - // connector info - .org 0x140 -_ati_connector: - .byte 0x10 // one chip - .byte 0x01 // one connector - .word 0x3000 // type DVI-I - .word 0 // end of list - - .org 0x200 diff --git a/vgasrc/atiext.c b/vgasrc/atiext.c index 69dfd46e..f003eea8 100644 --- a/vgasrc/atiext.c +++ b/vgasrc/atiext.c @@ -338,6 +338,65 @@ static void ati_i2c_edid_rage128(void) dprintf(1, "ati: ... %s\n", valid ? "good" : "invalid"); } =20 +/**************************************************************** + * Fake ati bios tables + ****************************************************************/ + +// aty128fb and radeonfb try to gather informations from these tables, +// so add some stuff here to make the drivers happy. Specifically +// radeonfb needs the pll information, otherwise it'll crash with a +// division by zero ... +struct ati_main_table_s { + u8 pad_0[48]; + u16 pll_table; + u8 pad_50[30]; + u16 connector_table; + u8 pad_82[94]; +} PACKED; + +struct ati_pll_table_s { + u8 pad_0[8]; + u16 sclk; + u16 mclk; + u8 pad_12[2]; + u16 ref_clk; + u16 ref_div; + u32 ppll_min; + u32 ppll_max; + u8 pad_26[38]; +} PACKED; + +struct ati_connector_table_s { + u8 num_chip; + u8 num_connector; + u16 flags; + u16 next; +} PACKED; + +extern u16 _rom_header_ati_table_anchor; +static struct ati_main_table_s ati_main_table VAR16 __aligned(16); +static struct ati_pll_table_s ati_pll_table VAR16 __aligned(16) =3D { + .sclk =3D 23000, + .mclk =3D 23000, + .ref_clk =3D 2700, + .ref_div =3D 4, + .ppll_min =3D 12000, + .ppll_max =3D 35000, +}; +static struct ati_connector_table_s ati_connector_table VAR16 __aligned(16= ) =3D { + .num_chip =3D 0x10, + .num_connector =3D 1, + .flags =3D 0x3000, +}; + +static void +ati_table_setup(void) +{ + SET_VGA(ati_main_table.pll_table, (u32)&ati_pll_table); + SET_VGA(ati_main_table.connector_table, (u32)&ati_connector_table); + SET_VGA(_rom_header_ati_table_anchor, (u32)&ati_main_table); +} + /**************************************************************** * init ****************************************************************/ @@ -379,6 +438,8 @@ ati_setup(void) SET_VGA(VBE_total_memory, totalmem); SET_VGA(ati_io_addr, io_addr); =20 + ati_table_setup(); + // Validate modes struct generic_svga_mode *m =3D svga_modes; unsigned int mcount =3D GET_GLOBAL(svga_mcount); diff --git a/vgasrc/vgaentry.S b/vgasrc/vgaentry.S index f9624fce..14e557a1 100644 --- a/vgasrc/vgaentry.S +++ b/vgasrc/vgaentry.S @@ -41,7 +41,11 @@ _rom_header_signature: .asciz "IBM" =20 #if CONFIG_VGA_ATI -#include "ati-tables.S" + .org 0x48 + .global _rom_header_ati_table_anchor +_rom_header_ati_table_anchor: + .word 0 + .align 16 #endif =20 /**************************************************************** --=20 2.54.0 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org From nobody Sat Aug 15 10:42:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail(p=none dis=none) header.from=jablonski.xyz Return-Path: Received: from coreboot.org (mail.coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 1785261040179429.64862400507116; Tue, 28 Jul 2026 10:50:40 -0700 (PDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id BE98F54E4A9; Tue, 28 Jul 2026 17:50:33 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) (fhigh-a8-smtp.messagingengine.com [103.168.172.159]) by coreboot.org (Postfix) with ESMTP id AAEDF54E495 for ; Tue, 28 Jul 2026 17:43:12 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by mailfhigh.phl.internal (Postfix) with ESMTP id 9F2F8140010D; Tue, 28 Jul 2026 13:43:11 -0400 (EDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by phl-compute-06.internal (MEProxy); Tue, 28 Jul 2026 13:43:11 -0400 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) 28 Jul 2026 13:43:11 -0400 (EDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by chomposaur (OpenSMTPD) with ESMTPA id 7dedaf05; Tue, 28 Jul 2026 17:43:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jablonski.xyz; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1785260591; x= 1785346991; bh=Sp0A7hd3pRDFGgpG4veteTqm59s8VRUfFUpvn4vmqd0=; b=F VL+dAxHud3gDKNrTzWkrjcVuAvN7OM04RekGkTb6jc8/6j79sO20xQVthqBxjMSj uHapyX5afEcasBnITobG4dcnQMh3FitcHJC8FYATIPGdHIzQEce2HAfcKovBRnCd QiM5u8BBsn9BzrGmbeWhK9Fymu/HE/U5Vv9hlA99iMQoWpECfVkx1XgHbdbRFoqp BTorsbbxsVhGVaFLlwqlm19VBwoUkYbf6QL13Gc+9KRHJWFfRHyf71KZHcOQIorN 7JoTWe4tE8q9syFRGxUU4IE5scZJq8xUpo5TlVL1IyUN/XqFJgvbqsmKooOuDw0j OS+4x2AQ8ghcxDakRSEig== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1785260591; x=1785346991; bh=S p0A7hd3pRDFGgpG4veteTqm59s8VRUfFUpvn4vmqd0=; b=OX9vBa/2Dys11vPEB Q+CwF6a6x6fWAIBiPVfWFVP1JtJ9JnXcmHwDgdluxFENjf7JI3y1FVb0/WFIW5g6 DgQ8+S1DYiZle7uydgCLJ5Bwb+03DEk6dWuNI7tRyWR3n14ZlO3L2ZZv7xSnGldW D92neKaVh8oeiBFuQdsyivhT1g2tiPh92FoKOfvBf7Nt5dy4tBowzpID3rKN+A+o by3a5YFSI6zwzTG/bEd5X7PtEgt6caXOCMTJL+a5WOvsK+jTWxkRe4AoWyr4xfS+ TkoyyVeGXmLplInUO6nznYyJv0lHiijH/eypnP8fZmXtW3WwI+nl7U83zJr35zqu gbRHQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGTZqke8f2iSLZvWeqN/SZ2g6GQALNHBfPAZaw6ttUk4D7PLK9KrmPMUe6zOD2pKx /4xmOM27JULEi0xj1gRxkFbt/yLg/R3Hh/VdR6nLZIPvhbJphvjO6Lg1nTwvQ80WFUhDnl 8w4wkTlxaUPlgx3bi+iCcDjx0QgNsKDVXBO6YPtJ9nv1yGG51Npy4rgqEp5Nlz7I83m1i8 CYI9hceta02kx6mPxSQGh0DxngudSh46OazBz63kHplhI1DkRZnXFeJ07gK9nqhNzdTdhN TioGO7rdX4T/8xhfY2lixb+mBkPCSVOVGp+6eg1OmY6ibawGEmmezYrvsC/WfjvuSdO7q2 3c3R4uNuCsVuypkx+VZakqxwTIOcsn00qDso4tbM54Eg4e0dnv74yZD9lc+r19ELvetqzQ UgZVvsdT3dV4F7gx2VtgQ+jEUJkCsUv4RpmbS/bGXSZM88hM+rdV5tcXTFwivQpfR6NEy8 cJaoldeiwbiAIv+lMbhBWm2XBHH4QKkIl/8DXGuEgSNQUQl+ksflEQyz20oCirSWfnQsuV QockwsaTOCXU6Gq0No9gmgs1R63tXdqL5H9pyxj7JV5M9PI4lsRYQngR/vIGS+pNWKjM00 J+1YAC5d4FARh0E7CfPlQYLy9WbD9EzybFIsGcl3aOIWVeRPkbGaruwAQFpQ X-ME-Proxy: Feedback-ID: ib26944c1:Fastmail From: Chad Jablonski To: seabios@seabios.org Date: Tue, 28 Jul 2026 13:42:42 -0400 Message-ID: <20260728174243.1644268-3-chad@jablonski.xyz> In-Reply-To: <20260728174243.1644268-1-chad@jablonski.xyz> References: <20260728174243.1644268-1-chad@jablonski.xyz> MIME-Version: 1.0 Message-ID-Hash: TO4ROQWMMSDNFOLMOOTBWY36M6NVLCMT X-Message-ID-Hash: TO4ROQWMMSDNFOLMOOTBWY36M6NVLCMT X-MailFrom: chad@jablonski.xyz X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header Cc: Gerd Hoffmann , Paul Menzel , Chad Jablonski X-Mailman-Version: 3.3.11b1 Precedence: list Subject: [SeaBIOS] [PATCH v3 2/3] atiext: Add size to bios table for radeon Linux driver (KMS) List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-Spamd-Bar: --- X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZM-MESSAGEID: 1785261040699158500 Content-Type: text/plain; charset="utf-8" The Linux radeon KMS driver does an additional check when looking up COMBIOS table entries. It checks a header size field to validate that the entry falls in the header region. Prior to this patch that size field is zero which causes the driver to fall back to another method (CLOCK_CNTL registers) also resulting in bad values and a division by zero. Tested on Debian Squeeze (Linux 2.6.32) and Debian Trixie (Linux 6.12.94) with: qemu-system-x86_64 -vga none -device ati-vga,model=3Drv100,vgamem_mb=3D32 Signed-off-by: Chad Jablonski Acked-by: Gerd Hoffmann --- vgasrc/atiext.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/vgasrc/atiext.c b/vgasrc/atiext.c index f003eea8..44c9afa0 100644 --- a/vgasrc/atiext.c +++ b/vgasrc/atiext.c @@ -347,7 +347,9 @@ static void ati_i2c_edid_rage128(void) // radeonfb needs the pll information, otherwise it'll crash with a // division by zero ... struct ati_main_table_s { - u8 pad_0[48]; + u8 pad_0[6]; + u8 size; + u8 pad_7[41]; u16 pll_table; u8 pad_50[30]; u16 connector_table; @@ -374,7 +376,9 @@ struct ati_connector_table_s { } PACKED; =20 extern u16 _rom_header_ati_table_anchor; -static struct ati_main_table_s ati_main_table VAR16 __aligned(16); +static struct ati_main_table_s ati_main_table VAR16 __aligned(16) =3D { + .size =3D sizeof(struct ati_main_table_s), +}; static struct ati_pll_table_s ati_pll_table VAR16 __aligned(16) =3D { .sclk =3D 23000, .mclk =3D 23000, --=20 2.54.0 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org From nobody Sat Aug 15 10:42:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail(p=none dis=none) header.from=jablonski.xyz Return-Path: Received: from coreboot.org (mail.coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 1785261186252765.8365291052436; Tue, 28 Jul 2026 10:53:06 -0700 (PDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id D49AB54E4B2; Tue, 28 Jul 2026 17:52:59 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) (fhigh-a8-smtp.messagingengine.com [103.168.172.159]) by coreboot.org (Postfix) with ESMTP id B760654E497 for ; Tue, 28 Jul 2026 17:43:12 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by mailfhigh.phl.internal (Postfix) with ESMTP id C811614000E2; Tue, 28 Jul 2026 13:43:11 -0400 (EDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by phl-compute-04.internal (MEProxy); Tue, 28 Jul 2026 13:43:11 -0400 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) 28 Jul 2026 13:43:11 -0400 (EDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by chomposaur (OpenSMTPD) with ESMTPA id c49eae3d; Tue, 28 Jul 2026 17:43:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jablonski.xyz; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1785260591; x= 1785346991; bh=DDHgczlboW0J9gPt3qlya+4gm168ndgO3wJPsC/Ey2k=; b=P NFT6jDxpjmIIybXBCmXhvY9P9W3rszpGZfZfYhrq/qSGCq9WBQ9AbFgqFubqMMfr 4Lfd3aGj2IWeVttwXagr/L4n/TLI7l0bGVHRytrW0LN7EPxcudekFR+tqWt6cyVI 4xcoTB6d3i3BaOK+JXQnrEgtTm9p5nWeQyHtzwMndliwoxGR4Q3vmZTy38KcknNm 3TJazdg7/m/vHZ0/fCMj5S5N8ZYCILJrNLCRvYg/36N4vDEaeuJEzqwiw+6J+HOa RSgJU1FzBWu4CBVCevSgdarBUyxZYjN5Bj+RpdACBx1lvzSz9nXPZDPYwM54p5xV zZg1bJ2uEl6B9JeEB8XsA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1785260591; x=1785346991; bh=D DHgczlboW0J9gPt3qlya+4gm168ndgO3wJPsC/Ey2k=; b=Di+lzT7FrVUYoYyDD kNNAMHrPXybVaLv4YIGKUZV3mqmSGwivto8v/7WqD7+aNEk6/nPN3O7fuhKysy7q qLvLabbAvB44S1qlVkscim7WnIXhrCwnKwPgua/XMzXlf3SwokqrtN13VtrnlY20 XlFdnRPqRyXjYQmcILsoAmESQuIWWPlxoHgEqH3FkJj3nhi9+EXD9fS/4hMzLfwq mlxw8Dty+EnEE8WUt4pcJxwVFC1vJV/FtVjQehiUtlZuzcEG9BmSfrXnRqHKhvwc KEJdr/JoozKOalnBWU8WQKKfSVl2IJFQ7JUmRd1PnIB/ClCClU+prnG/yow4IZLm EB/Bg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTF81LDbH42TJ1Uz1HN/uEjCrEZGlSAq71qyQQitL/ar+Q6pRtgwqdG+x9geW8JrlD 0qZu9Q4BnwFvii6uKl7hXJK9aMzBY5Ewwnf3hHPLOJ+73FOJ5cW0lYSJkR0hzujwnIb1x5 ZKD++uaUiE2lP3Z0OnGGa7qR/vhel6/aPyWmqvnISZ5uta6LRqOcY5X1imfo79dA3VMshv fT0SjsM7VqEKq9ICeczmubJa0zSwsKblekaEa3gYsmD6LlqzPJGOvZvhbDj3uDU7//RLFr FAdy4Zu69g1/INxVIcdfKBGFUHvUKsKUCsdPaOuUvZjP+4IMkwlOeFSyPOZvJJs/p/u6ft X9fomF3pBVdSD/8aPFHm2QqqoHqbQtc6P5/U4up9pN4Rg9lEVegXbtYhrsvr7fOtTWYaU7 tStu/5e/bwZbWuMdQMLg9QAKRjDEQmhWu91M9qM7CDWoeTdv4b59SKmbV1YnpT/DJR8DMR FxPZtv4dJS+1kqY3JXSD2o5TPrNp2T44iO+GmMmbb/U4DvNwyZhQj9O4ge+fySdhN5A6N9 n6tnT83n+l0t/oHJFmXjnv5skji8keu0NWm8ey8T/ZVVUILUOJvTfk+fLv45tbNvhW7KC+ Xho8oIK6WKR3kiwQmqIQRujwWeLMBxM7RfXcG+AdxMphHZk92mr2OVtow1Gw X-ME-Proxy: Feedback-ID: ib26944c1:Fastmail From: Chad Jablonski To: seabios@seabios.org Date: Tue, 28 Jul 2026 13:42:43 -0400 Message-ID: <20260728174243.1644268-4-chad@jablonski.xyz> In-Reply-To: <20260728174243.1644268-1-chad@jablonski.xyz> References: <20260728174243.1644268-1-chad@jablonski.xyz> MIME-Version: 1.0 X-Spam-Level: *** Message-ID-Hash: TXP65WGILTLKH7JCM4P5XOAOP6OF57DI X-Message-ID-Hash: TXP65WGILTLKH7JCM4P5XOAOP6OF57DI X-MailFrom: chad@jablonski.xyz X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header Cc: Gerd Hoffmann , Paul Menzel , Chad Jablonski X-Mailman-Version: 3.3.11b1 Precedence: list Subject: [SeaBIOS] [PATCH v3 3/3] atiext: Add DDC type to tables for radeon Linux driver (KMS) List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-Spamd-Bar: --- X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZM-MESSAGEID: 1785261187437158500 Content-Type: text/plain; charset="utf-8" The connector info section needs a non-zero value in the DDC type field. Zero causes the Linux radeon driver to fail to initialize the D= DC bus and then no connectors are found. DDC_DVI (0x2) is used here so that the GPIO_DVI_DDC register is used for the radeon. From what I have seen r128 drivers ignore this field entirely. Tested on Debian Squeeze (Linux 2.6.32) and Debian Trixie (Linux 6.12.94) with: qemu-system-x86_64 -vga none -device ati-vga,model=3Drv100,vgamem_mb=3D32 Signed-off-by: Chad Jablonski Acked-by: Gerd Hoffmann --- vgasrc/atiext.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/vgasrc/atiext.c b/vgasrc/atiext.c index 44c9afa0..1b857967 100644 --- a/vgasrc/atiext.c +++ b/vgasrc/atiext.c @@ -15,6 +15,9 @@ =20 #include "svgamodes.h" =20 +#define CONNECTOR_DVI_I_LEGACY 0x3 +#define DDC_DVI 0x2 + #define MM_INDEX 0x0000 #define MM_DATA 0x0004 #define CRTC_GEN_CNTL 0x0050 @@ -390,7 +393,7 @@ static struct ati_pll_table_s ati_pll_table VAR16 __ali= gned(16) =3D { static struct ati_connector_table_s ati_connector_table VAR16 __aligned(16= ) =3D { .num_chip =3D 0x10, .num_connector =3D 1, - .flags =3D 0x3000, + .flags =3D (CONNECTOR_DVI_I_LEGACY << 12) | (DDC_DVI << 8) }; =20 static void --=20 2.54.0 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org