From nobody Sat Jul 25 08:00:05 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=pass(p=reject dis=none) header.from=seabios.org ARC-Seal: i=1; a=rsa-sha256; t=1784741279; cv=none; d=zohomail.com; s=zohoarc; b=BR7DaibeBBNys3ZsPgFlfdg5wBFAiX58jD4j2a86U9q5IQQRSs45R7cRVvgHAS5KE3I7lVHMQ5fw0xqylW2ih5u6AUvFv6gEUxg5n2sEFtAwipOY42XwCu7jJKWHapL5+zyAOXsNtLgc6X0jVFNB5T+OsyCSQRfw4aDCHtHCkTQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784741279; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id; bh=pZuMqfaym99SQp0OXvWsCemw4Nm7ueNbQ1lK5jCNIbw=; b=eS+5KKeeZ/vjo/VeqNz23KG2nE2dvVhnByjqI5wfYuhM506q5zHADbDQ8psnDy1pNymaA4Rxsmn4c2lDNBGpfT2rBcKU5Va3YrZqsYWIUGxWOpxZCxpnLEgrZEfI/AeP33RAiZPtXjc+tKrHuAAPj4NOBfcCEZo8K39+JsfxKA8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from coreboot.org (mail.coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 1784741279686248.82107602501526; Wed, 22 Jul 2026 10:27:59 -0700 (PDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id 8930D54E50D; Wed, 22 Jul 2026 17:27:57 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) [185.70.43.17]) by coreboot.org (Postfix) with ESMTP id 572F754E4E1 for ; Wed, 22 Jul 2026 17:27:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seabios.org; s=dkim; t=1784741277; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:list-id:list-owner:list-unsubscribe:list-subscribe:list-post; bh=pZuMqfaym99SQp0OXvWsCemw4Nm7ueNbQ1lK5jCNIbw=; b=Ml7EFT2FCOLqogcntzu9brFr6pymnGU1HAYE+DBcsB56WqWmIsgLWgJdI4EhMCWtI4dv1B IytdFA+nqHicUWtaMDkFz9lmLNbtQ222pnAFHwD2IJd9Jvq+0+f/ulogW8ia1XSQ8LSVxF rjAzV1qSlMr8yas/zfN2h7Pxa3dfgDY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=koconnor.net; s=protonmail3; t=1784741257; x=1785000457; bh=KDa9C59DahJIl4m89A/By6J9eya3n2jI5RYEXcrJC6Y=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=qztG/nJjHokfOP064zf2KXeKrUr2TZJ1Vlf9ps1/FcTrq8JFOky5/b1izX+vHWrtk mnJ7YrIe7o38IhsS7bkj1Ilwnpjri3m5UChGqxLpxtsXocO3ZmYlOCnYDgnjIg0OUQ S1kELMZZKvd6+hUkYHZ4o23FK/MA3LAl/MMndSpOkDVXGRmM8vpuur388BrVn1bker DmazeuogIlquK94beKvR6N6LzGUuJxOoHizoliycnggooSOJ1O2+9L4WdqTi/0T68j ViFxxpnjtkdjbFMBaJhf/uQfzonNAJnU0Cz/JaB+zeJlaZzE8GFeIiDvYYV6SLrjlP 7vTwO5P4YY8Sg== Date: Wed, 22 Jul 2026 17:27:35 +0000 To: seabios@seabios.org Message-ID: <20260722172729.816870-1-kevin@koconnor.net> Feedback-ID: 132158305:user:proton X-Pm-Message-ID: 2c2c1b5f6f6cc0769a893cf2f2f1b7c68f45ecf3 MIME-Version: 1.0 Message-ID-Hash: 5EQWNINLR55GCV2I5SYKWG3PHR6LIQOP X-Message-ID-Hash: 5EQWNINLR55GCV2I5SYKWG3PHR6LIQOP X-MailFrom: kevin@koconnor.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header Cc: Christian Quante X-Mailman-Version: 3.3.11b1 Precedence: list Subject: [SeaBIOS] [PATCH] floppy: Fix failed media sense return code List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Kevin O'Connor via SeaBIOS Reply-To: Kevin O'Connor Content-Transfer-Encoding: quoted-printable Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-Spamd-Bar: / X-ZohoMail-DKIM: pass (identity @seabios.org) X-ZM-MESSAGEID: 1784741280221158500 Content-Type: text/plain; charset="utf-8" An error in floppy_media_sense() returned error code 0xc0. However, this appears to be a typo when porting the original bochs bios code, as it uses 0x0c. It appears this typo was introduced in the first SeaBIOS commit (f076a3ee). Change the code to return 0x0c (DISK_RET_EBADTRACK) on an error. Signed-off-by: Kevin O'Connor --- src/hw/floppy.c | 2 +- src/std/disk.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/hw/floppy.c b/src/hw/floppy.c index ebed54f..a51711a 100644 --- a/src/hw/floppy.c +++ b/src/hw/floppy.c @@ -515,7 +515,7 @@ floppy_media_sense(struct drive_s *drive_gf) // Attempt media sense. for (stype=3D1; ; stype++) { if (stype >=3D ARRAY_SIZE(FloppyInfo)) - return DISK_RET_EMEDIA; + return DISK_RET_EBADTRACK; if (stype=3D=3Dftype || (GET_GLOBAL(FloppyInfo[stype].floppy_size) !=3D GET_GLOBAL(FloppyInfo[ftype].floppy_size)) diff --git a/src/std/disk.h b/src/std/disk.h index 6397108..68ccecc 100644 --- a/src/std/disk.h +++ b/src/std/disk.h @@ -17,7 +17,6 @@ #define DISK_RET_ELOCKED 0xb1 #define DISK_RET_ENOTREMOVABLE 0xb2 #define DISK_RET_ETOOMANYLOCKS 0xb4 -#define DISK_RET_EMEDIA 0xC0 #define DISK_RET_ENOTREADY 0xAA =20 =20 --=20 2.53.0 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org