From nobody Sun Sep 21 23:30:55 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail(p=none dis=none) header.from=flygoat.com Return-Path: Received: from coreboot.org (mail.coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 1757391675846482.52959768316816; Mon, 8 Sep 2025 21:21:15 -0700 (PDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id 4498C403D3; Tue, 9 Sep 2025 04:21:13 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) (fout-b1-smtp.messagingengine.com [202.12.124.144]) by coreboot.org (Postfix) with ESMTP id 0513D40293 for ; Tue, 9 Sep 2025 04:18:16 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by mailfout.stl.internal (Postfix) with ESMTP id DB4651D001AF; Tue, 9 Sep 2025 00:18:14 -0400 (EDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by phl-compute-01.internal (MEProxy); Tue, 09 Sep 2025 00:18:14 -0400 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) 9 Sep 2025 00:18:13 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flygoat.com; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1757391494; x=1757477894; bh=l8RF2LZHSL+0M8bMBg2Zoeo6V7//TQDcBM1kuspPerU=; b= C7NC7sM2TjWiHJXHM5uNHggBgGmoUP3jolyuTYYHuq5fUQX9WGP+Ai1Unnt0vWBu rA8egpCJhqJ0sxNdB8SS4jKKExjzlsgdVs7XxthLSzP+3tTU8Y3XhWoplha4uEPk 5l0Z/9jkigK/JgFGMEGsFmgBsD6+QSiJsR3mYb26KNvp/e/rwP53p05eJFXl0FI7 ZRteQ/SormS+2TCNHr8hhJoruxyA+WgcnesUAPjuCaNLcoI5LJjgcAI3HzKhu0pH TdolQyCle7SUaGSFUBtNkKQHfiVHKFWXeT2+KptaqH1MpFWyapM/9978gCTOzj26 pdwMf/frLcqxSPXEKCK5Eg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1757391494; x= 1757477894; bh=l8RF2LZHSL+0M8bMBg2Zoeo6V7//TQDcBM1kuspPerU=; b=M HAf3pdGTf5eZfK/QaTlIloC3N0453xEfuygv3QkKGzYSZLrWuBL/JV/8qF71wOX8 OYABtKeuSYpUp7V7gzCKhJR6KHXizVfB9t1NV1QE/J7r/zrDnaT1OOJ5Xs75+9fD 0dcfKjeyg9yB1Yukk8KNVl6gq4yYtoc9CTtve1H4wAcCl1++ALMmrrWpDj9gEs97 D1ZlulSXJ0pBR9HKjuhkLKBx7WB+40rC3B5oDo4vpJKT1iovkeJbHosZigI10Iyh rIavwmhukuim2VUUonTmI0P5PHM46vZVrZpS23EPHP8aDlPf74cxu6nmq7/IyktS QPHLbf5m/lHQxGct/ByRA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdduleegfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecunecujfgurhephfffufggtgfgkfhfjgfvvefosehtjeertd ertdejnecuhfhrohhmpeflihgrgihunhcujggrnhhguceojhhirgiguhhnrdihrghnghes fhhlhihgohgrthdrtghomheqnecuggftrfgrthhtvghrnhepvdekiefhfeevkeeuveetfe elffekgedugefhtdduudeghfeuveegffegudekjeelnecuvehluhhsthgvrhfuihiivgep udenucfrrghrrghmpehmrghilhhfrhhomhepjhhirgiguhhnrdihrghnghesfhhlhihgoh grthdrtghomhdpnhgspghrtghpthhtohepvddpmhhouggvpehsmhhtphhouhhtpdhrtghp thhtohepshgvrggsihhoshesshgvrggsihhoshdrohhrghdprhgtphhtthhopehjihgrgi hunhdrhigrnhhgsehflhihghhorghtrdgtohhm X-ME-Proxy: Feedback-ID: ifd894703:Fastmail From: Jiaxun Yang Date: Tue, 09 Sep 2025 04:18:02 +0000 MIME-Version: 1.0 Message-Id: <20250909-build-v3-9-3128c8c8c3ad@flygoat.com> References: <20250909-build-v3-0-3128c8c8c3ad@flygoat.com> In-Reply-To: <20250909-build-v3-0-3128c8c8c3ad@flygoat.com> To: seabios@seabios.org Message-ID-Hash: GM5MGVS72S7ED7WMHDEAGJEXZX3QKVCL X-Message-ID-Hash: GM5MGVS72S7ED7WMHDEAGJEXZX3QKVCL X-MailFrom: jiaxun.yang@flygoat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Jiaxun Yang X-Mailman-Version: 3.3.11b1 Precedence: list Subject: [SeaBIOS] [PATCH v3 9/9] usb-ohci: Fix logical condition in start_ohci function List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-Spamd-Bar: ---- X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZM-MESSAGEID: 1757391677208116600 Content-Type: text/plain; charset="utf-8" Correct the logical condition in the start_ohci function to ensure proper evaluation of the status variable. Fix warning: ./src/hw/usb-ohci.c:192:13: warning: logical not is only applied to the lef= t hand side of this bitwise operator [-Wlogical-not-parentheses] 192 | if (! status & OHCI_HCR) Signed-off-by: Jiaxun Yang --- src/hw/usb-ohci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hw/usb-ohci.c b/src/hw/usb-ohci.c index 90f60e6452957552412d2aa9958f00141473437a..0fe8ea9e5d36468516e60830510= 4da1e2129be70 100644 --- a/src/hw/usb-ohci.c +++ b/src/hw/usb-ohci.c @@ -189,7 +189,7 @@ start_ohci(struct usb_ohci_s *cntl, struct ohci_hcca *h= cca) writel(&cntl->regs->cmdstatus, OHCI_HCR); for (;;) { u32 status =3D readl(&cntl->regs->cmdstatus); - if (! status & OHCI_HCR) + if (!(status & OHCI_HCR)) break; if (timer_check(end)) { warn_timeout(); --=20 2.43.0 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org