From nobody Sun Sep 21 21:44:29 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail(p=none dis=none) header.from=flygoat.com Return-Path: Received: from coreboot.org (mail.coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 1756882328502515.3767596185611; Tue, 2 Sep 2025 23:52:08 -0700 (PDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id 293124037C; Wed, 3 Sep 2025 06:52:06 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) (fout-a3-smtp.messagingengine.com [103.168.172.146]) by coreboot.org (Postfix) with ESMTP id 6E50740192 for ; Wed, 3 Sep 2025 06:51:31 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by mailfout.phl.internal (Postfix) with ESMTP id 301D6EC0324; Wed, 3 Sep 2025 02:51:30 -0400 (EDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by phl-compute-04.internal (MEProxy); Wed, 03 Sep 2025 02:51:30 -0400 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) 3 Sep 2025 02:51:28 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flygoat.com; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1756882290; x=1756968690; bh=/D4k+xdpBLnHgGg47/1XASBgV8Hn6yniMGf6rZtCfCg=; b= Q8bHXuUBDohY84UA5FaM6TJrI5i09oOCZ5EdNs7kqMdILwE/BSASj3dphKYauM66 i+PATjYRQ8qGY566t5Y0lxhm8ntvcE1CniHkG4vG0q4XMzL3FabdpCanF8l5Rcr4 RByo03GOyWVyoeLBr1gqSZfFP0VsuPpi3nrWZOQy06UbS2I58xpsrCmap5JfwLhC L9SF87G+B0pvIi9s2odLBsbu0iNq9NkDH3lx702W8SJkee9ikeHhlCrIuePqfrL0 zL+euj/KepxVSkwsYPvT8NfVtOPIz89j5KrMNxS3QBVNUbrLjXoOo1FkZ91lcR8X MBgb6WzzKBzX2dHUKACZXQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1756882290; x= 1756968690; bh=/D4k+xdpBLnHgGg47/1XASBgV8Hn6yniMGf6rZtCfCg=; b=L Z5TkcvK9lBr4v0GIi4M+FGPvDE8iY68hTlEoDkD2hFWD8eb871bZlAn/CR/FsFNU yt8lXTJWv3i0RpWic/WxG/Fg3ZI9H50o0+3DSeDU7SA+YFckeB4Ft5I5B/tosbjd OQjNL8dzdLhcGLbacRu3nlwBJzRjVGFy1MUWozYKd5sQR9iqHm87ta3uJMXmkzZD YgW0IjXO5rT55SMkXWzrz3JRDQtjxL1R9j2vO38fcu0YFmlDTk1E7d54mHiCauuK HAfLUZOWitcwwEeiqJ7aU5j8WKRfXEakvJlhJ3+l12vwV+Jqic/ghOwvl47Me2PD 4HxpelMB/GGh5TqzHyclA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvgeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh ephfffufggtgfgkfhfjgfvvefosehtkeertdertdejnecuhfhrohhmpeflihgrgihunhcu jggrnhhguceojhhirgiguhhnrdihrghnghesfhhlhihgohgrthdrtghomheqnecuggftrf grthhtvghrnhepveevteehgefggeejkeejtddtteeuleduheevjefgjeetvdfhudegtefg lefhveeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epjhhirgiguhhnrdihrghnghesfhhlhihgohgrthdrtghomhdpnhgspghrtghpthhtohep fedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepphhhihhlmhgusehlihhnrghroh drohhrghdprhgtphhtthhopehsvggrsghiohhssehsvggrsghiohhsrdhorhhgpdhrtghp thhtohepjhhirgiguhhnrdihrghnghesfhhlhihgohgrthdrtghomh X-ME-Proxy: Feedback-ID: ifd894703:Fastmail From: Jiaxun Yang Date: Wed, 03 Sep 2025 06:51:22 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Message-Id: <20250903-build-v2-1-8e8916974f9c@flygoat.com> References: <20250903-build-v2-0-8e8916974f9c@flygoat.com> In-Reply-To: <20250903-build-v2-0-8e8916974f9c@flygoat.com> To: seabios@seabios.org Message-ID-Hash: NRM6U6UWPV36UFC4WFWPPSLAX72ZISLY X-Message-ID-Hash: NRM6U6UWPV36UFC4WFWPPSLAX72ZISLY X-MailFrom: jiaxun.yang@flygoat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Jiaxun Yang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Mailman-Version: 3.3.11b1 Precedence: list Subject: [SeaBIOS] [PATCH v2 1/9] Remove remaining ACPI tooling bits List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-Spamd-Bar: ---- X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZM-MESSAGEID: 1756882330431124100 Builtin ACPI support was removed before. Now clean remaining tooling bits. Fixes: 35aa9a72c279 ("drop obsolete acpi table code") Signed-off-by: Jiaxun Yang Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- Makefile | 3 +- scripts/acpi_extract.py | 366 ---------------------------------= ---- scripts/acpi_extract_preprocess.py | 41 ----- 3 files changed, 1 insertion(+), 409 deletions(-) diff --git a/Makefile b/Makefile index 4ccc2bee8129b1f1d49f61559533fdbdf6e1ddd8..01f42ec334591be5c6ed58c6bbe= 478de01f4b26d 100644 --- a/Makefile +++ b/Makefile @@ -24,7 +24,6 @@ OBJDUMP=3D$(CROSS_PREFIX)objdump STRIP=3D$(CROSS_PREFIX)strip PYTHON=3Dpython CPP=3Dcpp -IASL:=3Diasl LD32BIT_FLAG:=3D-melf_i386 =20 # Source files @@ -111,7 +110,7 @@ all: $(target-y) ################ Common build rules =20 # Verify the build environment works. -TESTGCC:=3D$(shell OUT=3D"$(OUT)" CC=3D"$(CC)" LD=3D"$(LD)" IASL=3D"$(IASL= )" scripts/test-build.sh) +TESTGCC:=3D$(shell OUT=3D"$(OUT)" CC=3D"$(CC)" LD=3D"$(LD)" scripts/test-b= uild.sh) ifeq "$(TESTGCC)" "-1" $(error "Please upgrade the build environment") endif diff --git a/scripts/acpi_extract.py b/scripts/acpi_extract.py deleted file mode 100755 index 3ed863b6a79412a1276bb905d08f92bd677e9e09..000000000000000000000000000= 0000000000000 --- a/scripts/acpi_extract.py +++ /dev/null @@ -1,366 +0,0 @@ -#!/usr/bin/python -# Copyright (C) 2011 Red Hat, Inc., Michael S. Tsirkin -# -# This file may be distributed under the terms of the GNU GPLv3 license. - -# Process mixed ASL/AML listing (.lst file) produced by iasl -l -# Locate and execute ACPI_EXTRACT directives, output offset info -#=20 -# Documentation of ACPI_EXTRACT_* directive tags: -#=20 -# These directive tags output offset information from AML for BIOS runtime -# table generation. -# Each directive is of the form: -# ACPI_EXTRACT_ (...) -# and causes the extractor to create an array -# named with offset, in the generated AML, -# of an object of a given type in the following . -#=20 -# A directive must fit on a single code line. -#=20 -# Object type in AML is verified, a mismatch causes a build failure. -#=20 -# Directives and operators currently supported are: -# ACPI_EXTRACT_NAME_DWORD_CONST - extract a Dword Const object from Name() -# ACPI_EXTRACT_NAME_WORD_CONST - extract a Word Const object from Name() -# ACPI_EXTRACT_NAME_BYTE_CONST - extract a Byte Const object from Name() -# ACPI_EXTRACT_METHOD_STRING - extract a NameString from Method() -# ACPI_EXTRACT_NAME_STRING - extract a NameString from Name() -# ACPI_EXTRACT_PROCESSOR_START - start of Processor() block -# ACPI_EXTRACT_PROCESSOR_STRING - extract a NameString from Processor() -# ACPI_EXTRACT_PROCESSOR_END - offset at last byte of Processor() + 1 -# ACPI_EXTRACT_DEVICE_START - start of Device() block -# ACPI_EXTRACT_DEVICE_STRING - extract a NameString from Device() -# ACPI_EXTRACT_DEVICE_END - offset at last byte of Device() + 1 -# ACPI_EXTRACT_PKG_START - start of Package block -# -# ACPI_EXTRACT_ALL_CODE - create an array storing the generated AML byteco= de -#=20 -# ACPI_EXTRACT is not allowed anywhere else in code, except in comments. - -import re -import sys -import fileinput - -aml =3D [] -asl =3D [] -output =3D {} -debug =3D "" - -class asl_line: - line =3D None - lineno =3D None - aml_offset =3D None - -def die(diag): - sys.stderr.write("Error: %s; %s\n" % (diag, debug)) - sys.exit(1) - -#Store an ASL command, matching AML offset, and input line (for debugging) -def add_asl(lineno, line): - l =3D asl_line() - l.line =3D line - l.lineno =3D lineno - l.aml_offset =3D len(aml) - asl.append(l) - -#Store an AML byte sequence -#Verify that offset output by iasl matches # of bytes so far -def add_aml(offset, line): - o =3D int(offset, 16) - # Sanity check: offset must match size of code so far - if (o !=3D len(aml)): - die("Offset 0x%x !=3D 0x%x" % (o, len(aml))) - # Strip any trailing dots and ASCII dump after " - line =3D re.sub(r'\s*\.*\s*".*$', "", line) - # Strip traling whitespace - line =3D re.sub(r'\s+$', "", line) - # Strip leading whitespace - line =3D re.sub(r'^\s+', "", line) - # Split on whitespace - code =3D re.split(r'\s+', line) - for c in code: - # Require a legal hex number, two digits - if (not(re.search(r'^[0-9A-Fa-f][0-9A-Fa-f]$', c))): - die("Unexpected octet %s" % c) - aml.append(int(c, 16)) - -# Process aml bytecode array, decoding AML -def aml_pkglen_bytes(offset): - # PkgLength can be multibyte. Bits 8-7 give the # of extra bytes. - pkglenbytes =3D aml[offset] >> 6 - return pkglenbytes + 1 - -def aml_pkglen(offset): - pkgstart =3D offset - pkglenbytes =3D aml_pkglen_bytes(offset) - pkglen =3D aml[offset] & 0x3F - # If multibyte, first nibble only uses bits 0-3 - if ((pkglenbytes > 1) and (pkglen & 0x30)): - die("PkgLen bytes 0x%x but first nibble 0x%x expected 0x0X" % - (pkglen, pkglen)) - offset +=3D 1 - pkglenbytes -=3D 1 - for i in range(pkglenbytes): - pkglen |=3D aml[offset + i] << (i * 8 + 4) - if (len(aml) < pkgstart + pkglen): - die("PckgLen 0x%x at offset 0x%x exceeds AML size 0x%x" % - (pkglen, offset, len(aml))) - return pkglen - -# Given method offset, find its NameString offset -def aml_method_string(offset): - #0x14 MethodOp PkgLength NameString MethodFlags TermList - if (aml[offset] !=3D 0x14): - die( "Method offset 0x%x: expected 0x14 actual 0x%x" % - (offset, aml[offset])) - offset +=3D 1 - pkglenbytes =3D aml_pkglen_bytes(offset) - offset +=3D pkglenbytes - return offset - -# Given name offset, find its NameString offset -def aml_name_string(offset): - #0x08 NameOp NameString DataRef - if (aml[offset] !=3D 0x08): - die( "Name offset 0x%x: expected 0x08 actual 0x%x" % - (offset, aml[offset])) - offset +=3D 1 - # Block Name Modifier. Skip it. - if (aml[offset] =3D=3D 0x5c or aml[offset] =3D=3D 0x5e): - offset +=3D 1 - return offset - -# Given data offset, find 8 byte buffer offset -def aml_data_buffer8(offset): - #0x08 NameOp NameString DataRef - expect =3D [0x11, 0x0B, 0x0A, 0x08] - if (aml[offset:offset+4] !=3D expect): - die( "Name offset 0x%x: expected %s actual %s" % - (offset, aml[offset:offset+4], expect)) - return offset + len(expect) - -# Given data offset, find dword const offset -def aml_data_dword_const(offset): - #0x08 NameOp NameString DataRef - if (aml[offset] !=3D 0x0C): - die( "Name offset 0x%x: expected 0x0C actual 0x%x" % - (offset, aml[offset])) - return offset + 1 - -# Given data offset, find word const offset -def aml_data_word_const(offset): - #0x08 NameOp NameString DataRef - if (aml[offset] !=3D 0x0B): - die( "Name offset 0x%x: expected 0x0B actual 0x%x" % - (offset, aml[offset])) - return offset + 1 - -# Given data offset, find byte const offset -def aml_data_byte_const(offset): - #0x08 NameOp NameString DataRef - if (aml[offset] !=3D 0x0A): - die( "Name offset 0x%x: expected 0x0A actual 0x%x" % - (offset, aml[offset])) - return offset + 1 - -# Find name'd buffer8 -def aml_name_buffer8(offset): - return aml_data_buffer8(aml_name_string(offset) + 4) - -# Given name offset, find dword const offset -def aml_name_dword_const(offset): - return aml_data_dword_const(aml_name_string(offset) + 4) - -# Given name offset, find word const offset -def aml_name_word_const(offset): - return aml_data_word_const(aml_name_string(offset) + 4) - -# Given name offset, find byte const offset -def aml_name_byte_const(offset): - return aml_data_byte_const(aml_name_string(offset) + 4) - -def aml_device_start(offset): - #0x5B 0x82 DeviceOp PkgLength NameString - if ((aml[offset] !=3D 0x5B) or (aml[offset + 1] !=3D 0x82)): - die( "Name offset 0x%x: expected 0x5B 0x82 actual 0x%x 0x%x" % - (offset, aml[offset], aml[offset + 1])) - return offset - -def aml_device_string(offset): - #0x5B 0x82 DeviceOp PkgLength NameString - start =3D aml_device_start(offset) - offset +=3D 2 - pkglenbytes =3D aml_pkglen_bytes(offset) - offset +=3D pkglenbytes - return offset - -def aml_device_end(offset): - start =3D aml_device_start(offset) - offset +=3D 2 - pkglenbytes =3D aml_pkglen_bytes(offset) - pkglen =3D aml_pkglen(offset) - return offset + pkglen - -def aml_processor_start(offset): - #0x5B 0x83 ProcessorOp PkgLength NameString ProcID - if ((aml[offset] !=3D 0x5B) or (aml[offset + 1] !=3D 0x83)): - die( "Name offset 0x%x: expected 0x5B 0x83 actual 0x%x 0x%x" % - (offset, aml[offset], aml[offset + 1])) - return offset - -def aml_processor_string(offset): - #0x5B 0x83 ProcessorOp PkgLength NameString ProcID - start =3D aml_processor_start(offset) - offset +=3D 2 - pkglenbytes =3D aml_pkglen_bytes(offset) - offset +=3D pkglenbytes - return offset - -def aml_processor_end(offset): - start =3D aml_processor_start(offset) - offset +=3D 2 - pkglenbytes =3D aml_pkglen_bytes(offset) - pkglen =3D aml_pkglen(offset) - return offset + pkglen - -def aml_package_start(offset): - offset =3D aml_name_string(offset) + 4 - # 0x12 PkgLength NumElements PackageElementList - if (aml[offset] !=3D 0x12): - die( "Name offset 0x%x: expected 0x12 actual 0x%x" % - (offset, aml[offset])) - offset +=3D 1 - return offset + aml_pkglen_bytes(offset) + 1 - -def get_value_type(maxvalue): - #Use type large enough to fit the table - if (maxvalue >=3D 0x10000): - return "int" - elif (maxvalue >=3D 0x100): - return "short" - else: - return "char" - -def main(): - global debug - lineno =3D 0 - for line in fileinput.input(): - # Strip trailing newline - line =3D line.rstrip() - # line number and debug string to output in case of errors - lineno =3D lineno + 1 - debug =3D "input line %d: %s" % (lineno, line) - #ASL listing: space, then line#, then ...., then code - pasl =3D re.compile('^\s+([0-9]+)(:\s\s|\.\.\.\.)\s*') - m =3D pasl.search(line) - if (m): - add_asl(lineno, pasl.sub("", line)) - # AML listing: offset in hex, then ...., then code - paml =3D re.compile('^([0-9A-Fa-f]+)(:\s\s|\.\.\.\.)\s*') - m =3D paml.search(line) - if (m): - add_aml(m.group(1), paml.sub("", line)) - - # Now go over code - # Track AML offset of a previous non-empty ASL command - prev_aml_offset =3D -1 - for i in range(len(asl)): - debug =3D "input line %d: %s" % (asl[i].lineno, asl[i].line) - - l =3D asl[i].line - - # skip if not an extract directive - a =3D len(re.findall(r'ACPI_EXTRACT', l)) - if (not a): - # If not empty, store AML offset. Will be used for sanity chec= ks - # IASL seems to put {}. at random places in the listing. - # Ignore any non-words for the purpose of this test. - m =3D re.search(r'\w+', l) - if (m): - prev_aml_offset =3D asl[i].aml_offset - continue - - if (a > 1): - die("Expected at most one ACPI_EXTRACT per line, actual %d" % = a) - - mext =3D re.search(r''' - ^\s* # leading whitespace - /\*\s* # start C comment - (ACPI_EXTRACT_\w+) # directive: group(1) - \s+ # whitspace separates directive from array n= ame - (\w+) # array name: group(2) - \s*\*/ # end of C comment - \s*$ # trailing whitespace - ''', l, re.VERBOSE) - if (not mext): - die("Stray ACPI_EXTRACT in input") - - # previous command must have produced some AML, - # otherwise we are in a middle of a block - if (prev_aml_offset =3D=3D asl[i].aml_offset): - die("ACPI_EXTRACT directive in the middle of a block") - - directive =3D mext.group(1) - array =3D mext.group(2) - offset =3D asl[i].aml_offset - - if (directive =3D=3D "ACPI_EXTRACT_ALL_CODE"): - if array in output: - die("%s directive used more than once" % directive) - output[array] =3D aml - continue - if (directive =3D=3D "ACPI_EXTRACT_NAME_BUFFER8"): - offset =3D aml_name_buffer8(offset) - elif (directive =3D=3D "ACPI_EXTRACT_NAME_DWORD_CONST"): - offset =3D aml_name_dword_const(offset) - elif (directive =3D=3D "ACPI_EXTRACT_NAME_WORD_CONST"): - offset =3D aml_name_word_const(offset) - elif (directive =3D=3D "ACPI_EXTRACT_NAME_BYTE_CONST"): - offset =3D aml_name_byte_const(offset) - elif (directive =3D=3D "ACPI_EXTRACT_NAME_STRING"): - offset =3D aml_name_string(offset) - elif (directive =3D=3D "ACPI_EXTRACT_METHOD_STRING"): - offset =3D aml_method_string(offset) - elif (directive =3D=3D "ACPI_EXTRACT_DEVICE_START"): - offset =3D aml_device_start(offset) - elif (directive =3D=3D "ACPI_EXTRACT_DEVICE_STRING"): - offset =3D aml_device_string(offset) - elif (directive =3D=3D "ACPI_EXTRACT_DEVICE_END"): - offset =3D aml_device_end(offset) - elif (directive =3D=3D "ACPI_EXTRACT_PROCESSOR_START"): - offset =3D aml_processor_start(offset) - elif (directive =3D=3D "ACPI_EXTRACT_PROCESSOR_STRING"): - offset =3D aml_processor_string(offset) - elif (directive =3D=3D "ACPI_EXTRACT_PROCESSOR_END"): - offset =3D aml_processor_end(offset) - elif (directive =3D=3D "ACPI_EXTRACT_PKG_START"): - offset =3D aml_package_start(offset) - else: - die("Unsupported directive %s" % directive) - - if array not in output: - output[array] =3D [] - output[array].append(offset) - - debug =3D "at end of file" - - # Pretty print output - outstrs =3D ["/* DO NOT EDIT! This is an autogenerated file." - " See scripts/acpi_extract.py. */"] - for array in output.keys(): - otype =3D get_value_type(max(output[array])) - outstrs.append("static unsigned %s %s[] =3D {" % (otype, array)) - odata =3D [] - for value in output[array]: - odata.append("0x%02x" % value) - if len(odata) >=3D 8: - outstrs.append(" %s," % (', '.join(odata),)) - del odata[:] - outstrs.append(" %s" % (', '.join(odata),)) - outstrs.append('};') - outstrs.append('') - sys.stdout.write('\n'.join(outstrs)) - -if __name__ =3D=3D '__main__': - main() diff --git a/scripts/acpi_extract_preprocess.py b/scripts/acpi_extract_prep= rocess.py deleted file mode 100755 index 2698118406d97c164783335c7fb6cbfa6239183b..000000000000000000000000000= 0000000000000 --- a/scripts/acpi_extract_preprocess.py +++ /dev/null @@ -1,41 +0,0 @@ -#!/usr/bin/python -# Copyright (C) 2011 Red Hat, Inc., Michael S. Tsirkin -# -# This file may be distributed under the terms of the GNU GPLv3 license. - -# Read a preprocessed ASL listing and put each ACPI_EXTRACT -# directive in a comment, to make iasl skip it. -# We also put each directive on a new line, the machinery -# in scripts/acpi_extract.py requires this. - -import re -import sys -import fileinput - -def die(diag): - sys.stderr.write("Error: %s\n" % (diag)) - sys.exit(1) - -# Note: () around pattern make split return matched string as part of list -psplit =3D re.compile(r''' ( - \b # At word boundary - ACPI_EXTRACT_\w+ # directive - \s+ # some whitespace - \w+ # array name - )''', re.VERBOSE) - -lineno =3D 0 -for line in fileinput.input(): - # line number and debug string to output in case of errors - lineno =3D lineno + 1 - debug =3D "input line %d: %s" % (lineno, line.rstrip()) - - s =3D psplit.split(line) - # The way split works, each odd item is the matching ACPI_EXTRACT dire= ctive. - # Put each in a comment, and on a line by itself. - for i in range(len(s)): - if (i % 2): - sys.stdout.write("\n/* %s */\n" % s[i]) - else: - sys.stdout.write(s[i]) - --=20 2.43.0 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org From nobody Sun Sep 21 21:44:29 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail(p=none dis=none) header.from=flygoat.com Return-Path: Received: from coreboot.org (mail.coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 175688234720886.73032183941746; Tue, 2 Sep 2025 23:52:27 -0700 (PDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id 1601140192; Wed, 3 Sep 2025 06:52:24 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) (fout-a3-smtp.messagingengine.com [103.168.172.146]) by coreboot.org (Postfix) with ESMTP id 8F4884033D for ; Wed, 3 Sep 2025 06:51:32 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by mailfout.phl.internal (Postfix) with ESMTP id A8EFCEC0352; Wed, 3 Sep 2025 02:51:31 -0400 (EDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by phl-compute-06.internal (MEProxy); Wed, 03 Sep 2025 02:51:31 -0400 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) 3 Sep 2025 02:51:30 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flygoat.com; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1756882291; x=1756968691; bh=MY9mwkbFVd5DeBCOTrAqvnvUyLgbfcbbLERc49E5caE=; b= WDdoLgXgXT0tfThTHyRwdAM3kYl9n8XVFjrqcPRhNzLc2qFzdCw6JaFy5U3SztQt ZodwSMC8Qetmr6hBpdF/L74lAAmuApvMciHyPTWdBxRvGxLG9cbyTHYDqJQbpJ8A WaENvzEw5VV1whGjPsKz7Ce3saJLXBPh2JvVMtebAmA8OFkFaNPtBuYDPKbuvvK/ FuS+XUpUJlwaXrrrarQz/jmPtgyhDVi3BreIRUForvQrnjCFjw3Uq7eluwaKAJcL UcDZ8x48iWayaTR0allN+nwF3dY21tzMW18Zx5eH3ut+CzTKsQ1gJL8tlXscAIyP nkycmfF91RNx/kqGrFyCQw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1756882291; x= 1756968691; bh=MY9mwkbFVd5DeBCOTrAqvnvUyLgbfcbbLERc49E5caE=; b=U 8/bWskkyl1/yDkFsxY7QUlD08lhxE6YwDIf+lGF3iBZtcUqbweluKAw2lOVo0A30 HpjnVMapaTd7rq0ZYN1tKC/bYWjmpKpOo8N5CEdqiqlfpsRr7sViSIIsTDkttqgr ocTEm6zSRaF0VGslKu66UYsHOvZ9Mv7wN0WuicmBmbYEyQQx06J5HwSBC+hw95+g Syr/LhSi0fa9dF1TlPF4n4WY1ESaIWu3o+cuVVMZoJgjCCXgJ4tcBVBS/kMm+3wd U5zSWOBDFyQtG7xkOUS8Ne23qEHFROU6UpvJEty00B1pgI3MpDxZMzaFfY+8iQMG PG4/JEzHhl6Jtw9OachEQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvgeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucenucfjughrpefhfffugggtgffkfhgjvfevofesthejredtre dtjeenucfhrhhomheplfhirgiguhhnucgjrghnghcuoehjihgrgihunhdrhigrnhhgsehf lhihghhorghtrdgtohhmqeenucggtffrrghtthgvrhhnpedvkeeihfefveekueevteefle ffkeegudeghfdtuddugefhueevgeffgedukeejleenucevlhhushhtvghrufhiiigvpedt necurfgrrhgrmhepmhgrihhlfhhrohhmpehjihgrgihunhdrhigrnhhgsehflhihghhorg htrdgtohhmpdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphht thhopehsvggrsghiohhssehsvggrsghiohhsrdhorhhgpdhrtghpthhtohepjhhirgiguh hnrdihrghnghesfhhlhihgohgrthdrtghomh X-ME-Proxy: Feedback-ID: ifd894703:Fastmail From: Jiaxun Yang Date: Wed, 03 Sep 2025 06:51:23 +0000 MIME-Version: 1.0 Message-Id: <20250903-build-v2-2-8e8916974f9c@flygoat.com> References: <20250903-build-v2-0-8e8916974f9c@flygoat.com> In-Reply-To: <20250903-build-v2-0-8e8916974f9c@flygoat.com> To: seabios@seabios.org Message-ID-Hash: IWH6ZYA2WESPSNPFAZ2NR7ZJO5ZU55VQ X-Message-ID-Hash: IWH6ZYA2WESPSNPFAZ2NR7ZJO5ZU55VQ X-MailFrom: jiaxun.yang@flygoat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Jiaxun Yang X-Mailman-Version: 3.3.11b1 Precedence: list Subject: [SeaBIOS] [PATCH v2 2/9] Makefile: Don't use $(CC) as default $(HOSTCC) List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-Spamd-Bar: --- X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZM-MESSAGEID: 1756882351403124100 Content-Type: text/plain; charset="utf-8" In context of cross compiling, $(CC) refers to compiler to generate target binary, we can't assume $(CC) will generate target binary. Set default HOSTCC to cc, and make override of CC unconditional. Signed-off-by: Jiaxun Yang --- Makefile | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 01f42ec334591be5c6ed58c6bbe478de01f4b26d..1e03a0e5af9a974b0c8c0c8c952= 69b7635737315 100644 --- a/Makefile +++ b/Makefile @@ -8,15 +8,14 @@ OUT=3Dout/ =20 # Common command definitions -export HOSTCC :=3D $(CC) +export HOSTCC :=3D cc export CONFIG_SHELL :=3D sh export KCONFIG_AUTOHEADER :=3D autoconf.h export KCONFIG_CONFIG :=3D $(CURDIR)/.config export LC_ALL :=3D C -CROSS_PREFIX=3D -ifneq ($(CROSS_PREFIX),) + +CROSS_PREFIX :=3D CC=3D$(CROSS_PREFIX)gcc -endif AS=3D$(CROSS_PREFIX)as LD=3D$(CROSS_PREFIX)ld OBJCOPY=3D$(CROSS_PREFIX)objcopy --=20 2.43.0 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org From nobody Sun Sep 21 21:44:29 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail(p=none dis=none) header.from=flygoat.com Return-Path: Received: from coreboot.org (mail.coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 1756882365445902.341038249547; Tue, 2 Sep 2025 23:52:45 -0700 (PDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id 6FC684037C; Wed, 3 Sep 2025 06:52:43 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) (fout-a3-smtp.messagingengine.com [103.168.172.146]) by coreboot.org (Postfix) with ESMTP id 0260A40357 for ; Wed, 3 Sep 2025 06:51:33 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by mailfout.phl.internal (Postfix) with ESMTP id 267E3EC0352; Wed, 3 Sep 2025 02:51:33 -0400 (EDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by phl-compute-11.internal (MEProxy); Wed, 03 Sep 2025 02:51:33 -0400 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) 3 Sep 2025 02:51:31 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flygoat.com; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1756882293; x=1756968693; bh=91q3/JsGwMiEGwon2C37FLFfYg2g1BjxCfqBich86tc=; b= WdAZ4afL60xQne07LuIwML9uO8J6g+YDbsIh61DRtkw1azpZB9QyYgKYFO7tUcc3 nb3cwylbJc7g6Y6QPqcQmxjND03SdL1hL83ORUUNBhWK/STfUon+tbdGXQfKqSmh 9YP99KZUDd4vL2hetWLVLZtICEcB6AgbK/HzVvxtV94ukJ3Tbiiq6iWs8NWorfuX /Gxfb+apdTPYbAB/nsncb4VJ9iaNieWzWCezWXqQ+CxmLpH9jMhxU2n5RuGkvkGk 5LtX2C000wchGC8tE5p2wU7Zc+HTNIrlYQTE2cUHjAkatw3n5wyxys4YJaFdWFki Mb+U1z5s7KQBQre8SYOLRg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1756882293; x= 1756968693; bh=91q3/JsGwMiEGwon2C37FLFfYg2g1BjxCfqBich86tc=; b=U Um7ARKLoZsiaXdYZrLCkFLB4hTLlRbPdKLPxTg5u1JW6+7AMgM/h/JWwo9pG68iO qx9r2DHSQqrcRlY4YkCdaZjCdExZPj2oLOIRGoH+9BfpKhUqX0eiK1ZXoLSKn2jZ JzJDrVJe4xppCZR4Pv3Qr8RO9qYX46BdRwLKi9xsbAu2d06JhvhxLQOoCDbs018j Kg9awvItdVKU4jHKJ/tK8dSvh7rolVzBMAS3kI6Pg/ebERKGPm4HqGXaf6ahWe8c TslheM2agnRg3/EauNQHDkdRScoohmGpNvzyIctmn6qSWTPlj3BtlBKeBxemrWi9 WDVKGOH1qDUa8tMovR61w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvgeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucenucfjughrpefhfffugggtgffkfhgjvfevofesthejredtre dtjeenucfhrhhomheplfhirgiguhhnucgjrghnghcuoehjihgrgihunhdrhigrnhhgsehf lhihghhorghtrdgtohhmqeenucggtffrrghtthgvrhhnpedvkeeihfefveekueevteefle ffkeegudeghfdtuddugefhueevgeffgedukeejleenucevlhhushhtvghrufhiiigvpedt necurfgrrhgrmhepmhgrihhlfhhrohhmpehjihgrgihunhdrhigrnhhgsehflhihghhorg htrdgtohhmpdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphht thhopehsvggrsghiohhssehsvggrsghiohhsrdhorhhgpdhrtghpthhtohepjhhirgiguh hnrdihrghnghesfhhlhihgohgrthdrtghomh X-ME-Proxy: Feedback-ID: ifd894703:Fastmail From: Jiaxun Yang Date: Wed, 03 Sep 2025 06:51:24 +0000 MIME-Version: 1.0 Message-Id: <20250903-build-v2-3-8e8916974f9c@flygoat.com> References: <20250903-build-v2-0-8e8916974f9c@flygoat.com> In-Reply-To: <20250903-build-v2-0-8e8916974f9c@flygoat.com> To: seabios@seabios.org Message-ID-Hash: DUUVXCQVUI4MS6GNS3WKCC22N4RI6GO5 X-Message-ID-Hash: DUUVXCQVUI4MS6GNS3WKCC22N4RI6GO5 X-MailFrom: jiaxun.yang@flygoat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Jiaxun Yang X-Mailman-Version: 3.3.11b1 Precedence: list Subject: [SeaBIOS] [PATCH v2 3/9] Makefile: Invlode preprocessor and assembler with CC List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-Spamd-Bar: ---- X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZM-MESSAGEID: 1756882366753124100 Content-Type: text/plain; charset="utf-8" Our build system was using host CPP preprocessor which is not gaurenteed to have necessaey target macros set, convert to use target CC to invole preprocessor. The same change is applied to assembler as well for simplicity. Signed-off-by: Jiaxun Yang Reviewed-by: Paul Menzel --- Makefile | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index 1e03a0e5af9a974b0c8c0c8c95269b7635737315..f2f4ebc5b69be1d4b9ecfc99b63= f09ecaecd9474 100644 --- a/Makefile +++ b/Makefile @@ -16,13 +16,11 @@ export LC_ALL :=3D C =20 CROSS_PREFIX :=3D CC=3D$(CROSS_PREFIX)gcc -AS=3D$(CROSS_PREFIX)as LD=3D$(CROSS_PREFIX)ld OBJCOPY=3D$(CROSS_PREFIX)objcopy OBJDUMP=3D$(CROSS_PREFIX)objdump STRIP=3D$(CROSS_PREFIX)strip PYTHON=3Dpython -CPP=3Dcpp LD32BIT_FLAG:=3D-melf_i386 =20 # Source files @@ -141,7 +139,7 @@ $(OUT)%.o: %.c $(OUT)autoconf.h =20 $(OUT)%.lds: %.lds.S @echo " Precompiling $@" - $(Q)$(CPP) $(CPPFLAGS) -D__ASSEMBLY__ $< -o $@ + $(Q)$(CC) -E $(COMMONCFLAGS) $(CPPFLAGS) -D__ASSEMBLY__ $< -o $@ =20 =20 ################ Main BIOS build rules @@ -164,7 +162,7 @@ $(OUT)romlayout.o: src/romlayout.S $(OUT)autoconf.h $(O= UT)asm-offsets.h =20 $(OUT)romlayout16.lds: $(OUT)ccode32flat.o $(OUT)code32seg.o $(OUT)ccode16= .o $(OUT)romlayout.o src/version.c scripts/layoutrom.py scripts/buildversio= n.py @echo " Building ld scripts" - $(Q)$(PYTHON) ./scripts/buildversion.py -e "$(EXTRAVERSION)" -t "$(CC);$(= AS);$(LD);$(OBJCOPY);$(OBJDUMP);$(STRIP)" $(OUT)autoversion.h + $(Q)$(PYTHON) ./scripts/buildversion.py -e "$(EXTRAVERSION)" -t "$(CC);$(= LD);$(OBJCOPY);$(OBJDUMP);$(STRIP)" $(OUT)autoversion.h $(Q)$(CC) $(CFLAGS32FLAT) -c src/version.c -o $(OUT)version.o $(Q)$(LD) $(LD32BIT_FLAG) -r $(OUT)ccode32flat.o $(OUT)version.o -o $(OUT= )code32flat.o $(Q)$(LD) $(LD32BIT_FLAG) -r $(OUT)ccode16.o $(OUT)romlayout.o -o $(OUT)c= ode16.o @@ -225,7 +223,7 @@ $(OUT)vgaccode16.raw.s: $(OUT)autoconf.h $(patsubst %.c= , $(OUT)%.o,$(SRCVGA)) ; $(OUT)vgaccode16.o: $(OUT)vgaccode16.raw.s scripts/vgafixup.py @echo " Fixup VGA rom assembler" $(Q)$(PYTHON) ./scripts/vgafixup.py $< $(OUT)vgaccode16.s - $(Q)$(AS) --32 src/code16gcc.s $(OUT)vgaccode16.s -o $@ + $(Q)$(CC) -c $(CFLAGS16) $(OUT)vgaccode16.s -o $@ else $(OUT)vgaccode16.o: $(OUT)autoconf.h $(patsubst %.c, $(OUT)%.o,$(SRCVGA)) = ; $(call whole-compile, $(CFLAGS16) -Isrc, $(SRCVGA),$@) endif --=20 2.43.0 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org From nobody Sun Sep 21 21:44:29 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail(p=none dis=none) header.from=flygoat.com Return-Path: Received: from coreboot.org (mail.coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 1756882383092325.48348340028133; Tue, 2 Sep 2025 23:53:03 -0700 (PDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id 7AEE44045B; Wed, 3 Sep 2025 06:53:00 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) (fout-a3-smtp.messagingengine.com [103.168.172.146]) by coreboot.org (Postfix) with ESMTP id E024340382 for ; Wed, 3 Sep 2025 06:51:35 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by mailfout.phl.internal (Postfix) with ESMTP id 01D6FEC0324; Wed, 3 Sep 2025 02:51:35 -0400 (EDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by phl-compute-06.internal (MEProxy); Wed, 03 Sep 2025 02:51:35 -0400 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) 3 Sep 2025 02:51:33 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flygoat.com; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1756882294; x=1756968694; bh=Sifsw0Msp7rzVwBpOip5C1pxNiQKMm0kJnlLm3SECZ4=; b= d+bhgBOFuukVjWZSuSgN0gTLT8VtDeEFdFDVPQeMYeYpPhVDpjJJi8hIMcv60HI3 5tblMEY+hLH2dCjNPAaxndK/T23nxeCKbWUW+hcNRPd26OcDUMkQljEZCv4UQLzY MWKlR9qcK3z0M9pNLbpskcqyt5/E1OoOc88r/QaRX57EbJhQGGzVtTmfYAxDJgMw 1nqVTzx0j3InhBi0sBRZJpDnlo3Qw17RL4JAYHuDnwj+poshZC07x5+lnCAlXsxR FieB5MCEduv3hXRXOR/bGn4xrEiNUd/tD2P8pOibEs4/dGPjQRcTpc5dRR7/4CRH 4TzIfDvduv+P1a8EkCREPA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1756882294; x= 1756968694; bh=Sifsw0Msp7rzVwBpOip5C1pxNiQKMm0kJnlLm3SECZ4=; b=F cy9Hmrgtp2/iRe6xQlb7+IbETIEF2UmzrfBybNUkAJ2IQvZCPjjyn6xi1yCmh2TC jip/7i5fgS/Qgg4AOq5FPzhr7LsCgl/W30Bp2bx83pt6gkiYTOxYZFdI1sCSh3I0 MepD8vr5Ai3Vmfdnxuz38pQXv0L4T9RFL9wdomeLZlGq7pJTBG5pU2aTjaeFZUrp /ZPMbs6+TPb5IY88JctGBI2TcQ9wfyp/1WEtmsvdAg9HZqj0e6esVn+sAz3ztPL7 XMsLXPysYZLa/3rMU5k1SEfjwVYtRLbG17Ql+mPun53QQdV1VYKP0IKMf/8THIMW CG/BphFnJaU9iA+ansvlg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvgeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucenucfjughrpefhfffugggtgffkfhgjvfevofesthejredtre dtjeenucfhrhhomheplfhirgiguhhnucgjrghnghcuoehjihgrgihunhdrhigrnhhgsehf lhihghhorghtrdgtohhmqeenucggtffrrghtthgvrhhnpedvkeeihfefveekueevteefle ffkeegudeghfdtuddugefhueevgeffgedukeejleenucevlhhushhtvghrufhiiigvpedt necurfgrrhgrmhepmhgrihhlfhhrohhmpehjihgrgihunhdrhigrnhhgsehflhihghhorg htrdgtohhmpdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphht thhopehsvggrsghiohhssehsvggrsghiohhsrdhorhhgpdhrtghpthhtohepjhhirgiguh hnrdihrghnghesfhhlhihgohgrthdrtghomh X-ME-Proxy: Feedback-ID: ifd894703:Fastmail From: Jiaxun Yang Date: Wed, 03 Sep 2025 06:51:25 +0000 MIME-Version: 1.0 Message-Id: <20250903-build-v2-4-8e8916974f9c@flygoat.com> References: <20250903-build-v2-0-8e8916974f9c@flygoat.com> In-Reply-To: <20250903-build-v2-0-8e8916974f9c@flygoat.com> To: seabios@seabios.org Message-ID-Hash: EBZPD37ZRLZ7U63DOT3CXKBJZR4SB7AD X-Message-ID-Hash: EBZPD37ZRLZ7U63DOT3CXKBJZR4SB7AD X-MailFrom: jiaxun.yang@flygoat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Jiaxun Yang X-Mailman-Version: 3.3.11b1 Precedence: list Subject: [SeaBIOS] [PATCH v2 4/9] Makefile: Allow more linux style knobs List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-Spamd-Bar: ---- X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZM-MESSAGEID: 1756882385164116600 Content-Type: text/plain; charset="utf-8" Allow all host flags to be set at top level makefile. Allow KBUILD_DEFCONFIG to be specified to load external defconfigs. Allow linux style CROSS_COMPILE specifier. Signed-off-by: Jiaxun Yang --- Makefile | 6 +++++- scripts/kconfig/Makefile | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index f2f4ebc5b69be1d4b9ecfc99b63f09ecaecd9474..b5660928c2056970e3174be368e= 65752a948f16a 100644 --- a/Makefile +++ b/Makefile @@ -9,12 +9,16 @@ OUT=3Dout/ =20 # Common command definitions export HOSTCC :=3D cc +export HOSTCFLAGS :=3D +export HOSTLDFLAGS :=3D export CONFIG_SHELL :=3D sh export KCONFIG_AUTOHEADER :=3D autoconf.h export KCONFIG_CONFIG :=3D $(CURDIR)/.config +export KBUILD_DEFCONFIG :=3D /dev/null export LC_ALL :=3D C =20 -CROSS_PREFIX :=3D +CROSS_COMPILE :=3D +CROSS_PREFIX :=3D $(CROSS_COMPILE) CC=3D$(CROSS_PREFIX)gcc LD=3D$(CROSS_PREFIX)ld OBJCOPY=3D$(CROSS_PREFIX)objcopy diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile index 1c1293618764c891f04d55f7ca5a24d42a218215..96793619356ed649a467513ebcd= 829a143798a57 100644 --- a/scripts/kconfig/Makefile +++ b/scripts/kconfig/Makefile @@ -11,6 +11,10 @@ else Kconfig :=3D Kconfig endif =20 +ifndef KBUILD_DEFCONFIG +KBUILD_DEFCONFIG :=3D defconfig +endif + # We need this, in case the user has it in its environment unexport CONFIG_ =20 @@ -96,7 +100,7 @@ savedefconfig: $(obj)/conf =20 defconfig: $(obj)/conf @echo " Build default config" - $(Q)$< --defconfig=3D/dev/null $(Kconfig) + $(Q)$< --defconfig=3D$(KBUILD_DEFCONFIG) $(Kconfig) =20 %_defconfig: $(obj)/conf $(Q)$< --defconfig=3Darch/$(SRCARCH)/configs/$@ $(Kconfig) --=20 2.43.0 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org From nobody Sun Sep 21 21:44:29 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail(p=none dis=none) header.from=flygoat.com Return-Path: Received: from coreboot.org (mail.coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 1756882399501625.2551289337242; Tue, 2 Sep 2025 23:53:19 -0700 (PDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id 0772C40471; Wed, 3 Sep 2025 06:53:16 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) (fhigh-a2-smtp.messagingengine.com [103.168.172.153]) by coreboot.org (Postfix) with ESMTP id 3DA384037C for ; Wed, 3 Sep 2025 06:51:37 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by mailfhigh.phl.internal (Postfix) with ESMTP id 620B114002F9; Wed, 3 Sep 2025 02:51:36 -0400 (EDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by phl-compute-09.internal (MEProxy); Wed, 03 Sep 2025 02:51:36 -0400 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) 3 Sep 2025 02:51:35 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flygoat.com; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1756882296; x=1756968696; bh=nH+QnaFz42C5eQWeSovF0HOBdGbPhped5c8EuEzjf+w=; b= R22asGIp52JNCuRV1Vprq8saiW7JUTTHf8MSLGKu0dldfa/LUzqAfpD9RpCU3Jet /FnZoLetbucC2mNjnqHDuYN+cqffepuh2zNpVlKSgcwTU8hP1dXkAoQB4ndPQhFq E21MmAFwolcDKTuDj0g7xo0j8uc84Ha81YfD3zEXtgmwELpJm5jM2AMmuPKZ3Ngq sHSmV54Ew24UZoeQaKssDVeEILn+AYMWfRjcR1R8Mkd3v/s+u2sveki79N7g4ihO yzkclOqpF0ed+Whqjh9AfTW1d3RHSbMfGPuuGpbGbRzuupZtmo+3O4bxrPTCt9/v fx1Nqw4p4OspU59wPCUm9Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1756882296; x= 1756968696; bh=nH+QnaFz42C5eQWeSovF0HOBdGbPhped5c8EuEzjf+w=; b=H 88VWjO0PLQv0PA5MR5SUIxGg42lo4JEaQlaOGcEznYWx/CZCf7htrEqFcoxT7+o4 33b0SErLqK9gccvrUlzmhXaQJ1yRIds71Qz1qWYciwPTNUWOL9Hvx6itgGFjPbu2 1in9bsoc5DsgOth+S47M07G3vlN5+rt0gG7EoqKmCPgRWVw83RJrNznFwRq9ClFW 2Xb0lHZfl7VWAQYO1BT+M08/y4xWbhUex2K+jFKwn4bC+NcDHPexB68N2Wh7F1bf y5O4gEzVosrgeewcCYfY8/Vyt5M3HIcrhmpqqnHz0Q/+kKNbr0e297NU6epZGY4d KNMoGve9J6sBEY1Lqb6gQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvgeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucenucfjughrpefhfffugggtgffkfhgjvfevofesthejredtre dtjeenucfhrhhomheplfhirgiguhhnucgjrghnghcuoehjihgrgihunhdrhigrnhhgsehf lhihghhorghtrdgtohhmqeenucggtffrrghtthgvrhhnpedvkeeihfefveekueevteefle ffkeegudeghfdtuddugefhueevgeffgedukeejleenucevlhhushhtvghrufhiiigvpedt necurfgrrhgrmhepmhgrihhlfhhrohhmpehjihgrgihunhdrhigrnhhgsehflhihghhorg htrdgtohhmpdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphht thhopehsvggrsghiohhssehsvggrsghiohhsrdhorhhgpdhrtghpthhtohepjhhirgiguh hnrdihrghnghesfhhlhihgohgrthdrtghomh X-ME-Proxy: Feedback-ID: ifd894703:Fastmail From: Jiaxun Yang Date: Wed, 03 Sep 2025 06:51:26 +0000 MIME-Version: 1.0 Message-Id: <20250903-build-v2-5-8e8916974f9c@flygoat.com> References: <20250903-build-v2-0-8e8916974f9c@flygoat.com> In-Reply-To: <20250903-build-v2-0-8e8916974f9c@flygoat.com> To: seabios@seabios.org Message-ID-Hash: BT5NI7HYAZN5MHAMLNH2GPUMTXDS6NN3 X-Message-ID-Hash: BT5NI7HYAZN5MHAMLNH2GPUMTXDS6NN3 X-MailFrom: jiaxun.yang@flygoat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Jiaxun Yang X-Mailman-Version: 3.3.11b1 Precedence: list Subject: [SeaBIOS] [PATCH v2 5/9] asm-offset: Refresh definations from Linux List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-Spamd-Bar: ---- X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZM-MESSAGEID: 1756882401347116600 Content-Type: text/plain; charset="utf-8" To adopt newer toolchains. Signed-off-by: Jiaxun Yang --- scripts/gen-offsets.sh | 7 ++++--- src/gen-defs.h | 8 +++----- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/scripts/gen-offsets.sh b/scripts/gen-offsets.sh index 73dede82b86da25cba0abbcf86039490c21e90cc..eeddca7f594a108a22439e5827b= a09714a52b254 100755 --- a/scripts/gen-offsets.sh +++ b/scripts/gen-offsets.sh @@ -9,9 +9,10 @@ cat > "$OUTFILE" </{s:->#\(.*\):/* \1 */:; \ - s:^->\([^ ]*\) [\$\#]*\([^ ]*\) \(.*\):#define \1 \2 /* \3 */:; \ - s:->::; p;}" < "$INFILE" >> "$OUTFILE" +sed -ne 's:^[[:space:]]*\.ascii[[:space:]]*"\(.*\)".*:\1:; + /^->/{s:->#\(.*\):/* \1 */:; + s:^->\([^ ]*\) [\$$#]*\([^ ]*\) \(.*\):#define \1 \2 /* \3 */:; + s:->::; p;}' < "$INFILE" >> "$OUTFILE" cat >> "$OUTFILE" <" #sym " %0 " #val : : "i" (val)) + asm volatile("\n.ascii \"->" #sym " %0 " #val "\"" : : "i" (val)) =20 -#define BLANK() \ - asm volatile("\n->" : : ) +#define BLANK() asm volatile("\n.ascii \"->\"" : : ) =20 #define OFFSET(sym, str, mem) \ DEFINE(sym, offsetof(struct str, mem)) =20 #define COMMENT(x) \ - asm volatile("\n->#" x) + asm volatile("\n.ascii \"->#" x "\"") =20 #endif // gen-defs.h --=20 2.43.0 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org From nobody Sun Sep 21 21:44:29 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail(p=none dis=none) header.from=flygoat.com Return-Path: Received: from coreboot.org (mail.coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 1756882413995534.2452641903002; Tue, 2 Sep 2025 23:53:33 -0700 (PDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id 916124047A; Wed, 3 Sep 2025 06:53:31 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) (fhigh-a2-smtp.messagingengine.com [103.168.172.153]) by coreboot.org (Postfix) with ESMTP id 24595403BA for ; Wed, 3 Sep 2025 06:51:39 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by mailfhigh.phl.internal (Postfix) with ESMTP id 47845140031C; Wed, 3 Sep 2025 02:51:38 -0400 (EDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by phl-compute-04.internal (MEProxy); Wed, 03 Sep 2025 02:51:38 -0400 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) 3 Sep 2025 02:51:36 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flygoat.com; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1756882298; x=1756968698; bh=FFJL+aFvVQE0Uszaw35FXrdGBBhIYR7+jB3hsbjs8M4=; b= jmgyrDiZ4Nahrxxvt+Ip9tsfK6wkKSZg3owkvfqaJIgpOaSUrHdWS9uYtUb/eEYz hf54DD8QArgORsMKgjPPrXgUsnzQTj7ZeqVSuyepo5xfRYTezkQqydyLYmq1er7G 0pJXQlvniiAt/bCMI49tZuOg5OXPpypjipLVq/vzBFKgJT/nB99NYbhmEAEqfpbo Yfh/1wieE6F++VYa4t2tZ5UdRXH6ER6jErpbpzoL2MPnKlgUk1URvtY1JAatqDem Gxva1Qer6QHjUCtuDynLaJvbPzTwjlY3BFyW+3LPZ5vdkdPbzUWzJrhFwZFQcE9t TIVIHkmEiHKfs2QYzU9w/w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1756882298; x= 1756968698; bh=FFJL+aFvVQE0Uszaw35FXrdGBBhIYR7+jB3hsbjs8M4=; b=S P/hDgg0wmFoNdU8FD692Xs9AJfgoWPPRJmrMVqROnHqAroTg2cFeXBqdl+GpmzfT vl8XEQDDGbIAkhh/mHkPFxKEO3PcOcqQyK1a9jKi5gXc0QUaMrGPXb2oKzj9+zSp r4vhm4WoU0rHpMV1OsiR4j2HAnxpj+n1U3AEWYjKG3N9NIzTwkFxksIRuR3MJAFg 3omNhlqjRkmBAd31fUSBZcow3gPKBTMAaBvRwBbAeEbx7baP5ReOAgBIX82Ri6RF CSDOEuhHTL1CDol0EG1vM269jaH2n3lKwB8v7NXL5fWm7ieLzYYpAn5fjr13TBIT PZ4Y0ODTmRI2Qz/Idslwg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvgeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucenucfjughrpefhfffugggtgffkfhgjvfevofesthejredtre dtjeenucfhrhhomheplfhirgiguhhnucgjrghnghcuoehjihgrgihunhdrhigrnhhgsehf lhihghhorghtrdgtohhmqeenucggtffrrghtthgvrhhnpedvkeeihfefveekueevteefle ffkeegudeghfdtuddugefhueevgeffgedukeejleenucevlhhushhtvghrufhiiigvpedt necurfgrrhgrmhepmhgrihhlfhhrohhmpehjihgrgihunhdrhigrnhhgsehflhihghhorg htrdgtohhmpdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphht thhopehsvggrsghiohhssehsvggrsghiohhsrdhorhhgpdhrtghpthhtohepjhhirgiguh hnrdihrghnghesfhhlhihgohgrthdrtghomh X-ME-Proxy: Feedback-ID: ifd894703:Fastmail From: Jiaxun Yang Date: Wed, 03 Sep 2025 06:51:27 +0000 MIME-Version: 1.0 Message-Id: <20250903-build-v2-6-8e8916974f9c@flygoat.com> References: <20250903-build-v2-0-8e8916974f9c@flygoat.com> In-Reply-To: <20250903-build-v2-0-8e8916974f9c@flygoat.com> To: seabios@seabios.org Message-ID-Hash: 3H3LOWXTQSBM5ICWA7T7DJXQMO37GNEO X-Message-ID-Hash: 3H3LOWXTQSBM5ICWA7T7DJXQMO37GNEO X-MailFrom: jiaxun.yang@flygoat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Jiaxun Yang X-Mailman-Version: 3.3.11b1 Precedence: list Subject: [SeaBIOS] [PATCH v2 6/9] scripts: Use python3 as python List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-Spamd-Bar: ---- X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZM-MESSAGEID: 1756882415577116600 Content-Type: text/plain; charset="utf-8" Some of our python3 scripts are python3 only. We can't assume python is python3 on build platforms. Explictly use python3 for running those scripts. Signed-off-by: Jiaxun Yang --- Makefile | 2 +- scripts/buildrom.py | 2 +- scripts/buildversion.py | 2 +- scripts/checkrom.py | 2 +- scripts/checkstack.py | 2 +- scripts/checksum.py | 2 +- scripts/encodeint.py | 2 +- scripts/layoutrom.py | 2 +- scripts/ldnoexec.py | 2 +- scripts/readserial.py | 2 +- scripts/transdump.py | 2 +- scripts/vgafixup.py | 2 +- 12 files changed, 12 insertions(+), 12 deletions(-) diff --git a/Makefile b/Makefile index b5660928c2056970e3174be368e65752a948f16a..64bd55d997009b2838d7ede437c= a7dd5e860d84e 100644 --- a/Makefile +++ b/Makefile @@ -24,7 +24,7 @@ LD=3D$(CROSS_PREFIX)ld OBJCOPY=3D$(CROSS_PREFIX)objcopy OBJDUMP=3D$(CROSS_PREFIX)objdump STRIP=3D$(CROSS_PREFIX)strip -PYTHON=3Dpython +PYTHON=3Dpython3 LD32BIT_FLAG:=3D-melf_i386 =20 # Source files diff --git a/scripts/buildrom.py b/scripts/buildrom.py index 48bfc177d27f1a4eb4984f5d1a1ff12413cceb6e..a4a7b95f8d3170bf5f231e6f41e= da17953cd2134 100755 --- a/scripts/buildrom.py +++ b/scripts/buildrom.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # Fill in checksum/size of an option rom, and pad it to proper length. # # Copyright (C) 2009 Kevin O'Connor diff --git a/scripts/buildversion.py b/scripts/buildversion.py index 8875497cb72cb26f6e438d10419c4583b61c5b64..13624ce8aa996e805e9c7cd0892= 0e2608d504869 100755 --- a/scripts/buildversion.py +++ b/scripts/buildversion.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # Generate version information for a program # # Copyright (C) 2015 Kevin O'Connor diff --git a/scripts/checkrom.py b/scripts/checkrom.py index a5b15a4c2816cffecc99dc9e2da6e3d9f87f2bb6..7d73eebb67db229c4bee2c977de= e764dd7ff22cb 100755 --- a/scripts/checkrom.py +++ b/scripts/checkrom.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # Script to check a bios image and report info on it. # # Copyright (C) 2008 Kevin O'Connor diff --git a/scripts/checkstack.py b/scripts/checkstack.py index 255768aebce0341f0bb06d13973e653735aa5154..3bb58bc8d5f5e021ec1cbe2f74e= 4c6b3a641e6a9 100755 --- a/scripts/checkstack.py +++ b/scripts/checkstack.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # Script that tries to find how much stack space each function in an # object is using. # diff --git a/scripts/checksum.py b/scripts/checksum.py index 773fa7aa9f956385ea20e055275b481adec8b4a4..87cce60319a43b256c2689ef282= b19d6b68c2121 100755 --- a/scripts/checksum.py +++ b/scripts/checksum.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # Script to report the checksum of a file. # # Copyright (C) 2009 Kevin O'Connor diff --git a/scripts/encodeint.py b/scripts/encodeint.py index 0d34aee071ffea8fd7b489cfae82fcc6e6528091..e861d8156b0db440f8301dd5391= 15e739bfbadf8 100755 --- a/scripts/encodeint.py +++ b/scripts/encodeint.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # Encode an integer in little endian format in a file. # # Copyright (C) 2011 Kevin O'Connor diff --git a/scripts/layoutrom.py b/scripts/layoutrom.py index abebf0211fa9627cec31cce76b8d55e688445b45..a193f258123bd36e8c6bdf455af= f6584d4216efd 100755 --- a/scripts/layoutrom.py +++ b/scripts/layoutrom.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # Script to analyze code and arrange ld sections. # # Copyright (C) 2008-2014 Kevin O'Connor diff --git a/scripts/ldnoexec.py b/scripts/ldnoexec.py index 60bed078866363a52c573360b3426dc91af0ebc1..97e0f387c9fa88e8d3cc958922e= e90d3d93db166 100755 --- a/scripts/ldnoexec.py +++ b/scripts/ldnoexec.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # Script to remove EXEC flag from an ELF file # # Copyright (C) 2020 Kevin O'Connor diff --git a/scripts/readserial.py b/scripts/readserial.py index e3f56e5da57c1a97c59ab856f82fae6c2346363c..b64fe07dc9bd709d8fd56fa1123= c4e0fa2a45cd5 100755 --- a/scripts/readserial.py +++ b/scripts/readserial.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # Script that can read from a serial device and show timestamps. # # Copyright (C) 2009 Kevin O'Connor diff --git a/scripts/transdump.py b/scripts/transdump.py index 665f04a000fccd9250a94357be9c16891a45c855..9877b33a2380a61138c4c6236de= c059be2e87b95 100755 --- a/scripts/transdump.py +++ b/scripts/transdump.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 =20 # This script is useful for taking the output of memdump() and # converting it back into binary output. This can be useful, for diff --git a/scripts/vgafixup.py b/scripts/vgafixup.py index 2053cd5d78e5935658e1fecec074b258ba1d75ba..01ec81496a18995197b4095217f= be25fd90b081d 100644 --- a/scripts/vgafixup.py +++ b/scripts/vgafixup.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # Work around x86emu bugs by replacing problematic instructions. # # Copyright (C) 2012 Kevin O'Connor --=20 2.43.0 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org From nobody Sun Sep 21 21:44:29 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail(p=none dis=none) header.from=flygoat.com Return-Path: Received: from coreboot.org (mail.coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 1756882430494638.4218973796127; Tue, 2 Sep 2025 23:53:50 -0700 (PDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id D1C254C400; Wed, 3 Sep 2025 06:53:47 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) (fhigh-a2-smtp.messagingengine.com [103.168.172.153]) by coreboot.org (Postfix) with ESMTP id 7F123403CB for ; Wed, 3 Sep 2025 06:51:41 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by mailfhigh.phl.internal (Postfix) with ESMTP id A33071400376; Wed, 3 Sep 2025 02:51:40 -0400 (EDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by phl-compute-06.internal (MEProxy); Wed, 03 Sep 2025 02:51:40 -0400 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) 3 Sep 2025 02:51:38 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flygoat.com; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1756882300; x=1756968700; bh=ZVq6/EqxAu5ImYWZs0BZ3M25POAtabPwdlpCOmiCmSE=; b= iTLICqazLH0FnDoCX8TwM9ERHEx4NYZM5fJRtVKH6b4jmy7dZj39GkU0rMNhpPPj iyS1yEqqaHvUGq4p80z4kfqK3A9egcIGwKP+MdjrcLZfQ0ODALnpvrbjOGQ/sVqy zrXTerrJKgl/7VfuMnOc3ZAFa8OVL0fCqvDtTyJqckisnS+99LsMFAB3OrzS5jA9 lc49PijupZ/EE44uijP9kMLIb81fC+3o3MpPBd9ZctKyz16QEiyNjr2lwej+Jhwx mAg/HERr3gIogkpMjfKQVVAvjRbfLe/+9ItN52sdB9s5hVcZgoSD5XAxZod+Difr vloMR/gK2s6bqJnieZcevg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1756882300; x= 1756968700; bh=ZVq6/EqxAu5ImYWZs0BZ3M25POAtabPwdlpCOmiCmSE=; b=c XLbDmwNVoYvgPCmScND44zfgiUNE3zUfpNqzauG8Ejnee/vuSKqAQ86gx8zulKDi 4KXYPLOcxLegCZz7TNSqWvgY/MNDUCttgcxEhUqufGD3CjxyZe82XAKBS/ypuwx0 WLhsrvGChdeHomLpJlydWpfCWOASKQK06Iy9SOY0kYK0hndWnO61St6LMcsQEfBn Pm07UR3mVYi7BZU4ArgW4SLXKbTdliIs5Xon6T7yS6DkJ8wt5ldT3CacUKXRJ69W NjLkEFqECuCLfswRboxFChDcuSObY0WNTS8AcMxdsVNN/867dJTdOsgx7JfMCVWQ pSITgku6Cp1Kv4j4wPT/w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvgeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucenucfjughrpefhfffugggtgffkfhgjvfevofesthejredtre dtjeenucfhrhhomheplfhirgiguhhnucgjrghnghcuoehjihgrgihunhdrhigrnhhgsehf lhihghhorghtrdgtohhmqeenucggtffrrghtthgvrhhnpeeitefgffeliefgfedvteekff ekfeffhfeludekueevhefhleegteehkefgteehheenucffohhmrghinhepohhpvghnshho uhhrtggvrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepjhhirgiguhhnrdihrghnghesfhhlhihgohgrthdrtghomhdpnhgspghrtghp thhtohepvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepshgvrggsihhoshessh gvrggsihhoshdrohhrghdprhgtphhtthhopehjihgrgihunhdrhigrnhhgsehflhihghho rghtrdgtohhm X-ME-Proxy: Feedback-ID: ifd894703:Fastmail From: Jiaxun Yang Date: Wed, 03 Sep 2025 06:51:28 +0000 MIME-Version: 1.0 Message-Id: <20250903-build-v2-7-8e8916974f9c@flygoat.com> References: <20250903-build-v2-0-8e8916974f9c@flygoat.com> In-Reply-To: <20250903-build-v2-0-8e8916974f9c@flygoat.com> To: seabios@seabios.org Message-ID-Hash: EJANNDM3G75D554H6LX5JUJ6JCFJTJGJ X-Message-ID-Hash: EJANNDM3G75D554H6LX5JUJ6JCFJTJGJ X-MailFrom: jiaxun.yang@flygoat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Jiaxun Yang X-Mailman-Version: 3.3.11b1 Precedence: list Subject: [SeaBIOS] [PATCH v2 7/9] LegacyBios.h: Add missing pack() pragma List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-Spamd-Bar: ---- X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZM-MESSAGEID: 1756882431847116600 Content-Type: text/plain; charset="utf-8" To match #pragma pack(1) at begining of this file. Signed-off-by: Jiaxun Yang --- src/std/LegacyBios.h | 238 ++++++++++++++++++++++++++---------------------= ---- 1 file changed, 120 insertions(+), 118 deletions(-) diff --git a/src/std/LegacyBios.h b/src/std/LegacyBios.h index 5170c37865fc573d54a06c8b1140a353721daec7..04fbc350abe6cf90e5643293c4e= 6fbd70739b536 100644 --- a/src/std/LegacyBios.h +++ b/src/std/LegacyBios.h @@ -10,12 +10,12 @@ environment. Reverse thunk is the code that does the opposite. =20 Copyright (c) 2007 - 2010, Intel Corporation. All rights reserved.
-This program and the accompanying materials are licensed and made availabl= e under=20 -the terms and conditions of the BSD License that accompanies this distribu= tion. =20 +This program and the accompanying materials are licensed and made availabl= e under +the terms and conditions of the BSD License that accompanies this distribu= tion. The full text of the license may be found at -http://opensource.org/licenses/bsd-license.php. = =20 - =20 -THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, = =20 +http://opensource.org/licenses/bsd-license.php. + +THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLI= ED. =20 @par Revision Reference: @@ -28,7 +28,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER= EXPRESS OR IMPLIED. #define _EFI_LEGACY_BIOS_H_ =20 /// -///=20 +/// /// #pragma pack(1) =20 @@ -51,75 +51,75 @@ typedef struct { /// 1 is "F," byte 2 is "E," and byte 3 is "$" and is normally accessed = as a DWORD or UINT32. /// UINT32 Signature; - =20 + /// /// The value required such that byte checksum of TableLength equals zer= o. /// UINT8 TableChecksum; - =20 + /// /// The length of this table. /// UINT8 TableLength; - =20 + /// /// The major EFI revision for which this table was generated. - ///=20 + /// UINT8 EfiMajorRevision; - =20 + /// /// The minor EFI revision for which this table was generated. /// UINT8 EfiMinorRevision; - =20 + /// /// The major revision of this table. /// UINT8 TableMajorRevision; - =20 + /// /// The minor revision of this table. /// UINT8 TableMinorRevision; - =20 + /// /// Reserved for future usage. /// UINT16 Reserved; - =20 + /// /// The segment of the entry point within the traditional BIOS for Compa= tibility16 functions. /// UINT16 Compatibility16CallSegment; - =20 + /// /// The offset of the entry point within the traditional BIOS for Compat= ibility16 functions. /// UINT16 Compatibility16CallOffset; - =20 + /// - /// The segment of the entry point within the traditional BIOS for EfiCo= mpatibility=20 + /// The segment of the entry point within the traditional BIOS for EfiCo= mpatibility /// to invoke the PnP installation check. /// UINT16 PnPInstallationCheckSegment; - =20 + /// - /// The Offset of the entry point within the traditional BIOS for EfiCom= patibility=20 + /// The Offset of the entry point within the traditional BIOS for EfiCom= patibility /// to invoke the PnP installation check. /// UINT16 PnPInstallationCheckOffset; - =20 + /// - /// EFI system resources table. Type EFI_SYSTEM_TABLE is defined in the = IntelPlatform=20 + /// EFI system resources table. Type EFI_SYSTEM_TABLE is defined in the = IntelPlatform ///Innovation Framework for EFI Driver Execution Environment Core Interf= ace Specification (DXE CIS). /// - UINT32 EfiSystemTable;=20 - =20 + UINT32 EfiSystemTable; + /// /// The address of an OEM-provided identifier string. The string is null= terminated. /// UINT32 OemIdStringPointer; - =20 + /// /// The 32-bit physical address where ACPI RSD PTR is stored within the = traditional /// BIOS. The remained of the ACPI tables are located at their EFI addre= sses. The size @@ -127,93 +127,93 @@ typedef struct { /// RSD PTR with either the ACPI 1.0b or 2.0 values. /// UINT32 AcpiRsdPtrPointer; - =20 + /// /// The OEM revision number. Usage is undefined but provided for OEM mod= ule usage. /// UINT16 OemRevision; - =20 + /// /// The 32-bit physical address where INT15 E820 data is stored within t= he traditional /// BIOS. The EfiCompatibility code will fill in the E820Pointer value a= nd copy the /// data to the indicated area. /// UINT32 E820Pointer; - =20 + /// /// The length of the E820 data and is filled in by the EfiCompatibility= code. /// UINT32 E820Length; - =20 + /// /// The 32-bit physical address where the $PIR table is stored in the tr= aditional BIOS. /// The EfiCompatibility code will fill in the IrqRoutingTablePointer va= lue and /// copy the data to the indicated area. /// UINT32 IrqRoutingTablePointer; - =20 + /// /// The length of the $PIR table and is filled in by the EfiCompatibilit= y code. /// UINT32 IrqRoutingTableLength; - =20 + /// /// The 32-bit physical address where the MP table is stored in the trad= itional BIOS. - /// The EfiCompatibility code will fill in the MpTablePtr value and copy= the data=20 + /// The EfiCompatibility code will fill in the MpTablePtr value and copy= the data /// to the indicated area. /// UINT32 MpTablePtr; - =20 + /// /// The length of the MP table and is filled in by the EfiCompatibility = code. /// UINT32 MpTableLength; - =20 + /// /// The segment of the OEM-specific INT table/code. - ///=20 + /// UINT16 OemIntSegment; - =20 + /// /// The offset of the OEM-specific INT table/code. /// UINT16 OemIntOffset; - =20 + /// /// The segment of the OEM-specific 32-bit table/code. /// UINT16 Oem32Segment; - =20 + /// /// The offset of the OEM-specific 32-bit table/code. /// UINT16 Oem32Offset; - =20 + /// /// The segment of the OEM-specific 16-bit table/code. /// UINT16 Oem16Segment; - =20 + /// /// The offset of the OEM-specific 16-bit table/code. /// UINT16 Oem16Offset; - =20 + /// /// The segment of the TPM binary passed to 16-bit CSM. /// UINT16 TpmSegment; - =20 + /// /// The offset of the TPM binary passed to 16-bit CSM. /// UINT16 TpmOffset; - =20 + /// /// A pointer to a string identifying the independent BIOS vendor. /// UINT32 IbvPointer; - =20 + /// /// This field is NULL for all systems not supporting PCI Express. This = field is the base /// value of the start of the PCI Express memory-mapped configuration re= gisters and @@ -223,7 +223,7 @@ typedef struct { /// Functions. /// UINT32 PciExpressBase; - =20 + /// /// Maximum PCI bus number assigned. /// @@ -251,12 +251,12 @@ typedef struct { } EFI_COMPATIBILITY16_TABLE; =20 /// -/// Functions provided by the CSM binary which communicate between the Efi= Compatibility=20 +/// Functions provided by the CSM binary which communicate between the Efi= Compatibility /// and Compatability16 code. /// -/// Inconsistent with the specification here:=20 -/// The member's name started with "Compatibility16" [defined in Intel Fra= mework=20 -/// Compatibility Support Module Specification / 0.97 version]=20 +/// Inconsistent with the specification here: +/// The member's name started with "Compatibility16" [defined in Intel Fra= mework +/// Compatibility Support Module Specification / 0.97 version] /// has been changed to "Legacy16" since keeping backward compatible. /// typedef enum { @@ -269,7 +269,7 @@ typedef enum { /// AX =3D Return Status codes /// Legacy16InitializeYourself =3D 0x0000, - =20 + /// /// Causes the Compatibility16 BIOS to perform any drive number translat= ions to match the boot sequence. /// Input: @@ -279,18 +279,18 @@ typedef enum { /// AX =3D Returned status codes /// Legacy16UpdateBbs =3D 0x0001, - =20 + /// /// Allows the Compatibility16 code to perform any final actions before = booting. The Compatibility16 /// code is read/write. /// Input: /// AX =3D Compatibility16PrepareToBoot - /// ES:BX =3D Pointer to EFI_TO_COMPATIBILITY16_BOOT_TABLE structure =20 + /// ES:BX =3D Pointer to EFI_TO_COMPATIBILITY16_BOOT_TABLE structure /// Return: /// AX =3D Returned status codes /// Legacy16PrepareToBoot =3D 0x0002, - =20 + /// /// Causes the Compatibility16 BIOS to boot. The Compatibility16 code is= Read/Only. /// Input: @@ -299,7 +299,7 @@ typedef enum { /// AX =3D Returned status codes /// Legacy16Boot =3D 0x0003, - =20 + /// /// Allows the Compatibility16 code to get the last device from which a = boot was attempted. This is /// stored in CMOS and is the priority number of the last attempted boot= device. @@ -310,7 +310,7 @@ typedef enum { /// BX =3D Priority number of the boot device. /// Legacy16RetrieveLastBootDevice =3D 0x0004, - =20 + /// /// Allows the Compatibility16 code rehook INT13, INT18, and/or INT19 af= ter dispatching a legacy OpROM. /// Input: @@ -321,7 +321,7 @@ typedef enum { /// BX =3D Number of non-BBS-compliant devices found. Equals 0 if BBS = compliant. /// Legacy16DispatchOprom =3D 0x0005, - =20 + /// /// Finds a free area in the 0xFxxxx or 0xExxxx region of the specified = length and returns the address /// of that region. @@ -338,7 +338,7 @@ typedef enum { /// DS:BX =3D Address of the region /// Legacy16GetTableAddress =3D 0x0006, - =20 + /// /// Enables the EfiCompatibility module to do any nonstandard processing= of keyboard LEDs or state. /// Input: @@ -351,7 +351,7 @@ typedef enum { /// AX =3D Returned status codes /// Legacy16SetKeyboardLeds =3D 0x0007, - =20 + /// /// Enables the EfiCompatibility module to install an interrupt handler = for PCI mass media devices that /// do not have an OpROM associated with them. An example is SATA. @@ -380,8 +380,8 @@ typedef struct { UINT32 BbsTablePointer; ///< A pointer to the BBS table. UINT16 RuntimeSegment; ///< The segment where the OpROM c= an be relocated to. If this value is 0x0000, this ///< means that the relocation of = this run time code is not supported. - ///< Inconsistent with specificati= on here:=20 - ///< The member's name "OpromDesti= nationSegment" [defined in Intel Framework Compatibility Support Module Spe= cification / 0.97 version]=20 + ///< Inconsistent with specificati= on here: + ///< The member's name "OpromDesti= nationSegment" [defined in Intel Framework Compatibility Support Module Spe= cification / 0.97 version] ///< has been changed to "RuntimeS= egment" since keeping backward compatible. =20 } EFI_DISPATCH_OPROM_TABLE; @@ -394,52 +394,52 @@ typedef struct { /// Starting address of memory under 1 MB. The ending address is assumed= to be 640 KB or 0x9FFFF. /// UINT32 BiosLessThan1MB; - =20 + /// /// The starting address of the high memory block. /// UINT32 HiPmmMemory; - =20 + /// /// The length of high memory block. /// UINT32 HiPmmMemorySizeInBytes; - =20 + /// /// The segment of the reverse thunk call code. /// UINT16 ReverseThunkCallSegment; - =20 + /// /// The offset of the reverse thunk call code. /// UINT16 ReverseThunkCallOffset; - =20 + /// /// The number of E820 entries copied to the Compatibility16 BIOS. /// UINT32 NumberE820Entries; - =20 + /// /// The amount of usable memory above 1 MB, e.g., E820 type 1 memory. /// UINT32 OsMemoryAbove1Mb; - =20 + /// /// The start of thunk code in main memory. Memory cannot be used by BIO= S or PMM. /// UINT32 ThunkStart; - =20 + /// /// The size of the thunk code. /// UINT32 ThunkSizeInBytes; - =20 + /// /// Starting address of memory under 1 MB. /// UINT32 LowPmmMemory; - =20 + /// /// The length of low Memory block. /// @@ -530,40 +530,40 @@ typedef struct { /// per IDE controller. The IdentifyDrive is per drive. Index 0 is maste= r and index /// 1 is slave. /// - UINT16 Status; =20 - =20 + UINT16 Status; + /// /// PCI bus of IDE controller. /// UINT32 Bus; - =20 + /// /// PCI device of IDE controller. /// UINT32 Device; - =20 + /// /// PCI function of IDE controller. /// UINT32 Function; - =20 + /// /// Command ports base address. /// UINT16 CommandBaseAddress; - =20 + /// /// Control ports base address. /// UINT16 ControlBaseAddress; - =20 + /// /// Bus master address. /// UINT16 BusMasterAddress; - =20 + UINT8 HddIrq; - =20 + /// /// Data that identifies the drive data; one per possible attached drive. /// @@ -591,7 +591,7 @@ typedef struct { UINT16 Enabled : 1; ///< If 0, ignore = this entry. UINT16 Failed : 1; ///< 0 =3D Not kno= wn if boot failure occurred. ///< 1 =3D Boot at= tempted failed. - =20 + /// /// State of media present. /// 00 =3D No bootable media is present in the device. @@ -611,64 +611,64 @@ typedef struct { /// The boot priority for this boot device. Values are defined below. /// UINT16 BootPriority; - =20 + /// /// The PCI bus for this boot device. /// UINT32 Bus; - =20 + /// /// The PCI device for this boot device. /// UINT32 Device; - =20 + /// /// The PCI function for the boot device. /// UINT32 Function; - =20 + /// /// The PCI class for this boot device. /// UINT8 Class; - =20 + /// /// The PCI Subclass for this boot device. /// UINT8 SubClass; - =20 + /// /// Segment:offset address of an ASCIIZ description string describing th= e manufacturer. /// UINT16 MfgStringOffset; - =20 + /// /// Segment:offset address of an ASCIIZ description string describing th= e manufacturer. - /// =20 + /// UINT16 MfgStringSegment; - =20 + /// /// BBS device type. BBS device types are defined below. /// UINT16 DeviceType; - =20 + /// /// Status of this boot device. Type BBS_STATUS_FLAGS is defined below. /// BBS_STATUS_FLAGS StatusFlags; - =20 + /// /// Segment:Offset address of boot loader for IPL devices or install INT= 13 handler for /// BCV devices. /// UINT16 BootHandlerOffset; - =20 + /// /// Segment:Offset address of boot loader for IPL devices or install INT= 13 handler for /// BCV devices. - /// =20 + /// UINT16 BootHandlerSegment; - =20 + /// /// Segment:offset address of an ASCIIZ description string describing th= is device. /// @@ -678,38 +678,38 @@ typedef struct { /// Segment:offset address of an ASCIIZ description string describing th= is device. /// UINT16 DescStringSegment; - =20 + /// /// Reserved. /// UINT32 InitPerReserved; - =20 + /// /// The use of these fields is IBV dependent. They can be used to flag t= hat an OpROM /// has hooked the specified IRQ. The OpROM may be BBS compliant as some= SCSI /// BBS-compliant OpROMs also hook IRQ vectors in order to run their BIO= S Setup /// UINT32 AdditionalIrq13Handler; - =20 + /// /// The use of these fields is IBV dependent. They can be used to flag t= hat an OpROM /// has hooked the specified IRQ. The OpROM may be BBS compliant as some= SCSI /// BBS-compliant OpROMs also hook IRQ vectors in order to run their BIO= S Setup - /// =20 + /// UINT32 AdditionalIrq18Handler; - =20 + /// /// The use of these fields is IBV dependent. They can be used to flag t= hat an OpROM /// has hooked the specified IRQ. The OpROM may be BBS compliant as some= SCSI /// BBS-compliant OpROMs also hook IRQ vectors in order to run their BIO= S Setup - /// =20 + /// UINT32 AdditionalIrq19Handler; - =20 + /// /// The use of these fields is IBV dependent. They can be used to flag t= hat an OpROM /// has hooked the specified IRQ. The OpROM may be BBS compliant as some= SCSI /// BBS-compliant OpROMs also hook IRQ vectors in order to run their BIO= S Setup - /// =20 + /// UINT32 AdditionalIrq40Handler; UINT8 AssignedDriveNumber; UINT32 AdditionalIrq41Handler; @@ -749,17 +749,17 @@ typedef struct { /// values are reserved for future usage. /// UINT16 Type : 3; - =20 + /// /// The size of "port" in bits. Defined values are below. /// UINT16 PortGranularity : 3; - =20 + /// /// The size of data in bits. Defined values are below. /// UINT16 DataGranularity : 3; - =20 + /// /// Reserved for future use. /// @@ -824,17 +824,17 @@ typedef struct { /// SMM_ATTRIBUTES is defined below. /// SMM_ATTRIBUTES SmmAttributes; - =20 + /// /// Function Soft SMI is to perform. Type SMM_FUNCTION is defined below. /// SMM_FUNCTION SmmFunction; - =20 + /// /// SmmPort size depends upon SmmAttributes and ranges from2 bytes to 16= bytes. /// UINT8 SmmPort; - =20 + /// /// SmmData size depends upon SmmAttributes and ranges from2 bytes to 16= bytes. /// @@ -857,18 +857,18 @@ typedef struct { /// This bit set indicates that the ServiceAreaData is valid. /// UINT8 DirectoryServiceValidity : 1; - =20 + /// /// This bit set indicates to use the Reserve Area Boot Code Address (RA= CBA) only if /// DirectoryServiceValidity is 0. /// UINT8 RabcaUsedFlag : 1; - =20 + /// /// This bit set indicates to execute hard disk diagnostics. /// UINT8 ExecuteHddDiagnosticsFlag : 1; - =20 + /// /// Reserved for future use. Set to 0. /// @@ -884,35 +884,35 @@ typedef struct { /// UDC_ATTRIBUTES is defined below. /// UDC_ATTRIBUTES Attributes; - =20 + /// /// This field contains the zero-based device on which the selected - /// ServiceDataArea is present. It is 0 for master and 1 for the slave d= evice. =20 + /// ServiceDataArea is present. It is 0 for master and 1 for the slave d= evice. /// UINT8 DeviceNumber; - =20 + /// /// This field contains the zero-based index into the BbsTable for the p= arent device. /// This index allows the user to reference the parent device informatio= n such as PCI /// bus, device function. /// UINT8 BbsTableEntryNumberForParentDevice; - =20 + /// /// This field contains the zero-based index into the BbsTable for the b= oot entry. /// UINT8 BbsTableEntryNumberForBoot; - =20 + /// /// This field contains the zero-based index into the BbsTable for the H= DD diagnostics entry. /// UINT8 BbsTableEntryNumberForHddDiag; - =20 + /// /// The raw Beer data. /// UINT8 BeerData[128]; - =20 + /// /// The raw data of selected service area. /// @@ -982,4 +982,6 @@ typedef struct { UINT16 SecondaryBusMaster; ///< The secondary= device bus master I/O base. } EFI_LEGACY_INSTALL_PCI_HANDLER; =20 +#pragma pack() + #endif --=20 2.43.0 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org From nobody Sun Sep 21 21:44:29 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail(p=none dis=none) header.from=flygoat.com Return-Path: Received: from coreboot.org (mail.coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 1756882446855652.0498931203805; Tue, 2 Sep 2025 23:54:06 -0700 (PDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id CD5F54C400; Wed, 3 Sep 2025 06:54:04 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) (fhigh-a2-smtp.messagingengine.com [103.168.172.153]) by coreboot.org (Postfix) with ESMTP id E744940357 for ; Wed, 3 Sep 2025 06:51:42 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by mailfhigh.phl.internal (Postfix) with ESMTP id 072F414003A4; Wed, 3 Sep 2025 02:51:42 -0400 (EDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by phl-compute-04.internal (MEProxy); Wed, 03 Sep 2025 02:51:42 -0400 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) 3 Sep 2025 02:51:40 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flygoat.com; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1756882302; x=1756968702; bh=HaY8JCdjhNIlehKO7eq3t7ubeskKgCdejJ5ZYTQzY5k=; b= Kp+2abpqixODQynJIkfN1jRmYTwVqfWuo+h1ftzC0k8ZtYW8JMAb/tqtdM16Rjew XsMp7fApeoBitpBBldosSD2YUg8iaXLtWevwUnRACIJtMJZOw4N3i8KkTSNmeI+E Z1MDMoUb9amb7/s8TGqJmkTIWD6mjQNJDGdLB5KD0lXr9sAK51islh8+Pdv9Gdoc +h9nY0IkVFsbIMHEXidrAEKjIzHwTO0xkLaqcPuCU2MUMI4Q4xDcNaugHtXHTHkI D7LQA8axVTDRBmsLaXhBNMkZcrSpkNID6TKd9VYlJL75Q8GjavxRcCLG8WeQvKhJ 7t+kiqz6CejYKnO+nBMMPQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1756882302; x= 1756968702; bh=HaY8JCdjhNIlehKO7eq3t7ubeskKgCdejJ5ZYTQzY5k=; b=Q 8ci606+Jm+1z9f4kPC191Ag4hGIzBn2W/ZHJ1+qUwk5RqIQR7zI+McolPm5CzP9n rJWP1LLocOnAkJhHaUAESM5iXfHRuy2eb7SzOg08HWtqXUxjfPBwS3daRtZ+HKcy IQ6m7hoR1pBC6kBSjNhtH59XCl2iIN/onh/WgoxayRGjUtLBtqxhTR7WMlChX6rs 8vRjgJ5F8vGNzuzfuF0cyN2tNti9bMUGJSCA7mBJnJX29XNkZbFZ7r07ro+Koesq lWlAFMPlqH1WanUdQat0jWoirEdBs4h/woj/lW+O5XB8d/590sEtOctNf5WPPAtT l0tnbjPTXtoW2leG05BkQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvgeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucenucfjughrpefhfffugggtgffkfhgjvfevofesthejredtre dtjeenucfhrhhomheplfhirgiguhhnucgjrghnghcuoehjihgrgihunhdrhigrnhhgsehf lhihghhorghtrdgtohhmqeenucggtffrrghtthgvrhhnpedvkeeihfefveekueevteefle ffkeegudeghfdtuddugefhueevgeffgedukeejleenucevlhhushhtvghrufhiiigvpedt necurfgrrhgrmhepmhgrihhlfhhrohhmpehjihgrgihunhdrhigrnhhgsehflhihghhorg htrdgtohhmpdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphht thhopehsvggrsghiohhssehsvggrsghiohhsrdhorhhgpdhrtghpthhtohepjhhirgiguh hnrdihrghnghesfhhlhihgohgrthdrtghomh X-ME-Proxy: Feedback-ID: ifd894703:Fastmail From: Jiaxun Yang Date: Wed, 03 Sep 2025 06:51:29 +0000 MIME-Version: 1.0 Message-Id: <20250903-build-v2-8-8e8916974f9c@flygoat.com> References: <20250903-build-v2-0-8e8916974f9c@flygoat.com> In-Reply-To: <20250903-build-v2-0-8e8916974f9c@flygoat.com> To: seabios@seabios.org Message-ID-Hash: S5YAXK3VOSWY4C5N3FBY77LL3OQALJJ7 X-Message-ID-Hash: S5YAXK3VOSWY4C5N3FBY77LL3OQALJJ7 X-MailFrom: jiaxun.yang@flygoat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Jiaxun Yang X-Mailman-Version: 3.3.11b1 Precedence: list Subject: [SeaBIOS] [PATCH v2 8/9] virtio-blk: Fix indentation for vring_get_buf call List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-Spamd-Bar: ---- X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZM-MESSAGEID: 1756882449728124100 Content-Type: text/plain; charset="utf-8" Adjusted the indentation of the vring_get_buf function call to improve code= readability and maintain consistency with surrounding code. Fix warning: In file included from out/ccode32flat.o.tmp.c:83: ./src/hw/virtio-blk.c:56:9: warning: misleading indentation; statement is n= ot part of the previous 'while' [-Wmisleading-indentation] 56 | vring_get_buf(vq, NULL); Signed-off-by: Jiaxun Yang Reviewed-by: Paul Menzel --- src/hw/virtio-blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hw/virtio-blk.c b/src/hw/virtio-blk.c index 137a2c3c75579beae69611e248002d48f947fdac..351692e22e6ebaf63626348e47a= 0f0533617325e 100644 --- a/src/hw/virtio-blk.c +++ b/src/hw/virtio-blk.c @@ -53,7 +53,7 @@ virtio_blk_op_one_segment(struct virtiodrive_s *vdrive, usleep(5); =20 /* Reclaim virtqueue element */ - vring_get_buf(vq, NULL); + vring_get_buf(vq, NULL); =20 /** ** Clear interrupt status register. Avoid leaving interrupts stuck --=20 2.43.0 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org From nobody Sun Sep 21 21:44:29 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail(p=none dis=none) header.from=flygoat.com Return-Path: Received: from coreboot.org (mail.coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 1756882461988545.738824497927; Tue, 2 Sep 2025 23:54:21 -0700 (PDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id 82AD14C400; Wed, 3 Sep 2025 06:54:19 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) (fhigh-a2-smtp.messagingengine.com [103.168.172.153]) by coreboot.org (Postfix) with ESMTP id 2C7CA403A2 for ; Wed, 3 Sep 2025 06:51:45 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by mailfhigh.phl.internal (Postfix) with ESMTP id 464111400382; Wed, 3 Sep 2025 02:51:44 -0400 (EDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by phl-compute-06.internal (MEProxy); Wed, 03 Sep 2025 02:51:44 -0400 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) 3 Sep 2025 02:51:43 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flygoat.com; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1756882304; x=1756968704; bh=8KU3/KdQ6HJfYc0VUoQJQQiRsQvW7tPz+F7Eu2rITaw=; b= eeVTO9MdcO8VTYGDywRxjrVXd55Pe1ZYK1CkN5H/nl35NufXOzHjMUnk7xzrmY0u 8Krqo5NAgCQ+aFsTG3jKVfsLLETYvs6kv3nR+zt5SsIneZBh689K75mRuuwQ0E+y z/GLdmgX56j3P78m+88SB7zHMMcifaaG5RB0K42tJkljhcY0U7tcsL0/VnawvEx4 faV/PoR5ltVbWEZ+7D0QhfyuQGhBTZsekraqxgk85jKtTKiJ+FhPiwd4g8IZqnwL vihyy9Xsa4XgH4WDlcUBKaS+yPdd7A/gN+PwJnlmFKOh71w/wtM1zQ0PqxsqYkrb pU4jKTFZBmUkp1UQJdU43A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1756882304; x= 1756968704; bh=8KU3/KdQ6HJfYc0VUoQJQQiRsQvW7tPz+F7Eu2rITaw=; b=P C3YlmtJ9Dp3ZxTC8yqkaq5LKFGHb53yBjy/fcEvaF10vhGe6X5dez247VBkzRavz GAkXrTn5hIBlwSg/mGRDuGYxxXLBt1+z4eeYxnlxMAA395Z66PTT4cR7hTBpteJf fxZ3DmSvhTyuFDikzAxOdz3B/CWSh9xxHqlMrQrag1MfWulPTKKOyC1M7T7powzO 3HSrmfrw1Win2IIqhVHzr4B+u2rAw04sfhaHK2EUZ7oRYSOrqiJgkXlvDkJpIl9j K5JjD/VXovQ0dKWF4e8+dbCxdMVYOxkUFbBvnQdyfDiqV7zADjMBUsE7wnSguvZU MaFr8aNfFBupG7rLPKLXw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvgeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucenucfjughrpefhfffugggtgffkfhgjvfevofesthejredtre dtjeenucfhrhhomheplfhirgiguhhnucgjrghnghcuoehjihgrgihunhdrhigrnhhgsehf lhihghhorghtrdgtohhmqeenucggtffrrghtthgvrhhnpedvkeeihfefveekueevteefle ffkeegudeghfdtuddugefhueevgeffgedukeejleenucevlhhushhtvghrufhiiigvpedv necurfgrrhgrmhepmhgrihhlfhhrohhmpehjihgrgihunhdrhigrnhhgsehflhihghhorg htrdgtohhmpdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphht thhopehsvggrsghiohhssehsvggrsghiohhsrdhorhhgpdhrtghpthhtohepjhhirgiguh hnrdihrghnghesfhhlhihgohgrthdrtghomh X-ME-Proxy: Feedback-ID: ifd894703:Fastmail From: Jiaxun Yang Date: Wed, 03 Sep 2025 06:51:30 +0000 MIME-Version: 1.0 Message-Id: <20250903-build-v2-9-8e8916974f9c@flygoat.com> References: <20250903-build-v2-0-8e8916974f9c@flygoat.com> In-Reply-To: <20250903-build-v2-0-8e8916974f9c@flygoat.com> To: seabios@seabios.org Message-ID-Hash: QSFCBIJB2LGCWG2LXRMNLAYWCMBYYNAJ X-Message-ID-Hash: QSFCBIJB2LGCWG2LXRMNLAYWCMBYYNAJ X-MailFrom: jiaxun.yang@flygoat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Jiaxun Yang X-Mailman-Version: 3.3.11b1 Precedence: list Subject: [SeaBIOS] [PATCH v2 9/9] usb-ohci: Fix logical condition in start_ohci function List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-Spamd-Bar: ---- X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZM-MESSAGEID: 1756882463889116600 Content-Type: text/plain; charset="utf-8" Corrected the logical condition in the start_ohci function to ensure proper= evaluation of the status variable. This change prevents potential misinter= pretation of the command status register. Fix warning: ./src/hw/usb-ohci.c:192:13: warning: logical not is only applied to the lef= t hand side of this bitwise operator [-Wlogical-not-parentheses] 192 | if (! status & OHCI_HCR) Signed-off-by: Jiaxun Yang Reviewed-by: Paul Menzel --- src/hw/usb-ohci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hw/usb-ohci.c b/src/hw/usb-ohci.c index 90f60e6452957552412d2aa9958f00141473437a..0fe8ea9e5d36468516e60830510= 4da1e2129be70 100644 --- a/src/hw/usb-ohci.c +++ b/src/hw/usb-ohci.c @@ -189,7 +189,7 @@ start_ohci(struct usb_ohci_s *cntl, struct ohci_hcca *h= cca) writel(&cntl->regs->cmdstatus, OHCI_HCR); for (;;) { u32 status =3D readl(&cntl->regs->cmdstatus); - if (! status & OHCI_HCR) + if (!(status & OHCI_HCR)) break; if (timer_check(end)) { warn_timeout(); --=20 2.43.0 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org