Gerd Hoffmann (2):
  drop obsolete acpi table code
  drop acpi tables and hex includes

 Makefile                         |  15 -
 src/fw/acpi.c                    | 668 +------------------------------
 src/Kconfig                      |  10 -
 src/fw/acpi-dsdt-cpu-hotplug.dsl |  78 ----
 src/fw/acpi-dsdt-dbug.dsl        |  26 --
 src/fw/acpi-dsdt-hpet.dsl        |  36 --
 src/fw/acpi-dsdt-isa.dsl         | 102 -----
 src/fw/acpi-dsdt-pci-crs.dsl     |  90 -----
 src/fw/acpi-dsdt.dsl             | 342 ----------------
 src/fw/acpi-dsdt.hex             | 554 -------------------------
 src/fw/q35-acpi-dsdt.dsl         | 450 ---------------------
 src/fw/ssdt-misc.dsl             | 104 -----
 src/fw/ssdt-misc.hex             |  88 ----
 src/fw/ssdt-pcihp.dsl            |  36 --
 src/fw/ssdt-pcihp.hex            |  38 --
 src/fw/ssdt-proc.dsl             |  48 ---
 src/fw/ssdt-proc.hex             |  35 --
 17 files changed, 1 insertion(+), 2719 deletions(-)
 delete mode 100644 src/fw/acpi-dsdt-cpu-hotplug.dsl
 delete mode 100644 src/fw/acpi-dsdt-dbug.dsl
 delete mode 100644 src/fw/acpi-dsdt-hpet.dsl
 delete mode 100644 src/fw/acpi-dsdt-isa.dsl
 delete mode 100644 src/fw/acpi-dsdt-pci-crs.dsl
 delete mode 100644 src/fw/acpi-dsdt.dsl
 delete mode 100644 src/fw/acpi-dsdt.hex
 delete mode 100644 src/fw/q35-acpi-dsdt.dsl
 delete mode 100644 src/fw/ssdt-misc.dsl
 delete mode 100644 src/fw/ssdt-misc.hex
 delete mode 100644 src/fw/ssdt-pcihp.dsl
 delete mode 100644 src/fw/ssdt-pcihp.hex
 delete mode 100644 src/fw/ssdt-proc.dsl
 delete mode 100644 src/fw/ssdt-proc.hex

-- 
2.47.0

_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org

On Thu, Nov 21, 2024 at 05:52:41PM +0100, Gerd Hoffmann wrote:
> 
> 
> Gerd Hoffmann (2):
>   drop obsolete acpi table code
>   drop acpi tables and hex includes

Thanks for working on this.  I wonder if we should disable it by
default in "make menuconfig" for a year or so prior to full removal?

-Kevin
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org

On Thu, Nov 21, 2024 at 01:34:10PM -0500, Kevin O'Connor wrote:
> On Thu, Nov 21, 2024 at 05:52:41PM +0100, Gerd Hoffmann wrote:
> > 
> > 
> > Gerd Hoffmann (2):
> >   drop obsolete acpi table code
> >   drop acpi tables and hex includes
> 
> Thanks for working on this.  I wonder if we should disable it by
> default in "make menuconfig" for a year or so prior to full removal?

Well, I think the only thing this code does at this point is confusing
people.

I also have a small compatibility story:  seabios got build-in serial
console support a while back.  We never managed to add some kind of
automatic switch-over from sgabios rom though (there only is a sanity
check to make sure they are not both active).  So the code got little
actual usage for quite a while.  Roughly five years later qemu and
libvirt did a hard switch-over from sgabios to the seabios build-in
serial console.  No compatibility problems.

The qemu versions which depend on this code are more than ten years
old meanwhile ...

take care,
  Gerd

_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org

On Fri, Nov 22, 2024 at 03:00:41PM +0100, Gerd Hoffmann wrote:
> On Thu, Nov 21, 2024 at 01:34:10PM -0500, Kevin O'Connor wrote:
> > On Thu, Nov 21, 2024 at 05:52:41PM +0100, Gerd Hoffmann wrote:
> > > 
> > > 
> > > Gerd Hoffmann (2):
> > >   drop obsolete acpi table code
> > >   drop acpi tables and hex includes
> > 
> > Thanks for working on this.  I wonder if we should disable it by
> > default in "make menuconfig" for a year or so prior to full removal?
> 
> Well, I think the only thing this code does at this point is confusing
> people.

Okay.  I'm fine with that as well.

Cheers,
-Kevin


> 
> I also have a small compatibility story:  seabios got build-in serial
> console support a while back.  We never managed to add some kind of
> automatic switch-over from sgabios rom though (there only is a sanity
> check to make sure they are not both active).  So the code got little
> actual usage for quite a while.  Roughly five years later qemu and
> libvirt did a hard switch-over from sgabios to the seabios build-in
> serial console.  No compatibility problems.
> 
> The qemu versions which depend on this code are more than ten years
> old meanwhile ...
> 
> take care,
>   Gerd
> 
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org

On Tue, Dec 24, 2024 at 06:50:48PM -0500, Kevin O'Connor wrote:
> On Fri, Nov 22, 2024 at 03:00:41PM +0100, Gerd Hoffmann wrote:
> > On Thu, Nov 21, 2024 at 01:34:10PM -0500, Kevin O'Connor wrote:
> > > On Thu, Nov 21, 2024 at 05:52:41PM +0100, Gerd Hoffmann wrote:
> > > > 
> > > > 
> > > > Gerd Hoffmann (2):
> > > >   drop obsolete acpi table code
> > > >   drop acpi tables and hex includes
> > > 
> > > Thanks for working on this.  I wonder if we should disable it by
> > > default in "make menuconfig" for a year or so prior to full removal?
> > 
> > Well, I think the only thing this code does at this point is confusing
> > people.
> 
> Okay.  I'm fine with that as well.

Pushed now.

take care,
  Gerd

_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org

On 21/11/24 17:52, Gerd Hoffmann wrote:
> 
> 
> Gerd Hoffmann (2):
>    drop obsolete acpi table code
>    drop acpi tables and hex includes

Nice cleanup!

Series:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org