From nobody Wed Feb 5 12:47:47 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail(p=none dis=none) header.from=koconnor.net Return-Path: Received: from coreboot.org (coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 171198690594775.36854063764201; Mon, 1 Apr 2024 08:55:05 -0700 (PDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id E9F5F225D2; Mon, 1 Apr 2024 15:55:00 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTP id 625342247E for ; Mon, 1 Apr 2024 15:54:26 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) for ; Mon, 01 Apr 2024 08:54:26 -0700 (PDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by smtp.gmail.com with ESMTPSA id ks28-20020a056214311c00b0068f35e9e9a2sm4615920qvb.8.2024.04.01.08.54.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Apr 2024 08:54:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=koconnor.net; s=google; t=1711986865; x=1712591665; darn=seabios.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=zqC0WkgJnosuNh3fc7KqGFY730MJZmlHMmMM6gMyVN8=; b=TrgYZH2bSJRtwmdvpcrtvU8wX3LbXmpqpvBW3S69lusdhwuZWL0A3zDzL0K9n8OQuX Kb+u7B9sWNH2T2nfaz7kRppYJ1xjQ2HnNqCo9VIGqlUFT/Q64cOie/QkvG9dVMSmbtP5 ElRuWBgjxQd7EYeyb3zlXGe0GVgN9sMjo7ymE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711986865; x=1712591665; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zqC0WkgJnosuNh3fc7KqGFY730MJZmlHMmMM6gMyVN8=; b=h2o7jleL4Qpzz8JKAfbs9ElNpSQYmVqFlWL39chQhDUiEnVV+ZFRqdU8JrHNDcUGig u9M8KVU2WlGH/Z1ksG0CY3rP86eBqApoI+bHJuQQZcw3JVqa9hDvpa6XJKUciBUfAUO8 +3U0JJ3T+CRvg429RG6o4UyIt3pOwiSzNBhM4Ow0HtwgEVIS2WXe8lRnBSM4Ae3nntjO BPDGzt/XfmzaFXWvexE0P6Sb5q/6AhvLRamTugVOTQLtn+lJzDwNwQOs1h20jUxkmHbN PgZLLsvcjhFz5W6eZIMiEvQONEKmfQCwaX8qv6LFoDFdt2nLktthxzFFc+wAwFkal7RZ wlrw== X-Gm-Message-State: AOJu0YzBfWVD0+Taok+VKFh8cHEijUFGw/lMc9LeQVXm+avxo3UCqgWO L6KiLNjUN47F5OqkwnAG0WoHTy30tnS3zd7h5/KHF81/gf/kf+mjd9d5WUW0wKiCivOJ15TfXgD T X-Google-Smtp-Source: AGHT+IEQw8EeXss6nRwDm5Gqxhj62NJbB1DKnRaLEghbTQyLBt3M7fLif/0HahFgaY0mdKQLB8JaBg== X-Received: by 2002:a0c:dd0d:0:b0:691:8661:1069 with SMTP id u13-20020a0cdd0d000000b0069186611069mr9324750qvk.25.1711986865027; Mon, 01 Apr 2024 08:54:25 -0700 (PDT) From: Kevin O'Connor To: seabios@seabios.org Date: Mon, 1 Apr 2024 11:51:23 -0400 Message-ID: <20240401155420.880666-2-kevin@koconnor.net> In-Reply-To: <20240401155420.880666-1-kevin@koconnor.net> References: <20240401155420.880666-1-kevin@koconnor.net> MIME-Version: 1.0 X-Spam-Level: *** Message-ID-Hash: WSQ6CHP3XL4SKJL4JEOGJI3CTUVDOI2U X-Message-ID-Hash: WSQ6CHP3XL4SKJL4JEOGJI3CTUVDOI2U X-MailFrom: kevin@koconnor.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.6b1 Precedence: list Subject: [SeaBIOS] [PATCH 1/9] stdvgamodes: No need to store pelmask in vga_modes[] List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-Spamd-Bar: --- X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1711986907913100001 Content-Type: text/plain; charset="utf-8" The pelmask is always 0xff so no need to store in a static table. Signed-off-by: Kevin O'Connor --- vgasrc/stdvgamodes.c | 37 ++++++++++++++++++------------------- 1 file changed, 18 insertions(+), 19 deletions(-) diff --git a/vgasrc/stdvgamodes.c b/vgasrc/stdvgamodes.c index 3e6b575..ed1d983 100644 --- a/vgasrc/stdvgamodes.c +++ b/vgasrc/stdvgamodes.c @@ -263,7 +263,6 @@ struct stdvga_mode_s { u16 mode; struct vgamode_s info; =20 - u8 pelmask; u8 *dac; u16 dacsize; u8 *sequ_regs; @@ -275,39 +274,39 @@ struct stdvga_mode_s { =20 static struct stdvga_mode_s vga_modes[] VAR16 =3D { //mode { model tx ty bpp cw ch sstart } - // pelm dac sequ misc crtc actl grdc + // dac sequ misc crtc actl grdc {0x00, { MM_TEXT, 40, 25, 4, 9, 16, SEG_CTEXT } - , 0xFF, PAL(palette2), sequ_01, 0x67, crtc_01, actl_01, grdc_01}, + , PAL(palette2), sequ_01, 0x67, crtc_01, actl_01, grdc_01}, {0x01, { MM_TEXT, 40, 25, 4, 9, 16, SEG_CTEXT } - , 0xFF, PAL(palette2), sequ_01, 0x67, crtc_01, actl_01, grdc_01}, + , PAL(palette2), sequ_01, 0x67, crtc_01, actl_01, grdc_01}, {0x02, { MM_TEXT, 80, 25, 4, 9, 16, SEG_CTEXT } - , 0xFF, PAL(palette2), sequ_03, 0x67, crtc_03, actl_01, grdc_01}, + , PAL(palette2), sequ_03, 0x67, crtc_03, actl_01, grdc_01}, {0x03, { MM_TEXT, 80, 25, 4, 9, 16, SEG_CTEXT } - , 0xFF, PAL(palette2), sequ_03, 0x67, crtc_03, actl_01, grdc_01}, + , PAL(palette2), sequ_03, 0x67, crtc_03, actl_01, grdc_01}, {0x04, { MM_CGA, 320, 200, 2, 8, 8, SEG_CTEXT } - , 0xFF, PAL(palette1), sequ_04, 0x63, crtc_04, actl_04, grdc_04}, + , PAL(palette1), sequ_04, 0x63, crtc_04, actl_04, grdc_04}, {0x05, { MM_CGA, 320, 200, 2, 8, 8, SEG_CTEXT } - , 0xFF, PAL(palette1), sequ_04, 0x63, crtc_04, actl_04, grdc_04}, + , PAL(palette1), sequ_04, 0x63, crtc_04, actl_04, grdc_04}, {0x06, { MM_CGA, 640, 200, 1, 8, 8, SEG_CTEXT } - , 0xFF, PAL(palette1), sequ_06, 0x63, crtc_06, actl_06, grdc_06}, + , PAL(palette1), sequ_06, 0x63, crtc_06, actl_06, grdc_06}, {0x07, { MM_TEXT, 80, 25, 4, 9, 16, SEG_MTEXT } - , 0xFF, PAL(palette0), sequ_03, 0x66, crtc_07, actl_07, grdc_07}, + , PAL(palette0), sequ_03, 0x66, crtc_07, actl_07, grdc_07}, {0x0D, { MM_PLANAR, 320, 200, 4, 8, 8, SEG_GRAPH } - , 0xFF, PAL(palette1), sequ_0d, 0x63, crtc_0d, actl_0d, grdc_0d}, + , PAL(palette1), sequ_0d, 0x63, crtc_0d, actl_0d, grdc_0d}, {0x0E, { MM_PLANAR, 640, 200, 4, 8, 8, SEG_GRAPH } - , 0xFF, PAL(palette1), sequ_0e, 0x63, crtc_0e, actl_0d, grdc_0d}, + , PAL(palette1), sequ_0e, 0x63, crtc_0e, actl_0d, grdc_0d}, {0x0F, { MM_PLANAR, 640, 350, 1, 8, 14, SEG_GRAPH } - , 0xFF, PAL(palette0), sequ_0e, 0xa3, crtc_0f, actl_0f, grdc_0d}, + , PAL(palette0), sequ_0e, 0xa3, crtc_0f, actl_0f, grdc_0d}, {0x10, { MM_PLANAR, 640, 350, 4, 8, 14, SEG_GRAPH } - , 0xFF, PAL(palette2), sequ_0e, 0xa3, crtc_0f, actl_10, grdc_0d}, + , PAL(palette2), sequ_0e, 0xa3, crtc_0f, actl_10, grdc_0d}, {0x11, { MM_PLANAR, 640, 480, 1, 8, 16, SEG_GRAPH } - , 0xFF, PAL(palette2), sequ_0e, 0xe3, crtc_11, actl_11, grdc_0d}, + , PAL(palette2), sequ_0e, 0xe3, crtc_11, actl_11, grdc_0d}, {0x12, { MM_PLANAR, 640, 480, 4, 8, 16, SEG_GRAPH } - , 0xFF, PAL(palette2), sequ_0e, 0xe3, crtc_11, actl_10, grdc_0d}, + , PAL(palette2), sequ_0e, 0xe3, crtc_11, actl_10, grdc_0d}, {0x13, { MM_PACKED, 320, 200, 8, 8, 8, SEG_GRAPH } - , 0xFF, PAL(palette3), sequ_13, 0x63, crtc_13, actl_13, grdc_13}, + , PAL(palette3), sequ_13, 0x63, crtc_13, actl_13, grdc_13}, {0x6A, { MM_PLANAR, 800, 600, 4, 8, 16, SEG_GRAPH } - , 0xFF, PAL(palette2), sequ_0e, 0xe3, crtc_6A, actl_10, grdc_0d}, + , PAL(palette2), sequ_0e, 0xe3, crtc_6A, actl_10, grdc_0d}, }; =20 =20 @@ -457,7 +456,7 @@ stdvga_set_mode(struct vgamode_s *vmode_g, int flags) =20 // if palette loading (bit 3 of modeset ctl =3D 0) if (!(flags & MF_NOPALETTE)) { // Set the PEL mask - stdvga_pelmask_write(GET_GLOBAL(stdmode_g->pelmask)); + stdvga_pelmask_write(0xff); =20 // From which palette u8 *palette_g =3D GET_GLOBAL(stdmode_g->dac); --=20 2.44.0 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org