From nobody Sat Dec 21 12:21:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail(p=none dis=none) header.from=ilande.co.uk Return-Path: Received: from coreboot.org (coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 1704111616277961.3283981916389; Mon, 1 Jan 2024 04:20:16 -0800 (PST) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id 72D3820CB2; Mon, 1 Jan 2024 12:20:10 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTP id 4DBAA205B6 for ; Mon, 1 Jan 2024 12:19:51 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rKHGJ-0007o8-Pz; Mon, 01 Jan 2024 12:19:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:MIME-Version: Message-Id:Date:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cOlQuU/GVaFFmJcdL+KH3emVW3NwBjdacxs1ujp85XE=; b=nzvfFqJqbiCls0A0w5nXat1FSL ReNGrnP+9ExJPydcuGApf/cwsfAbDdGhozg7P+XhEGvIGWd6kXOflITzzUPw0RtO3iWb5tQa+DIuD +OSdaQSIENpXaNWfhK332/H7uSVdkN3DF+snl9T8uyTiEBXjb0XnOrLo+9YDWb8iaowG8B7uhRage /TTEQxS/K5B9z87YwM9cT+PzWUy2xAtGot3OpOmCVeHbp0Qenfk2BsAxyAL+wJrGwXqojbLRBBMSq 53s4a0xEcWKU2XdTRaynev4quUYOuuLUIhwI/U1HXMHdBTlt0dSu3gz35L6jqwp5BsQ3Xtgnb4VWT qnKxiGRk5wzGf+o0FxNYvwI6uz119jkWKmWYF67TbOOdX/VPXtwzJ3szhwkg7wvIC9iDBB7anVs6V PjzYzMcR/GdkC/hjj3rXQwVuVMOGbrmW+nIGf52o6QTTzGm06DLESj7h8W7NWG+NfBCXPP/3NMv4t o3/B+JpmvfPBzJ3UkGaIUks1ppUeSWdeO/JwxOkXASJS2sDdJqiFPecgpo+rlcCP8PuryUlHVE+Cb EEk8a6SHmvTpdqAHm53OInoOSMJwhvm/4fQaVZNVa91N8vwWwzIUCK3AUZ7ZMALpZef1jTypOFZ0g sG0pvXENcTwsNyi81nxLTXu2AGCbzzg0A88m6p9kg=; From: Mark Cave-Ayland To: seabios@seabios.org, pbonzini@redhat.com, hpoussin@reactos.org Date: Mon, 1 Jan 2024 12:19:42 +0000 Message-Id: <20240101121942.383191-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a00:23c4:8bb0:f100:a9b5:881b:ff88:2c10 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.default.ilande.bv.iomart.io X-Spam-Status: No, score=-2.8 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED,URIBL_SBL_A autolearn=no autolearn_force=no version=3.4.2 X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) X-Spam-Level: *** Message-ID-Hash: 4O3P4VV2Q3JA236LBOU5T637HCZ2KYUA X-Message-ID-Hash: 4O3P4VV2Q3JA236LBOU5T637HCZ2KYUA X-MailFrom: mark.cave-ayland@ilande.co.uk X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.6b1 Precedence: list Subject: [SeaBIOS] [PATCH] esp-scsi: terminate DMA transfer when ESP data transfer completes List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-Spamd-Bar: / X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1704111618359100001 Content-Type: text/plain; charset="utf-8" When the ESP data transfer completes indicated by the STAT_TC flag being se= t, terminate the DMA transfer by issuing a DMA IDLE command. Otherwise in the = case where the guest sends a reset followed by an ESP command, the DMA signal re= mains enabled and so the next SeaBIOS DMA transfer begins immediately when the ne= xt ESP command is received rather than waiting until the data is ready and the= DMA command is issued. With this fix it is possible to boot a Windows XP ISO to the installer and complete a full installation within QEMU directly using SeaBIOS. Signed-off-by: Mark Cave-Ayland --- src/hw/esp-scsi.c | 2 ++ 1 file changed, 2 insertions(+) [This fixes the Windows XP setup issue reported by Paolo when DC390 support= was first added to QEMU (see https://lore.kernel.org/all/501A94D0.3080502@redha= t.com/ for the original thread) way back in 2012.] =20 diff --git a/src/hw/esp-scsi.c b/src/hw/esp-scsi.c index f19804f..8612069 100644 --- a/src/hw/esp-scsi.c +++ b/src/hw/esp-scsi.c @@ -147,6 +147,8 @@ esp_scsi_process_op(struct disk_op_s *op) /* At end of DMA TC is set again -> complete command. */ if (state =3D=3D 1 && (stat & ESP_STAT_TC)) { state++; + /* Terminate esp_scsi_dma() command */ + outb(0, iobase + ESP_DMA_CMD); continue; } =20 --=20 2.39.2 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org