From nobody Fri Apr 26 11:29:59 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from coreboot.org (coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 166884409762622.743902656391356; Fri, 18 Nov 2022 23:48:17 -0800 (PST) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id 334C720A41; Sat, 19 Nov 2022 07:48:13 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTP id D388920673 for ; Sat, 19 Nov 2022 07:47:58 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) for ; Fri, 18 Nov 2022 23:47:58 -0800 (PST) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by smtp.gmail.com with ESMTPSA id l7-20020a622507000000b0056328e516f4sm4529828pfl.148.2022.11.18.23.47.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Nov 2022 23:47:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hD5Naaq6VPK9QltBYKpqvt+9gYrJ2NjoR25SUKfPQa0=; b=Jqt2egExGz6gl5P/X9uaNC5MUxgu5aiLvX1a6HrQEQF6RHvTVs6XwD+D3I2axEihwV mOVGPSQjFKP8sRk97cC0fdaOy8oHDN1xytNaCooBGkxFD0iOMA8Y5OAuWvp1ncK122j1 AziiXjeGiAUpzdGxdq4nOkKJflT3U1SNhzlfyKZhu1ZGs7XTer+O7xgjgOSR+5i9hRHu eVvwloYqSZ/XWNbEQ+kXYv39kbQgRa4BciFglv1fK0u5rJ4epgqfJDDAKEmN8TnzP//R h5u/UKHL+GSh3XUyy7GOTfQRY73HTDtepxeW5e9hwLK0p/Eg8M07o7TRjbodIv7syjAQ c9eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hD5Naaq6VPK9QltBYKpqvt+9gYrJ2NjoR25SUKfPQa0=; b=vE13dNhxpXy11TNnQ8ozaIj3u3lZ4E//FUjRarrtjlOPRFhe5pPTGLCXoQo8buELy5 2Qec30PuWbNb24qH5NCmkMCPeRK2/6ERZILhC3m7qclQRLlKT94769K5AewcknXDqg/N FJTZ+JdGsN/WVoyll0+wdvlXlXreVCdWrg8+gc2G3Y4WSVBeZB4C24ShjgmlpbJ+NoPU pzGlUyZdgWF2ybccAM3ZzsXaZx6G0kw70e7aBksXrF7nHYphfL/FT629RuLq6Q6Vn1/8 fopJjePdD21P8VEso3/kn6rP6207mVOaeWAStwOzioMsRNd5C0ro84wR492Z+jGsOfUo 5JQg== X-Gm-Message-State: ANoB5plmhr5ZbQ7euAK9z5+U3HI04ehbbfy5LHLH21hxq1aw9ZxOmvjA oBlgqDFiyeqg4gDzz1SUyUlLc638A2YPHQ== X-Google-Smtp-Source: AA0mqf55hEGQ5O8Tv7T0Y9BDBl5Ngp+2FVf1aYr9f9VBr1tpFDqvLS4NzYQhiVPH/Zf0EHblp2+ehg== X-Received: by 2002:a63:c14e:0:b0:470:4f30:6d80 with SMTP id p14-20020a63c14e000000b004704f306d80mr9774822pgi.285.1668844076848; Fri, 18 Nov 2022 23:47:56 -0800 (PST) From: Xiaofei To: seabios@seabios.org Date: Sat, 19 Nov 2022 15:47:50 +0800 Message-Id: <20221119074750.83531-1-hbuxiaofei@gmail.com> MIME-Version: 1.0 X-Spam-Level: ** Message-ID-Hash: APYPHGLX5JPS2WE2K2RECG6GABJVCHH5 X-Message-ID-Hash: APYPHGLX5JPS2WE2K2RECG6GABJVCHH5 X-MailFrom: hbuxiaofei@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pmenzel@molgen.mpg.de, andy.pei@intel.com, mst@redhat.com, Xiaofei X-Mailman-Version: 3.3.6b1 Precedence: list Subject: [SeaBIOS] [PATCH] virtio-blk: Fix incorrect type conversion in virtio_blk_op() List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-Spamd-Bar: / X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1668844098250100001 Content-Type: text/plain; charset="utf-8" Fixes: a05af290bac5 ("virtio-blk: split large IO according to size_max") When using spdk aio bdev driver, the qemu command line like this: qemu-system-x86_64 \ -chardev socket,id=3Dchar0,path=3D/tmp/vhost.0 \ -device vhost-user-blk-pci,id=3Dblk0,chardev=3Dchar0 \ ... Boot failure message as below: e820 map has 7 items: 0: 0000000000000000 - 000000000009fc00 =3D 1 RAM 1: 000000000009fc00 - 00000000000a0000 =3D 2 RESERVED 2: 00000000000f0000 - 0000000000100000 =3D 2 RESERVED 3: 0000000000100000 - 000000007ffdd000 =3D 1 RAM 4: 000000007ffdd000 - 0000000080000000 =3D 2 RESERVED 5: 00000000feffc000 - 00000000ff000000 =3D 2 RESERVED 6: 00000000fffc0000 - 0000000100000000 =3D 2 RESERVED enter handle_19: NULL Booting from Hard Disk... Boot failed: could not read the boot disk Signed-off-by: Xiaofei Acked-by: Andy Pei < andy.pei@intel.com> Acked-by: Gerd Hoffmann --- src/hw/virtio-blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hw/virtio-blk.c b/src/hw/virtio-blk.c index 9b4a05a..ce3265e 100644 --- a/src/hw/virtio-blk.c +++ b/src/hw/virtio-blk.c @@ -92,7 +92,7 @@ virtio_blk_op(struct disk_op_s *op, int write) u16 blk_num_max; =20 if (vdrive->drive.blksize !=3D 0 && max_io_size !=3D 0) - blk_num_max =3D (u16)max_io_size / vdrive->drive.blksize; + blk_num_max =3D (u16)(max_io_size / vdrive->drive.blksize); else /* default blk_num_max if hardware doesnot advise a proper value */ blk_num_max =3D 64; --=20 2.27.0 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org