From nobody Wed Apr 24 09:17:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=pass(p=reject dis=none) header.from=seabios.org ARC-Seal: i=1; a=rsa-sha256; t=1657676148; cv=none; d=zohomail.com; s=zohoarc; b=ZiGOlrApzKwv2SrQtkSI5e8YuiyiPVrYB1KmPa8xL87BAzV+zU7v4xKASgMp8FL5zFPrzBleDqULSowIid5KzgtEVouus+mN7DyV91ZyxaqH4MsRYR00mj5dIBksKs8sJSyyhnIKNTM5qBN5LjRZMt0OSUQqi6N3VbYhMN3X+hk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657676148; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Subject:To; bh=J7Ert4iX0iYO/kOx9kweT2RPNA3DRREIXKwpOJxkcBo=; b=f/pGO4PyvNM42q1puntlnPI4YotNYl5FXwzs9rRQmMQi4ayZ4AaEm1OXH13P4AQQ3DdHRLFalFptM0lJxuzAf9zLlOpb4KPxd4/p7EdiPjIIW/GTxTvMxoXStMy18PYXoHKzJkpUVMSUCMxfE1/TSLXF7GSlZwIhMq7GthfIyuI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from coreboot.org (coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 1657676148163552.121389483391; Tue, 12 Jul 2022 18:35:48 -0700 (PDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id 5B2202D9BF; Wed, 13 Jul 2022 01:35:44 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTP id 26AD12D696 for ; Wed, 13 Jul 2022 01:35:16 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) for ; Tue, 12 Jul 2022 18:35:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seabios.org; s=dkim; t=1657676145; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-owner: list-unsubscribe:list-subscribe:list-post; bh=J7Ert4iX0iYO/kOx9kweT2RPNA3DRREIXKwpOJxkcBo=; b=kqx10Z8gwRt1hG6LX0xcrL6Pkp1HhM9cwZAK0Roc3WsqfMPd3y7WZekfugV9USHBRz2Rci RQN/Jjg/aUEanEeDok1U7g7OEkmBQ0nzKehrlti82JjzBLaqhfur9Bopm1pMIUcEvKbrwa KEJfK4TIozdeMZ5ot+8AuTYqlhP/RHY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=UTVpE9Cm1AhiCfIj0fXCwQrV/I3COIW2H346vSDDxas=; b=L+hOotpPNsP7h47R4TvZ9bdRNG+HVcqaVc6ngA+axER3ahkE9YxCVQ6ku9WLXKfIPo eTo6cL2d0kR1+fC2+QdQPWTwDgk//MuOii9KHCaoC3rMupe35yznoPiGXHB3RC98Cuq3 9BzuSa7TGYGa8BP5GX4egy8xL2esqRJYnBYoSlXvzUDDLYp5Gw/ejm2FspxY/P8V1GK9 9KsNx0s8lIZ3AlYlyETcbgjc5WVSynkmGlondYnOWRLlQplYtN9i1QwkjXCrWlaTv6Be gcTrzgJn3oN5GpjaCIHqvDT/DLAFn7c4y17Fj+FflcgsT2UParlVkFn6fcXqRjl4ypmx Fsyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=UTVpE9Cm1AhiCfIj0fXCwQrV/I3COIW2H346vSDDxas=; b=T60qkxRUFj060O5H+65hYVhopMDD9rTCtu27rB+C22QxW6pEQDxZXPzjKIsIvZkScd 8Ebm/+RK4hRxU71hHJ9FlQ0ITQOtxl7oBCBpSAUSIR7jRCs3E848leT7h7Wt4p6mBGB+ IGBhoLQC0UVe4HoJks7pC+3AxoDsZo/weSM26KCPlexbhunnUgk2Q0t19AT6WF72HI/4 UPEqud1kEFjjb+o/Yd69Xhtr9cMg068e98xbgTY0mA6qB/DnF3+BoWRz/Zijgm/TMs+m upauPoFi6dt/BvH8+orUu3amVIzSAIvMOyBhPaUdzJnLB2MPizXvMwfXgwXHBqOt4/cn hSlQ== X-Gm-Message-State: AJIora/w+VZ4Y3rIFtW+GnS4p6T0gd41YxPAZiz9ZOdbsTYOVndfYiVl eZOqJ02hoEvHlxHoKdoENYsjuZnCLiwGEz8VSzTTxTaY4AeKYwv13/1QGYoL7gQcm1VATgMMUno p0hIqKR+TR/HGpCsY96Wq/aVCwgIasjAP8CAah0akeya6Qv/Os9d47csrSpj4 X-Google-Smtp-Source: AGRyM1ufJjVU0KpZWN3bmIPcf1CONbQAzqd5r58znO8T6grArwZAL6QaToVd2vjETSHiTChJmttwQgKRjDFX X-Received: from maskray1.svl.corp.google.com ([2620:15c:2ce:200:2d73:f468:8288:85ec]) (user=maskray job=sendgmr) by 2002:a05:6902:1083:b0:66f:193f:edf with SMTP id v3-20020a056902108300b0066f193f0edfmr1253979ybu.281.1657676114972; Tue, 12 Jul 2022 18:35:14 -0700 (PDT) Date: Tue, 12 Jul 2022 18:35:05 -0700 In-Reply-To: <20220713013508.3428114-1-maskray@google.com> Message-Id: <20220713013508.3428114-2-maskray@google.com> Mime-Version: 1.0 References: <20220713013508.3428114-1-maskray@google.com> To: seabios@seabios.org, Brad Smith Message-ID-Hash: 2G6ZWCUSEIQLEVWZSYVZ6HMUWEV4KWIX X-Message-ID-Hash: 2G6ZWCUSEIQLEVWZSYVZ6HMUWEV4KWIX X-MailFrom: 3UiHOYgcKB-kXLdVcLjRZZRWP.NZXdPLMTZddPLMTZd.ZcR@flex--maskray.bounces.google.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Fangrui Song X-Mailman-Version: 3.3.5rc1 Precedence: list Subject: [SeaBIOS] [PATCH v4 1/4] romlayout.S: Add missing SHF_ALLOC flag to .fixedaddr.\addr List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Fangrui Song via SeaBIOS Reply-To: Fangrui Song Content-Transfer-Encoding: quoted-printable Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-Spamd-Bar: --- X-ZohoMail-DKIM: pass (identity @seabios.org) X-ZM-MESSAGEID: 1657676149318100001 Content-Type: text/plain; charset="utf-8" It does not make sense to reference a SHF_ALLOC section from a non-SHF_ALLOC section via R_386_PC16. Conceptually, even if a non-SHF_ALLOC is loaded as part of the memory image, the distance between it and a SHF_ALLOC section may not be a constant, so the linker cannot reasonably resolve the relocation. GNU ld allows it but lld will warn. Add the SHF_ALLOC flag. Signed-off-by: Fangrui Song --- src/romlayout.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/romlayout.S b/src/romlayout.S index c4a4635..a854783 100644 --- a/src/romlayout.S +++ b/src/romlayout.S @@ -587,7 +587,7 @@ entry_18: =20 // Specify a location in the fixed part of bios area. .macro ORG addr - .section .fixedaddr.\addr + .section .fixedaddr.\addr,"a" .endm =20 ORG 0xe05b --=20 2.37.0.144.g8ac04bfd2-goog _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org