From nobody Fri Apr 19 14:24:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from coreboot.org (coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 1657188404273228.77020577323128; Thu, 7 Jul 2022 03:06:44 -0700 (PDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id 2DD1723404; Thu, 7 Jul 2022 10:06:39 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTP id 374CC23182 for ; Thu, 7 Jul 2022 10:06:24 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-400-L586PYbFOV2ESrFDOq5ybA-1; Thu, 07 Jul 2022 06:06:21 -0400 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6BECD2999B25 for ; Thu, 7 Jul 2022 10:06:21 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 22F99492C3B; Thu, 7 Jul 2022 10:06:21 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) id 1F32A1800094; Thu, 7 Jul 2022 12:06:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657188383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tG/i75HAnPtLcmbbINHDhnp8JI/zgNxRRS7VfbVYoc4=; b=FpFzBbDjEwo+xSYp5p97PuR00LKhNUA50cwO5kMzHCpC1YCBEEPN3CFYFvM/ax20V+FrlE of7fAg5/KEKtFCiigOt51DZ/A/O36DQmcBHPEcNu21pHsm6L9qnhw26cFdLaOk3N+Ldt7U OqOEbFuKpJZkjOmWYecbzDryrNOzCM8= X-MC-Unique: L586PYbFOV2ESrFDOq5ybA-1 From: Gerd Hoffmann To: seabios@seabios.org Date: Thu, 7 Jul 2022 12:06:16 +0200 Message-Id: <20220707100616.1919003-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: WK2VJSMC5CEPDBIHZPXTKCEKX4Z44KZS X-Message-ID-Hash: WK2VJSMC5CEPDBIHZPXTKCEKX4Z44KZS X-MailFrom: kraxel@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Gerd Hoffmann X-Mailman-Version: 3.3.5rc1 Precedence: list Subject: [SeaBIOS] [PATCH] virtio-blk: use larger default request size List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-Spamd-Bar: - X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1657188405972100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Bump default from 8 to 64 blocks. Using 8 by default leads to requests being splitted on qemu, which slows down boot. Some (temporary) debug logging added showed that almost all requests on a standard fedora install are less than 64 blocks, so that should bring us back to 1.15 performance levels. Signed-off-by: Gerd Hoffmann --- src/hw/virtio-blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hw/virtio-blk.c b/src/hw/virtio-blk.c index 929ba8873dc0..9b4a05a4c424 100644 --- a/src/hw/virtio-blk.c +++ b/src/hw/virtio-blk.c @@ -95,7 +95,7 @@ virtio_blk_op(struct disk_op_s *op, int write) blk_num_max =3D (u16)max_io_size / vdrive->drive.blksize; else /* default blk_num_max if hardware doesnot advise a proper value */ - blk_num_max =3D 8; + blk_num_max =3D 64; =20 if (op->count <=3D blk_num_max) { virtio_blk_op_one_segment(vdrive, write, sg); --=20 2.36.1 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org