From nobody Fri Apr 26 16:59:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail(p=none dis=none) header.from=canonical.com ARC-Seal: i=1; a=rsa-sha256; t=1622119265; cv=none; d=zohomail.com; s=zohoarc; b=mu+gze80Cb0XlnkdVClu1IBMQavszW7pt1CArGYzaPxkt17yrFhc6PBBlbriHxqgdMepJP5zXxXVWbPhWTBj7ISfm0FkveMWtFTNSluZX1CF5yCGOi1pglUMGs6ARsFIw+WpUZaWh7UH3eW9cF83MRTOl6iRSMP5QCK4teW6cDE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622119265; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Subject:To; bh=WCIS5O2H52jgrhBnsWL9RGssTdkkQvzr36223HhjRSk=; b=NxxKcwbFaSIOJx3HIKsdU5LtJ3kfr+/ImUJ9O2C5hD1brqFiL+NP9PqLFE583vm387dJK5vBa3NJY+8wRXh26sQ1Gj4/4hONJ+MM8hEitLG6wIuSgSNMXCMFiSu8quvTBXoQcJ8cvXVdhRvArpi+uq0UIeOCsNMjGzXkzqQmRM0= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of seabios.org designates 78.46.105.101 as permitted sender) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from coreboot.org (coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 1622119265204582.3263305429692; Thu, 27 May 2021 05:41:05 -0700 (PDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id 5810F1061A04; Thu, 27 May 2021 12:41:01 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTP id 7FACD10619DA for ; Thu, 27 May 2021 12:40:33 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lmF4U-0007KG-Ti for seabios@seabios.org; Thu, 27 May 2021 12:25:06 +0000 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) for ; Thu, 27 May 2021 05:25:06 -0700 (PDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by smtp.gmail.com with ESMTPSA id s10sm1215932qkj.77.2021.05.27.05.25.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 May 2021 05:25:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KhvOBkPBD7Fc4X1v5jppzxEBWD69kB2ARVa/UGSH2h4=; b=dW/LV+vKitkG10MZt57e23r4YX8C7Hs2gRcOzWRVXFBIZzqAQZfVcOrJAdC6gCG2o8 REJbD5QbKbw2x3dcRdr1zLaggOaYOlUjW+wsV/oWhID1qLXKj1MLSFTNGeteTkwdlJQs qxgKsRS3ne5y4nFh1GI08Y6wYFpNqzztKC6kkhRuM3IVKmwIajXhhKootM5kUt7Opcr0 Rx4ScX+9ZEqWfXegspv6DvRTgFDrNVgjepX7JxeiR5coag9iRAozCn8nKBT6QAfABhKh fm0Bnt0Wsq/aCJNB73+2jvHEPvvvbPFkl9+OgtxBJuvVZYdTzY1wkdjwL2IffmGeQL7y XfFg== X-Gm-Message-State: AOAM532C4nKO434ijju9/DOqOkYTMRY6+DXYRj4L1Y8P7rFJRi7Dbeqv waSvXMBid+I5iU2BIDRe1ROi9G2f7RIs5hV+Xyq5EpK6Y5nI9T5s1+x7djpqgonTUBoAvmVFgjM qnEwGB64BAaPKNnRaG8yTYlEQIndTTw== X-Received: by 2002:a05:622a:164c:: with SMTP id y12mr2804106qtj.318.1622118305714; Thu, 27 May 2021 05:25:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz65rnXL6TU4EW4kMnD/lnENETokHRkT10a41ANpt0ut4Rax9sdyrXTkyJIN2pkjVgR8L2+bA== X-Received: by 2002:a05:622a:164c:: with SMTP id y12mr2804088qtj.318.1622118305478; Thu, 27 May 2021 05:25:05 -0700 (PDT) From: Heitor Alves de Siqueira To: seabios@seabios.org Date: Thu, 27 May 2021 09:25:01 -0300 Message-Id: <20210527122501.70478-2-halves@canonical.com> In-Reply-To: <20210527122501.70478-1-halves@canonical.com> References: <20210527122501.70478-1-halves@canonical.com> MIME-Version: 1.0 X-Spam-Level: **** Message-ID-Hash: FREDWTOVWQMVQ3HC72EB5J3BEJ77EBFM X-Message-ID-Hash: FREDWTOVWQMVQ3HC72EB5J3BEJ77EBFM X-MailFrom: halves@canonical.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.4 Precedence: list Subject: [SeaBIOS] [PATCH 1/1] stacks: fix missing NMI_DISABLE_BIT on call32_post() List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-Spamd-Bar: ----- Content-Type: text/plain; charset="utf-8" We should disable NMIs when accessing CMOS ports during state restore, like it's done during state backup in call32_prep(). Signed-off-by: Heitor Alves de Siqueira --- src/stacks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/stacks.c b/src/stacks.c index 2fe1bfbd64fd..e315066d52e8 100644 --- a/src/stacks.c +++ b/src/stacks.c @@ -107,7 +107,7 @@ call32_post(void) // Restore cmos index register u8 cmosindex =3D GET_LOW(Call16Data.cmosindex); if (!(cmosindex & NMI_DISABLE_BIT)) { - outb(cmosindex, PORT_CMOS_INDEX); + outb(cmosindex | NMI_DISABLE_BIT, PORT_CMOS_INDEX); inb(PORT_CMOS_DATA); } return method; --=20 2.31.1 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org