From nobody Fri Apr 26 12:09:32 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1585903154; cv=none; d=zohomail.com; s=zohoarc; b=YUifUUEuuUPbj24F97C4ijE/nZm1EHeoU8LsTM9LCYuACGpsDC1+4LWjF4yQUAPWjE60amTYDfW3GVnIGiGXCe5KzvvhJwlZE9XGFj/SFuAqbc5oovXx4dGfTtYG/ErxaXDRZy0QrZEgkodxi0A3YyeedRkRZRZaPYZXMJ81mu4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585903154; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Subject:To; bh=DSsbvOboXkgffYb9lpFutWtoXXkDMUIg0p3HpxQX6fQ=; b=Z3jA2fm4D4pMbN0WkMFg+43wr3C5+DtydUYNSaCexEVMYI3Z+wrqLabBjxH6P6YB19n8BvTvSMP5plSJ3nYQUo/n27DHf1rMg5CLd/bFFAcGgeq9xLJtFMHKpzj9EHsJ4bfDbcx47G/M7aQ2lCU6Dmuyob+wlFdtOI6hAz5NDBg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from coreboot.org (coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 1585903154539311.93419778489647; Fri, 3 Apr 2020 01:39:14 -0700 (PDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id 68BBAB01D15; Fri, 3 Apr 2020 08:39:10 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTP id 79675B01A2D for ; Fri, 3 Apr 2020 08:38:05 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-497-0SX56FRjPyevryAc0jedWg-1; Fri, 03 Apr 2020 04:31:39 -0400 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B8E008017F4 for ; Fri, 3 Apr 2020 08:31:38 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by smtp.corp.redhat.com (Postfix) with ESMTP id 35E1E1001B0B; Fri, 3 Apr 2020 08:31:35 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) id 9E16517502; Fri, 3 Apr 2020 10:31:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585903084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HwlXHvJEntUUcd/BKDfa3DW+iOvWi6lUwqDF5wbBYAk=; b=ZKZ9GIidPoFK66mCnHSQ2Ej2uJpQO/EHKWlqkH3mL+JBCOsqmHOkPYu4h0HUUgKCZCdgfT AvljmvrIEclPwvIhicPDAVbR5gnGK/R9I4aimb7IATN3VwOWAy5Tr9u5F/2rAjlbS47LMh 14OpngjTHMvqSPV5stF+8UTCgnlVuzQ= X-MC-Unique: 0SX56FRjPyevryAc0jedWg-1 From: Gerd Hoffmann To: seabios@seabios.org Date: Fri, 3 Apr 2020 10:31:13 +0200 Message-Id: <20200403083121.10766-2-kraxel@redhat.com> In-Reply-To: <20200403083121.10766-1-kraxel@redhat.com> References: <20200403083121.10766-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Level: **** Message-ID-Hash: WHTD62MFOGILTL4ZS6GYTG5HHIDAQW3I X-Message-ID-Hash: WHTD62MFOGILTL4ZS6GYTG5HHIDAQW3I X-MailFrom: kraxel@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Gerd Hoffmann X-Mailman-Version: 3.3.1 Precedence: list Subject: [SeaBIOS] [PATCH 1/9] virtio-mmio: device registry List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-Spamd-Bar: / X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Add a new virtio-mmio.c source file, providing a function to register virtio-mmio devices. Signed-off-by: Gerd Hoffmann --- Makefile | 2 +- src/hw/virtio-mmio.h | 6 ++++++ src/hw/virtio-mmio.c | 30 ++++++++++++++++++++++++++++++ 3 files changed, 37 insertions(+), 1 deletion(-) create mode 100644 src/hw/virtio-mmio.h create mode 100644 src/hw/virtio-mmio.c diff --git a/Makefile b/Makefile index 5f7d5370198a..985ef591a13b 100644 --- a/Makefile +++ b/Makefile @@ -43,7 +43,7 @@ SRC32FLAT=3D$(SRCBOTH) post.c e820map.c malloc.c romfile.= c x86.c optionroms.c \ fw/coreboot.c fw/lzmadecode.c fw/multiboot.c fw/csm.c fw/biostables.c \ fw/paravirt.c fw/shadow.c fw/pciinit.c fw/smm.c fw/smp.c fw/mtrr.c fw/= xen.c \ fw/acpi.c fw/mptable.c fw/pirtable.c fw/smbios.c fw/romfile_loader.c \ - hw/virtio-ring.c hw/virtio-pci.c hw/virtio-blk.c hw/virtio-scsi.c \ + hw/virtio-ring.c hw/virtio-pci.c hw/virtio-mmio.c hw/virtio-blk.c hw/v= irtio-scsi.c \ hw/tpm_drivers.c hw/nvme.c SRC32SEG=3Dstring.c output.c pcibios.c apm.c stacks.c hw/pci.c hw/serialio= .c DIRS=3Dsrc src/hw src/fw vgasrc diff --git a/src/hw/virtio-mmio.h b/src/hw/virtio-mmio.h new file mode 100644 index 000000000000..751984241f49 --- /dev/null +++ b/src/hw/virtio-mmio.h @@ -0,0 +1,6 @@ +#ifndef _VIRTIO_MMIO_H +#define _VIRTIO_MMIO_H + +void virtio_mmio_register(u64 mmio); + +#endif /* _VIRTIO_MMIO_H */ diff --git a/src/hw/virtio-mmio.c b/src/hw/virtio-mmio.c new file mode 100644 index 000000000000..6c969d787ec7 --- /dev/null +++ b/src/hw/virtio-mmio.c @@ -0,0 +1,30 @@ +#include "config.h" // CONFIG_DEBUG_LEVEL +#include "malloc.h" // free +#include "output.h" // dprintf +#include "virtio-pci.h" +#include "virtio-ring.h" + +/* qemu microvm supports 8 virtio-mmio devices */ +static u64 devs[8]; + +void virtio_mmio_register(u64 mmio) +{ + int i; + + for (i =3D 0; i < ARRAY_SIZE(devs); i++) { + if (devs[i] =3D=3D mmio) { + /* + * This can happen in case we have multiple scsi devices + * attached to a single virtio-scsi controller + */ + dprintf(3, "virtio-mmio: duplicate device at 0x%llx, ignoring\= n", mmio); + return; + } + if (devs[i] =3D=3D 0) { + dprintf(3, "virtio-mmio: register device at 0x%llx\n", mmio); + devs[i] =3D mmio; + return; + } + } + dprintf(1, "virtio-mmio: device list full\n"); +} --=20 2.18.2 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org From nobody Fri Apr 26 12:09:32 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1585903218; cv=none; d=zohomail.com; s=zohoarc; b=VGTu/+9pRLwMnSSZrSQsxvpQ8dc5Rz+jeQaOsdUcgIq0jaToYXFK5NYLsUrfJq3TRw5pRzjwBqEY7RNAkxxJxkxXoyFK9szrsw082p9jPfTgsIZVfmpucFCE/k5q6jkWy+aq0jGqonEoKdGdLmpdUypxxSo3luTJCDPFP8GN+gE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585903218; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Subject:To; bh=TbYWvvsHbs2dcEjMuXT6p/Fx9z5m4cp+VPqb2oz/vKU=; b=oJjKongwSdU5OGEqIBtaTcn2phRD8FbN/HQEnwonf8fHYM7PSPcs71reHr/mwohqZHxbVZ+skrcOFjlD8zHn7zFQ5VrJU71DwQCEN8F3x/vvnsBZyYLp3BWquvPS8GQluYEovwjlFT7CX/57Pulc3CLmZc9Y+8RT5arj4ZB5sk0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from coreboot.org (coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 1585903218207189.41242889839828; Fri, 3 Apr 2020 01:40:18 -0700 (PDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id 7BCF4B01D14; Fri, 3 Apr 2020 08:40:13 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTP id 78A0BB01A27 for ; Fri, 3 Apr 2020 08:38:11 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-317-GXf6vxqlO2qEn51d8-YF1g-1; Fri, 03 Apr 2020 04:31:40 -0400 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 231E18017FB for ; Fri, 3 Apr 2020 08:31:39 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by smtp.corp.redhat.com (Postfix) with ESMTP id 690F248; Fri, 3 Apr 2020 08:31:35 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) id A0C4617506; Fri, 3 Apr 2020 10:31:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585903090; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hiBfW3vDePqIMRLeoj1WijG/teqBK+WDHkLsbmqRGzQ=; b=Vv8GCPSiZAmA+ruZTZfq9E74EzK+jgq6l+GUPxa1tneSSVj0p2c6mKd2q07UGN06+tunmc deOtYpUxpolVkxoRGCB4pRmlmBOKtxwNlClu3LyKRBRl5yMWrAKtUnR0lh5PghrgVy02yF /bhoCDDM89HvncXBioS17iEYit6ndjI= X-MC-Unique: GXf6vxqlO2qEn51d8-YF1g-1 From: Gerd Hoffmann To: seabios@seabios.org Date: Fri, 3 Apr 2020 10:31:14 +0200 Message-Id: <20200403083121.10766-3-kraxel@redhat.com> In-Reply-To: <20200403083121.10766-1-kraxel@redhat.com> References: <20200403083121.10766-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam: Yes Message-ID-Hash: TBJGBIOLRJGZZ6NWLY7QPMJ45JO4NWAQ X-Message-ID-Hash: TBJGBIOLRJGZZ6NWLY7QPMJ45JO4NWAQ X-MailFrom: kraxel@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Gerd Hoffmann X-Mailman-Version: 3.3.1 Precedence: list Subject: [SeaBIOS] [PATCH 2/9] virtio-mmio: device probing and initialization. List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: +++++ X-Spam-Level: ***** Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Add virtio_mmio_setup() to probe virtio mmio devices. Add vp_init_mmio() to initialize device struct. Because virtio-pci and virtio-mmio are quite simliar we reuse the infrastructure we already have for virtio-pci and just setup struct vp_cap for virtio-mmio. Signed-off-by: Gerd Hoffmann --- src/hw/virtio-mmio.h | 71 ++++++++++++++++++++++++++++++++++++++++++++ src/hw/virtio-pci.h | 1 + src/block.c | 2 ++ src/hw/virtio-mmio.c | 49 ++++++++++++++++++++++++++++++ 4 files changed, 123 insertions(+) diff --git a/src/hw/virtio-mmio.h b/src/hw/virtio-mmio.h index 751984241f49..5e24f692c1ae 100644 --- a/src/hw/virtio-mmio.h +++ b/src/hw/virtio-mmio.h @@ -1,6 +1,77 @@ #ifndef _VIRTIO_MMIO_H #define _VIRTIO_MMIO_H =20 +struct vp_device; + +typedef struct virtio_mmio_cfg { + u32 magic; + u32 version; + u32 device_id; + u32 vendor_id; + + u32 device_feature; + u32 device_feature_select; + u32 res_18; + u32 res_1c; + + u32 guest_feature; + u32 guest_feature_select; + u32 legacy_guest_page_size; + u32 res_2c; + + u32 queue_select; + u32 queue_num_max; + u32 queue_num; + u32 legacy_queue_align; + + u32 legacy_queue_pfn; + u32 queue_ready; + u32 res_48; + u32 res_4c; + + u32 queue_notify; + u32 res_54; + u32 res_58; + u32 res_5c; + + u32 irq_status; + u32 irq_ack; + u32 res_68; + u32 res_6c; + + u32 device_status; + u32 res_74; + u32 res_78; + u32 res_7c; + + u32 queue_desc_lo; + u32 queue_desc_hi; + u32 res_88; + u32 res_8c; + + u32 queue_driver_lo; + u32 queue_driver_hi; + u32 res_98; + u32 res_9c; + + u32 queue_device_lo; + u32 queue_device_hi; + u32 res_a8; + u32 shm_sel; + + u32 shmem_len_lo; + u32 shmem_len_hi; + u32 shmem_base_lo; + u32 shmem_base_hi; + + u32 res_c0_f7[14]; + + u32 res_f8; + u32 config_generation; +} virtio_mmio_cfg; + void virtio_mmio_register(u64 mmio); +void virtio_mmio_setup(void); +void vp_init_mmio(struct vp_device *vp, void *mmio); =20 #endif /* _VIRTIO_MMIO_H */ diff --git a/src/hw/virtio-pci.h b/src/hw/virtio-pci.h index 492e5c7c9166..269626448558 100644 --- a/src/hw/virtio-pci.h +++ b/src/hw/virtio-pci.h @@ -111,6 +111,7 @@ struct vp_device { struct vp_cap common, notify, isr, device, legacy; u32 notify_off_multiplier; u8 use_modern; + u8 use_mmio; }; =20 u64 _vp_read(struct vp_cap *cap, u32 offset, u8 size); diff --git a/src/block.c b/src/block.c index 1f600b85391b..9ef607610c40 100644 --- a/src/block.c +++ b/src/block.c @@ -20,6 +20,7 @@ #include "hw/usb-uas.h" // uas_process_op #include "hw/virtio-blk.h" // process_virtio_blk_op #include "hw/virtio-scsi.h" // virtio_scsi_process_op +#include "hw/virtio-mmio.h" // virtio_mmio_setup #include "hw/nvme.h" // nvme_process_op #include "malloc.h" // malloc_low #include "output.h" // dprintf @@ -514,6 +515,7 @@ block_setup(void) ramdisk_setup(); virtio_blk_setup(); virtio_scsi_setup(); + virtio_mmio_setup(); lsi_scsi_setup(); esp_scsi_setup(); megasas_setup(); diff --git a/src/hw/virtio-mmio.c b/src/hw/virtio-mmio.c index 6c969d787ec7..9f4f5b780f59 100644 --- a/src/hw/virtio-mmio.c +++ b/src/hw/virtio-mmio.c @@ -1,8 +1,11 @@ #include "config.h" // CONFIG_DEBUG_LEVEL #include "malloc.h" // free #include "output.h" // dprintf +#include "stacks.h" // run_thread +#include "string.h" // memset #include "virtio-pci.h" #include "virtio-ring.h" +#include "virtio-mmio.h" =20 /* qemu microvm supports 8 virtio-mmio devices */ static u64 devs[8]; @@ -28,3 +31,49 @@ void virtio_mmio_register(u64 mmio) } dprintf(1, "virtio-mmio: device list full\n"); } + +void virtio_mmio_setup(void) +{ + u32 magic, version, devid; + void *mmio; + int i; + + for (i =3D 0; i < ARRAY_SIZE(devs); i++) { + if (devs[i] =3D=3D 0) + return; + mmio =3D (void*)(u32)(devs[i]); + magic =3D readl(mmio); + if (magic !=3D 0x74726976) + continue; + version =3D readl(mmio+4); + if (version !=3D 1 /* legacy */ && + version !=3D 2 /* 1.0 */) + continue; + devid =3D readl(mmio+8); + dprintf(1, "virtio-mmio: %llx: device id %x%s\n", + devs[i], devid, version =3D=3D 1 ? " (legacy)" : ""); + switch (devid) { + case 2: /* blk */ + /* TODO */ + break; + case 8: /* scsi */ + /* TODO */ + break; + default: + break; + } + } +} + +void vp_init_mmio(struct vp_device *vp, void *mmio) +{ + memset(vp, 0, sizeof(*vp)); + vp->use_mmio =3D 1; + vp->common.mode =3D VP_ACCESS_MMIO; + vp->common.memaddr =3D mmio; + vp->device.mode =3D VP_ACCESS_MMIO; + vp->device.memaddr =3D mmio + 0x100; + vp_reset(vp); + vp_set_status(vp, VIRTIO_CONFIG_S_ACKNOWLEDGE | + VIRTIO_CONFIG_S_DRIVER); +} --=20 2.18.2 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org From nobody Fri Apr 26 12:09:32 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1585903186; cv=none; d=zohomail.com; s=zohoarc; b=Bin54mUhDXniF+UXCPZ1zcgj/mSdTZXlTt008hLted/0Q+P1p4NODEmLh25s5E6pqh+Sk+ejfUpk5AqztLc2uMf1Rh8J7q/8983aE+GPx1YV0RwJoir/kJsOnyMEc07CilyJAgi+pBmzBz/HL88jkkuLNZa/bgHuSeOMWCAoTOU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585903186; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Subject:To; bh=MwloAa4u7F70S2fySVnpIK0AFwQM2MUj7p3G5hbkr1w=; b=QbR83kVvh2f0vh6nel4c9as8B8cpYk28iJDbwj4nlYe5goUlcne+8fL9+t8JAQyLWLEeABnDRGci5rc/mCh9k90BbSPulY3/rYYxQ1QIdc9Seqsot11qRIASo5Fe2XTNJbz0A6onYDLBXJNMuxQAXHkY09rRXf8uitrIK3QvtCc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from coreboot.org (coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 1585903186922263.6486785533914; Fri, 3 Apr 2020 01:39:46 -0700 (PDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id 89C40B01A34; Fri, 3 Apr 2020 08:39:42 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTP id 7C15DB01A32 for ; Fri, 3 Apr 2020 08:38:05 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-92-sXkz-fySMn2O15Yv_Jt1eA-1; Fri, 03 Apr 2020 04:31:39 -0400 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 126638017F6 for ; Fri, 3 Apr 2020 08:31:39 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by smtp.corp.redhat.com (Postfix) with ESMTP id 35276196AE; Fri, 3 Apr 2020 08:31:35 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) id A2F9E1750A; Fri, 3 Apr 2020 10:31:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585903084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MOkgIlEw0GKmYZABAz6WoX9ib6y5sw03PWFACNKSNWs=; b=YXemWnLbLIfnwIpxGWXLZHpbIrkjfHejBFS+l/TNaLXInpl88NxkR9nqI0wWhVhCLnAuO3 Ui8NLrGc8HEGXHCangJGo16ahrc6TOxO7V8/PucPcnsuSCwaw67rbRZH1a6OFYule4BnEy 7CRYxpS1+aCuCWMaT43Th3C2syifb6M= X-MC-Unique: sXkz-fySMn2O15Yv_Jt1eA-1 From: Gerd Hoffmann To: seabios@seabios.org Date: Fri, 3 Apr 2020 10:31:15 +0200 Message-Id: <20200403083121.10766-4-kraxel@redhat.com> In-Reply-To: <20200403083121.10766-1-kraxel@redhat.com> References: <20200403083121.10766-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Level: **** Message-ID-Hash: 5Z3I5246DT5GA2LOFTKPWIZL7MOFUKMN X-Message-ID-Hash: 5Z3I5246DT5GA2LOFTKPWIZL7MOFUKMN X-MailFrom: kraxel@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Gerd Hoffmann X-Mailman-Version: 3.3.1 Precedence: list Subject: [SeaBIOS] [PATCH 3/9] virtio-mmio: add support to vp_*() functions List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-Spamd-Bar: / X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Add support for virtio-mmio to the vp_*() helper functions. Both legacy and 1.0 virto-mmio versions are supported. They are very simliar anyway, only the virtqueue initialization is slightly different. Signed-off-by: Gerd Hoffmann --- src/hw/virtio-pci.c | 68 +++++++++++++++++++++++++++++++++++++-------- 1 file changed, 57 insertions(+), 11 deletions(-) diff --git a/src/hw/virtio-pci.c b/src/hw/virtio-pci.c index d5435218fb0a..213c49777c40 100644 --- a/src/hw/virtio-pci.c +++ b/src/hw/virtio-pci.c @@ -23,6 +23,7 @@ #include "pci_regs.h" // PCI_BASE_ADDRESS_0 #include "string.h" // memset #include "virtio-pci.h" +#include "virtio-mmio.h" #include "virtio-ring.h" =20 u64 _vp_read(struct vp_cap *cap, u32 offset, u8 size) @@ -189,7 +190,11 @@ u64 vp_get_features(struct vp_device *vp) { u32 f0, f1; =20 - if (vp->use_modern) { + if (vp->use_mmio) { + vp_write(&vp->common, virtio_mmio_cfg, device_feature_select, 0); + f0 =3D vp_read(&vp->common, virtio_mmio_cfg, device_feature); + f1 =3D 0; + } else if (vp->use_modern) { vp_write(&vp->common, virtio_pci_common_cfg, device_feature_select= , 0); f0 =3D vp_read(&vp->common, virtio_pci_common_cfg, device_feature); vp_write(&vp->common, virtio_pci_common_cfg, device_feature_select= , 1); @@ -208,7 +213,10 @@ void vp_set_features(struct vp_device *vp, u64 feature= s) f0 =3D features; f1 =3D features >> 32; =20 - if (vp->use_modern) { + if (vp->use_mmio) { + vp_write(&vp->common, virtio_mmio_cfg, guest_feature_select, f0); + vp_write(&vp->common, virtio_mmio_cfg, guest_feature, f0); + } else if (vp->use_modern) { vp_write(&vp->common, virtio_pci_common_cfg, guest_feature_select,= 0); vp_write(&vp->common, virtio_pci_common_cfg, guest_feature, f0); vp_write(&vp->common, virtio_pci_common_cfg, guest_feature_select,= 1); @@ -220,7 +228,9 @@ void vp_set_features(struct vp_device *vp, u64 features) =20 u8 vp_get_status(struct vp_device *vp) { - if (vp->use_modern) { + if (vp->use_mmio) { + return vp_read(&vp->common, virtio_mmio_cfg, device_status); + } else if (vp->use_modern) { return vp_read(&vp->common, virtio_pci_common_cfg, device_status); } else { return vp_read(&vp->legacy, virtio_pci_legacy, status); @@ -231,7 +241,9 @@ void vp_set_status(struct vp_device *vp, u8 status) { if (status =3D=3D 0) /* reset */ return; - if (vp->use_modern) { + if (vp->use_mmio) { + vp_write(&vp->common, virtio_mmio_cfg, device_status, status); + } else if (vp->use_modern) { vp_write(&vp->common, virtio_pci_common_cfg, device_status, status= ); } else { vp_write(&vp->legacy, virtio_pci_legacy, status, status); @@ -240,7 +252,9 @@ void vp_set_status(struct vp_device *vp, u8 status) =20 u8 vp_get_isr(struct vp_device *vp) { - if (vp->use_modern) { + if (vp->use_mmio) { + return vp_read(&vp->common, virtio_mmio_cfg, irq_status); + } else if (vp->use_modern) { return vp_read(&vp->isr, virtio_pci_isr, isr); } else { return vp_read(&vp->legacy, virtio_pci_legacy, isr); @@ -249,7 +263,10 @@ u8 vp_get_isr(struct vp_device *vp) =20 void vp_reset(struct vp_device *vp) { - if (vp->use_modern) { + if (vp->use_mmio) { + vp_write(&vp->common, virtio_mmio_cfg, device_status, 0); + vp_read(&vp->common, virtio_mmio_cfg, irq_status); + } else if (vp->use_modern) { vp_write(&vp->common, virtio_pci_common_cfg, device_status, 0); vp_read(&vp->isr, virtio_pci_isr, isr); } else { @@ -260,7 +277,9 @@ void vp_reset(struct vp_device *vp) =20 void vp_notify(struct vp_device *vp, struct vring_virtqueue *vq) { - if (vp->use_modern) { + if (vp->use_mmio) { + vp_write(&vp->common, virtio_mmio_cfg, queue_notify, vq->queue_ind= ex); + } else if (vp->use_modern) { u32 offset =3D vq->queue_notify_off * vp->notify_off_multiplier; switch (vp->notify.mode) { case VP_ACCESS_IO: @@ -305,14 +324,21 @@ int vp_find_vq(struct vp_device *vp, int queue_index, =20 =20 /* select the queue */ - if (vp->use_modern) { + if (vp->use_mmio) { + vp_write(&vp->common, virtio_mmio_cfg, queue_select, queue_index); + } else if (vp->use_modern) { vp_write(&vp->common, virtio_pci_common_cfg, queue_select, queue_in= dex); } else { vp_write(&vp->legacy, virtio_pci_legacy, queue_sel, queue_index); } =20 /* check if the queue is available */ - if (vp->use_modern) { + if (vp->use_mmio) { + num =3D vp_read(&vp->common, virtio_mmio_cfg, queue_num_max); + if (num > MAX_QUEUE_NUM) + num =3D MAX_QUEUE_NUM; + vp_write(&vp->common, virtio_mmio_cfg, queue_num, num); + } else if (vp->use_modern) { num =3D vp_read(&vp->common, virtio_pci_common_cfg, queue_size); if (num > MAX_QUEUE_NUM) { vp_write(&vp->common, virtio_pci_common_cfg, queue_size, @@ -332,7 +358,9 @@ int vp_find_vq(struct vp_device *vp, int queue_index, } =20 /* check if the queue is already active */ - if (vp->use_modern) { + if (vp->use_mmio) { + /* TODO */; + } else if (vp->use_modern) { if (vp_read(&vp->common, virtio_pci_common_cfg, queue_enable)) { dprintf(1, "ERROR: queue already active\n"); goto fail; @@ -354,7 +382,25 @@ int vp_find_vq(struct vp_device *vp, int queue_index, * NOTE: vr->desc is initialized by vring_init() */ =20 - if (vp->use_modern) { + if (vp->use_mmio) { + if (vp_read(&vp->common, virtio_mmio_cfg, version) =3D=3D 2) { + vp_write(&vp->common, virtio_mmio_cfg, queue_desc_lo, + (unsigned long)virt_to_phys(vr->desc)); + vp_write(&vp->common, virtio_mmio_cfg, queue_desc_hi, 0); + vp_write(&vp->common, virtio_mmio_cfg, queue_driver_lo, + (unsigned long)virt_to_phys(vr->avail)); + vp_write(&vp->common, virtio_mmio_cfg, queue_driver_hi, 0); + vp_write(&vp->common, virtio_mmio_cfg, queue_device_lo, + (unsigned long)virt_to_phys(vr->used)); + vp_write(&vp->common, virtio_mmio_cfg, queue_device_hi, 0); + vp_write(&vp->common, virtio_mmio_cfg, queue_ready, 1); + } else { + vp_write(&vp->common, virtio_mmio_cfg, legacy_guest_page_size, + (unsigned long)1 << PAGE_SHIFT); + vp_write(&vp->common, virtio_mmio_cfg, legacy_queue_pfn, + (unsigned long)virt_to_phys(vr->desc) >> PAGE_SHIFT); + } + } else if (vp->use_modern) { vp_write(&vp->common, virtio_pci_common_cfg, queue_desc_lo, (unsigned long)virt_to_phys(vr->desc)); vp_write(&vp->common, virtio_pci_common_cfg, queue_desc_hi, 0); --=20 2.18.2 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org From nobody Fri Apr 26 12:09:32 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1585903202; cv=none; d=zohomail.com; s=zohoarc; b=VdiB2KqeXKUdsAXMGfWkw249dQbLcagkE3bsjkqxdlBdLkxdYkwsHDeaajd7txORI7pWfGR9GAT3aiPHN3IxZYb/wSiIaaRj9TxBho8c+D8HsW9a7c5+aRRkoeaEBoWTcYolHg/7CpU3jv2W4YeYfRXUw/3D/fwF5SdqsG9SWzk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585903202; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Subject:To; bh=i8rjTLFWvm+1+BZPTuf68vA1Sop/BxzVQkrM/SKzK4w=; b=BuTmXppoZwLN423WQnKTlAcmgedHkuhPNN2CPpcYy0yTURFAWS2FJlqeE2eY/UHBCBmRkdLKLGuRKJewSXfCz35bg5PbceXKRD3Z5r1Gu/x47RnpVhW/z4rtXOrqdHxx2uRRCVDvF3x3B2y8F2NMd++osbxrc2rbnJndSbPXe+E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from coreboot.org (coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 158590320207949.20466135278912; Fri, 3 Apr 2020 01:40:02 -0700 (PDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id 72F96B01A32; Fri, 3 Apr 2020 08:39:57 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTP id 4B0F6B01A27 for ; Fri, 3 Apr 2020 08:38:08 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-305-jFAb2EBUPdiVqpqZ7ZW0IQ-1; Fri, 03 Apr 2020 04:31:39 -0400 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 015301005509 for ; Fri, 3 Apr 2020 08:31:39 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by smtp.corp.redhat.com (Postfix) with ESMTP id 328AE60BF3; Fri, 3 Apr 2020 08:31:35 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) id A536B1750C; Fri, 3 Apr 2020 10:31:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585903087; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pUeL2jZpr0sLVqcBPmVqj5IVjzng26xzfJ110EdiBlM=; b=ONlKxOaLcOrBoIqF0qa8x5LQxeWBFhALF81uXlV0JCxBxgJbGiqWzt2eXXIRW7y2ELzC8+ X8b3skGH1tHiRo8BhYTnyBzdF+waMktKKHv89p2O7OHZ0PAbS5wi8Tw8WeD2xC/IdK74LV qcnXiCVO73JVreaPjHTi650/ZEZQGag= X-MC-Unique: jFAb2EBUPdiVqpqZ7ZW0IQ-1 From: Gerd Hoffmann To: seabios@seabios.org Date: Fri, 3 Apr 2020 10:31:16 +0200 Message-Id: <20200403083121.10766-5-kraxel@redhat.com> In-Reply-To: <20200403083121.10766-1-kraxel@redhat.com> References: <20200403083121.10766-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Level: **** Message-ID-Hash: 3HGEUD73SKSRBKABEQ2CAWHXLA7NK3UD X-Message-ID-Hash: 3HGEUD73SKSRBKABEQ2CAWHXLA7NK3UD X-MailFrom: kraxel@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Gerd Hoffmann X-Mailman-Version: 3.3.1 Precedence: list Subject: [SeaBIOS] [PATCH 4/9] virtio-mmio: add support for scsi devices. List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-Spamd-Bar: / X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Add new fields to struct virtio_lun_s for mmio support, add mmio parameter to virtio_scsi_init_lun(), so both pci and mmio devices can be handled. Add and use bootprio_find_scsi_mmio_device() to figure boot priority of devices connected to a virtio-mmio scsi controller. Finally add init_virtio_scsi_mmio() to initialize one virtio-mmio scsi controller. Signed-off-by: Gerd Hoffmann --- src/hw/virtio-scsi.h | 1 + src/util.h | 1 + src/boot.c | 10 ++++++ src/hw/virtio-mmio.c | 3 +- src/hw/virtio-scsi.c | 73 +++++++++++++++++++++++++++++++++++++------- 5 files changed, 76 insertions(+), 12 deletions(-) diff --git a/src/hw/virtio-scsi.h b/src/hw/virtio-scsi.h index 7532cc98e56e..8f01de4cba99 100644 --- a/src/hw/virtio-scsi.h +++ b/src/hw/virtio-scsi.h @@ -43,5 +43,6 @@ struct virtio_scsi_resp_cmd { struct disk_op_s; int virtio_scsi_process_op(struct disk_op_s *op); void virtio_scsi_setup(void); +void init_virtio_scsi_mmio(void *data); =20 #endif /* _VIRTIO_SCSI_H */ diff --git a/src/util.h b/src/util.h index 94592a2d2e8d..1c82e09ed87b 100644 --- a/src/util.h +++ b/src/util.h @@ -31,6 +31,7 @@ u8 is_bootprio_strict(void); struct pci_device; int bootprio_find_pci_device(struct pci_device *pci); int bootprio_find_scsi_device(struct pci_device *pci, int target, int lun); +int bootprio_find_scsi_mmio_device(void *mmio, int target, int lun); int bootprio_find_ata_device(struct pci_device *pci, int chanid, int slave= ); int bootprio_find_fdc_device(struct pci_device *pci, int port, int fdid); int bootprio_find_pci_rom(struct pci_device *pci, int instance); diff --git a/src/boot.c b/src/boot.c index 4f12988f687c..f2f084bea843 100644 --- a/src/boot.c +++ b/src/boot.c @@ -328,6 +328,16 @@ int bootprio_find_scsi_device(struct pci_device *pci, = int target, int lun) return find_prio(desc); } =20 +int bootprio_find_scsi_mmio_device(void *mmio, int target, int lun) +{ + if (!CONFIG_BOOTORDER) + return -1; + char desc[256]; + snprintf(desc, sizeof(desc), "/virtio-mmio@%016x/*@0/*@%x,%x", + (u32)mmio, target, lun); + return find_prio(desc); +} + int bootprio_find_ata_device(struct pci_device *pci, int chanid, int slave) { if (CONFIG_CSM) diff --git a/src/hw/virtio-mmio.c b/src/hw/virtio-mmio.c index 9f4f5b780f59..a72f5fc5e6a1 100644 --- a/src/hw/virtio-mmio.c +++ b/src/hw/virtio-mmio.c @@ -4,6 +4,7 @@ #include "stacks.h" // run_thread #include "string.h" // memset #include "virtio-pci.h" +#include "virtio-scsi.h" #include "virtio-ring.h" #include "virtio-mmio.h" =20 @@ -57,7 +58,7 @@ void virtio_mmio_setup(void) /* TODO */ break; case 8: /* scsi */ - /* TODO */ + run_thread(init_virtio_scsi_mmio, mmio); break; default: break; diff --git a/src/hw/virtio-scsi.c b/src/hw/virtio-scsi.c index a5332848b8c8..59f1c654d76b 100644 --- a/src/hw/virtio-scsi.c +++ b/src/hw/virtio-scsi.c @@ -22,10 +22,13 @@ #include "virtio-pci.h" #include "virtio-ring.h" #include "virtio-scsi.h" +#include "virtio-mmio.h" =20 struct virtio_lun_s { struct drive_s drive; struct pci_device *pci; + void *mmio; + char name[16]; struct vring_virtqueue *vq; struct vp_device *vp; u16 target; @@ -94,7 +97,8 @@ virtio_scsi_process_op(struct disk_op_s *op) } =20 static void -virtio_scsi_init_lun(struct virtio_lun_s *vlun, struct pci_device *pci, +virtio_scsi_init_lun(struct virtio_lun_s *vlun, + struct pci_device *pci, void *mmio, struct vp_device *vp, struct vring_virtqueue *vq, u16 target, u16 lun) { @@ -102,10 +106,15 @@ virtio_scsi_init_lun(struct virtio_lun_s *vlun, struc= t pci_device *pci, vlun->drive.type =3D DTYPE_VIRTIO_SCSI; vlun->drive.cntl_id =3D pci->bdf; vlun->pci =3D pci; + vlun->mmio =3D mmio; vlun->vp =3D vp; vlun->vq =3D vq; vlun->target =3D target; vlun->lun =3D lun; + if (vlun->pci) + snprintf(vlun->name, sizeof(vlun->name), "pci:%pP", vlun->pci); + if (vlun->mmio) + snprintf(vlun->name, sizeof(vlun->name), "mmio:%08x", (u32)vlun->m= mio); } =20 static int @@ -114,12 +123,17 @@ virtio_scsi_add_lun(u32 lun, struct drive_s *tmpl_drv) u8 skip_nonbootable =3D is_bootprio_strict(); struct virtio_lun_s *tmpl_vlun =3D container_of(tmpl_drv, struct virtio_lun_s, drive); - int prio =3D bootprio_find_scsi_device(tmpl_vlun->pci, tmpl_vlun->targ= et, tmpl_vlun->lun); + int prio =3D -1; + + if (tmpl_vlun->pci) + prio =3D bootprio_find_scsi_device(tmpl_vlun->pci, tmpl_vlun->targ= et, tmpl_vlun->lun); + if (tmpl_vlun->mmio) + prio =3D bootprio_find_scsi_mmio_device(tmpl_vlun->mmio, tmpl_vlun= ->target, tmpl_vlun->lun); =20 if (skip_nonbootable && prio < 0) { - dprintf(1, "skipping init of a non-bootable virtio-scsi dev at %pP= ," + dprintf(1, "skipping init of a non-bootable virtio-scsi dev at %s," " target %d, lun %d\n", - tmpl_vlun->pci, tmpl_vlun->target, tmpl_vlun->lun); + tmpl_vlun->name, tmpl_vlun->target, tmpl_vlun->lun); return -1; } =20 @@ -128,11 +142,12 @@ virtio_scsi_add_lun(u32 lun, struct drive_s *tmpl_drv) warn_noalloc(); return -1; } - virtio_scsi_init_lun(vlun, tmpl_vlun->pci, tmpl_vlun->vp, tmpl_vlun->v= q, - tmpl_vlun->target, lun); + virtio_scsi_init_lun(vlun, tmpl_vlun->pci, tmpl_vlun->mmio,tmpl_vlun->= vp, + tmpl_vlun->vq, tmpl_vlun->target, lun); =20 - boot_lchs_find_scsi_device(vlun->pci, vlun->target, vlun->lun, - &(vlun->drive.lchs)); + if (vlun->pci) + boot_lchs_find_scsi_device(vlun->pci, vlun->target, vlun->lun, + &(vlun->drive.lchs)); int ret =3D scsi_drive_setup(&vlun->drive, "virtio-scsi", prio); if (ret) goto fail; @@ -144,13 +159,13 @@ fail: } =20 static int -virtio_scsi_scan_target(struct pci_device *pci, struct vp_device *vp, +virtio_scsi_scan_target(struct pci_device *pci, void *mmio, struct vp_devi= ce *vp, struct vring_virtqueue *vq, u16 target) { =20 struct virtio_lun_s vlun0; =20 - virtio_scsi_init_lun(&vlun0, pci, vp, vq, target, 0); + virtio_scsi_init_lun(&vlun0, pci, mmio, vp, vq, target, 0); =20 int ret =3D scsi_rep_luns_scan(&vlun0.drive, virtio_scsi_add_lun); return ret < 0 ? 0 : ret; @@ -198,7 +213,43 @@ init_virtio_scsi(void *data) =20 int i, tot; for (tot =3D 0, i =3D 0; i < 256; i++) - tot +=3D virtio_scsi_scan_target(pci, vp, vq, i); + tot +=3D virtio_scsi_scan_target(pci, NULL, vp, vq, i); + + if (!tot) + goto fail; + + return; + +fail: + vp_reset(vp); + free(vp); + free(vq); +} + +void +init_virtio_scsi_mmio(void *mmio) +{ + dprintf(1, "found virtio-scsi-mmio at %p\n", mmio); + struct vring_virtqueue *vq =3D NULL; + struct vp_device *vp =3D malloc_high(sizeof(*vp)); + if (!vp) { + warn_noalloc(); + return; + } + vp_init_mmio(vp, mmio); + u8 status =3D VIRTIO_CONFIG_S_ACKNOWLEDGE | VIRTIO_CONFIG_S_DRIVER; + + if (vp_find_vq(vp, 2, &vq) < 0 ) { + dprintf(1, "fail to find vq for virtio-scsi-mmio %p\n", mmio); + goto fail; + } + + status |=3D VIRTIO_CONFIG_S_DRIVER_OK; + vp_set_status(vp, status); + + int i, tot; + for (tot =3D 0, i =3D 0; i < 256; i++) + tot +=3D virtio_scsi_scan_target(NULL, mmio, vp, vq, i); =20 if (!tot) goto fail; --=20 2.18.2 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org From nobody Fri Apr 26 12:09:32 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1585903109; cv=none; d=zohomail.com; s=zohoarc; b=YvFrvUkwk/rgXdrIf1tR0B8/Cc/x+Zx714niVepv4ZoEt2i1I4eXv4oSaahrvxQxBB7q7LofIM5pP/lwiJlsl16f0QPwtJNHqHpN0I4LgZhjwlsodrqUI3hRQEnDhnxmq6zsYF2QqfkZFyXnh/kfojIegRHQwk/UPXXpVPHCFFE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585903109; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Subject:To; bh=+q5/Ow1itog6aNsWo2NWJfV2xm6xN+FRkK7gbYulq/c=; b=gAaYjwAk2Lpt4Cvqi4jt6aiK+xgIKoyMHecxMLlMwzprsk1uk+rmgQnAxBfNbagQa7r3ig1BhFfxtUvM85c4HVDlC3w89C8exTbJ88sJlJvuWX5h46JLIfy5Ln978LMCCIsCY/uXIO3T8t7GfSln9CUX/zGJSySx0DEJl/1BbeI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from coreboot.org (coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 1585903109284919.1912317179332; Fri, 3 Apr 2020 01:38:29 -0700 (PDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id DF3F8B01A28; Fri, 3 Apr 2020 08:38:23 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTP id 225C8B00165 for ; Fri, 3 Apr 2020 08:38:05 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-423-DwZ6Aq_zO3qomh5Tst1rQA-1; Fri, 03 Apr 2020 04:31:41 -0400 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 81E01190B2A0 for ; Fri, 3 Apr 2020 08:31:40 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by smtp.corp.redhat.com (Postfix) with ESMTP id D9B8148; Fri, 3 Apr 2020 08:31:39 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) id A7AEC17510; Fri, 3 Apr 2020 10:31:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585903084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=niMlZGKCZrqy/ckwYcwdJJAAVEYHZcLbyD1MGrKqORY=; b=HwbengRKDw26LfBUoDSBhYUH2+biqNcXQTbaBJbYdTw9YWjbFHwtZzCnoh3lULu1IRtUx/ NSBlSjMJSP1kGopE0+7XCvhOIuCJJalQA8LiX6c8NCu5d9tycjo93gjvNsOAXhg+K2nNmO Ft2Ex2vLBkum3mUHrTVE1YB6igrxsIA= X-MC-Unique: DwZ6Aq_zO3qomh5Tst1rQA-1 From: Gerd Hoffmann To: seabios@seabios.org Date: Fri, 3 Apr 2020 10:31:17 +0200 Message-Id: <20200403083121.10766-6-kraxel@redhat.com> In-Reply-To: <20200403083121.10766-1-kraxel@redhat.com> References: <20200403083121.10766-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: NTCQVOBJIM7ON42ZVYRXOGCRIZC52EJJ X-Message-ID-Hash: NTCQVOBJIM7ON42ZVYRXOGCRIZC52EJJ X-MailFrom: kraxel@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Gerd Hoffmann X-Mailman-Version: 3.3.1 Precedence: list Subject: [SeaBIOS] [PATCH 5/9] virtio-mmio: add support for block devices. List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ++++ X-Spam-Level: **** Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Add and use bootprio_find_mmio_device() to figure the boot priority of virtio-mmio block devices. Add init_virtio_blk_mmio to initialize one virtio-mmio block device. Signed-off-by: Gerd Hoffmann --- src/hw/virtio-blk.h | 1 + src/util.h | 1 + src/boot.c | 9 ++++++ src/hw/virtio-blk.c | 71 ++++++++++++++++++++++++++++++++++++++++++++ src/hw/virtio-mmio.c | 3 +- 5 files changed, 84 insertions(+), 1 deletion(-) diff --git a/src/hw/virtio-blk.h b/src/hw/virtio-blk.h index 157bed62744a..d20461a2a3b2 100644 --- a/src/hw/virtio-blk.h +++ b/src/hw/virtio-blk.h @@ -39,5 +39,6 @@ struct virtio_blk_outhdr { struct disk_op_s; int virtio_blk_process_op(struct disk_op_s *op); void virtio_blk_setup(void); +void init_virtio_blk_mmio(void *mmio); =20 #endif /* _VIRTIO_BLK_H */ diff --git a/src/util.h b/src/util.h index 1c82e09ed87b..4f27fc307439 100644 --- a/src/util.h +++ b/src/util.h @@ -30,6 +30,7 @@ void bcv_prepboot(void); u8 is_bootprio_strict(void); struct pci_device; int bootprio_find_pci_device(struct pci_device *pci); +int bootprio_find_mmio_device(void *mmio); int bootprio_find_scsi_device(struct pci_device *pci, int target, int lun); int bootprio_find_scsi_mmio_device(void *mmio, int target, int lun); int bootprio_find_ata_device(struct pci_device *pci, int chanid, int slave= ); diff --git a/src/boot.c b/src/boot.c index f2f084bea843..cc87b1d98476 100644 --- a/src/boot.c +++ b/src/boot.c @@ -316,6 +316,15 @@ int bootprio_find_pci_device(struct pci_device *pci) return find_prio(desc); } =20 +int bootprio_find_mmio_device(void *mmio) +{ + if (!CONFIG_BOOTORDER) + return -1; + char desc[256]; + snprintf(desc, sizeof(desc), "/virtio-mmio@%016x/*", (u32)mmio); + return find_prio(desc); +} + int bootprio_find_scsi_device(struct pci_device *pci, int target, int lun) { if (!CONFIG_BOOTORDER) diff --git a/src/hw/virtio-blk.c b/src/hw/virtio-blk.c index a5e28fc858b1..3b198965c8ba 100644 --- a/src/hw/virtio-blk.c +++ b/src/hw/virtio-blk.c @@ -20,6 +20,7 @@ #include "string.h" // memset #include "util.h" // usleep, bootprio_find_pci_device, is_bootprio_strict #include "virtio-pci.h" +#include "virtio-mmio.h" #include "virtio-ring.h" #include "virtio-blk.h" =20 @@ -193,6 +194,76 @@ fail: free(vdrive); } =20 +void +init_virtio_blk_mmio(void *mmio) +{ + u8 status =3D VIRTIO_CONFIG_S_ACKNOWLEDGE | VIRTIO_CONFIG_S_DRIVER; + dprintf(1, "found virtio-blk-mmio at %p\n", mmio); + struct virtiodrive_s *vdrive =3D malloc_low(sizeof(*vdrive)); + if (!vdrive) { + warn_noalloc(); + return; + } + memset(vdrive, 0, sizeof(*vdrive)); + vdrive->drive.type =3D DTYPE_VIRTIO_BLK; + vdrive->drive.cntl_id =3D (u32)mmio; + + vp_init_mmio(&vdrive->vp, mmio); + if (vp_find_vq(&vdrive->vp, 0, &vdrive->vq) < 0 ) { + dprintf(1, "fail to find vq for virtio-blk-mmio %p\n", mmio); + goto fail; + } + + struct vp_device *vp =3D &vdrive->vp; + u64 features =3D vp_get_features(vp); + u64 version1 =3D 1ull << VIRTIO_F_VERSION_1; + u64 blk_size =3D 1ull << VIRTIO_BLK_F_BLK_SIZE; + + features =3D features & (version1 | blk_size); + vp_set_features(vp, features); + status |=3D VIRTIO_CONFIG_S_FEATURES_OK; + vp_set_status(vp, status); + if (!(vp_get_status(vp) & VIRTIO_CONFIG_S_FEATURES_OK)) { + dprintf(1, "device didn't accept features: %p\n", mmio); + goto fail; + } + + vdrive->drive.sectors =3D + vp_read(&vp->device, struct virtio_blk_config, capacity); + if (features & blk_size) { + vdrive->drive.blksize =3D + vp_read(&vp->device, struct virtio_blk_config, blk_size); + } else { + vdrive->drive.blksize =3D DISK_SECTOR_SIZE; + } + if (vdrive->drive.blksize !=3D DISK_SECTOR_SIZE) { + dprintf(1, "virtio-blk-mmio %p block size %d is unsupported\n", + mmio, vdrive->drive.blksize); + goto fail; + } + dprintf(1, "virtio-blk-mmio %p blksize=3D%d sectors=3D%u\n", + mmio, vdrive->drive.blksize, (u32)vdrive->drive.sectors); + + vdrive->drive.pchs.cylinder =3D + vp_read(&vp->device, struct virtio_blk_config, cylinders); + vdrive->drive.pchs.head =3D + vp_read(&vp->device, struct virtio_blk_config, heads); + vdrive->drive.pchs.sector =3D + vp_read(&vp->device, struct virtio_blk_config, sectors); + + char *desc =3D znprintf(MAXDESCSIZE, "Virtio disk mmio:%p", mmio); + boot_add_hd(&vdrive->drive, desc, bootprio_find_mmio_device(mmio)); + + status |=3D VIRTIO_CONFIG_S_DRIVER_OK; + vp_set_status(&vdrive->vp, status); + return; + +fail: + vp_reset(&vdrive->vp); + free(vdrive->vq); + free(vdrive); +} + void virtio_blk_setup(void) { diff --git a/src/hw/virtio-mmio.c b/src/hw/virtio-mmio.c index a72f5fc5e6a1..b205ec6ef6ae 100644 --- a/src/hw/virtio-mmio.c +++ b/src/hw/virtio-mmio.c @@ -4,6 +4,7 @@ #include "stacks.h" // run_thread #include "string.h" // memset #include "virtio-pci.h" +#include "virtio-blk.h" #include "virtio-scsi.h" #include "virtio-ring.h" #include "virtio-mmio.h" @@ -55,7 +56,7 @@ void virtio_mmio_setup(void) devs[i], devid, version =3D=3D 1 ? " (legacy)" : ""); switch (devid) { case 2: /* blk */ - /* TODO */ + run_thread(init_virtio_blk_mmio, mmio); break; case 8: /* scsi */ run_thread(init_virtio_scsi_mmio, mmio); --=20 2.18.2 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org From nobody Fri Apr 26 12:09:32 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1585903170; cv=none; d=zohomail.com; s=zohoarc; b=jdgJMeOsidNmDSRKaUXt02FDjFIyWd/muxJlzHDCIR0vzLwjPaleDXJaaDXr599RpIw1zCaEq3nsSqFa55ztNuvlvZQu6Rwky1MRtCBlzkzTz/NK5FvlvtKmCDqO6WZDsdykD/5Cawd1abqzrX10vvTrkVnLzUh75b6zpFzj+VY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585903170; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Subject:To; bh=jhX1uwZEJ7HKyPKgZOyqrCA1A/IogczMqwP1IqizOEg=; b=DBgIldjjSvtIbl+cbDvVKeKWKpoPOlzcgyaA2xdOlP4Gheg8cogmQtvaYe6Ce4BFuMzl9q61XjtwF5GH4lcfwXj2ROMOrE0NQ/hpSzqN/6Ub77xuj0pwb2OghWWeNI0T7udYFd4VCEtUtmAi77usFxss8tQOeejRW+p+pclHR1w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from coreboot.org (coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 1585903170505267.2096586048258; Fri, 3 Apr 2020 01:39:30 -0700 (PDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id 91CF4B01A34; Fri, 3 Apr 2020 08:39:25 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTP id 7838CB01A2B for ; Fri, 3 Apr 2020 08:38:05 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-395-1V1OraRmNcGRiBCDySMU4A-1; Fri, 03 Apr 2020 04:31:43 -0400 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BB1FB477 for ; Fri, 3 Apr 2020 08:31:42 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by smtp.corp.redhat.com (Postfix) with ESMTP id 70A525C1D6; Fri, 3 Apr 2020 08:31:39 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) id AA17D17511; Fri, 3 Apr 2020 10:31:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585903084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3gqf7sqAN84AZD2SPOEBWjlwOfgVepZODYFWIExJPhc=; b=bxkyfOdCWimxKzP95x4taZZ67aIRoNwbitOYHTSurhRmRW62eE2J56e4tcHntNnMriGYbE IPoZ+F/HSkNJbIdc1yYiqP8UbVRDAxuojqptIft/XpVOgQodRWtP0RqSnloRptqC1EUU6f Q7Jkc1Iy8+/r8aVWiBRh14z8vqQNvTA= X-MC-Unique: 1V1OraRmNcGRiBCDySMU4A-1 From: Gerd Hoffmann To: seabios@seabios.org Date: Fri, 3 Apr 2020 10:31:18 +0200 Message-Id: <20200403083121.10766-7-kraxel@redhat.com> In-Reply-To: <20200403083121.10766-1-kraxel@redhat.com> References: <20200403083121.10766-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Level: **** Message-ID-Hash: OLV3JGSVD7U3MSNOMUU5SHHU6LOOAZ66 X-Message-ID-Hash: OLV3JGSVD7U3MSNOMUU5SHHU6LOOAZ66 X-MailFrom: kraxel@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Gerd Hoffmann X-Mailman-Version: 3.3.1 Precedence: list Subject: [SeaBIOS] [PATCH 6/9] acpi: add xsdt support List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-Spamd-Bar: / X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" In case a xsdt table is present (and located below 4G) prefer it over rsdt. Signed-off-by: Gerd Hoffmann --- src/std/acpi.h | 11 +++++++++++ src/fw/biostables.c | 40 ++++++++++++++++++++++++++++++---------- 2 files changed, 41 insertions(+), 10 deletions(-) diff --git a/src/std/acpi.h b/src/std/acpi.h index c01fa7be827c..81c22757f50e 100644 --- a/src/std/acpi.h +++ b/src/std/acpi.h @@ -132,6 +132,17 @@ struct rsdt_descriptor_rev1 /* ACPI tables */ } PACKED; =20 +/* + * ACPI 2.0 eXtended System Description Table (XSDT) + */ +#define XSDT_SIGNATURE 0x54445358 // XSDT +struct xsdt_descriptor_rev2 +{ + ACPI_TABLE_HEADER_DEF /* ACPI common table header */ + u64 table_offset_entry[0]; /* Array of pointers to other */ + /* ACPI tables */ +} PACKED; + /* * ACPI 1.0 Firmware ACPI Control Structure (FACS) */ diff --git a/src/fw/biostables.c b/src/fw/biostables.c index fe8626efc05d..0d4fdb9c22e8 100644 --- a/src/fw/biostables.c +++ b/src/fw/biostables.c @@ -141,18 +141,38 @@ find_acpi_table(u32 signature) if (!RsdpAddr || RsdpAddr->signature !=3D RSDP_SIGNATURE) return NULL; struct rsdt_descriptor_rev1 *rsdt =3D (void*)RsdpAddr->rsdt_physical_a= ddress; + struct xsdt_descriptor_rev2 *xsdt =3D + RsdpAddr->xsdt_physical_address >=3D 0x100000000 + ? NULL : (void*)(u32)(RsdpAddr->xsdt_physical_address); dprintf(4, "rsdt=3D%p\n", rsdt); - if (!rsdt || rsdt->signature !=3D RSDT_SIGNATURE) - return NULL; - void *end =3D (void*)rsdt + rsdt->length; - int i; - for (i=3D0; (void*)&rsdt->table_offset_entry[i] < end; i++) { - struct acpi_table_header *tbl =3D (void*)rsdt->table_offset_entry[= i]; - if (!tbl || tbl->signature !=3D signature) - continue; - dprintf(4, "table(%x)=3D%p\n", signature, tbl); - return tbl; + dprintf(4, "xsdt=3D%p\n", xsdt); + + if (xsdt && xsdt->signature =3D=3D XSDT_SIGNATURE) { + void *end =3D (void*)xsdt + xsdt->length; + int i; + for (i=3D0; (void*)&xsdt->table_offset_entry[i] < end; i++) { + if (xsdt->table_offset_entry[i] >=3D 0x100000000) + continue; /* above 4G */ + struct acpi_table_header *tbl =3D (void*)(u32)xsdt->table_offs= et_entry[i]; + if (!tbl || tbl->signature !=3D signature) + continue; + dprintf(1, "table(%x)=3D%p (via xsdt)\n", signature, tbl); + return tbl; + } } + + if (rsdt && rsdt->signature =3D=3D RSDT_SIGNATURE) { + void *end =3D (void*)rsdt + rsdt->length; + int i; + for (i=3D0; (void*)&rsdt->table_offset_entry[i] < end; i++) { + struct acpi_table_header *tbl =3D (void*)rsdt->table_offset_en= try[i]; + if (!tbl || tbl->signature !=3D signature) + continue; + dprintf(1, "table(%x)=3D%p (via rsdt)\n", signature, tbl); + return tbl; + } + } + dprintf(4, "no table %x found\n", signature); return NULL; } --=20 2.18.2 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org From nobody Fri Apr 26 12:09:32 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1585902723; cv=none; d=zohomail.com; s=zohoarc; b=AkSYBbZL4bu1M1RRJ6jQhD/9ZfchayhrUpkkd7U1Y/BBwAGY0Sq2ynJvjMAWTzy9AeIQI/o7wvk3p9IT7Bku9+qjtB1Q2xTuylA56KV1i7Sl0v+uX53lkFnBrTg7i3t23uTYi7A0vVozqDRnpLU6UIlaLMBolKwVtv+P6oGjF3I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585902723; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Subject:To; bh=Yz27HmMXoNn7BZj1gyHI41DOYXWtBfxRavxP/G9OLHA=; b=OZUvAeRhw4L4rm3tFNALf9sn8hff5f6A1pqTDOv+JKTIfTe2zrIEP9gRPlH7p4+XsFbneeXSl/ot6CzaxJ9UguBzzq5UGw5ZgdXRqeLWmMdpYF0ZeYMyd32cS8rTHyj69gOP/rUMvpo0CuErDghIiuy3XHL7PlDcbW9aSaQIeKQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from coreboot.org (coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 15859027236888.353319551894742; Fri, 3 Apr 2020 01:32:03 -0700 (PDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id 01578B01A28; Fri, 3 Apr 2020 08:31:59 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTP id 036ADB00165 for ; Fri, 3 Apr 2020 08:31:45 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-391-gH7nl_veOtK09IeFJ6xKJQ-1; Fri, 03 Apr 2020 04:31:41 -0400 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F23AF107ACC9 for ; Fri, 3 Apr 2020 08:31:40 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by smtp.corp.redhat.com (Postfix) with ESMTP id E3C6C396; Fri, 3 Apr 2020 08:31:39 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) id AC5F017516; Fri, 3 Apr 2020 10:31:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585902705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8pBBGt1w9CMsLiistmVD+jqwxNqE9/clvVwvVAPH6hc=; b=Fmui1IbVuJJTLl93DGfPtJqfh/JaskhtcRVjnOE4L04OWOSxBT/JsXDyFPF4DJR0rvKjAr 7fEV5GUHNIt/GjMs85roQGuXZdkCVHkFL6/MRwcSUQuKZM+BgloabDwgmOf6g6WkELW4RH U3+cRffLuPsFYZzn4AjosFmZtMLHIXA= X-MC-Unique: gH7nl_veOtK09IeFJ6xKJQ-1 From: Gerd Hoffmann To: seabios@seabios.org Date: Fri, 3 Apr 2020 10:31:19 +0200 Message-Id: <20200403083121.10766-8-kraxel@redhat.com> In-Reply-To: <20200403083121.10766-1-kraxel@redhat.com> References: <20200403083121.10766-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: SNRIP43BECGXY2MPSLU6PZPYOJPOHLAR X-Message-ID-Hash: SNRIP43BECGXY2MPSLU6PZPYOJPOHLAR X-MailFrom: kraxel@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Gerd Hoffmann X-Mailman-Version: 3.3.1 Precedence: list Subject: [SeaBIOS] [PATCH 7/9] acpi: add dsdt parser List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ++++ X-Spam-Level: **** Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Create a list of devices found in the DSDT table. Add helper functions to find devices, walk the list and figure device informations like mmio ranges and irqs. Signed-off-by: Gerd Hoffmann --- src/util.h | 10 + src/fw/biostables.c | 622 ++++++++++++++++++++++++++++++++++++++++++++ src/post.c | 2 + src/Kconfig | 7 + 4 files changed, 641 insertions(+) diff --git a/src/util.h b/src/util.h index 4f27fc307439..8ee0370492b8 100644 --- a/src/util.h +++ b/src/util.h @@ -94,6 +94,16 @@ void display_uuid(void); void copy_table(void *pos); void smbios_setup(void); =20 +struct acpi_device; +void acpi_dsdt_parse(void); +struct acpi_device *acpi_dsdt_find_string(struct acpi_device *prev, const = char *hid); +struct acpi_device *acpi_dsdt_find_eisaid(struct acpi_device *prev, u16 ei= said); +char *acpi_dsdt_name(struct acpi_device *dev); +int acpi_dsdt_present_eisaid(u16 eisaid); +int acpi_dsdt_find_io(struct acpi_device *dev, u64 *min, u64 *max); +int acpi_dsdt_find_mem(struct acpi_device *dev, u64 *min, u64 *max); +int acpi_dsdt_find_irq(struct acpi_device *dev, u64 *irq); + // fw/coreboot.c extern const char *CBvendor, *CBpart; struct cbfs_file; diff --git a/src/fw/biostables.c b/src/fw/biostables.c index 0d4fdb9c22e8..ebe1c90fca5e 100644 --- a/src/fw/biostables.c +++ b/src/fw/biostables.c @@ -17,6 +17,7 @@ #include "std/smbios.h" // struct smbios_entry_point #include "string.h" // memcpy #include "util.h" // copy_table +#include "list.h" // hlist_* #include "x86.h" // outb =20 struct pir_header *PirAddr VARFSEG; @@ -509,3 +510,624 @@ copy_table(void *pos) copy_acpi_rsdp(pos); copy_smbios(pos); } + +/**************************************************************** + * DSDT parser + ****************************************************************/ + +struct acpi_device { + struct hlist_node node; + char name[16]; + u8 *hid_aml; + u8 *sta_aml; + u8 *crs_data; + int crs_size; +}; +static struct hlist_head acpi_devices; + +static int parse_error =3D 0; +static int parse_dumptree =3D 0; +static char parse_name[32]; +static struct acpi_device *parse_dev; + +static void parse_termlist(u8 *ptr, int offset, int pkglength); + +static void hex(const u8 *ptr, int count, int lvl, const char *item) +{ + int l =3D 0, i; + + do { + dprintf(lvl, "%s: %04x: ", item, l); + for (i =3D l; i < l+16; i +=3D 4) + dprintf(lvl, "%02x %02x %02x %02x ", + ptr[i+0], ptr[i+1], ptr[i+2], ptr[i+3]); + for (i =3D l; i < l+16; i++) + dprintf(lvl, "%c", (ptr[i] > 0x20 && ptr[i] < 0x80) ? ptr[i] := '.'); + dprintf(lvl, "\n"); + l +=3D 16; + } while (l < count); +} + +static u64 parse_resource_int(u8 *ptr, int count) +{ + u64 value =3D 0; + int index =3D 0; + + for (index =3D 0; index < count; index++) + value |=3D (u64)ptr[index] << (index * 8); + return value; +} + +static int parse_resource_bit(u8 *ptr, int count) +{ + int bit; + + for (bit =3D 0; bit < count*8; bit++) + if (ptr[bit/8] & (1 << (bit%8))) + return bit; + return 0; +} + +static int parse_resource(u8 *ptr, int length, int *type, u64 *min, u64 *m= ax) +{ + int rname, rsize; + u64 len; + + *type =3D -1; + *min =3D 0; + *max =3D 0; + len =3D 0; + if (!(ptr[0] & 0x80)) { + /* small resource */ + rname =3D (ptr[0] >> 3) & 0x0f; + rsize =3D ptr[0] & 0x07; + rsize++; + switch (rname) { + case 0x04: /* irq */ + *min =3D parse_resource_bit(ptr + 1, rsize); + *max =3D *min; + *type =3D 3; + break; + case 0x0f: /* end marker */ + return 0; + case 0x08: /* io */ + *min =3D parse_resource_int(ptr + 2, 2); + *max =3D parse_resource_int(ptr + 4, 2); + if (*min =3D=3D *max) { + *max =3D *min + ptr[7] - 1; + *type =3D 1; + } + break; + case 0x09: /* fixed io */ + *min =3D parse_resource_int(ptr + 2, 2); + *max =3D *min + ptr[4] - 1; + *type =3D 1; + break; + default: + dprintf(3, "%s: small: 0x%x (len %d)\n", + __func__, rname, rsize); + break; + } + } else { + /* large resource */ + rname =3D ptr[0] & 0x7f; + rsize =3D ptr[2] << 8 | ptr[1]; + rsize +=3D 3; + switch (rname) { + case 0x06: /* 32-bit Fixed Location Memory Range Descriptor */ + *min =3D parse_resource_int(ptr + 4, 4); + len =3D parse_resource_int(ptr + 8, 4); + *max =3D *min + len - 1; + *type =3D 0; + break; + case 0x07: /* DWORD Address Space Descriptor */ + *min =3D parse_resource_int(ptr + 10, 4); + *max =3D parse_resource_int(ptr + 14, 4); + *type =3D ptr[3]; + break; + case 0x08: /* WORD Address Space Descriptor */ + *min =3D parse_resource_int(ptr + 8, 2); + *max =3D parse_resource_int(ptr + 10, 2); + *type =3D ptr[3]; + break; + case 0x09: /* irq */ + *min =3D parse_resource_int(ptr + 5, 4); + *max =3D *min; + *type =3D 3; + break; + case 0x0a: /* QWORD Address Space Descriptor */ + *min =3D parse_resource_int(ptr + 14, 8); + *max =3D parse_resource_int(ptr + 22, 8); + *type =3D ptr[3]; + break; + default: + dprintf(3, "%s: large: 0x%x (len %d)\n", __func__, rname, rsiz= e); + break; + } + } + return rsize; +} + +static int find_resource(u8 *ptr, int len, int kind, u64 *min, u64 *max) +{ + int type, size, offset =3D 0; + + do { + size =3D parse_resource(ptr + offset, len - offset, + &type, min, max); + if (kind =3D=3D type) + return 0; + offset +=3D size; + } while (size > 0 && offset < len); + return -1; +} + +static int print_resources(const char *prefix, u8 *ptr, int len) +{ + static const char *typename[] =3D { "mem", "i/o", "bus" }; + int type, size, offset =3D 0; + u64 min, max; + + do { + size =3D parse_resource(ptr + offset, len - offset, + &type, &min, &max); + switch (type) { + case 0: + case 1: + case 2: + dprintf(1, "%s%s 0x%llx -> 0x%llx\n", + prefix, typename[type], min, max); + break; + case 3: + dprintf(1, "%sirq %lld\n", prefix, min); + break; + } + offset +=3D size; + } while (size > 0 && offset < len); + return -1; +} + +static int parse_nameseg(u8 *ptr, char **dst) +{ + if (dst && *dst) { + *(dst[0]++) =3D ptr[0]; + if (ptr[1] !=3D '_') + *(dst[0]++) =3D ptr[1]; + if (ptr[2] !=3D '_') + *(dst[0]++) =3D ptr[2]; + if (ptr[3] !=3D '_') + *(dst[0]++) =3D ptr[3]; + *(dst[0]) =3D 0; + } + return 4; +} + +static int parse_namestring(u8 *ptr, const char *item) +{ + char *dst =3D parse_name; + int offset =3D 0; + int i, count; + +again: + switch (ptr[offset]) { + case 0: /* null name */ + offset++; + *(dst++) =3D 0; + break; + case 0x2e: + offset++; + offset +=3D parse_nameseg(ptr + offset, &dst); + *(dst++) =3D '.'; + offset +=3D parse_nameseg(ptr + offset, &dst); + break; + case 0x2f: + offset++; + count =3D ptr[offset]; + offset++; + for (i =3D 0; i < count; i++) { + if (i) + *(dst++) =3D '.'; + offset +=3D parse_nameseg(ptr + offset, &dst); + } + break; + case '\\': + *(dst++) =3D '\\'; + offset++; + goto again; + case '^': + *(dst++) =3D '^'; + offset++; + goto again; + case 'A' ... 'Z': + case '_': + offset +=3D parse_nameseg(ptr, &dst); + break; + default: + hex(ptr, 16, 3, __func__); + parse_error =3D 1; + break; + } + dprintf(5, "%s: %s '%s'\n", __func__, item, parse_name); + return offset; +} + +static int parse_termarg_int(u8 *ptr, u64 *dst) +{ + u64 value; + int offset =3D 1; + + switch (ptr[0]) { + case 0x00: /* zero */ + value =3D 0; + break; + case 0x01: /* one */ + value =3D 1; + break; + case 0x0a: /* byte prefix */ + value =3D ptr[1]; + offset++; + break; + case 0x0b: /* word prefix */ + value =3D ptr[1] | + ((unsigned long)ptr[2] << 8); + offset +=3D 2; + break; + case 0x0c: /* dword prefix */ + value =3D ptr[1] | + ((unsigned long)ptr[2] << 8) | + ((unsigned long)ptr[3] << 16) | + ((unsigned long)ptr[4] << 24); + offset +=3D 4; + break; + default: + value =3D 0; + hex(ptr, 16, 3, __func__); + parse_error =3D 1; + break; + } + + if (dst) + *dst =3D value; + dprintf(5, "%s: 0x%llx\n", __func__, value); + return offset; +} + +static int parse_pkglength(u8 *ptr, int *pkglength) +{ + int offset =3D 2; + + *pkglength =3D 0; + switch (ptr[0] >> 6) { + case 3: + *pkglength |=3D ptr[3] << 20; + offset++; + case 2: + *pkglength |=3D ptr[2] << 12; + offset++; + case 1: + *pkglength |=3D ptr[1] << 4; + *pkglength |=3D ptr[0] & 0x0f; + return offset; + case 0: + default: + *pkglength |=3D ptr[0] & 0x3f; + return 1; + } +} + +static int parse_pkg_common(u8 *ptr, const char *item, int *pkglength) +{ + int offset; + + offset =3D parse_pkglength(ptr, pkglength); + offset +=3D parse_namestring(ptr + offset, item); + return offset; +} + +static int parse_pkg_scope(u8 *ptr) +{ + int offset, pkglength; + + offset =3D parse_pkg_common(ptr, "skope", &pkglength); + parse_termlist(ptr, offset, pkglength); + return pkglength; +} + +static int parse_pkg_device(u8 *ptr) +{ + int offset, pkglength; + + offset =3D parse_pkg_common(ptr, "device", &pkglength); + + parse_dev =3D malloc_high(sizeof(*parse_dev)); + if (!parse_dev) { + warn_noalloc(); + parse_error =3D 1; + return pkglength; + } + + memset(parse_dev, 0, sizeof(*parse_dev)); + hlist_add_head(&parse_dev->node, &acpi_devices); + strtcpy(parse_dev->name, parse_name, sizeof(parse_dev->name)); + + parse_termlist(ptr, offset, pkglength); + return pkglength; +} + +static int parse_pkg_buffer(u8 *ptr) +{ + u64 blen; + int pkglength, offset; + + offset =3D parse_pkglength(ptr, &pkglength); + offset +=3D parse_termarg_int(ptr + offset, &blen); + if (strcmp(parse_name, "_CRS") =3D=3D 0) { + parse_dev->crs_data =3D ptr + offset; + parse_dev->crs_size =3D blen; + } + return pkglength; +} + +static int parse_pkg_skip(u8 *ptr, int op, int name) +{ + int pkglength, offset; + char item[8]; + + snprintf(item, sizeof(item), "op %x", op); + offset =3D parse_pkglength(ptr, &pkglength); + if (name) { + parse_namestring(ptr + offset, item); + } else { + dprintf(5, "%s: %s (%d)\n", __func__, item, pkglength); + } + return pkglength; +} + +static int parse_termobj(u8 *ptr) +{ + int offset =3D 1; + + switch (ptr[0]) { + case 0x00: /* zero */ + break; + case 0x01: /* one */ + break; + case 0x08: /* name op */ + offset +=3D parse_namestring(ptr + offset, "name"); + offset +=3D parse_termobj(ptr + offset); + if (strcmp(parse_name, "_HID") =3D=3D 0) + parse_dev->hid_aml =3D ptr; + if (strcmp(parse_name, "_STA") =3D=3D 0) + parse_dev->sta_aml =3D ptr; + break; + case 0x0a: /* byte prefix */ + offset++; + break; + case 0x0b: /* word prefix */ + offset +=3D 2; + break; + case 0x0c: /* dword prefix */ + offset +=3D 4; + break; + case 0x0d: /* string prefix */ + while (ptr[offset]) + offset++; + offset++; + break; + case 0x10: /* scope op */ + offset +=3D parse_pkg_scope(ptr + offset); + break; + case 0x11: /* buffer op */ + offset +=3D parse_pkg_buffer(ptr + offset); + break; + case 0x12: /* package op */ + case 0x13: /* var package op */ + offset +=3D parse_pkg_skip(ptr + offset, ptr[0], 0); + break; + case 0x14: /* method op */ + offset +=3D parse_pkg_skip(ptr + offset, ptr[0], 1); + if (strcmp(parse_name, "_STA") =3D=3D 0) + parse_dev->sta_aml =3D ptr; + break; + case 0x5b: /* ext op prefix */ + offset++; + switch (ptr[1]) { + case 0x01: /* mutex op */ + offset +=3D parse_namestring(ptr + offset, "mutex"); + offset++; /* sync flags */ + break; + case 0x80: /* op region op */ + offset +=3D parse_namestring(ptr + offset, "op region"); + offset++; /* region space */ + offset +=3D parse_termarg_int(ptr + offset, NULL); + offset +=3D parse_termarg_int(ptr + offset, NULL); + break; + case 0x81: /* field op */ + case 0x83: /* processor op */ + case 0x84: /* power resource op */ + case 0x85: /* thermal zone op */ + offset +=3D parse_pkg_skip(ptr + offset, 0x5b00 | ptr[1], 1); + break; + case 0x82: /* device op */ + offset +=3D parse_pkg_device(ptr + offset); + break; + default: + hex(ptr, 16, 3, __func__); + parse_error =3D 1; + break; + } + break; + default: + hex(ptr, 16, 3, __func__); + parse_error =3D 1; + break; + } + + return offset; +} + +static void parse_termlist(u8 *ptr, int offset, int pkglength) +{ + for (;;) { + offset +=3D parse_termobj(ptr + offset); + if (offset =3D=3D pkglength) + return; + if (offset > pkglength) { + dprintf(1, "%s: overrun: %d/%d\n", __func__, + offset, pkglength); + parse_error =3D 1; + return; + } + if (parse_error) { + dprintf(1, "%s: parse error, skip from %d/%d\n", __func__, + offset, pkglength); + parse_error =3D 0; + return; + } + } +} + +static struct acpi_device *acpi_dsdt_find(struct acpi_device *prev, const = u8 *aml, int size) +{ + struct acpi_device *dev; + struct hlist_node *node; + + if (!prev) + node =3D acpi_devices.first; + else + node =3D prev->node.next; + + for (; node !=3D NULL; node =3D dev->node.next) { + dev =3D container_of(node, struct acpi_device, node); + if (!aml) + return dev; + if (!dev->hid_aml) + continue; + if (memcmp(dev->hid_aml + 5, aml, size) =3D=3D 0) + return dev; + } + return NULL; +} + +static int acpi_dsdt_present(struct acpi_device *dev) +{ + if (!dev) + return 0; /* no */ + if (!dev->sta_aml) + return 1; /* yes */ + if (dev->sta_aml[0] =3D=3D 0x14) + return -1; /* unknown (can't evaluate method) */ + if (dev->sta_aml[0] =3D=3D 0x08) { + u64 value =3D 0; + parse_termarg_int(dev->sta_aml + 5, &value); + if (value =3D=3D 0) + return 0; /* no */ + else + return 1; /* yes */ + } + return -1; /* unknown (should not happen) */ +} + +/**************************************************************** + * DSDT parser, public interface + ****************************************************************/ + +struct acpi_device *acpi_dsdt_find_string(struct acpi_device *prev, const = char *hid) +{ + if (!CONFIG_ACPI_PARSE) + return NULL; + + u8 aml[10]; + int len =3D snprintf((char*)aml, sizeof(aml), "\x0d%s", hid); + return acpi_dsdt_find(prev, aml, len); +} + +struct acpi_device *acpi_dsdt_find_eisaid(struct acpi_device *prev, u16 ei= said) +{ + if (!CONFIG_ACPI_PARSE) + return NULL; + u8 aml[] =3D { + 0x0c, 0x41, 0xd0, + eisaid >> 8, + eisaid & 0xff + }; + return acpi_dsdt_find(prev, aml, 5); +} + +char *acpi_dsdt_name(struct acpi_device *dev) +{ + if (!CONFIG_ACPI_PARSE || !dev) + return NULL; + return dev->name; +} + +int acpi_dsdt_find_io(struct acpi_device *dev, u64 *min, u64 *max) +{ + if (!CONFIG_ACPI_PARSE || !dev || !dev->crs_data) + return -1; + return find_resource(dev->crs_data, dev->crs_size, + 1 /* I/O */, min, max); +} + +int acpi_dsdt_find_mem(struct acpi_device *dev, u64 *min, u64 *max) +{ + if (!CONFIG_ACPI_PARSE || !dev || !dev->crs_data) + return -1; + return find_resource(dev->crs_data, dev->crs_size, + 0 /* mem */, min, max); +} + +int acpi_dsdt_find_irq(struct acpi_device *dev, u64 *irq) +{ + u64 max; + if (!CONFIG_ACPI_PARSE || !dev || !dev->crs_data) + return -1; + return find_resource(dev->crs_data, dev->crs_size, + 3 /* irq */, irq, &max); +} + +int acpi_dsdt_present_eisaid(u16 eisaid) +{ + if (!CONFIG_ACPI_PARSE) + return -1; /* unknown */ + + struct acpi_device *dev =3D acpi_dsdt_find_eisaid(NULL, eisaid); + return acpi_dsdt_present(dev); +} + +void acpi_dsdt_parse(void) +{ + if (!CONFIG_ACPI_PARSE) + return; + + struct fadt_descriptor_rev1 *fadt =3D find_acpi_table(FACP_SIGNATURE); + if (!fadt) + return; + u8 *dsdt =3D (void*)(fadt->dsdt); + if (!dsdt) + return; + + u32 length =3D *(u32*)(dsdt + 4); + u32 offset =3D 0x24; + dprintf(1, "ACPI: parse DSDT at %p (len %d)\n", dsdt, length); + parse_termlist(dsdt, offset, length); + + if (parse_dumptree) { + struct acpi_device *dev; + dprintf(1, "ACPI: dumping dsdt devices\n"); + for (dev =3D acpi_dsdt_find(NULL, NULL, 0); + dev !=3D NULL; + dev =3D acpi_dsdt_find(dev, NULL, 0)) { + dprintf(1, " %s", acpi_dsdt_name(dev)); + if (dev->hid_aml) + dprintf(1, ", hid"); + if (dev->sta_aml) + dprintf(1, ", sta (0x%x)", dev->sta_aml[0]); + if (dev->crs_data) + dprintf(1, ", crs"); + dprintf(1, "\n"); + if (dev->crs_data) + print_resources(" ", dev->crs_data, dev->crs_size); + } + } +} diff --git a/src/post.c b/src/post.c index f93106a1c9c9..febdc0859764 100644 --- a/src/post.c +++ b/src/post.c @@ -149,6 +149,8 @@ platform_hardware_setup(void) qemu_platform_setup(); coreboot_platform_setup(); =20 + acpi_dsdt_parse(); + // Setup timers and periodic clock interrupt timer_setup(); clock_setup(); diff --git a/src/Kconfig b/src/Kconfig index 6606ce4d46c9..ab36e676bf12 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -524,6 +524,13 @@ menu "BIOS Tables" This option can be disabled for QEMU 1.6 and older to save some space in the ROM file. If unsure, say Y. + config ACPI_PARSE + bool "Include ACPI DSDT parser." + default n + help + Support parsing ACPI DSDT for device probing. + Needed to find virtio-mmio devices. + If unsure, say N. endmenu =20 source vgasrc/Kconfig --=20 2.18.2 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org From nobody Fri Apr 26 12:09:32 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1585902737; cv=none; d=zohomail.com; s=zohoarc; b=FIBrkp2dvllHaw9AD5EWlFelNEpVU0DMUvHeZz4HmrVVGDIqMUGt6CFrTzNWegtU4hvTZ/beLiznGwzmzKmUL+jT6Sb1WUaelqPZFkIOmPajT8un7h/ZRh56lZ+JtJJQf6ltKRc8+o8J4as5C6MD9iLZuXVhWiWyy9y5ru+BCEg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585902737; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Subject:To; bh=HGdnkM17HL9uaCtrakhAYhMPEz8tSMrXplJ+zuuUge4=; b=DTo3T10XOt+GmB1f9HP11rCRmBTFzxC56vd05o3NHzR13p0olxTYR3Gg1nkRThcoYnTbNxoWCHJ9ldln52MRzvBGBP1xKHtUODkBTLeKxsKGFQW770lVfBo9sNPlcSyRcwsq1nTaGUthsviIDSOnWnEWFvnYFuMXCvqAvuW5M3w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from coreboot.org (coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 1585902737443434.1758786951966; Fri, 3 Apr 2020 01:32:17 -0700 (PDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id C0F38B01D14; Fri, 3 Apr 2020 08:32:13 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTP id AE69DB00165 for ; Fri, 3 Apr 2020 08:31:46 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-248-F9d9qaJ1NDSr82-KGtEvYA-1; Fri, 03 Apr 2020 04:31:43 -0400 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C227B100551A for ; Fri, 3 Apr 2020 08:31:42 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by smtp.corp.redhat.com (Postfix) with ESMTP id 80C436EF97; Fri, 3 Apr 2020 08:31:39 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) id AEDFE17517; Fri, 3 Apr 2020 10:31:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585902705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5wcnUNBZABa0/rohONyzEk4ZrPmX9TlkuAzzfKGIgAg=; b=BnGB1zhY811Qu5Hx4mjwauSKediFu0I+9S0vXuCaBeAUdFsiY7TPvgnHc1rC+MwEgLRuuJ C/is0QQTnO6ksq/IqfCJj+D91wE6GBmlStb3soNlrnIrhtlm6Xp+VmdiK8PTTxPE2WBoQ0 W/qDP69PsIw5eCCbjeP2gM7b5pAuKXk= X-MC-Unique: F9d9qaJ1NDSr82-KGtEvYA-1 From: Gerd Hoffmann To: seabios@seabios.org Date: Fri, 3 Apr 2020 10:31:20 +0200 Message-Id: <20200403083121.10766-9-kraxel@redhat.com> In-Reply-To: <20200403083121.10766-1-kraxel@redhat.com> References: <20200403083121.10766-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: 4FC6DO43R7XMSQ32RA6AUIALRWNRTAGT X-Message-ID-Hash: 4FC6DO43R7XMSQ32RA6AUIALRWNRTAGT X-MailFrom: kraxel@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Gerd Hoffmann X-Mailman-Version: 3.3.1 Precedence: list Subject: [SeaBIOS] [PATCH 8/9] acpi: skip kbd init if not present List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ++++ X-Spam-Level: **** Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Don't initialize the ps/2 keyboard in case the device is not listed in the ACPi DSDT table. Signed-off-by: Gerd Hoffmann --- src/hw/ps2port.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/hw/ps2port.c b/src/hw/ps2port.c index 2c334c06b7eb..c82521b42e16 100644 --- a/src/hw/ps2port.c +++ b/src/hw/ps2port.c @@ -542,6 +542,10 @@ ps2port_setup(void) ASSERT32FLAT(); if (! CONFIG_PS2PORT) return; + if (acpi_dsdt_present_eisaid(0x0303) =3D=3D 0) { + dprintf(1, "ACPI: no PS/2 keyboard present\n"); + return; + } dprintf(3, "init ps2port\n"); =20 enable_hwirq(1, FUNC16(entry_09)); --=20 2.18.2 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org From nobody Fri Apr 26 12:09:32 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1585903123; cv=none; d=zohomail.com; s=zohoarc; b=Mf3aWZ/f/1GHSxpE0zluJUp0gxE3XOfj2ozfuu8JlPzWADJqkb0qzlnMWkzPAznY1b/lm31CsQ4r20Az09rjXDu1Y4lowqU5iAHWXHR/y/Ds5ZWrlx0FmoQt0wBYImjkdRGbZPzfooJRrDC1NmgXH4XkY8Q7kC69q2/NhwLLlWY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585903123; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Subject:To; bh=JN2DY/wgOtktNKnL62+Sxa38SwnoS8ODoOX6vtQ6rlA=; b=dQjUt8YO4Nga4YqhjLsRzskWjinrZJL3YzQ2rOoF8Wpq5CSJQWSxydszZZR+nZ3BEBQT56jG/NXUHB3QuCTO9MBCknZWifz2iIZaJMR+d2U4zo6KB8zh1uJAb8L40xNos1qaxW7WJiP9vmkpoMFIZnlGxOcqFINCAU4OV2IkJvI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from coreboot.org (coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 1585903123885371.43730883713033; Fri, 3 Apr 2020 01:38:43 -0700 (PDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id BD88AB01D14; Fri, 3 Apr 2020 08:38:38 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTP id 2D658B01A27 for ; Fri, 3 Apr 2020 08:38:05 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-396-wocffT0qO4KsHtvogb4Rjg-1; Fri, 03 Apr 2020 04:31:41 -0400 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 71A3F107ACC4 for ; Fri, 3 Apr 2020 08:31:40 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by smtp.corp.redhat.com (Postfix) with ESMTP id F088E60BF3; Fri, 3 Apr 2020 08:31:39 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) id B15BC17518; Fri, 3 Apr 2020 10:31:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585903084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZZNOnQbXrdWnKticUVX6V2XG0PPxOJDj7MUGhMlQyGc=; b=AJQqFnKx1IVTmyttgQE+fb6MU6rmMm9hDCDEKw6VvccUB+RIzAZwKrOCWgvlp+BRmEyZb5 +odkh1X/ZWAzLSH8NBRoDPQOQwdMQ7b1CXZlS+Kknx969mcEoy8B8MHcA2MVCiHV5nmjWK numC9yOZdlCfDdvQPphcbkxpn7m/nTc= X-MC-Unique: wocffT0qO4KsHtvogb4Rjg-1 From: Gerd Hoffmann To: seabios@seabios.org Date: Fri, 3 Apr 2020 10:31:21 +0200 Message-Id: <20200403083121.10766-10-kraxel@redhat.com> In-Reply-To: <20200403083121.10766-1-kraxel@redhat.com> References: <20200403083121.10766-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: OXVFDIKU54ADXLUOYSWK7KGPXPUAUKUN X-Message-ID-Hash: OXVFDIKU54ADXLUOYSWK7KGPXPUAUKUN X-MailFrom: kraxel@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-seabios.seabios.org-0; header-match-seabios.seabios.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Gerd Hoffmann X-Mailman-Version: 3.3.1 Precedence: list Subject: [SeaBIOS] [PATCH 9/9] acpi: find and register virtio-mmio devices List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ++++ X-Spam-Level: **** Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=seabios-bounces@seabios.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Seach for virtio-mmio devices in the DSDT table, register the devices found. Signed-off-by: Gerd Hoffmann --- src/hw/virtio-mmio.h | 1 + src/util.h | 1 + src/hw/virtio-mmio.c | 20 ++++++++++++++++++++ src/post.c | 2 ++ 4 files changed, 24 insertions(+) diff --git a/src/hw/virtio-mmio.h b/src/hw/virtio-mmio.h index 5e24f692c1ae..349d744d9364 100644 --- a/src/hw/virtio-mmio.h +++ b/src/hw/virtio-mmio.h @@ -71,6 +71,7 @@ typedef struct virtio_mmio_cfg { } virtio_mmio_cfg; =20 void virtio_mmio_register(u64 mmio); +void virtio_mmio_acpi(void); void virtio_mmio_setup(void); void vp_init_mmio(struct vp_device *vp, void *mmio); =20 diff --git a/src/util.h b/src/util.h index 8ee0370492b8..76e1bfcd9897 100644 --- a/src/util.h +++ b/src/util.h @@ -100,6 +100,7 @@ struct acpi_device *acpi_dsdt_find_string(struct acpi_d= evice *prev, const char * struct acpi_device *acpi_dsdt_find_eisaid(struct acpi_device *prev, u16 ei= said); char *acpi_dsdt_name(struct acpi_device *dev); int acpi_dsdt_present_eisaid(u16 eisaid); +void acpi_dsdt_virtio(void); int acpi_dsdt_find_io(struct acpi_device *dev, u64 *min, u64 *max); int acpi_dsdt_find_mem(struct acpi_device *dev, u64 *min, u64 *max); int acpi_dsdt_find_irq(struct acpi_device *dev, u64 *irq); diff --git a/src/hw/virtio-mmio.c b/src/hw/virtio-mmio.c index b205ec6ef6ae..78618ab49e44 100644 --- a/src/hw/virtio-mmio.c +++ b/src/hw/virtio-mmio.c @@ -3,6 +3,7 @@ #include "output.h" // dprintf #include "stacks.h" // run_thread #include "string.h" // memset +#include "util.h" // acpi_dsdt_* #include "virtio-pci.h" #include "virtio-blk.h" #include "virtio-scsi.h" @@ -34,6 +35,25 @@ void virtio_mmio_register(u64 mmio) dprintf(1, "virtio-mmio: device list full\n"); } =20 +void virtio_mmio_acpi(void) +{ + static const char *virtio_hid =3D "LNRO0005"; + struct acpi_device *dev; + u64 mem, irq, unused; + + for (dev =3D acpi_dsdt_find_string(NULL, virtio_hid); + dev !=3D NULL; + dev =3D acpi_dsdt_find_string(dev, virtio_hid)) { + if (acpi_dsdt_find_mem(dev, &mem, &unused) < 0) + continue; + if (acpi_dsdt_find_irq(dev, &irq) < 0) + continue; + dprintf(1, "ACPI: virtio-mmio device %s at 0x%llx, irq %lld\n", + acpi_dsdt_name(dev), mem, irq); + virtio_mmio_register(mem); + } +} + void virtio_mmio_setup(void) { u32 magic, version, devid; diff --git a/src/post.c b/src/post.c index febdc0859764..c4ab5b814a00 100644 --- a/src/post.c +++ b/src/post.c @@ -17,6 +17,7 @@ #include "hw/rtc.h" // rtc_write #include "hw/serialio.h" // serial_debug_preinit #include "hw/usb.h" // usb_setup +#include "hw/virtio-mmio.h" // virtio_mmio_acpi #include "malloc.h" // malloc_init #include "memmap.h" // SYMBOL #include "output.h" // dprintf @@ -150,6 +151,7 @@ platform_hardware_setup(void) coreboot_platform_setup(); =20 acpi_dsdt_parse(); + virtio_mmio_acpi(); =20 // Setup timers and periodic clock interrupt timer_setup(); --=20 2.18.2 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org